objection 4.0.0-rc.1 → 4.0.0-rc.2

package/lib/queryBuilder/graph/GraphSchedule.js

@@ -0,0 +1,513 @@
+import { hasOwnerKey, hasSameKey } from './graphKeys.js';
+import { groupBy } from '../../utils/objectUtils.js';
+
+// Order the writes of a planned graph in steps that keep keys and constraints
+// intact (#214), which `GraphWriter` writes:
+// 1. Move the rows that the graph relates to existing owners of HasMany and
+//    HasOne relations, as they may still sit below rows that the next step
+//    deletes. Rows that wait for inserts are related in step 3 or 4.
+// 2. Remove rows that reference their owners, before the inserts that may need
+//    their unique keys.
+// 3. Insert the new rows in the order of their keys and references, then the
+//    keys deferred to break cycles and the join rows. Rows that move out of
+//    the slots of HasOneRelations that new rows go into are related in the
+//    same order, as the foreign key may be unique.
+// 4. Patch the changed rows, the other relates, and the keys of owners whose
+//    BelongsToOne rows were inserted, related or removed.
+// 5. Remove the BelongsToOne rows that the owners no longer reference.
+// Each step writes a row that goes into the slot of a HasOneRelation after the
+// row that moves out of it, unless that closes a cycle.
+// `insertGraph()` only inserts.
+export class GraphSchedule {
+  constructor(plan, keys) {
+    this.plan = plan;
+    this.keys = keys;
+    // The nodes that each node waits for, through its keys, its references and
+    // the rows that move out of the slots that it goes into:
+    this.dependencies = createDependencies(plan, this.keys);
+    // Dependencies that aren't waited for, to break cycles, and the ones of
+    // owners that earlier passes wrote, whose keys are patched in once their
+    // BelongsToOne rows of this pass are written. Deferred keys are written
+    // after the inserts:
+    const activeNodes = new Set(plan.activeNodes);
+    this.deferredDependencies = new Set(
+      [...this.dependencies].flatMap(([node, dependencies]) =>
+        activeNodes.has(node) ? [] : dependencies.filter((dependency) => dependency.relation),
+      ),
+    );
+    // Relates whose rows are moved to their new owners before the removals:
+    this.movedNodes = new Set(
+      plan.graphOptions.isInsertOnly()
+        ? []
+        : plan.activeNodes.filter((node) => this._isMovedFirst(node)),
+    );
+    // Relates that move the rows out of the slots of HasOneRelations that new
+    // rows go into, and that aren't moved first:
+    this.slotMovedNodes = this._getSlotMovedNodes();
+    this.steps = this._planSteps();
+  }
+
+  _planSteps() {
+    const { activeNodes, activeCurrentNodes, actions, graphOptions } = this.plan;
+    const insertSteps = [
+      ...this._planLevels(activeNodes, { resolvesReferences: true }).map((level) => ({
+        kind: 'insert',
+        ...level,
+      })),
+      {
+        kind: 'deferredKeys',
+        dependencies: [...this.deferredDependencies].filter((dependency) => dependency.relation),
+      },
+      {
+        kind: 'joinRows',
+        nodes: activeNodes.filter(
+          (node) =>
+            node.relation?.keySide === 'join' &&
+            !node.current &&
+            ['insert', 'relate'].includes(actions.get(node)) &&
+            // Models that `noInsert` skips have no key for join rows (#369):
+            actions.get(node.parent) !== 'ignore',
+        ),
+      },
+    ];
+
+    if (graphOptions.isInsertOnly()) {
+      return insertSteps;
+    } else {
+      const removedNodes = activeCurrentNodes.filter((node) => actions.get(node) !== 'keep');
+      const isReferencedByOwner = (currentNode) => currentNode.relation.keySide === 'owner';
+
+      return [
+        ...this._planLevels([...this.movedNodes]).map(({ nodes }) => ({ kind: 'move', nodes })),
+        {
+          kind: 'remove',
+          nodes: removedNodes.filter((node) => !isReferencedByOwner(node)),
+          areReferenced: true,
+        },
+        ...insertSteps,
+        ...this._planLevels(
+          activeNodes.filter((node) => {
+            const action = actions.get(node);
+            return (
+              (action === 'patch' ||
+                (action === 'relate' &&
+                  !this.movedNodes.has(node) &&
+                  !this.slotMovedNodes.has(node))) &&
+              // The row of a `#ref` model is written once, by its model:
+              !this._isWrittenByModel(node)
+            );
+          }),
+        ).map(({ nodes }) => ({ kind: 'patch', nodes })),
+        {
+          kind: 'remove',
+          // Owners unrelate their BelongsToOne rows by patching their keys:
+          nodes: removedNodes.filter(
+            (node) => isReferencedByOwner(node) && actions.get(node) === 'delete',
+          ),
+          areReferenced: false,
+        },
+      ];
+    }
+  }
+
+  // Group the nodes into levels that can be written once the levels before
+  // them are: Nodes wait for the nodes whose keys they store, the nodes that
+  // they reference, and the rows that move out of the slots they go into. For
+  // the inserts, all nodes take part, so that the keys of the nodes that aren't
+  // inserted are resolved in order too, and `resolvesReferences` says so.
+  _planLevels(nodes, { resolvesReferences = false } = {}) {
+    const nodeSet = new Set(nodes);
+    const handledNodes = new Set();
+    const levels = [];
+
+    // The keys of models with rows are known, also of related models that were
+    // fetched, except for the props that the graph fills in:
+    const hasRow = (node) => !!(node.referencedNode || node).existing;
+    // Nodes outside this pass were written by an earlier one, or are never
+    // written, see `checkReferences()`:
+    const getPendingDependencies = (node) =>
+      (this.dependencies.get(node) || []).filter(
+        (dependency) =>
+          nodeSet.has(dependency.node) &&
+          !this.deferredDependencies.has(dependency) &&
+          !handledNodes.has(dependency.node) &&
+          (dependency.isSlotMove ||
+            dependency.isKeyWait ||
+            !hasRow(dependency.node) ||
+            this.readsFilledProps(dependency)),
+      );
+
+    // Return true if `node` waits for `blockingNode`, through other nodes too.
+    const isBlockedBy = (node, blockingNode, visitedNodes = new Set()) => {
+      if (node === blockingNode) {
+        return true;
+      } else if (visitedNodes.has(node)) {
+        return false;
+      } else {
+        visitedNodes.add(node);
+        return getPendingDependencies(node).some((dependency) =>
+          isBlockedBy(dependency.node, blockingNode, visitedNodes),
+        );
+      }
+    };
+
+    // Break a cycle by deferring one BelongsToOne key that points to a `#ref`
+    // model: Its owner is inserted without the key, which is patched in once
+    // the referenced model is inserted. Without `#ref`, the graph is a tree,
+    // and only waits for the rows that move out of slots can close a cycle,
+    // like rows that swap slots. One of these isn't waited for then.
+    const breakCycle = () => {
+      for (const canDefer of [
+        (dependency, node) => this._canDefer(dependency, node),
+        (dependency) => dependency.isSlotMove,
+      ]) {
+        for (const node of nodes) {
+          if (!handledNodes.has(node)) {
+            for (const dependency of getPendingDependencies(node)) {
+              if (canDefer(dependency, node) && isBlockedBy(dependency.node, node)) {
+                this.deferredDependencies.add(dependency);
+                return true;
+              }
+            }
+          }
+        }
+      }
+
+      return false;
+    };
+
+    const isReady = (node) => !handledNodes.has(node) && getPendingDependencies(node).length === 0;
+    const isReadyReference = (node) => resolvesReferences && node.isReference && isReady(node);
+
+    while (handledNodes.size < nodes.length) {
+      const levelNodes = nodes.filter(isReady);
+
+      if (levelNodes.length > 0) {
+        const level = { nodes: levelNodes, references: [] };
+        levels.push(level);
+
+        for (const node of levelNodes) {
+          handledNodes.add(node);
+        }
+
+        // `#ref` models aren't inserted. They're resolved right after the
+        // inserts of the level that completes their dependencies, so that the
+        // nodes that wait for them can be inserted in the next level (#311).
+        // The other steps write them in levels of their own.
+        for (
+          let references = nodes.filter(isReadyReference);
+          references.length > 0;
+          references = nodes.filter(isReadyReference)
+        ) {
+          for (const node of references) {
+            handledNodes.add(node);
+            level.references.push(node);
+          }
+        }
+      } else if (!breakCycle()) {
+        throw new Error('the object graph contains cyclic references');
+      }
+    }
+
+    return levels;
+  }
+
+  _canDefer(dependency, node) {
+    const { actions } = this.plan;
+    const { relation } = dependency;
+
+    return (
+      relation &&
+      hasOwnerKey(relation) &&
+      dependency.node.isReference &&
+      // The owner is patched by its id, which models without one don't have (#2305).
+      node.modelClass.getIdColumnArray().length > 0 &&
+      // Both ends need to be inserted for the key to be patched in later.
+      actions.get(node) === 'insert' &&
+      actions.get(dependency.node.referencedNode) === 'insert' &&
+      // A `#ref{}` that reads the key might be resolved before it's patched in.
+      !node.propertyReferencingNodes.some((referencingNode) =>
+        referencingNode.propertyReferences.some(
+          (reference) =>
+            reference.referencedNode === node &&
+            relation.ownerProp.props.includes(reference.refPath[0]),
+        ),
+      )
+    );
+  }
+
+  // Return true if the HasMany or HasOne relate of `node` moves its row to an
+  // existing owner before the removals, see the steps above. `#ref` models may
+  // get their ids from the inserts, rows that wait for the inserts are written
+  // once they're known, and a relate into the slot of a HasOne row waits for
+  // the removal of that row, or its move, as its key may be unique.
+  _isMovedFirst(node, visitedNodes = new Set()) {
+    const { actions } = this.plan;
+    visitedNodes.add(node);
+
+    if (
+      actions.get(node) === 'relate' &&
+      !node.isReference &&
+      node.relation.keySide === 'related' &&
+      node.parent.existing &&
+      !this._waitsForInserts(node)
+    ) {
+      const slotNode = getSlotNode(node);
+      const moverNode = getSlotMover(this.plan, node);
+      return (
+        !(slotNode && actions.get(slotNode) !== 'keep') &&
+        // Swapped rows are related together:
+        (!moverNode || visitedNodes.has(moverNode) || this._isMovedFirst(moverNode, visitedNodes))
+      );
+    } else {
+      return false;
+    }
+  }
+
+  // Find the relates that move the rows out of the slots of HasOneRelations
+  // that new rows go into, and that aren't moved first. They're related in the
+  // inserts, along with the relates that move the rows out of their own slots,
+  // as the foreign key may be unique.
+  _getSlotMovedNodes() {
+    const nodes = new Set();
+    const addMoverNodes = (node) => {
+      for (const { node: moverNode, isSlotMove } of this.dependencies.get(node) || []) {
+        if (isSlotMove && !this.movedNodes.has(moverNode) && !nodes.has(moverNode)) {
+          nodes.add(moverNode);
+          addMoverNodes(moverNode);
+        }
+      }
+    };
+
+    for (const node of this.plan.activeNodes) {
+      if (this.plan.actions.get(node) === 'insert') {
+        addMoverNodes(node);
+      }
+    }
+
+    return nodes;
+  }
+
+  // Return the props of `node` that the graph fills in from other models: its
+  // keys and its `#ref{}` values.
+  getFilledProps(node) {
+    return [
+      ...this.keys.getFilledProps(node),
+      ...(this.dependencies.get(node) || []).flatMap((dependency) =>
+        dependency.reference ? [dependency.reference.path[0]] : [],
+      ),
+    ];
+  }
+
+  // Return true if the `#ref{}` of `dependency` reads a prop that the graph
+  // fills into the model it depends on. The other props of existing models are
+  // known right away, but these only once they're filled in (#356). A `#ref`
+  // model is the model it refers to.
+  readsFilledProps(dependency) {
+    const { node, reference } = dependency;
+    const filledProps = this.getFilledProps(node.referencedNode || node);
+    return !!reference && filledProps.includes(reference.refPath[0]);
+  }
+
+  // Return true if `node` waits for the keys or references of inserted models,
+  // also through the models that it references (#356), and through the models
+  // that it waits for to get its keys.
+  _waitsForInserts(node, visitedNodes = new Set()) {
+    const { actions } = this.plan;
+    visitedNodes.add(node);
+    return (this.dependencies.get(node) || []).some((dependency) => {
+      const { node: dependencyNode, relation } = dependency;
+      const referencedNode = dependencyNode.referencedNode || dependencyNode;
+      return (
+        actions.get(referencedNode) === 'insert' ||
+        ((!relation || dependency.isKeyWait) &&
+          !visitedNodes.has(referencedNode) &&
+          this._waitsForInserts(referencedNode, visitedNodes))
+      );
+    });
+  }
+
+  // Return true if `node` is a `#ref` model whose model writes all that it would
+  // write, as its place keeps nothing of its own: It's a BelongsToOne model, or
+  // it's placed where its model is. Many-to-many models write their join rows.
+  _isWrittenByModel(node) {
+    const { referencedNode, relation, parent } = node;
+    return (
+      !!referencedNode &&
+      (relation.keySide === 'owner' ||
+        (relation.keySide === 'related' &&
+          referencedNode.relation === relation &&
+          referencedNode.parent === parent)) &&
+      this.plan.isCoveredByModel(node)
+    );
+  }
+
+  // Map the nodes whose rows reference each other through the keys and values
+  // that they write, also through the rows of other nodes, to the first node of
+  // their cycle: the strongly connected components of these references, found
+  // with Tarjan's algorithm.
+  findReferenceCycles(nodes) {
+    const getRow = (node) => node.referencedNode || node;
+    const nodesByRow = groupBy(nodes, getRow);
+    const getReferencedNodes = (node) =>
+      (this.dependencies.get(node) || [])
+        .flatMap((dependency) => nodesByRow.get(getRow(dependency.node)) || [])
+        .filter((referencedNode) => referencedNode !== node);
+
+    const indices = new Map();
+    const lowLinks = new Map();
+    const stack = [];
+    const stackedNodes = new Set();
+    const cycles = new Map();
+
+    const visit = (node) => {
+      indices.set(node, indices.size);
+      lowLinks.set(node, indices.get(node));
+      stack.push(node);
+      stackedNodes.add(node);
+
+      for (const referencedNode of getReferencedNodes(node)) {
+        if (!indices.has(referencedNode)) {
+          visit(referencedNode);
+          lowLinks.set(node, Math.min(lowLinks.get(node), lowLinks.get(referencedNode)));
+        } else if (stackedNodes.has(referencedNode)) {
+          lowLinks.set(node, Math.min(lowLinks.get(node), indices.get(referencedNode)));
+        }
+      }
+
+      // `node` is the first node of a component, which holds the nodes above
+      // it on the stack:
+      if (lowLinks.get(node) === indices.get(node)) {
+        const componentNodes = stack.splice(stack.lastIndexOf(node));
+
+        for (const componentNode of componentNodes) {
+          stackedNodes.delete(componentNode);
+
+          if (componentNodes.length > 1) {
+            cycles.set(componentNode, node);
+          }
+        }
+      }
+    };
+
+    for (const node of nodes) {
+      if (!indices.has(node)) {
+        visit(node);
+      }
+    }
+
+    return cycles;
+  }
+}
+
+// Collect what each node waits for: The node on the other side of its relation
+// if the node stores its keys, and the nodes it references with `#ref` and
+// `#ref{}`.
+function createDependencies(plan, keys) {
+  const { actions } = plan;
+  const dependencies = new Map();
+
+  const addDependency = (dependent, dependency) => {
+    const nodeDependencies = dependencies.get(dependent);
+    const entry = { dependent, ...dependency };
+
+    if (nodeDependencies) {
+      nodeDependencies.push(entry);
+    } else {
+      dependencies.set(dependent, [entry]);
+    }
+  };
+
+  for (const node of plan.activeNodes) {
+    const { parent, relation } = node;
+
+    // Models marked with `#unrelate` or `#delete` are never inserted or related,
+    // so they don't wait for keys. Ignored models don't replace the current one,
+    // so their owners don't wait for them either.
+    if (parent && !node.toBeUnrelatedOrDeleted) {
+      if (relation.keySide === 'related') {
+        addDependency(node, { node: parent, relation, related: node });
+      } else if (relation.keySide === 'owner' && actions.get(node) !== 'ignore') {
+        addDependency(parent, { node, relation, related: node });
+      }
+    }
+  }
+
+  for (const node of plan.activeNodes) {
+    if (node.referencedNode) {
+      addDependency(node, { node: node.referencedNode });
+    }
+
+    for (const reference of node.propertyReferences) {
+      addDependency(node, { node: reference.referencedNode, reference });
+    }
+
+    // A missing row that the graph inserts elsewhere is related once it is:
+    const insertingNode =
+      node.isMissing && actions.get(node) === 'relate' && plan.findInsertingNode(node);
+
+    if (insertingNode) {
+      addDependency(node, { node: insertingNode });
+    }
+
+    // A place waits for the inserts and `#ref{}` values that bind the slots of
+    // its keys. A dependency on the same row through the same key becomes such
+    // a wait, and stays deferrable to break cycles. The other waits aren't:
+    const getRow = (node) => node.referencedNode || node;
+
+    for (const { node: waitedNode, prop } of keys.waitsFor(node)) {
+      const dependency = (dependencies.get(node) || []).find(
+        (dependency) =>
+          getRow(dependency.node) === getRow(waitedNode) &&
+          (!dependency.relation || getKeyProps(dependency, node).includes(prop)),
+      );
+
+      if (dependency) {
+        dependency.isKeyWait = true;
+      } else {
+        addDependency(node, { node: waitedNode, isKeyWait: true });
+      }
+    }
+
+    // A row that goes into the slot of a HasOneRelation waits for the relate
+    // that moves the current row out of it, as the foreign key may be unique.
+    const moverNode = getSlotMover(plan, node);
+
+    if (moverNode) {
+      addDependency(node, { node: moverNode, isSlotMove: true });
+    }
+  }
+
+  return dependencies;
+}
+
+// Find the relate that moves the current row in the slot of the HasOneRelation
+// that `node` is inserted or related into to another owner, through the same
+// key column.
+function getSlotMover(plan, node) {
+  const { actions } = plan;
+  const slotNode = ['insert', 'relate'].includes(actions.get(node)) && getSlotNode(node);
+  const keptNodes = slotNode ? plan.getKeptNodes(slotNode) : [];
+  return (
+    keptNodes.find(
+      (keptNode) =>
+        actions.get(keptNode) === 'relate' && hasSameKey(slotNode.relation, keptNode.relation),
+    ) || null
+  );
+}
+
+// Find the current row in the slot of the HasOneRelation that `node` relates
+// or is inserted into, or null if it's in another relation or an empty slot.
+function getSlotNode(node) {
+  const { relation } = node;
+  return relation?.keySide === 'related' && relation.isOneToOne()
+    ? (node.parent.existing?.activeChildren.find(
+        (child) => child.relation.name === relation.name,
+      ) ?? null)
+    : null;
+}
+
+// Return the key props of `node` on its side of the relation of `dependency`.
+function getKeyProps({ relation, related }, node) {
+  return (related === node ? relation.relatedProp : relation.ownerProp).props;
+}

package/lib/queryBuilder/graph/GraphUpsert.js

@@ -1,6 +1,8 @@
-import { GraphNode, createNotModelError } from './GraphNode.js';
+import { GraphNode, createNotModelError, formatPath } from './GraphNode.js';
 import { GraphOptions } from './GraphOptions.js';
 import { GraphPlan } from './GraphPlan.js';
+import { GraphKeys, hasSameColumns, readsWrittenValue } from './graphKeys.js';
+import { GraphSchedule } from './GraphSchedule.js';
 import { GraphWriter } from './GraphWriter.js';
 import { loadCurrentGraph } from './GraphLoader.js';
 import { ValidationErrorType } from '../../model/ValidationError.js';
@@ -68,8 +70,10 @@ export class GraphUpsert {
     try {
       checkGraph(builder, new GraphPlan({ nodes, graphOptions }));
       checkPlacements(builder, nodes);
+      checkReferenceCycles(nodes);
       const writtenNodes = new Set();
       let keptNodes = new Map();
+      let laterNodes = new Set();
 
       // Rows that the graph relates into a HasManyRelation or HasOneRelation
       // and gives relations are moved first, and their relations are upserted
@@ -79,6 +83,7 @@ export class GraphUpsert {
           nodes: passNodes,
           graphOptions,
           keptNodes,
+          laterNodes,
         });
         const movedNodes = graphOptions.isInsertOnly() ? [] : await loadCurrentGraph(builder, plan);
 
@@ -87,9 +92,12 @@ export class GraphUpsert {
         checkMissingModels(builder, plan);
         plan.prune().plan();
         checkChangedIds(builder, plan);
-        // The rows that this pass keeps stay kept in the next ones, as decided
-        // before its writes:
-        keptNodes = plan.keptNodes;
+        const [nextLaterNodes, keys] = deferLaterNodes(plan);
+
+        // A pass that only leaves its writes to the next one waits for itself:
+        if (plan.activeNodes.length === 0) {
+          throw new Error('the object graph contains cyclic references');
+        }
 
         // Models that `noInsert` or `noRelate` ignore aren't written, but the
         // ones marked with `#delete` or `#unrelate` keep their values:
@@ -101,9 +109,16 @@ export class GraphUpsert {
 
         checkReferences(builder, plan, writtenNodes);
         checkJoinTables(builder, plan);
-        await new GraphWriter(plan).write(builder);
-
-        passNodes = movedNodes.flatMap((node) => [node, ...node.descendants]);
+        await new GraphWriter(new GraphSchedule(plan, keys)).write(builder);
+        keptNodes = plan.getNextKeptNodes();
+
+        // Moved rows may also wait for a later pass:
+        passNodes = [
+          ...new Set(
+            [...movedNodes, ...nextLaterNodes].flatMap((node) => [node, ...node.descendants]),
+          ),
+        ];
+        laterNodes = new Set(nextLaterNodes);
         identifyReferences(passNodes);
       }
     } catch (err) {
@@ -120,6 +135,22 @@ export class GraphUpsert {
   }
 }
 
+// Leave the writes that need keys or `#ref{}` values that only a later pass
+// gives to that pass, with their branches, and return them with the keys of
+// the rest.
+function deferLaterNodes(plan) {
+  const laterNodes = [];
+  let keys = new GraphKeys(plan);
+
+  for (let nodes = keys.getLaterNodes(); nodes.length > 0; nodes = keys.getLaterNodes()) {
+    laterNodes.push(...nodes);
+    plan.defer([...plan.deferredNodes, ...nodes.flatMap((node) => [node, ...node.descendants])]);
+    keys = new GraphKeys(plan);
+  }
+
+  return [laterNodes, keys];
+}
+
 // Check the models with ids that are neither at their place nor related, once
 // the current graph of a pass is loaded.
 function checkMissingModels(builder, plan) {
@@ -417,7 +448,12 @@ function checkPlacements(builder, nodes) {
     const isDeleted = node.toBeDeleted && !isUnrelated;
 
     if (relation?.keySide === 'related') {
-      if (!isDeleted) {
+      // A row that lists itself on the same column restates its own key:
+      const isSelfLink =
+        getRowId(node) === getRowId(parent) &&
+        hasSameColumns(relation.relatedProp, relation.ownerProp);
+
+      if (!isDeleted && !isSelfLink) {
         relation.relatedProp.forEach((i) => {
           const key = isUnrelated ? null : getKey(parent, relation.ownerProp, i);
           setNodeValue(node, relation.relatedProp.props[i], key, path);
@@ -541,6 +577,31 @@ function checkReferences(builder, plan, writtenNodes) {
   }
 }
 
+// A `#ref{}` waits for the model it reads if the value only exists once that
+// model is written. These waits follow from the graph alone, so their cycles
+// are found across all passes, before the first write.
+function checkReferenceCycles(nodes) {
+  const getWaitedNodes = (node) =>
+    node.propertyReferences
+      .filter((reference) => reference.referencedNode !== node && readsWrittenValue(reference))
+      .map(({ referencedNode }) => referencedNode);
+  const visitingNodes = new Set();
+  const visitedNodes = new Set();
+
+  const visit = (node) => {
+    if (visitingNodes.has(node)) {
+      throw new Error('the object graph contains cyclic references');
+    } else if (!visitedNodes.has(node)) {
+      visitingNodes.add(node);
+      getWaitedNodes(node).forEach(visit);
+      visitingNodes.delete(node);
+      visitedNodes.add(node);
+    }
+  };
+
+  nodes.forEach(visit);
+}
+
 // Inserting or relating a model of a many-to-many relation inserts a join row,
 // which would be a new related row if the join table is also the related table
 // (#133).
@@ -558,12 +619,6 @@ function checkJoinTables(builder, plan) {
   }
 }
 
-// Name the place of a model in error messages, by its data path.
-function formatPath(dataPathKey) {
-  const path = dataPathKey.replace(/^\./, '');
-  return path ? `'${path}'` : 'the root';
-}
-
 function isOnConflictOperation(operation) {
   return ['onConflict', 'ignore', 'merge'].includes(operation.name);
 }