oauthlint-rules 0.2.4 → 0.2.5

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "oauthlint-rules",
-  "version": "0.2.4",
+  "version": "0.2.5",
   "description": "Semgrep rules catching the OAuth/OIDC/JWT anti-patterns that AI coding tools systematically produce.",
   "type": "module",
   "main": "./dist/index.js",

package/rules/flow/open-redirect.yml

@@ -0,0 +1,76 @@
+rules:
+  - id: auth.flow.open-redirect
+    languages:
+      - javascript
+      - typescript
+    severity: ERROR
+    message: |
+      Untrusted request input flows into a redirect destination. Because the
+      target URL is attacker-controlled, this is an open redirect (CWE-601):
+      an attacker can craft a link to your trusted host that bounces the victim
+      to an arbitrary external site. That fuels phishing, and in OAuth flows it
+      can be chained to steal authorization codes or access tokens by sending
+      the victim (and their callback) to a server you do not control.
+
+      Never redirect to a raw `req.query` / `req.body` / `req.params` /
+      `req.cookies` / `req.headers` value. Validate the destination against an
+      explicit allow-list of hosts or route names, or only allow relative paths
+      you control (reject anything containing a scheme or `//`).
+    # Taint mode so indirection is caught — `const dest = req.body.url;
+    # res.redirect(dest)` flags, not just the direct `res.redirect(req.query.x)`
+    # form. Passing the value through an allow-list / validation call
+    # (isAllowedUrl, allowlist.includes, Set.has) clears the taint, so a
+    # genuinely validated redirect does not fire.
+    mode: taint
+    pattern-sources:
+      - pattern: $REQ.query
+      - pattern: $REQ.params
+      - pattern: $REQ.body
+      - pattern: $REQ.cookies
+      - pattern: $REQ.headers
+      - pattern: $REQ.query.$X
+      - pattern: $REQ.params.$X
+      - pattern: $REQ.body.$X
+      - pattern: $REQ.cookies.$X
+      - pattern: $REQ.headers.$X
+      - pattern: $REQ.query[$K]
+      - pattern: $REQ.params[$K]
+      - pattern: $REQ.body[$K]
+      - pattern: $REQ.cookies[$K]
+      - pattern: $REQ.headers[$K]
+    pattern-sanitizers:
+      # Routing the value through an allow-list / validation helper clears the
+      # taint: only the vetted result (not the raw request input) reaches the
+      # sink. Matched by a conventional validation-helper call, or by an
+      # allow-list membership test (`Set.has` / `Array.includes`) that the
+      # value is passed through.
+      - pattern: isAllowedUrl(...)
+      - pattern: validateRedirect(...)
+      - pattern: sanitizeRedirect(...)
+      - pattern: $ALLOW.includes(...)
+      - pattern: $ALLOW.has(...)
+      - pattern: $ALLOW.indexOf(...)
+    pattern-sinks:
+      - patterns:
+          - pattern-either:
+              - pattern: $RES.redirect($SINK)
+              - pattern: $RES.redirect($CODE, $SINK)
+              - pattern: $RES.location($SINK)
+              - pattern: "$RES.set('Location', $SINK)"
+              - pattern: '$RES.set("Location", $SINK)'
+              - pattern: "$RES.setHeader('Location', $SINK)"
+              - pattern: '$RES.setHeader("Location", $SINK)'
+              - pattern: "$RES.writeHead($S, {..., Location: $SINK, ...})"
+          - focus-metavariable: $SINK
+    metadata:
+      oauthlint-rule-id: AUTH-FLOW-010
+      oauthlint-doc-url: https://oauthlint.dev/rules/flow-open-redirect
+      category: security
+      cwe: CWE-601
+      owasp: A01:2021
+      llm-prevalence: HIGH
+      technology:
+        - express
+      references:
+        - https://cheatsheetseries.owasp.org/cheatsheets/Unvalidated_Redirects_and_Forwards_Cheat_Sheet.html
+        - https://cwe.mitre.org/data/definitions/601.html

package/rules/flow/ssrf.yml

@@ -0,0 +1,85 @@
+rules:
+  - id: auth.flow.ssrf
+    languages:
+      - javascript
+      - typescript
+    severity: ERROR
+    message: |
+      Untrusted request input flows into the URL of an outbound HTTP request.
+      Because the destination is attacker-controlled, this is a Server-Side
+      Request Forgery (CWE-918): an attacker can point the request at internal
+      services behind your firewall, or at the cloud metadata endpoint
+      (http://169.254.169.254/...) to steal IAM/instance credentials and pivot
+      deeper into your infrastructure.
+
+      Never build a request URL straight from a raw `req.query` / `req.body` /
+      `req.params` / `req.cookies` / `req.headers` value. Validate the
+      destination against an explicit allow-list of hosts (resolve the URL and
+      check its host against the allow-list, rejecting private/loopback ranges)
+      before issuing the request.
+    # Taint mode so indirection is caught — `const u = req.query.endpoint;
+    # http.get(u)` flags, not just the direct `fetch(req.query.url)` form.
+    # Passing the value through a host allow-list / validation call
+    # (isAllowedUrl, allowlist.includes, Set.has) clears the taint, so a
+    # genuinely vetted outbound request does not fire.
+    mode: taint
+    pattern-sources:
+      - pattern: $REQ.query
+      - pattern: $REQ.params
+      - pattern: $REQ.body
+      - pattern: $REQ.cookies
+      - pattern: $REQ.headers
+      - pattern: $REQ.query.$X
+      - pattern: $REQ.params.$X
+      - pattern: $REQ.body.$X
+      - pattern: $REQ.cookies.$X
+      - pattern: $REQ.headers.$X
+      - pattern: $REQ.query[$K]
+      - pattern: $REQ.params[$K]
+      - pattern: $REQ.body[$K]
+      - pattern: $REQ.cookies[$K]
+      - pattern: $REQ.headers[$K]
+    pattern-sanitizers:
+      # Routing the value through a host allow-list / validation helper clears
+      # the taint: only the vetted destination (not the raw request input)
+      # reaches the request. Matched by a conventional validation-helper call,
+      # or by an allow-list membership test (`Set.has` / `Array.includes`) that
+      # the value is passed through.
+      - pattern: isAllowedUrl(...)
+      - pattern: validateUrl(...)
+      - pattern: assertAllowedHost(...)
+      - pattern: $ALLOW.includes(...)
+      - pattern: $ALLOW.has(...)
+      - pattern: $ALLOW.indexOf(...)
+    pattern-sinks:
+      - patterns:
+          - pattern-either:
+              - pattern: fetch($SINK, ...)
+              - pattern: nodeFetch($SINK, ...)
+              - pattern: request($SINK, ...)
+              - pattern: got($SINK, ...)
+              - pattern: axios($SINK)
+              - pattern: axios.get($SINK, ...)
+              - pattern: axios.post($SINK, ...)
+              - pattern: axios.put($SINK, ...)
+              - pattern: axios.delete($SINK, ...)
+              - pattern: "axios.request({..., url: $SINK, ...})"
+              - pattern: http.get($SINK, ...)
+              - pattern: https.get($SINK, ...)
+              - pattern: http.request($SINK, ...)
+              - pattern: https.request($SINK, ...)
+          - focus-metavariable: $SINK
+    metadata:
+      oauthlint-rule-id: AUTH-FLOW-011
+      oauthlint-doc-url: https://oauthlint.dev/rules/flow-ssrf
+      category: security
+      cwe: CWE-918
+      owasp: API7:2023
+      llm-prevalence: HIGH
+      technology:
+        - express
+        - axios
+        - fetch
+      references:
+        - https://cheatsheetseries.owasp.org/cheatsheets/Server_Side_Request_Forgery_Prevention_Cheat_Sheet.html
+        - https://cwe.mitre.org/data/definitions/918.html

package/rules/go/flow/open-redirect.yml

@@ -0,0 +1,58 @@
+rules:
+  - id: auth.go.flow.open-redirect
+    languages:
+      - go
+    severity: ERROR
+    message: |
+      Untrusted request data flows into an HTTP redirect destination. An
+      attacker who controls the redirect target (via a query parameter, form
+      field, or request header) can forward the victim to an arbitrary
+      external site while the link still appears to point at your trusted
+      domain — a classic open redirect, commonly abused to bypass OAuth
+      `redirect_uri` checks and to mount convincing phishing.
+
+      Do not pass request-derived values straight into `http.Redirect(...)`
+      or a `Location` header. Validate the destination against an explicit
+      allow-list, or restrict it to a known relative path (reject absolute
+      URLs, scheme-relative `//host` values, and back-references) before
+      redirecting. See CWE-601.
+    # Taint mode so indirection (dest := r.FormValue("url"); http.Redirect(w,
+    # r, dest, ...)) is caught, not just the inline form. The taint is cleared
+    # by an allow-list / validation helper that vets the destination, or by a
+    # url.Parse(...)-then-checked flow where the parsed value is inspected
+    # before use.
+    mode: taint
+    pattern-sources:
+      # $R is the *http.Request. Cover the common net/http input shapes.
+      - pattern: $R.URL.Query().Get(...)
+      - pattern: $R.URL.Query()
+      - pattern: $R.URL.Query()[$K]
+      - pattern: $R.FormValue(...)
+      - pattern: $R.PostFormValue(...)
+      - pattern: $R.Header.Get(...)
+    pattern-sanitizers:
+      # Allow-list / validation helper that vets the destination string.
+      - pattern: validateRedirect(...)
+      - pattern: isAllowedRedirect(...)
+      - pattern: $ALLOW.MatchString(...)
+      # url.Parse-then-checked: a parsed URL that has been inspected is treated
+      # as cleared (the result is rebuilt/validated rather than reflected raw).
+      - pattern: url.Parse(...)
+    pattern-sinks:
+      - patterns:
+          - pattern-either:
+              - pattern: http.Redirect($W, $R, $DEST, $CODE)
+              - pattern: $W.Header().Set("Location", $DEST)
+          - focus-metavariable: $DEST
+    metadata:
+      oauthlint-rule-id: AUTH-GO-FLOW-002
+      oauthlint-doc-url: https://oauthlint.dev/rules/go-flow-open-redirect
+      category: security
+      cwe: CWE-601
+      owasp: A01:2021
+      llm-prevalence: HIGH
+      technology:
+        - net/http
+      references:
+        - https://cheatsheetseries.owasp.org/cheatsheets/Unvalidated_Redirects_and_Forwards_Cheat_Sheet.html
+        - https://cwe.mitre.org/data/definitions/601.html

package/rules/go/flow/ssrf.yml

@@ -0,0 +1,76 @@
+rules:
+  - id: auth.go.flow.ssrf
+    languages:
+      - go
+    severity: ERROR
+    message: |
+      Untrusted request data flows into the URL of an outbound HTTP request.
+      An attacker who controls the request target (via a query parameter, form
+      field, or request header) can coerce your server into making requests to
+      arbitrary destinations — Server-Side Request Forgery (SSRF). This is
+      routinely abused to reach internal-only services behind your network
+      perimeter and, most damagingly, the cloud instance metadata endpoint
+      (e.g. http://169.254.169.254/...), letting an attacker steal short-lived
+      credentials and pivot into your cloud account.
+
+      Never pass a request-derived value straight into `http.Get`,
+      `http.Post`, `http.NewRequest`, or a client's `Get`/`Post`. Validate the
+      destination host against an explicit allow-list (parse the URL and check
+      the resolved host/scheme), and reject requests to private, loopback, and
+      link-local address ranges before dialing. See CWE-918.
+    # Taint mode so indirection (target := r.FormValue("endpoint");
+    # http.Get(target)) is caught, not just the inline form. The taint is
+    # cleared by an allow-list / host-validation helper, or by a
+    # url.Parse(...)-then-checked flow where the parsed host is vetted before
+    # the request is made.
+    mode: taint
+    pattern-sources:
+      # $R is the *http.Request. Cover the common net/http input shapes.
+      - pattern: $R.URL.Query().Get(...)
+      - pattern: $R.URL.Query()
+      - pattern: $R.URL.Query()[$K]
+      - pattern: $R.FormValue(...)
+      - pattern: $R.PostFormValue(...)
+      - pattern: $R.Header.Get(...)
+    pattern-sanitizers:
+      # Allow-list / host-validation helper that vets the URL string.
+      - pattern: validateURL(...)
+      - pattern: isAllowedHost(...)
+      - pattern: $ALLOW.MatchString(...)
+      # url.Parse-then-checked: a parsed URL whose host has been inspected is
+      # treated as cleared (the request is built from a vetted destination
+      # rather than the raw untrusted string).
+      - pattern: url.Parse(...)
+    pattern-sinks:
+      # Focus the URL argument so the finding lands on the tainted destination,
+      # not the whole call. The plain call form is used (no aliasing) because
+      # it matches reliably in taint mode.
+      - patterns:
+          - pattern-either:
+              - pattern: http.Get($URL)
+              - pattern: http.Post($URL, ...)
+              - pattern: http.Head($URL)
+              - pattern: http.NewRequest($M, $URL, ...)
+              - pattern: http.NewRequestWithContext($CTX, $M, $URL, ...)
+              - pattern: $CLIENT.Get($URL)
+              - pattern: $CLIENT.Post($URL, ...)
+          # The bare `$CLIENT.Get(...)` shape collides with the request-input
+          # SOURCES that are themselves `.Get(...)` calls (`r.URL.Query().Get(...)`
+          # and `r.Header.Get(...)`), which over-matched the source-assignment
+          # line. Exclude those accessors so each is only ever a source, leaving
+          # `client.Get(url)` as the genuine outbound-request sink.
+          - pattern-not: $Q.Query().Get(...)
+          - pattern-not: $H.Header.Get(...)
+          - focus-metavariable: $URL
+    metadata:
+      oauthlint-rule-id: AUTH-GO-FLOW-003
+      oauthlint-doc-url: https://oauthlint.dev/rules/go-flow-ssrf
+      category: security
+      cwe: CWE-918
+      owasp: API7:2023
+      llm-prevalence: HIGH
+      technology:
+        - net/http
+      references:
+        - https://owasp.org/www-community/attacks/Server_Side_Request_Forgery
+        - https://cwe.mitre.org/data/definitions/918.html

package/rules/py/flow/open-redirect.yml

@@ -0,0 +1,82 @@
+rules:
+  - id: auth.py.flow.open-redirect
+    languages:
+      - python
+    severity: ERROR
+    message: |
+      Untrusted request data flows into a Flask `redirect(...)` without
+      validation — an open redirect (CWE-601). An attacker can craft a link
+      to your trusted domain that bounces the victim to an attacker-controlled
+      site, enabling phishing and OAuth redirect/authorization-code abuse (the
+      victim trusts your URL, then lands on the attacker's page).
+
+      Never redirect to a raw `request.args`/`request.form`/`request.values`/
+      `request.cookies`/`request.headers` value. Build the destination with
+      `url_for(...)` (safe by construction), or validate the target against an
+      explicit allow-list / an `is_safe_url(...)`-style same-host check before
+      redirecting.
+    # Taint mode so indirection (dest = request.args['url']; return redirect(dest))
+    # and `.get(...)` accessors are caught, not just the direct form. Passing the
+    # value through url_for(...) or an is_safe_url(...)/allow-list check clears the
+    # taint. The sink focuses the redirect target argument (and a Location header).
+    mode: taint
+    pattern-sources:
+      - pattern: flask.request.args
+      - pattern: flask.request.form
+      - pattern: flask.request.values
+      - pattern: flask.request.cookies
+      - pattern: flask.request.headers
+      - pattern: request.args
+      - pattern: request.form
+      - pattern: request.values
+      - pattern: request.cookies
+      - pattern: request.headers
+      - pattern: request.args.get(...)
+      - pattern: request.form.get(...)
+      - pattern: request.values.get(...)
+      - pattern: request.cookies.get(...)
+      - pattern: request.headers.get(...)
+      - pattern: request.args[$K]
+      - pattern: request.form[$K]
+      - pattern: request.values[$K]
+      - pattern: request.cookies[$K]
+      - pattern: request.headers[$K]
+    pattern-sanitizers:
+      # `url_for(...)` builds the URL from a known endpoint — safe by construction.
+      - pattern: url_for(...)
+      - pattern: flask.url_for(...)
+      # Allow-list / same-host validators used as a guard:
+      #   if is_safe_url(target): return redirect(target)
+      # A value used inside such an `if` body is treated as validated, so the
+      # guarded redirect does not fire.
+      - patterns:
+          - pattern: $V
+          - pattern-inside: |
+              if is_safe_url($V):
+                  ...
+      - patterns:
+          - pattern: $V
+          - pattern-inside: |
+              if url_has_allowed_host_and_scheme($V, ...):
+                  ...
+    pattern-sinks:
+      - patterns:
+          - pattern-either:
+              - pattern: redirect($SINK)
+              - pattern: redirect($SINK, ...)
+              - pattern: flask.redirect($SINK)
+              - pattern: flask.redirect($SINK, ...)
+              - pattern: 'Response(..., headers={..., "Location": $SINK, ...}, ...)'
+          - focus-metavariable: $SINK
+    metadata:
+      oauthlint-rule-id: AUTH-PY-FLOW-006
+      oauthlint-doc-url: https://oauthlint.dev/rules/py-flow-open-redirect
+      category: security
+      cwe: CWE-601
+      owasp: A01:2021
+      llm-prevalence: HIGH
+      technology:
+        - flask
+      references:
+        - https://cheatsheetseries.owasp.org/cheatsheets/Unvalidated_Redirects_and_Forwards_Cheat_Sheet.html
+        - https://cwe.mitre.org/data/definitions/601.html

package/rules/py/flow/ssrf.yml

@@ -0,0 +1,118 @@
+rules:
+  - id: auth.py.flow.ssrf
+    languages:
+      - python
+    severity: ERROR
+    message: |
+      Untrusted request data flows into an outbound HTTP request without
+      validation — a Server-Side Request Forgery (SSRF, CWE-918). An attacker
+      who controls the target URL can make your server reach internal-only
+      services (admin panels, databases, other microservices behind your
+      firewall) or the cloud metadata endpoint (e.g. http://169.254.169.254/),
+      stealing IAM/instance credentials and pivoting deeper into your network.
+
+      Never pass a raw `request.args`/`request.form`/`request.values`/
+      `request.json`/`request.cookies`/`request.headers` value to
+      `requests`/`urllib`/`httpx`/`aiohttp`. Validate the destination host
+      against an explicit allow-list (`is_allowed_url(...)` /
+      `validate_host(...)` / `url_has_allowed_host_and_scheme(...)`) before the
+      request, and reject link-local / private / metadata addresses.
+    # Taint mode so indirection (url = request.json['endpoint']; httpx.get(url))
+    # and `.get(...)` accessors are caught, not just the direct form. Passing the
+    # value through an allow-list / host validator clears the taint. The sink
+    # focuses the URL argument of each HTTP client call.
+    mode: taint
+    pattern-sources:
+      - pattern: flask.request.args
+      - pattern: flask.request.form
+      - pattern: flask.request.values
+      - pattern: flask.request.json
+      - pattern: flask.request.cookies
+      - pattern: flask.request.headers
+      - pattern: request.args
+      - pattern: request.form
+      - pattern: request.values
+      - pattern: request.json
+      - pattern: request.cookies
+      - pattern: request.headers
+      - pattern: request.args.get(...)
+      - pattern: request.form.get(...)
+      - pattern: request.values.get(...)
+      - pattern: request.json.get(...)
+      - pattern: request.cookies.get(...)
+      - pattern: request.headers.get(...)
+      - pattern: request.args[$K]
+      - pattern: request.form[$K]
+      - pattern: request.values[$K]
+      - pattern: request.json[$K]
+      - pattern: request.cookies[$K]
+      - pattern: request.headers[$K]
+    pattern-sanitizers:
+      # Allow-list / host validators used as a guard:
+      #   if is_allowed_url(url): requests.get(url)
+      # A value used inside such an `if` body is treated as validated, so the
+      # guarded request does not fire. `by-side-effect` is unsupported on
+      # semgrep 1.157, so we use the `pattern-inside` if-guard approach.
+      - patterns:
+          - pattern: $V
+          - pattern-inside: |
+              if is_allowed_url($V):
+                  ...
+      - patterns:
+          - pattern: $V
+          - pattern-inside: |
+              if validate_host($V):
+                  ...
+      - patterns:
+          - pattern: $V
+          - pattern-inside: |
+              if url_has_allowed_host_and_scheme($V, ...):
+                  ...
+    pattern-sinks:
+      - patterns:
+          - pattern-either:
+              - pattern: 'requests.get($URL, ...)'
+              - pattern: 'requests.post($URL, ...)'
+              - pattern: 'requests.put($URL, ...)'
+              - pattern: 'requests.delete($URL, ...)'
+              - pattern: 'requests.patch($URL, ...)'
+              - pattern: 'requests.head($URL, ...)'
+              - pattern: 'requests.request(..., $URL, ...)'
+              - pattern: 'urllib.request.urlopen($URL, ...)'
+              - pattern: urllib.request.urlopen($URL)
+              - pattern: 'httpx.get($URL, ...)'
+              - pattern: 'httpx.post($URL, ...)'
+              - pattern: 'httpx.put($URL, ...)'
+              - pattern: 'httpx.delete($URL, ...)'
+              - pattern: 'httpx.patch($URL, ...)'
+              - pattern: 'httpx.head($URL, ...)'
+              # httpx.Client()/aiohttp session calls. Excluding a `request`
+              # receiver keeps these from matching the `request.X.get(...)`
+              # SOURCE accessors (which would otherwise self-report).
+              - patterns:
+                  - pattern-either:
+                      - pattern: '$CLIENT.get($URL, ...)'
+                      - pattern: '$CLIENT.post($URL, ...)'
+                      - pattern: '$CLIENT.put($URL, ...)'
+                      - pattern: '$CLIENT.delete($URL, ...)'
+                      - pattern: '$CLIENT.patch($URL, ...)'
+                      - pattern: '$CLIENT.head($URL, ...)'
+                      - pattern: '$CLIENT.request(..., $URL, ...)'
+                  - metavariable-regex:
+                      metavariable: $CLIENT
+                      regex: '^(?!request(\.|$)).*'
+          - focus-metavariable: $URL
+    metadata:
+      oauthlint-rule-id: AUTH-PY-FLOW-007
+      oauthlint-doc-url: https://oauthlint.dev/rules/py-flow-ssrf
+      category: security
+      cwe: CWE-918
+      owasp: API7:2023
+      llm-prevalence: HIGH
+      technology:
+        - flask
+        - requests
+        - httpx
+      references:
+        - https://cheatsheetseries.owasp.org/cheatsheets/Server_Side_Request_Forgery_Prevention_Cheat_Sheet.html
+        - https://cwe.mitre.org/data/definitions/918.html