oas 18.0.4 → 18.0.5

package/@types/operation.d.ts

@@ -79,7 +79,8 @@ export default class Operation {
     prepareSecurity(): Record<SecurityType, RMOAS.KeyedSecuritySchemeObject[]>;
     getHeaders(): Operation['headers'];
     /**
-     * Determine if the operation has an operation present in its schema.
+     * Determine if the operation has an operation present in its schema. Note that if one is present
+     * in the schema but is an empty string then this will return false.
      *
      */
     hasOperationId(): boolean;

package/CHANGELOG.md

@@ -1,3 +1,9 @@
+## <small>18.0.5 (2022-03-21)</small>
+
+* fix: `operation.hasOperationId` should return false for an empty string (#624) ([bc23a43](https://github.com/readmeio/oas/commit/bc23a43)), closes [#624](https://github.com/readmeio/oas/issues/624)
+
+
+
 ## <small>18.0.4 (2022-03-21)</small>
 
 * docs: updating the changelog for 17.8.2 ([18c853c](https://github.com/readmeio/oas/commit/18c853c))

package/dist/operation.js

@@ -279,11 +279,12 @@ var Operation = /** @class */ (function () {
         return this.headers;
     };
     /**
-     * Determine if the operation has an operation present in its schema.
+     * Determine if the operation has an operation present in its schema. Note that if one is present
+     * in the schema but is an empty string then this will return false.
      *
      */
     Operation.prototype.hasOperationId = function () {
-        return 'operationId' in this.schema;
+        return Boolean('operationId' in this.schema && this.schema.operationId.length);
     };
     /**
      * Get an `operationId` for this operation. If one is not present (it's not required by the spec!)
@@ -293,7 +294,7 @@ var Operation = /** @class */ (function () {
      * @param opts.camelCase Generate a JS method-friendly operation ID when one isn't present.
      */
     Operation.prototype.getOperationId = function (opts) {
-        if ('operationId' in this.schema) {
+        if (this.hasOperationId()) {
             return this.schema.operationId;
         }
         var method = this.method.toLowerCase();
@@ -304,7 +305,7 @@ var Operation = /** @class */ (function () {
             .toLowerCase();
         if (opts === null || opts === void 0 ? void 0 : opts.camelCase) {
             operationId = operationId.replace(/[^a-zA-Z0-9]+(.)/g, function (_, chr) { return chr.toUpperCase(); });
-            // If the generated operationId already starts with the method (eg. `getPets`) we don't want
+            // If the generated `operationId` already starts with the method (eg. `getPets`) we don't want
             // to double it up into `getGetPets`.
             if (operationId.startsWith(method)) {
                 return operationId;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "oas",
-  "version": "18.0.4",
+  "version": "18.0.5",
   "description": "Working with OpenAPI definitions is hard. This makes it easier.",
   "license": "MIT",
   "author": "ReadMe <support@readme.io> (https://readme.com)",

package/src/operation.ts

@@ -315,11 +315,12 @@ export default class Operation {
   }
 
   /**
-   * Determine if the operation has an operation present in its schema.
+   * Determine if the operation has an operation present in its schema. Note that if one is present
+   * in the schema but is an empty string then this will return false.
    *
    */
   hasOperationId(): boolean {
-    return 'operationId' in this.schema;
+    return Boolean('operationId' in this.schema && this.schema.operationId.length);
   }
 
   /**
@@ -330,7 +331,7 @@ export default class Operation {
    * @param opts.camelCase Generate a JS method-friendly operation ID when one isn't present.
    */
   getOperationId(opts?: { camelCase: boolean }): string {
-    if ('operationId' in this.schema) {
+    if (this.hasOperationId()) {
       return this.schema.operationId;
     }
 
@@ -344,7 +345,7 @@ export default class Operation {
     if (opts?.camelCase) {
       operationId = operationId.replace(/[^a-zA-Z0-9]+(.)/g, (_, chr) => chr.toUpperCase());
 
-      // If the generated operationId already starts with the method (eg. `getPets`) we don't want
+      // If the generated `operationId` already starts with the method (eg. `getPets`) we don't want
       // to double it up into `getGetPets`.
       if (operationId.startsWith(method)) {
         return operationId;