nx 23.3.0-beta.1 → 23.3.0-beta.2

package/dist/src/daemon/client/client.d.ts

@@ -8,6 +8,7 @@ import type { MaybeStubbedPostTasksExecutionContext } from '../../project-graph/
 import { ConfigurationSourceMaps } from '../../project-graph/utils/project-configuration/source-maps';
 import type { FlushSyncGeneratorChangesResult, SyncGeneratorRunResult } from '../../utils/sync-generators';
 import { type ConfigureAiAgentsStatusResponse } from '../message-types/configure-ai-agents';
+import type { NxPluginCapabilities } from '../../project-graph/plugins/nx-plugin-capabilities';
 import { type NxConsoleStatusResponse, type SetNxConsolePreferenceAndInstallResponse } from '../message-types/nx-console';
 /** A refused connect: the errno, and the path it was made against. */
 type ConnectRefusal = {
@@ -100,6 +101,7 @@ export declare class DaemonClient {
         globalGenerators: string[];
         taskGenerators: string[];
     }>;
+    getPluginCapabilities(): Promise<NxPluginCapabilities[]>;
     updateWorkspaceContext(createdFiles: string[], updatedFiles: string[], deletedFiles: string[]): Promise<void>;
     runPreTasksExecution(context: PreTasksExecutionContext): Promise<NodeJS.ProcessEnv[]>;
     runPostTasksExecution(context: MaybeStubbedPostTasksExecutionContext): Promise<void>;

package/dist/src/daemon/client/client.js

@@ -35,6 +35,7 @@ const get_context_file_data_1 = require("../message-types/get-context-file-data"
 const get_files_in_directory_1 = require("../message-types/get-files-in-directory");
 const get_nx_workspace_files_1 = require("../message-types/get-nx-workspace-files");
 const get_registered_sync_generators_1 = require("../message-types/get-registered-sync-generators");
+const get_plugin_capabilities_1 = require("../message-types/get-plugin-capabilities");
 const get_sync_generator_changes_1 = require("../message-types/get-sync-generator-changes");
 const hash_glob_1 = require("../message-types/hash-glob");
 const nx_console_1 = require("../message-types/nx-console");
@@ -718,6 +719,12 @@ class DaemonClient {
         };
         return this.sendToDaemonViaQueue(message);
     }
+    getPluginCapabilities() {
+        const message = {
+            type: get_plugin_capabilities_1.GET_PLUGIN_CAPABILITIES,
+        };
+        return this.sendToDaemonViaQueue(message);
+    }
     updateWorkspaceContext(createdFiles, updatedFiles, deletedFiles) {
         const message = {
             type: update_workspace_context_1.UPDATE_WORKSPACE_CONTEXT,

package/dist/src/daemon/message-types/get-plugin-capabilities.d.ts

@@ -0,0 +1,5 @@
+export declare const GET_PLUGIN_CAPABILITIES: 'GET_PLUGIN_CAPABILITIES';
+export type HandleGetPluginCapabilitiesMessage = {
+    type: typeof GET_PLUGIN_CAPABILITIES;
+};
+export declare function isHandleGetPluginCapabilitiesMessage(message: unknown): message is HandleGetPluginCapabilitiesMessage;

package/dist/src/daemon/message-types/get-plugin-capabilities.js

@@ -0,0 +1,11 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.GET_PLUGIN_CAPABILITIES = void 0;
+exports.isHandleGetPluginCapabilitiesMessage = isHandleGetPluginCapabilitiesMessage;
+exports.GET_PLUGIN_CAPABILITIES = 'GET_PLUGIN_CAPABILITIES';
+function isHandleGetPluginCapabilitiesMessage(message) {
+    return (typeof message === 'object' &&
+        message !== null &&
+        'type' in message &&
+        message['type'] === exports.GET_PLUGIN_CAPABILITIES);
+}

package/dist/src/daemon/server/handle-get-plugin-capabilities.d.ts

@@ -0,0 +1,2 @@
+import type { HandlerResult } from './server';
+export declare function handleGetPluginCapabilities(): Promise<HandlerResult>;

package/dist/src/daemon/server/handle-get-plugin-capabilities.js

@@ -0,0 +1,13 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.handleGetPluginCapabilities = handleGetPluginCapabilities;
+const nx_json_1 = require("../../config/nx-json");
+const get_plugins_1 = require("../../project-graph/plugins/get-plugins");
+const workspace_root_1 = require("../../utils/workspace-root");
+async function handleGetPluginCapabilities() {
+    const plugins = await (0, get_plugins_1.getPlugins)((0, nx_json_1.readNxJson)(workspace_root_1.workspaceRoot), workspace_root_1.workspaceRoot);
+    return {
+        response: plugins.map((plugin) => plugin.capabilities()),
+        description: 'handleGetPluginCapabilities',
+    };
+}

package/dist/src/daemon/server/project-graph-incremental-recomputation.js

@@ -588,7 +588,7 @@ function persistProjectGraphToDisk(result) {
         !result.sourceMaps) {
         return;
     }
-    (0, nx_deps_cache_1.writeCache)(result.projectFileMapCache, result.projectGraph, result.sourceMaps, extractErrors(result.error));
+    (0, nx_deps_cache_1.writeCache)(result.projectFileMapCache, result.projectGraph, result.sourceMaps, extractErrors(result.error), Date.now());
     cacheHasBeenPersisted = true;
 }
 function copyFileData(d) {

package/dist/src/daemon/server/server.js

@@ -27,6 +27,7 @@ const get_context_file_data_1 = require("../message-types/get-context-file-data"
 const get_files_in_directory_1 = require("../message-types/get-files-in-directory");
 const get_nx_workspace_files_1 = require("../message-types/get-nx-workspace-files");
 const get_registered_sync_generators_1 = require("../message-types/get-registered-sync-generators");
+const get_plugin_capabilities_1 = require("../message-types/get-plugin-capabilities");
 const get_sync_generator_changes_1 = require("../message-types/get-sync-generator-changes");
 const glob_1 = require("../message-types/glob");
 const hash_glob_1 = require("../message-types/hash-glob");
@@ -45,6 +46,7 @@ const handle_force_shutdown_1 = require("./handle-force-shutdown");
 const handle_client_env_1 = require("./handle-client-env");
 const handle_get_files_in_directory_1 = require("./handle-get-files-in-directory");
 const handle_get_registered_sync_generators_1 = require("./handle-get-registered-sync-generators");
+const handle_get_plugin_capabilities_1 = require("./handle-get-plugin-capabilities");
 const handle_get_sync_generator_changes_1 = require("./handle-get-sync-generator-changes");
 const handle_glob_1 = require("./handle-glob");
 const handle_hash_glob_1 = require("./handle-hash-glob");
@@ -208,6 +210,9 @@ async function handleMessage(socket, data) {
     else if ((0, get_registered_sync_generators_1.isHandleGetRegisteredSyncGeneratorsMessage)(payload)) {
         await handleResult(socket, get_registered_sync_generators_1.GET_REGISTERED_SYNC_GENERATORS, () => (0, handle_get_registered_sync_generators_1.handleGetRegisteredSyncGenerators)(), mode);
     }
+    else if ((0, get_plugin_capabilities_1.isHandleGetPluginCapabilitiesMessage)(payload)) {
+        await handleResult(socket, get_plugin_capabilities_1.GET_PLUGIN_CAPABILITIES, () => (0, handle_get_plugin_capabilities_1.handleGetPluginCapabilities)(), mode);
+    }
     else if ((0, update_workspace_context_1.isHandleUpdateWorkspaceContextMessage)(payload)) {
         await handleResult(socket, update_workspace_context_1.UPDATE_WORKSPACE_CONTEXT, () => (0, handle_update_workspace_context_1.handleUpdateWorkspaceContext)(payload.createdFiles, payload.updatedFiles, payload.deletedFiles), mode);
     }

package/dist/src/native/index.d.ts

@@ -75,6 +75,8 @@ export declare class FileLock {
   check(): boolean
   wait(): Promise<void>
   lock(): void
+  /** Takes the lock without blocking; false means another handle holds it. */
+  tryLock(): boolean
 }
 
 export declare class HashPlanInspector {
@@ -162,6 +164,16 @@ export declare class NxConsolePreferences {
   setAutoInstallPreference(autoInstall: boolean): void
 }
 
+export declare class NxPluginCapabilities {
+  constructor(db: ExternalObject<NxDbConnection>)
+  record(computedAt: number, capabilities: Array<CachedPluginCapabilities>): void
+  /**
+   * The capabilities recorded with the graph computed at `computed_at`, or
+   * null when what is recorded belongs to another build or nothing is.
+   */
+  get(computedAt: number): Array<CachedPluginCapabilities> | null
+}
+
 export declare class NxTaskHistory {
   constructor(db: ExternalObject<NxDbConnection>)
   recordTaskRuns(taskRuns: Array<TaskRun>): void
@@ -381,6 +393,14 @@ export declare const enum BatchStatus {
   Failure = 'Failure'
 }
 
+export interface CachedPluginCapabilities {
+  createNodesPattern?: string
+  hasCreateDependencies: boolean
+  hasCreateMetadata: boolean
+  hasPreTasksExecution: boolean
+  hasPostTasksExecution: boolean
+}
+
 export interface CachedResult {
   code: number
   terminalOutput?: string

package/dist/src/native/native-bindings.js

@@ -586,6 +586,7 @@ module.exports.IgnoredIndexReader = nativeBinding.IgnoredIndexReader
 module.exports.ImportResult = nativeBinding.ImportResult
 module.exports.NxCache = nativeBinding.NxCache
 module.exports.NxConsolePreferences = nativeBinding.NxConsolePreferences
+module.exports.NxPluginCapabilities = nativeBinding.NxPluginCapabilities
 module.exports.NxTaskHistory = nativeBinding.NxTaskHistory
 module.exports.ProcessMetricsCollector = nativeBinding.ProcessMetricsCollector
 module.exports.RunningTasksService = nativeBinding.RunningTasksService

package/dist/src/project-graph/affected/locators/project-glob-changes.js

@@ -4,15 +4,17 @@ exports.getTouchedProjectsFromProjectGlobChanges = void 0;
 const minimatch_1 = require("minimatch");
 const nx_json_1 = require("../../../config/nx-json");
 const workspace_root_1 = require("../../../utils/workspace-root");
-const path_1 = require("path");
-const fs_1 = require("fs");
-const retrieve_workspace_files_1 = require("../../utils/retrieve-workspace-files");
 const globs_1 = require("../../../utils/globs");
 const get_plugins_1 = require("../../plugins/get-plugins");
+const file_utils_1 = require("../../file-utils");
 const getTouchedProjectsFromProjectGlobChanges = async (touchedFiles, projectGraphNodes, _nxJson, _packageJson, _projectGraph, projectDeletionAffectsAllProjects = true) => {
+    // Only deletions matter here. Uses `isDeletedFile`, not `getChanges()`,
+    // which also parses json/lock files at two revisions for every touched file.
+    const deleted = touchedFiles.filter((touchedFile) => (0, file_utils_1.isDeletedFile)(touchedFile.file));
+    if (!deleted.length) {
+        return [];
+    }
     const globPattern = await (async () => {
-        // TODO: We need a quicker way to get patterns that should not
-        // require starting up plugin workers
         if (process.env.NX_FORCE_REUSE_CACHED_GRAPH === 'true') {
             return (0, globs_1.combineGlobPatterns)([
                 '**/package.json',
@@ -21,27 +23,18 @@ const getTouchedProjectsFromProjectGlobChanges = async (touchedFiles, projectGra
                 'package.json',
             ]);
         }
-        const plugins = (await (0, get_plugins_1.getPlugins)((0, nx_json_1.readNxJson)(workspace_root_1.workspaceRoot))).filter((p) => !!p.createNodes);
-        return (0, globs_1.combineGlobPatterns)((0, retrieve_workspace_files_1.getGlobPatternsOfPlugins)(plugins));
+        const nxJson = (0, nx_json_1.readNxJson)(workspace_root_1.workspaceRoot);
+        const capabilities = await (0, get_plugins_1.capabilitiesOfConfiguredPlugins)(nxJson, workspace_root_1.workspaceRoot);
+        return (0, globs_1.combineGlobPatterns)(capabilities
+            .map((capability) => capability.createNodesPattern)
+            .filter((pattern) => !!pattern));
     })();
-    const touchedProjects = new Set();
-    for (const touchedFile of touchedFiles) {
-        const isProjectFile = (0, minimatch_1.minimatch)(touchedFile.file, globPattern, {
-            dot: true,
-        });
-        if (isProjectFile) {
-            // If the file no longer exists on disk, then it was deleted
-            if (!(0, fs_1.existsSync)((0, path_1.join)(workspace_root_1.workspaceRoot, touchedFile.file))) {
-                // If any project has been deleted, we must assume all projects were affected
-                if (projectDeletionAffectsAllProjects) {
-                    return Object.keys(projectGraphNodes);
-                }
-                continue;
-            }
-            // Modified project config files are under a project's root, and implicitly
-            // mark it as affected. Thus, we don't need to handle it here.
-        }
-    }
-    return Array.from(touchedProjects);
+    const configDeleted = deleted.some((touchedFile) => (0, minimatch_1.minimatch)(touchedFile.file, globPattern, { dot: true }));
+    // If any project has been deleted, we must assume all projects were
+    // affected. A modified project configuration is under its own project's
+    // root, which marks that project affected without this locator.
+    return configDeleted && projectDeletionAffectsAllProjects
+        ? Object.keys(projectGraphNodes)
+        : [];
 };
 exports.getTouchedProjectsFromProjectGlobChanges = getTouchedProjectsFromProjectGlobChanges;

package/dist/src/project-graph/error-types.d.ts

@@ -66,6 +66,10 @@ export declare class ProjectConfigurationsError extends Error {
     constructor(errors: Array<MergeNodesError | AggregateCreateNodesError | ProjectsWithNoNameError | MultipleProjectsWithSameNameError | WorkspaceValidityError>, partialProjectConfigurationsResult: ConfigurationResult);
 }
 export declare function isProjectConfigurationsError(e: unknown): e is ProjectConfigurationsError;
+export declare function formatProjectGraphError(error: ProjectGraphError | ProjectConfigurationsError, isVerbose: boolean): {
+    title: string;
+    bodyLines: string[];
+};
 /**
  * This error should be thrown when a `createNodesV2` function hits a recoverable error.
  * It allows Nx to recieve partial results and continue processing for better UX.
@@ -149,3 +153,4 @@ export declare class LoadPluginError extends Error {
     plugin: string;
     constructor(plugin: string, cause: Error);
 }
+export declare function formatErrorStackAndCause(error: Error): string;

package/dist/src/project-graph/error-types.js

@@ -7,12 +7,14 @@ exports.isMultipleProjectsWithSameNameError = isMultipleProjectsWithSameNameErro
 exports.isProjectsWithNoNameError = isProjectsWithNoNameError;
 exports.isProjectWithNoNameError = isProjectWithNoNameError;
 exports.isProjectConfigurationsError = isProjectConfigurationsError;
+exports.formatProjectGraphError = formatProjectGraphError;
 exports.formatAggregateCreateNodesError = formatAggregateCreateNodesError;
 exports.isWorkspaceValidityError = isWorkspaceValidityError;
 exports.isAggregateProjectGraphError = isAggregateProjectGraphError;
 exports.isCreateMetadataError = isCreateMetadataError;
 exports.isAggregateCreateNodesError = isAggregateCreateNodesError;
 exports.isMergeNodesError = isMergeNodesError;
+exports.formatErrorStackAndCause = formatErrorStackAndCause;
 const tslib_1 = require("tslib");
 class StaleProjectGraphCacheError extends Error {
     constructor() {
@@ -222,6 +224,27 @@ function isProjectConfigurationsError(e) {
             'name' in e &&
             e?.name === ProjectConfigurationsError.name));
 }
+function formatProjectGraphError(error, isVerbose) {
+    const errors = isProjectConfigurationsError(error)
+        ? error.errors
+        : error.getErrors();
+    let title = error.message;
+    if (error.cause &&
+        typeof error.cause === 'object' &&
+        'message' in error.cause) {
+        title += ' ' + error.cause.message + '.';
+    }
+    return {
+        title,
+        bodyLines: isVerbose
+            ? [formatErrorStackAndCause(error)]
+            : [
+                ...errors.map((e) => e.message),
+                '',
+                'Pass --verbose to see the stacktraces.',
+            ],
+    };
+}
 /**
  * This error should be thrown when a `createNodesV2` function hits a recoverable error.
  * It allows Nx to recieve partial results and continue processing for better UX.
@@ -476,9 +499,25 @@ function indentString(str, indent) {
             .join('\n'));
 }
 function formatErrorStackAndCause(error) {
-    const cause = error.cause && error.cause instanceof Error ? error.cause : null;
-    return (error.stack +
-        (cause
-            ? `\nCaused by: \n${indentString(cause.stack ?? cause.message, 2)}`
-            : ''));
+    const cause = describeCause(error.cause);
+    return ((error.stack ?? error.message) +
+        (cause ? `\nCaused by: \n${indentString(cause, 2)}` : ''));
+}
+function describeCause(cause) {
+    if (!cause) {
+        return null;
+    }
+    if (cause instanceof Error) {
+        return cause.stack ?? cause.message;
+    }
+    if (typeof cause === 'object') {
+        const { stack, message } = cause;
+        if (typeof stack === 'string') {
+            return stack;
+        }
+        if (typeof message === 'string') {
+            return message;
+        }
+    }
+    return String(cause);
 }

package/dist/src/project-graph/file-utils.d.ts

@@ -22,6 +22,8 @@ export declare class LockFileChange implements Change {
 export declare function isWholeFileChange(change: Change): change is WholeFileChange;
 export declare function isDeletedFileChange(change: Change): change is DeletedFileChange;
 export declare function isLockFileChange(change: Change): change is LockFileChange;
+/** Whether a touched file was deleted. Much cheaper than `getChanges()`. */
+export declare function isDeletedFile(file: string): boolean;
 export declare function calculateFileChanges(files: string[], nxArgs?: NxArgs, readFileAtRevision?: {
     (f: string, r: string | void): string;
 }, ignore?: ReturnType<typeof ignore>): FileChange[];

package/dist/src/project-graph/file-utils.js

@@ -4,6 +4,7 @@ exports.TEN_MEGABYTES = exports.LockFileChange = exports.DeletedFileChange = exp
 exports.isWholeFileChange = isWholeFileChange;
 exports.isDeletedFileChange = isDeletedFileChange;
 exports.isLockFileChange = isLockFileChange;
+exports.isDeletedFile = isDeletedFile;
 exports.calculateFileChanges = calculateFileChanges;
 exports.defaultFileRead = defaultFileRead;
 exports.readPackageJson = readPackageJson;
@@ -53,6 +54,10 @@ const TEXT_LOCK_FILES = new Set([
     'bun.lock',
 ]);
 const BINARY_LOCK_FILES = new Set(['bun.lockb']);
+/** Whether a touched file was deleted. Much cheaper than `getChanges()`. */
+function isDeletedFile(file) {
+    return !(0, fs_1.existsSync)((0, path_1.join)(workspace_root_1.workspaceRoot, file));
+}
 function calculateFileChanges(files, nxArgs, readFileAtRevision = defaultReadFileAtRevision, ignore = (0, ignore_1.getIgnoreObject)()) {
     files = files.filter((f) => !ignore.ignores(f));
     return files.map((f) => {
@@ -61,7 +66,7 @@ function calculateFileChanges(files, nxArgs, readFileAtRevision = defaultReadFil
         return {
             file: f,
             getChanges: () => {
-                if (!(0, fs_1.existsSync)((0, path_1.join)(workspace_root_1.workspaceRoot, f))) {
+                if (isDeletedFile(f)) {
                     return [new DeletedFileChange()];
                 }
                 if (!nxArgs) {

package/dist/src/project-graph/nx-deps-cache.d.ts

@@ -17,7 +17,10 @@ export declare const nxFileMap: string;
 export declare const nxSourceMaps: string;
 export declare function ensureCacheDirectory(): void;
 export declare function readFileMapCache(): null | FileMapCache;
-export declare function readProjectGraphCache(minimumComputedAt?: number): null | ProjectGraph;
+export declare function readProjectGraphCache(minimumComputedAt?: number): null | {
+    projectGraph: ProjectGraph;
+    computedAt: number | undefined;
+};
 export declare function readSourceMapsCache(): null | ConfigurationSourceMaps;
 export declare function createProjectFileMapCache(nxJson: NxJsonConfiguration<'*' | string[]>, packageJsonDeps: Record<string, string>, fileMap: FileMap, tsConfig: {
     compilerOptions?: {
@@ -26,7 +29,7 @@ export declare function createProjectFileMapCache(nxJson: NxJsonConfiguration<'*
         };
     };
 }, externalNodesHash: string): FileMapCache;
-export declare function writeCache(cache: FileMapCache, projectGraph: ProjectGraph, sourceMaps: ConfigurationSourceMaps, errors: ProjectGraphErrorTypes[]): void;
+export declare function writeCache(cache: FileMapCache, projectGraph: ProjectGraph, sourceMaps: ConfigurationSourceMaps, errors: ProjectGraphErrorTypes[], computedAt: number): void;
 /**
  * Writes the cache only if the on-disk cache file has been modified since
  * this process last wrote it (i.e. an external process overwrote it), or

package/dist/src/project-graph/nx-deps-cache.js

@@ -83,7 +83,7 @@ function readProjectGraphCache(minimumComputedAt) {
                 }
                 throw new error_types_1.ProjectGraphError(errors, projectGraphCache, readSourceMapsCache());
             }
-            return projectGraphCache;
+            return { projectGraph: projectGraphCache, computedAt };
         }
         else {
             return null;
@@ -140,7 +140,7 @@ function createProjectFileMapCache(nxJson, packageJsonDeps, fileMap, tsConfig, e
  * when no external process has modified the cache file since the last write.
  */
 let lastWrittenCacheMtimeMs;
-function writeCache(cache, projectGraph, sourceMaps, errors) {
+function writeCache(cache, projectGraph, sourceMaps, errors, computedAt) {
     perf_hooks_1.performance.mark('write cache:start');
     let retry = 1;
     let done = false;
@@ -158,7 +158,7 @@ function writeCache(cache, projectGraph, sourceMaps, errors) {
             (0, fileutils_1.writeJsonFile)(tmpProjectGraphPath, {
                 ...projectGraph,
                 errors,
-                computedAt: Date.now(),
+                computedAt,
             });
             (0, node_fs_1.renameSync)(tmpProjectGraphPath, exports.nxProjectGraph);
             (0, fileutils_1.writeJsonFile)(tmpSourceMapPath, sourceMaps);
@@ -221,7 +221,7 @@ function writeCacheIfStale(cache, projectGraph, sourceMaps, errors) {
             // File doesn't exist or can't be stat'd — proceed with write
         }
     }
-    writeCache(cache, projectGraph, sourceMaps, errors);
+    writeCache(cache, projectGraph, sourceMaps, errors, Date.now());
 }
 function shouldRecomputeWholeGraph(cache, packageJsonDeps, projects, nxJson, tsConfig, externalNodesHash) {
     if (cache.version !== '6.0') {

package/dist/src/project-graph/plugins/get-plugins.d.ts

@@ -1,4 +1,5 @@
 import { NxJsonConfiguration, PluginConfiguration } from '../../config/nx-json';
+import { type NxPluginCapabilities } from './nx-plugin-capabilities';
 import type { LoadedNxPlugin } from './loaded-nx-plugin';
 export interface SeparatedPlugins {
     specifiedPlugins: LoadedNxPlugin[];
@@ -21,7 +22,7 @@ export declare function resetIsolationFallbackForTesting(): void;
  * threw is rethrown, because rerunning it in-process would bury its actual
  * error.
  */
-export declare const loadingMethod: (plugin: PluginConfiguration, root: string, index?: number) => Promise<readonly [Promise<LoadedNxPlugin>, () => void]>;
+export declare const loadingMethod: (plugin: PluginConfiguration, root: string, index?: number) => Promise<LoadedNxPlugin>;
 /**
  * Returns all plugins (specified + default) as a flat list.
  * Specified plugins come first, followed by default plugins.
@@ -48,4 +49,5 @@ export declare function getOnlyDefaultPlugins(root?: string): Promise<LoadedNxPl
  */
 export declare function getPluginsIfLoadedOrLoading(): Promise<LoadedNxPlugin[]> | undefined;
 export declare function cleanupPlugins(): void;
+export declare function capabilitiesOfConfiguredPlugins(nxJson: NxJsonConfiguration, root?: string): Promise<NxPluginCapabilities[]>;
 export declare function reasonToError(reason: unknown): Error;