nx 23.2.0-beta.4 → 23.2.0-beta.5

package/dist/src/tasks-runner/life-cycles/performance-report.js

@@ -1,6 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.MEANINGFUL_OVERHEAD = exports.MIN_RECOMMENDATION_RUN_DURATION = void 0;
+exports.prefetchRemoteCacheOnboardingUrl = prefetchRemoteCacheOnboardingUrl;
 exports.recommendationToPayloadString = recommendationToPayloadString;
 exports.buildRecommendations = buildRecommendations;
 exports.formatReport = formatReport;
@@ -8,14 +9,72 @@ exports.formatReportMarkdown = formatReportMarkdown;
 exports.buildExitSummaryPayload = buildExitSummaryPayload;
 const native_1 = require("../../native");
 const terminal_link_1 = require("../../utils/terminal-link");
+const nx_cloud_utils_1 = require("../../utils/nx-cloud-utils");
+const url_shorten_1 = require("../../nx-cloud/utilities/url-shorten");
+const get_cloud_options_1 = require("../../nx-cloud/utilities/get-cloud-options");
+const git_utils_1 = require("../../utils/git-utils");
+const logger_1 = require("../../utils/logger");
 const NX_AGENTS_URL = 'https://nx.dev/ci/features/distribute-task-execution';
-const NX_REMOTE_CACHE_URL = 'https://nx.dev/ci/features/remote-cache';
+// Fallback for the remote-cache CTA when the short onboarding URL can't be
+// fetched: the generic Cloud get-started page (still drives to onboarding).
+const NX_CLOUD_GET_STARTED_URL = 'https://cloud.nx.app/get-started';
 const NX_PERFORMANCE_URL = 'https://nx.dev/docs/concepts/ci-concepts/parallelization-distribution';
 /** utm tag attributing report clicks back to it; the content names the CTA clicked. */
 const utm = (content) => `?utm_source=nx-cli&utm_medium=cli&utm_campaign=performance-report&utm_content=${content}`;
 const NX_PERFORMANCE_LINK = `${NX_PERFORMANCE_URL}${utm('parallelization')}`;
 const NX_AGENTS_LINK = `${NX_AGENTS_URL}${utm('nx-agents')}`;
-const NX_REMOTE_CACHE_LINK = `${NX_REMOTE_CACHE_URL}${utm('remote-cache')}`;
+const NX_REMOTE_CACHE_LINK = `${NX_CLOUD_GET_STARTED_URL}${utm('remote-cache')}`;
+// Defaults to the get-started link; a disconnected workspace gets a short Nx
+// Cloud onboarding URL instead (see prefetchRemoteCacheOnboardingUrl).
+let remoteCacheLink = NX_REMOTE_CACHE_LINK;
+// Give up on the short URL after this long so a slow/hung Cloud API never
+// lingers past the exit report. Covers two sequential round trips (features
+// GET, onboarding POST); the 30s CTA floor leaves room. Timing out also aborts
+// the request - Promise.race alone would leave the socket holding the event
+// loop open, which strands programmatic callers that never process.exit.
+const ONBOARDING_URL_TIMEOUT = 5000;
+/**
+ * Point the remote-cache CTA at a short Nx Cloud onboarding URL for a
+ * disconnected GitHub workspace - the VCS flow where Cloud opens the nx.json PR.
+ * Non-GitHub remotes keep the get-started link (handles every provider) and skip
+ * the network entirely. Runs in CI too - terminal + job summary.
+ *
+ * Best-effort: the get-started link stays on failure/timeout. Fired at run start;
+ * the CTA needs a >30s run (MIN_RECOMMENDATION_RUN_DURATION), so the fetch
+ * always resolves first.
+ */
+async function prefetchRemoteCacheOnboardingUrl(nxJson) {
+    if ((0, nx_cloud_utils_1.isNxCloudDisabled)(nxJson) || (0, nx_cloud_utils_1.isNxCloudUsed)(nxJson)) {
+        return;
+    }
+    if ((0, git_utils_1.getVcsRemoteInfo)()?.domain !== 'github.com') {
+        return;
+    }
+    const abortController = new AbortController();
+    try {
+        const url = await Promise.race([
+            (0, url_shorten_1.createNxCloudOnboardingURL)('nx-cli-perf-report', undefined, undefined, false, false, undefined, abortController.signal),
+            new Promise((resolve) => {
+                // unref so the pending timer never keeps the CLI alive on its own.
+                setTimeout(() => {
+                    abortController.abort();
+                    resolve(null);
+                }, ONBOARDING_URL_TIMEOUT).unref();
+            }),
+        ]);
+        // createNxCloudOnboardingURL never throws - on an unreachable API it returns a
+        // paste-a-token URL (accessToken=undefined). Only accept a real short link.
+        if (url?.startsWith(`${(0, get_cloud_options_1.getCloudUrl)()}/connect/`)) {
+            remoteCacheLink = url;
+        }
+        else {
+            logger_1.logger.verbose(`Keeping the get-started remote-cache link (${url === null ? 'onboarding URL timed out' : `got: ${url}`})`);
+        }
+    }
+    catch (e) {
+        logger_1.logger.verbose(`Keeping the get-started remote-cache link: ${e}`);
+    }
+}
 /**
  * Whole-phrase CTA: the whole sentence is the link. The Rust TUI popup keeps no
  * copy of this string; it gets the phrase + href from the exit payload's `links`.
@@ -176,7 +235,7 @@ const RECOMMENDATIONS = [
             c.cacheableCount > 0 &&
             !c.remoteCacheEnabled &&
             c.cacheHits / c.cacheableCount <= LOW_CACHE_HIT_RATE,
-        build: () => [phraseLink(NX_REMOTE_CACHE_CTA, NX_REMOTE_CACHE_LINK), `.`],
+        build: () => [phraseLink(NX_REMOTE_CACHE_CTA, remoteCacheLink), `.`],
     },
     {
         // Cache skipped: drop the flag to restore unchanged tasks instantly.

package/dist/src/tasks-runner/run-command.js

@@ -39,6 +39,7 @@ const store_run_information_life_cycle_1 = require("./life-cycles/store-run-info
 const task_history_life_cycle_1 = require("./life-cycles/task-history-life-cycle");
 const task_profiling_life_cycle_1 = require("./life-cycles/task-profiling-life-cycle");
 const performance_life_cycle_1 = require("./life-cycles/performance-life-cycle");
+const performance_report_1 = require("./life-cycles/performance-report");
 const task_results_life_cycle_1 = require("./life-cycles/task-results-life-cycle");
 const task_telemetry_life_cycle_1 = require("./life-cycles/task-telemetry-life-cycle");
 const task_timings_life_cycle_1 = require("./life-cycles/task-timings-life-cycle");
@@ -80,6 +81,9 @@ async function getTerminalOutputLifeCycle(initiatingProject, initiatingTasks, pr
     if (tasks.length === 1 && !is_tui_enabled_1.ORIGINAL_TUI_ENV_VALUE) {
         process.env.NX_TUI = 'false';
     }
+    // Kick off in the background so the URL is ready by the exit report. A brief
+    // sync preamble (git remote + axios load) runs here; the network call does not.
+    (0, performance_report_1.prefetchRemoteCacheOnboardingUrl)(nxJson);
     if ((0, is_tui_enabled_1.isTuiEnabled)()) {
         const interceptedNxCloudLogs = [];
         // Resolve where the Nx Cloud client bundle actually loads from so the

package/dist/src/utils/assert-workspace-validity.js

@@ -3,7 +3,12 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.assertWorkspaceValidity = assertWorkspaceValidity;
 const find_matching_projects_1 = require("./find-matching-projects");
 const output_1 = require("./output");
-const devkit_internals_1 = require("../devkit-internals");
+// Import from the defining module, not the devkit-internals barrel: this file
+// is on the project-graph construction path, and the barrel now eagerly
+// re-exports the project-graph modules, which would create a require cycle back
+// through build-project-graph. (Release modules cross the barrel as erased
+// types only — see the note in packages/devkit/internal.ts.)
+const error_types_1 = require("../project-graph/error-types");
 function assertWorkspaceValidity(projects, nxJson) {
     const projectNames = Object.keys(projects);
     const projectGraphNodes = projectNames.reduce((graph, project) => {
@@ -65,7 +70,7 @@ function assertWorkspaceValidity(projects, nxJson) {
         })
             .join('\n\n');
     }
-    throw new devkit_internals_1.WorkspaceValidityError(message);
+    throw new error_types_1.WorkspaceValidityError(message);
 }
 function detectAndSetInvalidProjectGlobValues(map, sourceName, desiredImplicitDeps, projectConfigurations, projects) {
     const invalidProjectsOrGlobs = desiredImplicitDeps.filter((implicit) => {

package/dist/src/utils/child-process.js

@@ -13,6 +13,8 @@ const exit_codes_1 = require("./exit-codes");
 function getRunNxBaseCommand(packageManagerCommand, cwd = process.cwd()) {
     if ((0, fs_1.existsSync)((0, path_1.join)(workspace_root_1.workspaceRoot, 'package.json'))) {
         if (!packageManagerCommand) {
+            // `readLocalNxVersion` (command-line/migrate/migrate.ts) mirrors this
+            // selector to predict which nx the spawn will run; keep the two in sync.
             const pm = (0, package_manager_1.detectPackageManager)(workspace_root_1.workspaceRoot);
             packageManagerCommand = (0, package_manager_1.getPackageManagerCommand)(pm, workspace_root_1.workspaceRoot);
         }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nx",
-  "version": "23.2.0-beta.4",
+  "version": "23.2.0-beta.5",
   "private": false,
   "type": "commonjs",
   "description": "The core Nx plugin contains the core functionality of Nx like the project graph, nx commands and task orchestration.",
@@ -65,7 +65,7 @@
     "balanced-match": "4.0.3",
     "base64-js": "1.5.1",
     "bl": "4.1.0",
-    "brace-expansion": "5.0.8",
+    "brace-expansion": "5.0.9",
     "buffer": "5.7.1",
     "bundle-name": "4.1.0",
     "call-bind-apply-helpers": "1.0.2",
@@ -181,16 +181,16 @@
     }
   },
   "optionalDependencies": {
-    "@nx/nx-darwin-arm64": "23.2.0-beta.4",
-    "@nx/nx-darwin-x64": "23.2.0-beta.4",
-    "@nx/nx-freebsd-x64": "23.2.0-beta.4",
-    "@nx/nx-linux-arm-gnueabihf": "23.2.0-beta.4",
-    "@nx/nx-linux-arm64-gnu": "23.2.0-beta.4",
-    "@nx/nx-linux-arm64-musl": "23.2.0-beta.4",
-    "@nx/nx-linux-x64-gnu": "23.2.0-beta.4",
-    "@nx/nx-linux-x64-musl": "23.2.0-beta.4",
-    "@nx/nx-win32-arm64-msvc": "23.2.0-beta.4",
-    "@nx/nx-win32-x64-msvc": "23.2.0-beta.4"
+    "@nx/nx-darwin-arm64": "23.2.0-beta.5",
+    "@nx/nx-darwin-x64": "23.2.0-beta.5",
+    "@nx/nx-freebsd-x64": "23.2.0-beta.5",
+    "@nx/nx-linux-arm-gnueabihf": "23.2.0-beta.5",
+    "@nx/nx-linux-arm64-gnu": "23.2.0-beta.5",
+    "@nx/nx-linux-arm64-musl": "23.2.0-beta.5",
+    "@nx/nx-linux-x64-gnu": "23.2.0-beta.5",
+    "@nx/nx-linux-x64-musl": "23.2.0-beta.5",
+    "@nx/nx-win32-arm64-msvc": "23.2.0-beta.5",
+    "@nx/nx-win32-x64-msvc": "23.2.0-beta.5"
   },
   "nx-migrations": {
     "migrations": "./migrations.json",