nx 23.2.0-beta.2 → 23.2.0-beta.3

package/dist/bin/nx.js

@@ -5,6 +5,7 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 const tslib_1 = require("tslib");
 if (process.env.FORCE_COLOR === '0') {
+    process.env.NX_ORIGINAL_FORCE_COLOR = '0';
     process.env.NO_COLOR = '1';
     delete process.env.FORCE_COLOR;
 }

package/dist/src/analytics/analytics.js

@@ -19,7 +19,7 @@ const os = tslib_1.__importStar(require("os"));
 const crypto_1 = require("crypto");
 const machine_id_cache_1 = require("../utils/machine-id-cache");
 const is_ci_1 = require("../utils/is-ci");
-const analytics_prompt_1 = require("../utils/analytics-prompt");
+const workspace_id_1 = require("../utils/workspace-id");
 const db_connection_1 = require("../utils/db-connection");
 // Conditionally import telemetry functions only on non-WASM platforms
 let initializeTelemetry;
@@ -58,17 +58,20 @@ async function startAnalytics() {
     // detection, machine id, telemetry init) may throw past this boundary -
     // on any failure, continue without telemetry.
     try {
-        if (!isAnalyticsEnabled()) {
+        const nxJson = (0, nx_json_1.readNxJson)(workspace_root_1.workspaceRoot);
+        if (!isAnalyticsEnabled(nxJson)) {
             return;
         }
-        const nxJson = (0, nx_json_1.readNxJson)(workspace_root_1.workspaceRoot);
-        const workspaceId = (0, analytics_prompt_1.generateWorkspaceId)();
+        const workspaceId = (0, workspace_id_1.generateWorkspaceId)(workspace_root_1.workspaceRoot, nxJson);
         if (!workspaceId) {
             // Not a git repo — no telemetry
             return;
         }
         const isNxCloud = !!(nxJson?.nxCloudId ?? nxJson?.nxCloudAccessToken);
-        const userId = await getTelemetryUserId(workspaceId);
+        // A CI fleet is not a user: shared images bake in /etc/machine-id, so a
+        // uid would collapse whole fleets into one GA "user" (and trip per-user
+        // collection caps). GA falls back to cid = workspace for CI traffic.
+        const userId = (0, is_ci_1.isCI)() ? undefined : await getTelemetryUserId(workspaceId);
         const packageManagerInfo = getPackageManagerInfo();
         const nodeVersion = (0, semver_1.parse)(process.version);
         const nodeVersionString = nodeVersion
@@ -232,8 +235,7 @@ function getPackageManagerInfo() {
         version: (0, package_manager_1.getPackageManagerVersion)(pm),
     };
 }
-function isAnalyticsEnabled() {
-    const nxJson = (0, nx_json_1.readNxJson)(workspace_root_1.workspaceRoot);
+function isAnalyticsEnabled(nxJson) {
     return nxJson?.analytics === true;
 }
 // Mix workspace id in: shared Docker images (Gitpod, Cypress, etc.) bake

package/dist/src/command-line/graph/graph.d.ts

@@ -50,6 +50,7 @@ export declare function generateGraph(args: {
     exclude?: string[];
     affected?: boolean;
 }, affectedProjects: string[]): Promise<void>;
+export declare function getExpandedTaskInputs(depGraphClientResponse: ProjectGraphClientResponse, expandedTaskInputsCache: Map<string, Record<string, string[]>>, taskId: string): Promise<Record<string, string[]>>;
 /**
  * The data type that `nx graph --file graph.json` or `nx build --graph graph.json` contains
  */

package/dist/src/command-line/graph/graph.js

@@ -1,6 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.generateGraph = generateGraph;
+exports.getExpandedTaskInputs = getExpandedTaskInputs;
 const tslib_1 = require("tslib");
 const crypto_1 = require("crypto");
 const node_child_process_1 = require("node:child_process");
@@ -9,7 +10,6 @@ const daemon_socket_messenger_1 = require("../../daemon/client/daemon-socket-mes
 const http = tslib_1.__importStar(require("node:http"));
 const minimatch_1 = require("minimatch");
 const node_url_1 = require("node:url");
-const open_1 = tslib_1.__importDefault(require("open"));
 const node_path_1 = require("node:path");
 const net = tslib_1.__importStar(require("node:net"));
 const node_perf_hooks_1 = require("node:perf_hooks");
@@ -34,6 +34,7 @@ const create_task_hasher_1 = require("../../hasher/create-task-hasher");
 const task_env_1 = require("../../tasks-runner/task-env");
 const error_types_1 = require("../../project-graph/error-types");
 const nx_cloud_utils_1 = require("../../utils/nx-cloud-utils");
+const split_target_1 = require("../../utils/split-target");
 // maps file extention to MIME types
 const mimeType = {
     '.ico': 'image/x-icon',
@@ -349,7 +350,11 @@ async function generateGraph(args, affectedProjects) {
             title: `Project graph started at ${url.toString()}`,
         });
         if (args.open) {
-            (0, open_1.default)(url.toString());
+            new Function('return import("open")')()
+                .then((m) => m.default(url.toString()))
+                .catch(() => {
+                // Ignore errors when opening browser (e.g. no browser available)
+            });
         }
         return new Promise((res) => {
             app.once('close', res);
@@ -438,7 +443,7 @@ async function startServer(html, environmentJs, host, port = 4211, watchForChang
             node_perf_hooks_1.performance.mark('task input generation:start');
             const taskId = parsedUrl.searchParams.get('taskId');
             res.writeHead(200, { 'Content-Type': 'application/json' });
-            const inputs = await getExpandedTaskInputs(taskId);
+            const inputs = await getExpandedTaskInputs(currentProjectGraphClientResponse, expandedTaskInputsCache, taskId);
             node_perf_hooks_1.performance.mark('task input generation:end');
             res.end(JSON.stringify({ [taskId]: inputs }));
             node_perf_hooks_1.performance.measure('task input generation', 'task input generation:start', 'task input generation:end');
@@ -823,19 +828,23 @@ async function createTaskGraphForTargetsAndProjects(targetNames, projectNames, c
         };
     }
 }
-async function getExpandedTaskInputs(taskId) {
+async function getExpandedTaskInputs(depGraphClientResponse, expandedTaskInputsCache, taskId) {
     // Check cache first
     if (expandedTaskInputsCache.has(taskId)) {
         return expandedTaskInputsCache.get(taskId);
     }
     // Use the optimized version that only creates the specific task graph needed
-    const [projectName, targetName, configuration] = taskId.split(':');
+    // Use colon-aware splitting so that target names containing colons
+    // (e.g. "test:integration") are parsed correctly instead of being
+    // mistaken for a target + configuration pair.
+    const projectNodes = Object.fromEntries(depGraphClientResponse.projects.map((p) => [p.name, p]));
+    const [projectName, targetName, configuration] = (0, split_target_1.splitTargetFromNodes)(taskId, projectNodes, { silent: true });
     const taskGraphResponse = await createTaskGraphForTargetsAndProjects([targetName], [projectName], configuration);
     const allWorkspaceFiles = await (0, all_file_data_1.allFileData)();
     const inputs = taskGraphResponse.plans?.[taskId];
     let result = {};
     if (inputs) {
-        result = expandInputs(inputs, currentProjectGraphClientResponse.projects.find((p) => p.name === projectName), allWorkspaceFiles, currentProjectGraphClientResponse);
+        result = expandInputs(inputs, depGraphClientResponse.projects.find((p) => p.name === projectName), allWorkspaceFiles, depGraphClientResponse);
     }
     // Cache the result
     expandedTaskInputsCache.set(taskId, result);

package/dist/src/command-line/migrate/migrate.js

@@ -1047,6 +1047,15 @@ function createFetcher(pmc) {
             migrationsCache[packageName + '-' + packageVersion] = migrations;
         }
         migrations = fetchMigrations(packageName, packageVersion, setCache).then((result) => {
+            // An exact requested version must come back verbatim; a mismatch means
+            // a config surface (registry proxy, override, cooldown gate) silently
+            // substituted another version, which would corrupt the whole plan.
+            if ((0, semver_1.valid)(packageVersion) &&
+                result.version &&
+                result.version !== packageVersion) {
+                throw new Error(`Fetching ${packageName}@${packageVersion} resolved to version ${result.version}. ` +
+                    `Check for registry, override, or minimum-release-age configuration that hides the requested version.`);
+            }
             if (result.schematics) {
                 result.generators = { ...result.schematics, ...result.generators };
                 delete result.schematics;
@@ -1107,7 +1116,13 @@ async function downloadPackageMigrationsFromRegistry(packageName, packageVersion
     const { dir, cleanup } = (0, package_manager_1.createTempNpmDirectory)();
     let result;
     try {
-        const { tarballPath } = await (0, package_manager_1.packageRegistryPack)(dir, packageName, packageVersion);
+        const { tarballPath } = await (0, package_manager_1.packageRegistryPack)(dir, packageName, packageVersion, 
+        // packageVersion is exact and already resolved through the workspace
+        // package manager's min-release-age policy by the fetcher. In an npm
+        // workspace the pack gate IS that policy, so leave it enforcing; for
+        // other package managers npm's gate is foreign config with no
+        // exclusions and would wrongly re-judge the vetted version.
+        { bypassMinReleaseAge: (0, package_manager_1.detectPackageManager)() !== 'npm' });
         const fullTarballPath = (0, path_1.join)(dir, tarballPath);
         let migrations;
         try {

package/dist/src/command-line/nx-cloud/connect/connect-to-nx-cloud.js

@@ -26,7 +26,6 @@ const workspace_root_1 = require("../../../utils/workspace-root");
 const git_utils_1 = require("../../../utils/git-utils");
 const pc = tslib_1.__importStar(require("picocolors"));
 const ora = require('ora');
-const open = require('open');
 function onlyDefaultRunnerIsUsed(nxJson) {
     const defaultRunner = nxJson.tasksRunnerOptions?.default?.runner;
     if (!defaultRunner) {
@@ -161,6 +160,7 @@ async function runConnectToNxCloud(options, command) {
     try {
         const cloudConnectSpinner = ora(`Opening Nx Cloud ${connectCloudUrl} in your browser to connect your workspace.`).start();
         await sleep(2000);
+        const { default: open } = await new Function('return import("open")')();
         await open(connectCloudUrl);
         cloudConnectSpinner.succeed();
     }

package/dist/src/command-line/release/utils/remote-release-clients/github.js

@@ -235,7 +235,7 @@ class GithubRemoteReleaseClient extends remote_release_client_1.RemoteReleaseCli
         if (!shouldContinueInGitHub) {
             return;
         }
-        const open = require('open');
+        const { default: open } = await new Function('return import("open")')();
         await open(result.url)
             .then(() => {
             console.info(`\nFollow up in the browser to manually create the release:\n\n` +

package/dist/src/command-line/release/utils/remote-release-clients/gitlab.js

@@ -157,7 +157,7 @@ class GitLabRemoteReleaseClient extends remote_release_client_1.RemoteReleaseCli
         if (!shouldContinueInGitLab) {
             return;
         }
-        const open = require('open');
+        const { default: open } = await new Function('return import("open")')();
         await open(result.url)
             .then(() => {
             console.info(`\nFollow up in the browser to manually create the release:\n\n` +

package/dist/src/config/nx-json.d.ts

@@ -54,8 +54,10 @@ export type TargetDefaultEntry = {
 export type TargetDefaultFilter = {
     /**
      * Restrict the default to targets originated by a specific plugin
-     * (e.g. `@nx/vite`). Matches against the plugin that wrote the target's
-     * `executor` or `command`.
+     * (e.g. `@nx/vite`). Matches against the plugin from nx.json's `plugins`
+     * that wrote the target's `executor` or `command`. Targets whose
+     * executor/command comes from `project.json` or `package.json` have no
+     * source plugin and never match.
      */
     plugin?: string;
     /**