nx 23.0.0-beta.13 → 23.0.0-beta.14

package/dist/src/migrations/update-23-0-0/convert-target-defaults-to-array.d.ts

@@ -1,25 +1,35 @@
 import { Tree } from '../../generators/tree';
+import type { TargetDefaultEntry, TargetDefaultsRecord } from '../../config/nx-json';
 import type { ProjectGraph } from '../../config/project-graph';
 /**
  * Converts the legacy record-shape `targetDefaults` in nx.json to the new
  * array shape introduced in Nx 23. No-op when `targetDefaults` is absent
  * or already an array.
  *
- * Disambiguation strategy for record keys (highest precedence first):
- * 1. Glob → `{ target: key }`.
- * 2. Project graph available: replicate legacy lookup by checking whether
- *    the key matches a target name and/or an executor string anywhere in
- *    the workspace. Emit one entry, or both when it matches both
- *    (genuinely ambiguous; safer to duplicate than drop a default).
- *    If neither matches, the default is dead and we drop the entry.
- * 3. No graph: fall back to the syntactic heuristic — `:` (and not a
- *    glob) → executor; otherwise target.
+ * This is a pure shape conversion: every legacy key produces at least one
+ * array entry, nothing is ever dropped. A key that looks unused at
+ * migration time may still be a live default — the target can be added
+ * later, and the project graph at migration time can be incomplete.
+ *
+ * A project graph is built internally (and only when needed) to
+ * disambiguate `:`-style keys; see {@link convertTargetDefaultsRecordToArray}.
  */
-export default function convertTargetDefaultsToArray(tree: Tree, projectGraph?: ProjectGraph): Promise<string[]>;
+export default function convertTargetDefaultsToArray(tree: Tree): Promise<string[]>;
 /**
- * Treat a legacy record key as an executor when it contains `:` and is
- * not a glob (executor strings are `pkg:name`; globs would also contain
- * `*` / `{` / etc., which `isGlobPattern` catches). Used only as a
- * syntactic fallback when no graph signal is available.
+ * Pure conversion from the legacy record shape to the array shape.
+ *
+ * Kept separate from the migration entry point — and accepting the graph
+ * as an explicit argument — so the disambiguation logic can be unit tested
+ * directly with synthetic graphs. The migration runner never hands a
+ * migration a project graph, so this seam is what keeps that behaviour
+ * testable without standing up a real workspace.
+ *
+ * Disambiguation per key:
+ * - A glob, or a plain key with no `:`, is unambiguously a target name.
+ * - A `:` key is ambiguous (target name vs `pkg:executor` id). When the
+ *   graph shows it used as a target name, an executor, or both, the
+ *   matching entry/entries are emitted. With no graph signal, it falls
+ *   back to the syntactic heuristic (`:` → executor). Either way an entry
+ *   is always emitted.
  */
-export declare function isExecutorLikeKey(key: string): boolean;
+export declare function convertTargetDefaultsRecordToArray(legacy: TargetDefaultsRecord, graph?: ProjectGraph): TargetDefaultEntry[];

package/dist/src/migrations/update-23-0-0/convert-target-defaults-to-array.js

@@ -1,7 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.default = convertTargetDefaultsToArray;
-exports.isExecutorLikeKey = isExecutorLikeKey;
+exports.convertTargetDefaultsRecordToArray = convertTargetDefaultsRecordToArray;
 const format_changed_files_with_prettier_if_available_1 = require("../../generators/internal-utils/format-changed-files-with-prettier-if-available");
 const nx_json_1 = require("../../generators/utils/nx-json");
 const project_graph_1 = require("../../project-graph/project-graph");
@@ -11,17 +11,15 @@ const globs_1 = require("../../utils/globs");
  * array shape introduced in Nx 23. No-op when `targetDefaults` is absent
  * or already an array.
  *
- * Disambiguation strategy for record keys (highest precedence first):
- * 1. Glob → `{ target: key }`.
- * 2. Project graph available: replicate legacy lookup by checking whether
- *    the key matches a target name and/or an executor string anywhere in
- *    the workspace. Emit one entry, or both when it matches both
- *    (genuinely ambiguous; safer to duplicate than drop a default).
- *    If neither matches, the default is dead and we drop the entry.
- * 3. No graph: fall back to the syntactic heuristic — `:` (and not a
- *    glob) → executor; otherwise target.
+ * This is a pure shape conversion: every legacy key produces at least one
+ * array entry, nothing is ever dropped. A key that looks unused at
+ * migration time may still be a live default — the target can be added
+ * later, and the project graph at migration time can be incomplete.
+ *
+ * A project graph is built internally (and only when needed) to
+ * disambiguate `:`-style keys; see {@link convertTargetDefaultsRecordToArray}.
  */
-async function convertTargetDefaultsToArray(tree, projectGraph) {
+async function convertTargetDefaultsToArray(tree) {
     if (!tree.exists('nx.json')) {
         return [];
     }
@@ -33,32 +31,59 @@ async function convertTargetDefaultsToArray(tree, projectGraph) {
         return [];
     if (Array.isArray(targetDefaults))
         return [];
-    const nextSteps = [];
-    const graph = projectGraph ?? (await tryCreateProjectGraph(nextSteps));
     const legacy = targetDefaults;
+    const nextSteps = [];
+    // The graph is only consulted to disambiguate `:`-style keys (target name
+    // vs `pkg:executor` id). Skip building it entirely when there are none.
+    const graph = Object.keys(legacy).some(isExecutorAmbiguousKey)
+        ? await tryCreateProjectGraph(nextSteps)
+        : undefined;
+    nxJson.targetDefaults = convertTargetDefaultsRecordToArray(legacy, graph);
+    (0, nx_json_1.updateNxJson)(tree, nxJson);
+    await (0, format_changed_files_with_prettier_if_available_1.formatChangedFilesWithPrettierIfAvailable)(tree);
+    return nextSteps;
+}
+/**
+ * Pure conversion from the legacy record shape to the array shape.
+ *
+ * Kept separate from the migration entry point — and accepting the graph
+ * as an explicit argument — so the disambiguation logic can be unit tested
+ * directly with synthetic graphs. The migration runner never hands a
+ * migration a project graph, so this seam is what keeps that behaviour
+ * testable without standing up a real workspace.
+ *
+ * Disambiguation per key:
+ * - A glob, or a plain key with no `:`, is unambiguously a target name.
+ * - A `:` key is ambiguous (target name vs `pkg:executor` id). When the
+ *   graph shows it used as a target name, an executor, or both, the
+ *   matching entry/entries are emitted. With no graph signal, it falls
+ *   back to the syntactic heuristic (`:` → executor). Either way an entry
+ *   is always emitted.
+ */
+function convertTargetDefaultsRecordToArray(legacy, graph) {
     const entries = [];
     for (const key of Object.keys(legacy)) {
         const value = legacy[key] ?? {};
         entries.push(...legacyKeyToEntries(key, value, graph));
     }
-    nxJson.targetDefaults = entries;
-    (0, nx_json_1.updateNxJson)(tree, nxJson);
-    await (0, format_changed_files_with_prettier_if_available_1.formatChangedFilesWithPrettierIfAvailable)(tree);
-    return nextSteps;
+    return entries;
 }
 /**
- * Treat a legacy record key as an executor when it contains `:` and is
- * not a glob (executor strings are `pkg:name`; globs would also contain
- * `*` / `{` / etc., which `isGlobPattern` catches). Used only as a
- * syntactic fallback when no graph signal is available.
+ * A legacy record key is ambiguous between a target name and an executor
+ * id only when it contains `:` and is not a glob (executor ids are
+ * `pkg:name`; globs would also contain `*` / `{` / etc., which
+ * `isGlobPattern` catches). These are the only keys the graph helps with.
  */
-function isExecutorLikeKey(key) {
+function isExecutorAmbiguousKey(key) {
     return key.includes(':') && !(0, globs_1.isGlobPattern)(key);
 }
 function legacyKeyToEntries(key, value, graph) {
-    if ((0, globs_1.isGlobPattern)(key)) {
+    // Globs and plain (no `:`) keys are unambiguously target names.
+    if (!isExecutorAmbiguousKey(key)) {
         return [{ target: key, ...value }];
     }
+    // A `:` key could be a target name or a `pkg:executor` id. Use the graph
+    // to disambiguate when it has something to say.
     if (graph) {
         const { matchesTargetName, matchesExecutor } = classifyKeyAgainstGraph(key, graph);
         if (matchesTargetName && matchesExecutor) {
@@ -71,14 +96,11 @@ function legacyKeyToEntries(key, value, graph) {
             return [{ target: key, ...value }];
         if (matchesExecutor)
             return [{ executor: key, ...value }];
-        // Graph evidence said no target and no executor in the workspace
-        // uses this key — the default is dead. Drop it rather than guess.
-        return [];
+        // Graph had no signal for this key — fall through to the syntactic
+        // heuristic rather than dropping the entry.
     }
-    // No graph available; fall back to the syntactic heuristic.
-    return isExecutorLikeKey(key)
-        ? [{ executor: key, ...value }]
-        : [{ target: key, ...value }];
+    // Syntactic fallback: a `:` key that is not a glob is an executor id.
+    return [{ executor: key, ...value }];
 }
 function classifyKeyAgainstGraph(key, graph) {
     let matchesTargetName = false;

package/dist/src/tasks-runner/init-tasks-runner.d.ts

@@ -1,22 +1,7 @@
 import type { NxJsonConfiguration } from '../config/nx-json';
-import { NxArgs } from '../utils/command-line-utils';
 import { Task, TaskGraph } from '../config/task-graph';
 import { LifeCycle, TaskResult } from './life-cycle';
 import type { ProjectGraph } from '../config/project-graph';
 import { RunningTask } from './running-tasks/running-task';
-/**
- * This function is deprecated. Do not use this
- * @deprecated This function is deprecated. Do not use this
- */
-export declare function initTasksRunner(nxArgs: NxArgs): Promise<{
-    invoke: (opts: {
-        tasks: Task[];
-        parallel: number;
-    }) => Promise<{
-        status: NodeJS.Process["exitCode"];
-        taskGraph: TaskGraph;
-        taskResults: Record<string, TaskResult>;
-    }>;
-}>;
 export declare function runDiscreteTasks(tasks: Task[], projectGraph: ProjectGraph, taskGraphForHashing: TaskGraph, nxJson: NxJsonConfiguration, lifeCycle: LifeCycle): Promise<Array<Promise<TaskResult[]>>>;
 export declare function runContinuousTasks(tasks: Task[], projectGraph: ProjectGraph, taskGraphForHashing: TaskGraph, nxJson: NxJsonConfiguration, lifeCycle: LifeCycle): Promise<Record<string, Promise<RunningTask>>>;

package/dist/src/tasks-runner/init-tasks-runner.js

@@ -1,78 +1,15 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.initTasksRunner = initTasksRunner;
 exports.runDiscreteTasks = runDiscreteTasks;
 exports.runContinuousTasks = runContinuousTasks;
-const nx_json_1 = require("../config/nx-json");
-const project_graph_1 = require("../project-graph/project-graph");
 const run_command_1 = require("./run-command");
 const invoke_runner_terminal_output_life_cycle_1 = require("./life-cycles/invoke-runner-terminal-output-life-cycle");
-const perf_hooks_1 = require("perf_hooks");
-const utils_1 = require("./utils");
 const dotenv_1 = require("../utils/dotenv");
 const life_cycle_1 = require("./life-cycle");
 const task_orchestrator_1 = require("./task-orchestrator");
 const create_task_hasher_1 = require("../hasher/create-task-hasher");
 const client_1 = require("../daemon/client/client");
 const task_results_life_cycle_1 = require("./life-cycles/task-results-life-cycle");
-/**
- * This function is deprecated. Do not use this
- * @deprecated This function is deprecated. Do not use this
- */
-async function initTasksRunner(nxArgs) {
-    perf_hooks_1.performance.mark('init-local');
-    (0, dotenv_1.loadRootEnvFiles)();
-    const nxJson = (0, nx_json_1.readNxJson)();
-    if (nxArgs.verbose) {
-        process.env.NX_VERBOSE_LOGGING = 'true';
-    }
-    const projectGraph = await (0, project_graph_1.createProjectGraphAsync)({ exitOnError: true });
-    return {
-        invoke: async (opts) => {
-            perf_hooks_1.performance.mark('code-loading:end');
-            // TODO: This polyfills the outputs if someone doesn't pass a task with outputs. Remove this in Nx 20
-            opts.tasks.forEach((t) => {
-                if (!t.outputs) {
-                    t.outputs = (0, utils_1.getOutputs)(projectGraph.nodes, t.target, t.overrides);
-                }
-            });
-            const lifeCycle = new invoke_runner_terminal_output_life_cycle_1.InvokeRunnerTerminalOutputLifeCycle(opts.tasks);
-            const taskGraph = {
-                roots: opts.tasks.map((task) => task.id),
-                tasks: opts.tasks.reduce((acc, task) => {
-                    acc[task.id] = task;
-                    return acc;
-                }, {}),
-                dependencies: opts.tasks.reduce((acc, task) => {
-                    acc[task.id] = [];
-                    return acc;
-                }, {}),
-                continuousDependencies: opts.tasks.reduce((acc, task) => {
-                    acc[task.id] = [];
-                    return acc;
-                }, {}),
-            };
-            const taskResults = await (0, run_command_1.invokeTasksRunner)({
-                tasks: opts.tasks,
-                projectGraph,
-                taskGraph,
-                lifeCycle,
-                nxJson,
-                nxArgs: { ...nxArgs, parallel: opts.parallel },
-                loadDotEnvFiles: true,
-                initiatingProject: null,
-                initiatingTasks: [],
-            });
-            return {
-                status: Object.values(taskResults).some((taskResult) => taskResult.status === 'failure' || taskResult.status === 'skipped')
-                    ? 1
-                    : 0,
-                taskGraph,
-                taskResults,
-            };
-        },
-    };
-}
 async function createOrchestrator(tasks, projectGraph, taskGraphForHashing, nxJson, lifeCycle) {
     (0, dotenv_1.loadRootEnvFiles)();
     const invokeRunnerTerminalLifecycle = new invoke_runner_terminal_output_life_cycle_1.InvokeRunnerTerminalOutputLifeCycle(tasks);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nx",
-  "version": "23.0.0-beta.13",
+  "version": "23.0.0-beta.14",
   "private": false,
   "type": "commonjs",
   "description": "The core Nx plugin contains the core functionality of Nx like the project graph, nx commands and task orchestration.",
@@ -170,16 +170,16 @@
     }
   },
   "optionalDependencies": {
-    "@nx/nx-darwin-arm64": "23.0.0-beta.13",
-    "@nx/nx-darwin-x64": "23.0.0-beta.13",
-    "@nx/nx-freebsd-x64": "23.0.0-beta.13",
-    "@nx/nx-linux-arm-gnueabihf": "23.0.0-beta.13",
-    "@nx/nx-linux-arm64-gnu": "23.0.0-beta.13",
-    "@nx/nx-linux-arm64-musl": "23.0.0-beta.13",
-    "@nx/nx-linux-x64-gnu": "23.0.0-beta.13",
-    "@nx/nx-linux-x64-musl": "23.0.0-beta.13",
-    "@nx/nx-win32-arm64-msvc": "23.0.0-beta.13",
-    "@nx/nx-win32-x64-msvc": "23.0.0-beta.13"
+    "@nx/nx-darwin-arm64": "23.0.0-beta.14",
+    "@nx/nx-darwin-x64": "23.0.0-beta.14",
+    "@nx/nx-freebsd-x64": "23.0.0-beta.14",
+    "@nx/nx-linux-arm-gnueabihf": "23.0.0-beta.14",
+    "@nx/nx-linux-arm64-gnu": "23.0.0-beta.14",
+    "@nx/nx-linux-arm64-musl": "23.0.0-beta.14",
+    "@nx/nx-linux-x64-gnu": "23.0.0-beta.14",
+    "@nx/nx-linux-x64-musl": "23.0.0-beta.14",
+    "@nx/nx-win32-arm64-msvc": "23.0.0-beta.14",
+    "@nx/nx-win32-x64-msvc": "23.0.0-beta.14"
   },
   "nx-migrations": {
     "migrations": "./migrations.json",
@@ -277,9 +277,6 @@
       "src/native": [
         "dist/src/native/index.d.ts"
       ],
-      "src": [
-        "dist/src/index.d.ts"
-      ],
       "src/analytics": [
         "dist/src/analytics/index.d.ts"
       ],
@@ -389,11 +386,6 @@
       "types": "./dist/plugins/*.d.ts",
       "default": "./dist/plugins/*.js"
     },
-    "./src": {
-      "@nx/nx-source": "./src/index.ts",
-      "types": "./dist/src/index.d.ts",
-      "default": "./dist/src/index.js"
-    },
     "./src/analytics": {
       "@nx/nx-source": "./src/analytics/index.ts",
       "types": "./dist/src/analytics/index.d.ts",

package/dist/src/index.d.ts

@@ -1 +0,0 @@
-export { initTasksRunner } from './tasks-runner/init-tasks-runner';

package/dist/src/index.js

@@ -1,5 +0,0 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.initTasksRunner = void 0;
-var init_tasks_runner_1 = require("./tasks-runner/init-tasks-runner");
-Object.defineProperty(exports, "initTasksRunner", { enumerable: true, get: function () { return init_tasks_runner_1.initTasksRunner; } });