nx 22.4.0-canary.20260109-0fe39b2 → 22.4.0-canary.20260112-6cca28c

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nx",
-  "version": "22.4.0-canary.20260109-0fe39b2",
+  "version": "22.4.0-canary.20260112-6cca28c",
   "private": false,
   "description": "The core Nx plugin contains the core functionality of Nx like the project graph, nx commands and task orchestration.",
   "repository": {
@@ -83,16 +83,16 @@
     }
   },
   "optionalDependencies": {
-    "@nx/nx-darwin-arm64": "22.4.0-canary.20260109-0fe39b2",
-    "@nx/nx-darwin-x64": "22.4.0-canary.20260109-0fe39b2",
-    "@nx/nx-freebsd-x64": "22.4.0-canary.20260109-0fe39b2",
-    "@nx/nx-linux-arm-gnueabihf": "22.4.0-canary.20260109-0fe39b2",
-    "@nx/nx-linux-arm64-gnu": "22.4.0-canary.20260109-0fe39b2",
-    "@nx/nx-linux-arm64-musl": "22.4.0-canary.20260109-0fe39b2",
-    "@nx/nx-linux-x64-gnu": "22.4.0-canary.20260109-0fe39b2",
-    "@nx/nx-linux-x64-musl": "22.4.0-canary.20260109-0fe39b2",
-    "@nx/nx-win32-arm64-msvc": "22.4.0-canary.20260109-0fe39b2",
-    "@nx/nx-win32-x64-msvc": "22.4.0-canary.20260109-0fe39b2"
+    "@nx/nx-darwin-arm64": "22.4.0-canary.20260112-6cca28c",
+    "@nx/nx-darwin-x64": "22.4.0-canary.20260112-6cca28c",
+    "@nx/nx-freebsd-x64": "22.4.0-canary.20260112-6cca28c",
+    "@nx/nx-linux-arm-gnueabihf": "22.4.0-canary.20260112-6cca28c",
+    "@nx/nx-linux-arm64-gnu": "22.4.0-canary.20260112-6cca28c",
+    "@nx/nx-linux-arm64-musl": "22.4.0-canary.20260112-6cca28c",
+    "@nx/nx-linux-x64-gnu": "22.4.0-canary.20260112-6cca28c",
+    "@nx/nx-linux-x64-musl": "22.4.0-canary.20260112-6cca28c",
+    "@nx/nx-win32-arm64-msvc": "22.4.0-canary.20260112-6cca28c",
+    "@nx/nx-win32-x64-msvc": "22.4.0-canary.20260112-6cca28c"
   },
   "nx-migrations": {
     "migrations": "./migrations.json",

package/src/project-graph/plugins/isolation/plugin-pool.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"plugin-pool.d.ts","sourceRoot":"","sources":["../../../../../../../packages/nx/src/project-graph/plugins/isolation/plugin-pool.ts"],"names":[],"mappings":"AAIA,OAAO,EAAE,mBAAmB,EAAE,MAAM,yBAAyB,CAAC;AAK9D,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,qBAAqB,CAAC;AA8C1D,wBAAsB,kBAAkB,CACtC,MAAM,EAAE,mBAAmB,EAC3B,IAAI,EAAE,MAAM,EACZ,KAAK,CAAC,EAAE,MAAM,GACb,OAAO,CAAC,CAAC,OAAO,CAAC,cAAc,CAAC,EAAE,MAAM,IAAI,CAAC,CAAC,CA0FhD"}
+{"version":3,"file":"plugin-pool.d.ts","sourceRoot":"","sources":["../../../../../../../packages/nx/src/project-graph/plugins/isolation/plugin-pool.ts"],"names":[],"mappings":"AAIA,OAAO,EAAE,mBAAmB,EAAE,MAAM,yBAAyB,CAAC;AAO9D,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,qBAAqB,CAAC;AA4C1D,wBAAsB,kBAAkB,CACtC,MAAM,EAAE,mBAAmB,EAC3B,IAAI,EAAE,MAAM,EACZ,KAAK,CAAC,EAAE,MAAM,GACb,OAAO,CAAC,CAAC,OAAO,CAAC,cAAc,CAAC,EAAE,MAAM,IAAI,CAAC,CAAC,CAmGhD"}

package/src/project-graph/plugins/isolation/plugin-pool.js

@@ -2,13 +2,15 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.loadRemoteNxPlugin = loadRemoteNxPlugin;
 const child_process_1 = require("child_process");
-const path = require("path");
 const net_1 = require("net");
+const path = require("path");
+// TODO (@AgentEnder): After scoped verbose logging is implemented, re-add verbose logs here.
+// import { logger } from '../../utils/logger';
 const socket_utils_1 = require("../../../daemon/socket-utils");
 const consume_messages_from_socket_1 = require("../../../utils/consume-messages-from-socket");
-const messaging_1 = require("./messaging");
 const installation_directory_1 = require("../../../utils/installation-directory");
 const resolve_plugin_1 = require("../resolve-plugin");
+const messaging_1 = require("./messaging");
 const cleanupFunctions = new Set();
 const pluginNames = new Map();
 const PLUGIN_TIMEOUT_HINT_TEXT = 'As a last resort, you can set NX_PLUGIN_NO_TIMEOUTS=true to bypass this timeout.';
@@ -60,6 +62,15 @@ async function loadRemoteNxPlugin(plugin, root, index) {
     const exitHandler = createWorkerExitHandler(worker, pendingPromises);
     const cleanupFunction = () => {
         worker.off('exit', exitHandler);
+        // Unpipe streams to prevent hanging processes and release references
+        if (worker.stdout) {
+            worker.stdout.unpipe(process.stdout);
+            worker.stdout.destroy();
+        }
+        if (worker.stderr) {
+            worker.stderr.unpipe(process.stderr);
+            worker.stderr.destroy();
+        }
         socket.destroy();
         nxPluginWorkerCache.delete(cacheKey);
     };
@@ -238,6 +249,13 @@ function createWorkerHandler(worker, pending, onload, onloadError, socket) {
 }
 function createWorkerExitHandler(worker, pendingPromises) {
     return () => {
+        // Clean up piped streams when worker exits to prevent hanging
+        if (worker.stdout) {
+            worker.stdout.unpipe(process.stdout);
+        }
+        if (worker.stderr) {
+            worker.stderr.unpipe(process.stderr);
+        }
         for (const [_, pendingPromise] of pendingPromises) {
             pendingPromise.rejector(new Error(`Plugin worker ${pluginNames.get(worker) ?? worker.pid} exited unexpectedly with code ${worker.exitCode}`));
         }
@@ -301,13 +319,56 @@ async function startPluginWorker(name) {
         ipcPath,
         name,
     ], {
-        stdio: 'inherit',
+        stdio: ['ignore', 'pipe', 'pipe'],
         env,
         detached: true,
         shell: false,
         windowsHide: true,
     });
+    // To make debugging easier and allow plugins to communicate things
+    // like performance metrics, we pipe the stdout/stderr of the worker
+    // to the main process.
+    // This adds one listener per plugin to a few events on process.stdout/stderr,
+    // so we need to increase the max listener count to avoid warnings.
+    //
+    // We originally used `inherit` for stdio, but that caused issues with
+    // some environments where the terminal was left in an inconsistent state
+    // that prevented `↑`/`↓` arrow keys from working correctly after Nx finished execution.
+    // Instead, they would print things like `^[[A`/`^[[B` to the terminal.
+    const stdoutMaxListeners = process.stdout.getMaxListeners();
+    const stderrMaxListeners = process.stderr.getMaxListeners();
+    if (stdoutMaxListeners !== 0) {
+        process.stdout.setMaxListeners(stdoutMaxListeners + 1);
+    }
+    if (stderrMaxListeners !== 0) {
+        process.stderr.setMaxListeners(stderrMaxListeners + 1);
+    }
+    worker.stdout.pipe(process.stdout);
+    worker.stderr.pipe(process.stderr);
+    // Unref the worker process so it doesn't prevent the parent from exiting.
+    // IMPORTANT: We must also unref the stdout/stderr streams. When streams are
+    // piped, they maintain internal references in Node's event loop. Without
+    // unreferencing them, the parent process will wait for the worker to exit
+    // even after worker.unref() is called. This causes e2e tests to hang on CI
+    // where test frameworks wait for all handles to be released.
+    //
+    // Although TypeScript types these as Readable/Writable, they are actually
+    // net.Socket instances at runtime. Node.js internally creates sockets for
+    // stdio pipes (see lib/internal/child_process.js createSocket function).
+    // Socket.unref() allows the event loop to exit if these are the only handles.
     worker.unref();
+    if (worker.stdout instanceof net_1.Socket) {
+        worker.stdout.unref();
+    }
+    else {
+        throw new Error(`Expected worker.stdout to be an instance of Socket, but got ${getTypeName(worker.stdout)}`);
+    }
+    if (worker.stderr instanceof net_1.Socket) {
+        worker.stderr.unref();
+    }
+    else {
+        throw new Error(`Expected worker.stderr to be an instance of Socket, but got ${getTypeName(worker.stderr)}`);
+    }
     let attempts = 0;
     return new Promise((resolve, reject) => {
         const id = setInterval(async () => {
@@ -346,3 +407,16 @@ function isServerAvailable(ipcPath) {
         }
     });
 }
+function getTypeName(u) {
+    if (u === null)
+        return 'null';
+    if (u === undefined)
+        return 'undefined';
+    if (typeof u !== 'object')
+        return typeof u;
+    if (Array.isArray(u)) {
+        const innerTypes = u.map((el) => getTypeName(el));
+        return `Array<${Array.from(new Set(innerTypes)).join('|')}>`;
+    }
+    return u.constructor?.name ?? 'unknown object';
+}