nx 22.1.0 → 22.1.2

package/src/command-line/report/report.js

@@ -21,6 +21,8 @@ const installed_plugins_1 = require("../../utils/plugins/installed-plugins");
 const installation_directory_1 = require("../../utils/installation-directory");
 const nx_json_1 = require("../../config/nx-json");
 const error_types_1 = require("../../project-graph/error-types");
+const operators_1 = require("../../project-graph/operators");
+const versions_1 = require("../../utils/versions");
 const nx_key_1 = require("../../utils/nx-key");
 const cache_1 = require("../../tasks-runner/cache");
 const nxPackageJson = (0, fileutils_1.readJsonFile)((0, path_1.join)(__dirname, '../../../package.json'));
@@ -47,7 +49,7 @@ const LINE_SEPARATOR = '---------------------------------------';
  *
  */
 async function reportHandler() {
-    const { pm, pmVersion, nxKey, nxKeyError, localPlugins, powerpackPlugins, communityPlugins, registeredPlugins, packageVersionsWeCareAbout, outOfSyncPackageGroup, projectGraphError, nativeTarget, cache, } = await getReportData();
+    const { pm, pmVersion, nxKey, nxKeyError, localPlugins, powerpackPlugins, communityPlugins, registeredPlugins, packageVersionsWeCareAbout, outOfSyncPackageGroup, mismatchedNxVersions, projectGraphError, nativeTarget, cache, } = await getReportData();
     const fields = [
         ['Node', process.versions.node],
         ['OS', `${process.platform}-${process.arch}`],
@@ -137,6 +139,26 @@ async function reportHandler() {
         bodyLines.push('');
         bodyLines.push(`To fix this, run \`nx migrate ${outOfSyncPackageGroup.migrateTarget}\``);
     }
+    if (mismatchedNxVersions && mismatchedNxVersions.length > 0) {
+        bodyLines.push(LINE_SEPARATOR);
+        bodyLines.push(chalk.yellow('⚠️ Multiple Nx versions detected'));
+        bodyLines.push('');
+        bodyLines.push(`Your workspace uses nx@${versions_1.nxVersion}, but other packages depend on a different version:`);
+        for (const { version, chain } of mismatchedNxVersions) {
+            if (chain.length === 0) {
+                bodyLines.push(`  - ${chalk.bold(`nx@${version}`)}`);
+            }
+            else {
+                bodyLines.push(`  - ${chain.reverse().join(' → ')} → ${chalk.bold(`nx@${version}`)}`);
+            }
+        }
+        bodyLines.push('');
+        bodyLines.push('These packages should not have nx as a dependency. Please report this issue to the package maintainers.');
+        const whyCommand = (0, package_manager_1.getPackageManagerCommand)(pm).why;
+        for (const { version } of mismatchedNxVersions) {
+            bodyLines.push(`Run \`${whyCommand} nx@${version}\` for more details.`);
+        }
+    }
     if (projectGraphError) {
         bodyLines.push(LINE_SEPARATOR);
         bodyLines.push('⚠️ Unable to construct project graph.');
@@ -148,6 +170,53 @@ async function reportHandler() {
         bodyLines,
     });
 }
+function findDependencyChain(graph, targetNode) {
+    const reversedGraph = (0, operators_1.reverse)(graph);
+    // BFS to find shortest path to root dependency
+    const queue = [
+        { node: targetNode, path: [] },
+    ];
+    const visited = new Set();
+    while (queue.length > 0) {
+        const { node, path } = queue.shift();
+        if (visited.has(node))
+            continue;
+        visited.add(node);
+        const deps = reversedGraph.dependencies[node] || [];
+        // Check for unvisited dependents
+        const unvisitedDeps = deps.filter((dep) => !visited.has(dep.target));
+        // No unvisited dependents - this is our shortest path
+        if (unvisitedDeps.length === 0) {
+            return path;
+        }
+        for (const dep of unvisitedDeps) {
+            const depName = graph.externalNodes?.[dep.target]?.data?.packageName ?? dep.target;
+            queue.push({
+                node: dep.target,
+                path: [...path, depName],
+            });
+        }
+    }
+    return [];
+}
+function findMismatchedNxVersions(graph) {
+    if (!graph || !graph.externalNodes) {
+        return [];
+    }
+    const result = [];
+    // Find all nx package versions that don't match the workspace version
+    for (const nodeName of Object.keys(graph.externalNodes)) {
+        const node = graph.externalNodes[nodeName];
+        if (node.data?.packageName === 'nx') {
+            const version = node.data.version || 'unknown';
+            if (version !== versions_1.nxVersion) {
+                const chain = findDependencyChain(graph, nodeName);
+                result.push({ version, chain });
+            }
+        }
+    }
+    return result;
+}
 async function getReportData() {
     const pm = (0, package_manager_1.detectPackageManager)();
     const pmVersion = (0, package_manager_1.getPackageManagerVersion)(pm);
@@ -169,6 +238,7 @@ async function getReportData() {
         });
     }
     const outOfSyncPackageGroup = findMisalignedPackagesForPackage(nxPackageJson);
+    const mismatchedNxVersions = findMismatchedNxVersions(graph);
     const native = isNativeAvailable();
     let nxKey = null;
     let nxKeyError = null;
@@ -197,6 +267,7 @@ async function getReportData() {
         registeredPlugins,
         packageVersionsWeCareAbout,
         outOfSyncPackageGroup,
+        mismatchedNxVersions,
         projectGraphError,
         nativeTarget: native ? native.getBinaryTarget() : null,
         cache,

package/src/command-line/yargs-utils/arguments-of.d.ts

@@ -0,0 +1,12 @@
+import type { Argv, CommandModule as YargsCommandModule } from 'yargs';
+export type Builder<InitialArgs, FinalArgs> = (yargs: Argv<InitialArgs>) => Argv<FinalArgs>;
+export type Handler<B extends Builder<any, any>> = (args: Awaited<ReturnType<B>['argv']>) => void | Promise<void>;
+export interface CommandModule<T, U> extends Omit<YargsCommandModule<T, U>, 'handler'> {
+    builder: Builder<T, U>;
+    handler: Handler<Builder<T, U>>;
+}
+/**
+ * Helper function to define a Yargs CommandModule with proper typing and not sacrifice inference.
+ */
+export declare function makeCommandModule<T, U>(module: CommandModule<T, U>): CommandModule<T, U>;
+//# sourceMappingURL=arguments-of.d.ts.map

package/src/command-line/yargs-utils/arguments-of.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"arguments-of.d.ts","sourceRoot":"","sources":["../../../../../../packages/nx/src/command-line/yargs-utils/arguments-of.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,IAAI,EAAE,aAAa,IAAI,kBAAkB,EAAE,MAAM,OAAO,CAAC;AAEvE,MAAM,MAAM,OAAO,CAAC,WAAW,EAAE,SAAS,IAAI,CAC5C,KAAK,EAAE,IAAI,CAAC,WAAW,CAAC,KACrB,IAAI,CAAC,SAAS,CAAC,CAAC;AAErB,MAAM,MAAM,OAAO,CAAC,CAAC,SAAS,OAAO,CAAC,GAAG,EAAE,GAAG,CAAC,IAAI,CACjD,IAAI,EAAE,OAAO,CAAC,UAAU,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,KACjC,IAAI,GAAG,OAAO,CAAC,IAAI,CAAC,CAAC;AAE1B,MAAM,WAAW,aAAa,CAAC,CAAC,EAAE,CAAC,CACjC,SAAQ,IAAI,CAAC,kBAAkB,CAAC,CAAC,EAAE,CAAC,CAAC,EAAE,SAAS,CAAC;IACjD,OAAO,EAAE,OAAO,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC;IACvB,OAAO,EAAE,OAAO,CAAC,OAAO,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC;CACjC;AAED;;GAEG;AACH,wBAAgB,iBAAiB,CAAC,CAAC,EAAE,CAAC,EACpC,MAAM,EAAE,aAAa,CAAC,CAAC,EAAE,CAAC,CAAC,GAC1B,aAAa,CAAC,CAAC,EAAE,CAAC,CAAC,CAErB"}

package/src/command-line/yargs-utils/arguments-of.js

@@ -0,0 +1,9 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.makeCommandModule = makeCommandModule;
+/**
+ * Helper function to define a Yargs CommandModule with proper typing and not sacrifice inference.
+ */
+function makeCommandModule(module) {
+    return module;
+}