nx 21.3.5 → 21.3.7

package/bin/nx.js

@@ -68,7 +68,12 @@ async function main() {
             handleMissingLocalInstallation(workspace ? workspace.dir : null);
         }
         // this file is already in the local workspace
-        if (isLocalInstall) {
+        if (isNxCloudCommand(process.argv[2])) {
+            // nx-cloud commands can run without local Nx installation
+            process.env.NX_DAEMON = 'false';
+            require('nx/src/command-line/nx-commands').commandsObject.argv;
+        }
+        else if (isLocalInstall) {
             await (0, init_local_1.initLocal)(workspace);
         }
         else if (localNx) {
@@ -82,11 +87,6 @@ async function main() {
                 require(localNx);
             }
         }
-        else if (isNxCloudCommand(process.argv[2])) {
-            // nx-cloud commands can run without local Nx installation
-            process.env.NX_DAEMON = 'false';
-            require('nx/src/command-line/nx-commands').commandsObject.argv;
-        }
     }
 }
 function handleNoWorkspace(globalNxVersion) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nx",
-  "version": "21.3.5",
+  "version": "21.3.7",
   "private": false,
   "description": "The core Nx plugin contains the core functionality of Nx like the project graph, nx commands and task orchestration.",
   "repository": {
@@ -83,16 +83,16 @@
     }
   },
   "optionalDependencies": {
-    "@nx/nx-darwin-arm64": "21.3.5",
-    "@nx/nx-darwin-x64": "21.3.5",
-    "@nx/nx-freebsd-x64": "21.3.5",
-    "@nx/nx-linux-arm-gnueabihf": "21.3.5",
-    "@nx/nx-linux-arm64-gnu": "21.3.5",
-    "@nx/nx-linux-arm64-musl": "21.3.5",
-    "@nx/nx-linux-x64-gnu": "21.3.5",
-    "@nx/nx-linux-x64-musl": "21.3.5",
-    "@nx/nx-win32-arm64-msvc": "21.3.5",
-    "@nx/nx-win32-x64-msvc": "21.3.5"
+    "@nx/nx-darwin-arm64": "21.3.7",
+    "@nx/nx-darwin-x64": "21.3.7",
+    "@nx/nx-freebsd-x64": "21.3.7",
+    "@nx/nx-linux-arm-gnueabihf": "21.3.7",
+    "@nx/nx-linux-arm64-gnu": "21.3.7",
+    "@nx/nx-linux-arm64-musl": "21.3.7",
+    "@nx/nx-linux-x64-gnu": "21.3.7",
+    "@nx/nx-linux-x64-musl": "21.3.7",
+    "@nx/nx-win32-arm64-msvc": "21.3.7",
+    "@nx/nx-win32-x64-msvc": "21.3.7"
   },
   "nx-migrations": {
     "migrations": "./migrations.json",

package/src/command-line/nx-cloud/connect/command-object.js

@@ -10,7 +10,8 @@ exports.yargsConnectCommand = {
     describe: `Connect workspace to Nx Cloud.`,
     builder: (yargs) => (0, documentation_1.linkToNxDevAndExamples)(withConnectOptions(yargs), 'connect-to-nx-cloud'),
     handler: async (args) => {
-        await (await Promise.resolve().then(() => require('./connect-to-nx-cloud'))).connectToNxCloudCommand(args);
+        const checkRemote = process.env.NX_SKIP_CHECK_REMOTE !== 'true';
+        await (await Promise.resolve().then(() => require('./connect-to-nx-cloud'))).connectToNxCloudCommand({ ...args, checkRemote });
         await (await Promise.resolve().then(() => require('../../../utils/ab-testing'))).recordStat({
             command: 'connect',
             nxVersion: versions_1.nxVersion,

package/src/command-line/nx-cloud/connect/connect-to-nx-cloud.d.ts

@@ -7,6 +7,7 @@ export declare function connectToNxCloudIfExplicitlyAsked(opts: NxArgs): Promise
 export declare function connectWorkspaceToCloud(options: ConnectToNxCloudOptions, directory?: string): Promise<string>;
 export declare function connectToNxCloudCommand(options: {
     generateToken?: boolean;
+    checkRemote?: boolean;
 }, command?: string): Promise<boolean>;
 export declare function connectExistingRepoToNxCloudPrompt(command?: string, key?: MessageKey): Promise<boolean>;
 export declare function connectToNxCloudWithPrompt(command: string): Promise<void>;

package/src/command-line/nx-cloud/connect/connect-to-nx-cloud.js

@@ -17,8 +17,9 @@ const ab_testing_1 = require("../../../utils/ab-testing");
 const versions_1 = require("../../../utils/versions");
 const workspace_root_1 = require("../../../utils/workspace-root");
 const chalk = require("chalk");
-const ora = require("ora");
-const open = require("open");
+const git_utils_1 = require("../../../utils/git-utils");
+const ora = require('ora');
+const open = require('open');
 function onlyDefaultRunnerIsUsed(nxJson) {
     const defaultRunner = nxJson.tasksRunnerOptions?.default?.runner;
     if (!defaultRunner) {
@@ -59,6 +60,17 @@ async function connectToNxCloudCommand(options, command) {
     const installationSource = process.env.NX_CONSOLE
         ? 'nx-console'
         : 'nx-connect';
+    const hasRemote = !!(0, git_utils_1.getGitRemote)();
+    if (!hasRemote && options.checkRemote) {
+        output_1.output.error({
+            title: 'Missing VCS provider',
+            bodyLines: [
+                'Push this repository to a VCS provider (e.g., GitHub) and try again.',
+                'Go to https://github.com/new to create a repository on GitHub.',
+            ],
+        });
+        return false;
+    }
     if ((0, nx_cloud_utils_1.isNxCloudUsed)(nxJson)) {
         const token = process.env.NX_CLOUD_ACCESS_TOKEN ||
             nxJson.nxCloudAccessToken ||

package/src/native/index.d.ts

@@ -252,6 +252,9 @@ export declare export declare function installNxConsole(): void
 
 export const IS_WASM: boolean
 
+/** Detects if the current process is being run by an AI agent */
+export declare export declare function isAiAgent(): boolean
+
 export declare export declare function logDebug(message: string): void
 
 /** Stripped version of the NxJson interface for use in rust */

package/src/native/native-bindings.js

@@ -392,6 +392,7 @@ module.exports.hashArray = nativeBinding.hashArray
 module.exports.hashFile = nativeBinding.hashFile
 module.exports.installNxConsole = nativeBinding.installNxConsole
 module.exports.IS_WASM = nativeBinding.IS_WASM
+module.exports.isAiAgent = nativeBinding.isAiAgent
 module.exports.logDebug = nativeBinding.logDebug
 module.exports.parseTaskStatus = nativeBinding.parseTaskStatus
 module.exports.remove = nativeBinding.remove

package/src/native/nx.wasi.cjs

@@ -124,16 +124,17 @@ function __napi_rs_initialize_modules(__napiInstance) {
   __napiInstance.exports['__napi_register__ExternalDependenciesInput_struct_49']?.()
   __napiInstance.exports['__napi_register__DepsOutputsInput_struct_50']?.()
   __napiInstance.exports['__napi_register__NxJson_struct_51']?.()
-  __napiInstance.exports['__napi_register__FileLock_struct_52']?.()
-  __napiInstance.exports['__napi_register__FileLock_impl_54']?.()
-  __napiInstance.exports['__napi_register__WorkspaceContext_struct_55']?.()
-  __napiInstance.exports['__napi_register__WorkspaceContext_impl_66']?.()
-  __napiInstance.exports['__napi_register__WorkspaceErrors_67']?.()
-  __napiInstance.exports['__napi_register__NxWorkspaceFiles_struct_68']?.()
-  __napiInstance.exports['__napi_register__NxWorkspaceFilesExternals_struct_69']?.()
-  __napiInstance.exports['__napi_register__UpdatedWorkspaceFiles_struct_70']?.()
-  __napiInstance.exports['__napi_register__FileMap_struct_71']?.()
-  __napiInstance.exports['__napi_register____test_only_transfer_file_map_72']?.()
+  __napiInstance.exports['__napi_register__is_ai_agent_52']?.()
+  __napiInstance.exports['__napi_register__FileLock_struct_53']?.()
+  __napiInstance.exports['__napi_register__FileLock_impl_55']?.()
+  __napiInstance.exports['__napi_register__WorkspaceContext_struct_56']?.()
+  __napiInstance.exports['__napi_register__WorkspaceContext_impl_67']?.()
+  __napiInstance.exports['__napi_register__WorkspaceErrors_68']?.()
+  __napiInstance.exports['__napi_register__NxWorkspaceFiles_struct_69']?.()
+  __napiInstance.exports['__napi_register__NxWorkspaceFilesExternals_struct_70']?.()
+  __napiInstance.exports['__napi_register__UpdatedWorkspaceFiles_struct_71']?.()
+  __napiInstance.exports['__napi_register__FileMap_struct_72']?.()
+  __napiInstance.exports['__napi_register____test_only_transfer_file_map_73']?.()
 }
 module.exports.FileLock = __napiModule.exports.FileLock
 module.exports.HashPlanInspector = __napiModule.exports.HashPlanInspector
@@ -153,6 +154,7 @@ module.exports.hashArray = __napiModule.exports.hashArray
 module.exports.hashFile = __napiModule.exports.hashFile
 module.exports.installNxConsole = __napiModule.exports.installNxConsole
 module.exports.IS_WASM = __napiModule.exports.IS_WASM
+module.exports.isAiAgent = __napiModule.exports.isAiAgent
 module.exports.logDebug = __napiModule.exports.logDebug
 module.exports.remove = __napiModule.exports.remove
 module.exports.testOnlyTransferFileMap = __napiModule.exports.testOnlyTransferFileMap

package/src/plugins/js/project-graph/build-dependencies/target-project-locator.js

@@ -292,9 +292,13 @@ class TargetProjectLocator {
             resolvedModule.includes('/node_modules/')) {
             return undefined;
         }
-        const normalizedResolvedModule = resolvedModule.startsWith('./')
+        let normalizedResolvedModule = resolvedModule.startsWith('./')
             ? resolvedModule.substring(2)
             : resolvedModule;
+        // Remove trailing slash to ensure proper project matching
+        if (normalizedResolvedModule.endsWith('/')) {
+            normalizedResolvedModule = normalizedResolvedModule.slice(0, -1);
+        }
         const importedProject = this.findMatchingProjectFiles(normalizedResolvedModule);
         return importedProject ? importedProject.name : void 0;
     }

package/src/project-graph/utils/normalize-project-nodes.d.ts

@@ -1,6 +1,6 @@
-import { ProjectGraphProjectNode } from '../../config/project-graph';
-import { ProjectGraphBuilder } from '../project-graph-builder';
-import { ProjectConfiguration } from '../../config/workspace-json-project-json';
-import { CreateDependenciesContext } from '../plugins';
-export declare function normalizeProjectNodes({ projects }: CreateDependenciesContext, builder: ProjectGraphBuilder): Promise<void>;
+import type { ProjectGraphProjectNode } from '../../config/project-graph';
+import type { ProjectConfiguration } from '../../config/workspace-json-project-json';
+import type { CreateDependenciesContext } from '../plugins';
+import type { ProjectGraphBuilder } from '../project-graph-builder';
+export declare function normalizeProjectNodes({ projects, workspaceRoot }: CreateDependenciesContext, builder: ProjectGraphBuilder): Promise<void>;
 export declare function normalizeImplicitDependencies(source: string, implicitDependencies: ProjectConfiguration['implicitDependencies'], projects: Record<string, ProjectGraphProjectNode>): string[];

package/src/project-graph/utils/normalize-project-nodes.js

@@ -2,8 +2,11 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.normalizeProjectNodes = normalizeProjectNodes;
 exports.normalizeImplicitDependencies = normalizeImplicitDependencies;
+const node_fs_1 = require("node:fs");
+const node_path_1 = require("node:path");
+const fileutils_1 = require("../../utils/fileutils");
 const find_matching_projects_1 = require("../../utils/find-matching-projects");
-async function normalizeProjectNodes({ projects }, builder) {
+async function normalizeProjectNodes({ projects, workspaceRoot }, builder) {
     // Sorting projects by name to make sure that the order of projects in the graph is deterministic.
     // This is important to ensure that expanded properties referencing projects (e.g. implicit dependencies)
     // are also deterministic, and thus don't cause the calculated project configuration hash to shift.
@@ -26,11 +29,7 @@ async function normalizeProjectNodes({ projects }, builder) {
         p.implicitDependencies = normalizeImplicitDependencies(key, p.implicitDependencies, partialProjectGraphNodes);
         p.targets ??= {};
         // TODO: remove in v16
-        const projectType = p.projectType === 'application'
-            ? key.endsWith('-e2e') || key === 'e2e'
-                ? 'e2e'
-                : 'app'
-            : 'lib';
+        const projectType = getProjectType(key, p.projectType, workspaceRoot, p.root);
         const tags = p.tags || [];
         toAdd.push({
             name: key,
@@ -86,3 +85,33 @@ function normalizeImplicitDependencies(source, implicitDependencies, projects) {
     // detected by createDependencies.
     return deps.concat(alwaysIgnoredDeps.map((x) => '!' + x));
 }
+function getProjectType(projectName, projectType, workspaceRoot, projectRoot) {
+    if (projectType) {
+        if (projectType === 'library') {
+            return 'lib';
+        }
+        if (projectName.endsWith('-e2e') || projectName === 'e2e') {
+            return 'e2e';
+        }
+        return 'app';
+    }
+    if ((0, node_fs_1.existsSync)((0, node_path_1.join)(workspaceRoot, projectRoot, 'tsconfig.lib.json'))) {
+        return 'lib';
+    }
+    if ((0, node_fs_1.existsSync)((0, node_path_1.join)(workspaceRoot, projectRoot, 'tsconfig.app.json'))) {
+        return 'app';
+    }
+    // If it doesn't have any common library entry points, assume it is an application
+    const packageJsonPath = (0, node_path_1.join)(workspaceRoot, projectRoot, 'package.json');
+    try {
+        const packageJson = (0, fileutils_1.readJsonFile)(packageJsonPath);
+        if (!packageJson.exports &&
+            !packageJson.main &&
+            !packageJson.module &&
+            !packageJson.bin) {
+            return 'app';
+        }
+    }
+    catch { }
+    return 'lib';
+}

package/src/tasks-runner/is-tui-enabled.js

@@ -56,6 +56,8 @@ function shouldUseTui(nxJson, nxArgs, skipCapabilityCheck = process.env.NX_TUI_S
     if (
     // Interactive TUI doesn't make sense on CI
     (0, is_ci_1.isCI)() ||
+        // Interactive TUI doesn't make sense in an AI agent context
+        (0, native_1.isAiAgent)() ||
         // TODO(@JamesHenry): Remove this check once Windows issues are fixed.
         // Windows is not working well right now, temporarily disable it on Windows even if it has been specified as enabled
         isWindows ||

package/src/utils/git-utils.d.ts

@@ -32,6 +32,7 @@ export declare class GitRepository {
     private quotePath;
     private quoteArg;
 }
+export declare function getGitRemote(): string;
 /**
  * This is currently duplicated in Nx Console. Please let @MaxKless know if you make changes here.
  */

package/src/utils/git-utils.js

@@ -2,6 +2,7 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.GitRepository = void 0;
 exports.cloneFromUpstream = cloneFromUpstream;
+exports.getGitRemote = getGitRemote;
 exports.getGithubSlugOrNull = getGithubSlugOrNull;
 exports.extractUserAndRepoFromGitHubUrl = extractUserAndRepoFromGitHubUrl;
 exports.commitChanges = commitChanges;
@@ -170,15 +171,21 @@ class GitRepository {
     }
 }
 exports.GitRepository = GitRepository;
+function getGitRemote() {
+    const res = (0, child_process_1.execSync)('git remote -v', {
+        stdio: 'pipe',
+        windowsHide: false,
+    })
+        .toString()
+        .trim();
+    return res;
+}
 /**
  * This is currently duplicated in Nx Console. Please let @MaxKless know if you make changes here.
  */
 function getGithubSlugOrNull() {
     try {
-        const gitRemote = (0, child_process_1.execSync)('git remote -v', {
-            stdio: 'pipe',
-            windowsHide: false,
-        }).toString();
+        const gitRemote = getGitRemote();
         // If there are no remotes, we default to github
         if (!gitRemote || gitRemote.length === 0) {
             return 'github';