nx 21.0.1 → 21.0.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nx",
-  "version": "21.0.1",
+  "version": "21.0.2",
   "private": false,
   "description": "The core Nx plugin contains the core functionality of Nx like the project graph, nx commands and task orchestration.",
   "repository": {
@@ -83,16 +83,16 @@
     }
   },
   "optionalDependencies": {
-    "@nx/nx-darwin-arm64": "21.0.1",
-    "@nx/nx-darwin-x64": "21.0.1",
-    "@nx/nx-freebsd-x64": "21.0.1",
-    "@nx/nx-linux-arm-gnueabihf": "21.0.1",
-    "@nx/nx-linux-arm64-gnu": "21.0.1",
-    "@nx/nx-linux-arm64-musl": "21.0.1",
-    "@nx/nx-linux-x64-gnu": "21.0.1",
-    "@nx/nx-linux-x64-musl": "21.0.1",
-    "@nx/nx-win32-arm64-msvc": "21.0.1",
-    "@nx/nx-win32-x64-msvc": "21.0.1"
+    "@nx/nx-darwin-arm64": "21.0.2",
+    "@nx/nx-darwin-x64": "21.0.2",
+    "@nx/nx-freebsd-x64": "21.0.2",
+    "@nx/nx-linux-arm-gnueabihf": "21.0.2",
+    "@nx/nx-linux-arm64-gnu": "21.0.2",
+    "@nx/nx-linux-arm64-musl": "21.0.2",
+    "@nx/nx-linux-x64-gnu": "21.0.2",
+    "@nx/nx-linux-x64-musl": "21.0.2",
+    "@nx/nx-win32-arm64-msvc": "21.0.2",
+    "@nx/nx-win32-x64-msvc": "21.0.2"
   },
   "nx-migrations": {
     "migrations": "./migrations.json",

package/src/executors/run-script/run-script.impl.js

@@ -5,6 +5,7 @@ const child_process_1 = require("child_process");
 const path = require("path");
 const pseudo_terminal_1 = require("../../tasks-runner/pseudo-terminal");
 const package_manager_1 = require("../../utils/package-manager");
+const exit_codes_1 = require("../../utils/exit-codes");
 async function default_1(options, context) {
     const pm = (0, package_manager_1.getPackageManagerCommand)();
     try {
@@ -38,11 +39,12 @@ function nodeProcess(command, cwd, env) {
         windowsHide: false,
     });
 }
+let cp;
 async function ptyProcess(command, cwd, env) {
     const terminal = (0, pseudo_terminal_1.createPseudoTerminal)();
     await terminal.init();
     return new Promise((res, rej) => {
-        const cp = terminal.runCommand(command, { cwd, jsEnv: env });
+        cp = terminal.runCommand(command, { cwd, jsEnv: env });
         cp.onExit((code) => {
             if (code === 0) {
                 res();
@@ -56,3 +58,16 @@ async function ptyProcess(command, cwd, env) {
         });
     });
 }
+// TODO: This only works because pseudo terminal registers signal handlers first but we need a service to handle this
+process.on('SIGHUP', () => {
+    cp.kill('SIGHUP');
+    process.exit((0, exit_codes_1.signalToCode)('SIGHUP'));
+});
+process.on('SIGTERM', () => {
+    cp.kill('SIGTERM');
+    process.exit((0, exit_codes_1.signalToCode)('SIGTERM'));
+});
+process.on('SIGINT', () => {
+    cp.kill('SIGINT');
+    process.exit((0, exit_codes_1.signalToCode)('SIGINT'));
+});

package/src/native/index.d.ts

@@ -18,7 +18,7 @@ export declare class AppLifeCycle {
   __init(doneCallback: () => any): void
   registerRunningTask(taskId: string, parserAndWriter: ExternalObject<[ParserArc, WriterArc]>): void
   registerRunningTaskWithEmptyParser(taskId: string): void
-  appendTaskOutput(taskId: string, output: string): void
+  appendTaskOutput(taskId: string, output: string, isPtyOutput: boolean): void
   setTaskStatus(taskId: string, status: TaskStatus): void
   registerForcedShutdownCallback(forcedShutdownCallback: () => any): void
   __setCloudMessage(message: string): Promise<void>

package/src/tasks-runner/forked-process-task-runner.js

@@ -136,7 +136,7 @@ class ForkedProcessTaskRunner {
             terminalOutput += msg;
         });
         p.onExit((code) => {
-            if (code > 128) {
+            if (!this.tuiEnabled && code > 128) {
                 process.exit(code);
             }
             this.pseudoTerminals.delete(pseudoTerminal);

package/src/tasks-runner/life-cycle.d.ts

@@ -38,7 +38,7 @@ export interface LifeCycle {
     printTaskTerminalOutput?(task: Task, status: TaskStatus, output: string): void;
     registerRunningTask?(taskId: string, parserAndWriter: ExternalObject<[any, any]>): void;
     registerRunningTaskWithEmptyParser?(taskId: string): void;
-    appendTaskOutput?(taskId: string, output: string): void;
+    appendTaskOutput?(taskId: string, output: string, isPtyTask: boolean): void;
     setTaskStatus?(taskId: string, status: NativeTaskStatus): void;
     registerForcedShutdownCallback?(callback: () => void): void;
 }
@@ -55,7 +55,7 @@ export declare class CompositeLifeCycle implements LifeCycle {
     printTaskTerminalOutput(task: Task, status: TaskStatus, output: string): void;
     registerRunningTask(taskId: string, parserAndWriter: ExternalObject<[any, any]>): void;
     registerRunningTaskWithEmptyParser(taskId: string): void;
-    appendTaskOutput(taskId: string, output: string): void;
+    appendTaskOutput(taskId: string, output: string, isPtyTask: boolean): void;
     setTaskStatus(taskId: string, status: NativeTaskStatus): void;
     registerForcedShutdownCallback(callback: () => void): void;
 }

package/src/tasks-runner/life-cycle.js

@@ -81,10 +81,10 @@ class CompositeLifeCycle {
             }
         }
     }
-    appendTaskOutput(taskId, output) {
+    appendTaskOutput(taskId, output, isPtyTask) {
         for (let l of this.lifeCycles) {
             if (l.appendTaskOutput) {
-                l.appendTaskOutput(taskId, output);
+                l.appendTaskOutput(taskId, output, isPtyTask);
             }
         }
     }

package/src/tasks-runner/life-cycles/tui-summary-life-cycle.js

@@ -26,15 +26,21 @@ function getTuiTerminalSummaryLifeCycle({ projectNames, tasks, taskGraph, args,
     const inProgressTasks = new Set();
     const stoppedTasks = new Set();
     const tasksToTerminalOutputs = {};
-    const taskIdsInOrderOfCompletion = [];
+    const tasksToTaskStatus = {};
+    const taskIdsInTheOrderTheyStart = [];
     lifeCycle.startTasks = (tasks) => {
         for (let t of tasks) {
+            tasksToTerminalOutputs[t.id] ??= '';
+            taskIdsInTheOrderTheyStart.push(t.id);
             inProgressTasks.add(t.id);
         }
     };
-    lifeCycle.printTaskTerminalOutput = (task, taskStatus, terminalOutput) => {
-        taskIdsInOrderOfCompletion.push(task.id);
-        tasksToTerminalOutputs[task.id] = { terminalOutput, taskStatus };
+    lifeCycle.appendTaskOutput = (taskId, output) => {
+        tasksToTerminalOutputs[taskId] += output;
+    };
+    // TODO(@AgentEnder): The following 2 methods should be one but will need more refactoring
+    lifeCycle.printTaskTerminalOutput = (task, taskStatus) => {
+        tasksToTaskStatus[task.id] = taskStatus;
     };
     lifeCycle.setTaskStatus = (taskId, taskStatus) => {
         if (taskStatus === 9 /* NativeTaskStatus.Stopped */) {
@@ -103,8 +109,9 @@ function getTuiTerminalSummaryLifeCycle({ projectNames, tasks, taskGraph, args,
         let lines = [];
         // Prints task outputs in the order they were completed
         // above the summary, since run-one should print all task results.
-        for (const taskId of taskIdsInOrderOfCompletion) {
-            const { terminalOutput, taskStatus } = tasksToTerminalOutputs[taskId];
+        for (const taskId of taskIdsInTheOrderTheyStart) {
+            const taskStatus = tasksToTaskStatus[taskId];
+            const terminalOutput = tasksToTerminalOutputs[taskId];
             output_1.output.logCommandOutput(taskId, taskStatus, terminalOutput);
         }
         lines.push(...output_1.output.getVerticalSeparatorLines(failure ? 'red' : 'green'));
@@ -157,9 +164,16 @@ function getTuiTerminalSummaryLifeCycle({ projectNames, tasks, taskGraph, args,
     const printRunManySummary = ({ failure, cancelled, }) => {
         console.log('');
         const lines = [''];
-        for (const taskId of taskIdsInOrderOfCompletion) {
-            const { terminalOutput, taskStatus } = tasksToTerminalOutputs[taskId];
-            if (taskStatus === 'failure') {
+        for (const taskId of taskIdsInTheOrderTheyStart) {
+            const taskStatus = tasksToTaskStatus[taskId];
+            const terminalOutput = tasksToTerminalOutputs[taskId];
+            // Task Status is null?
+            if (!taskStatus) {
+                output_1.output.logCommandOutput(taskId, taskStatus, terminalOutput);
+                output_1.output.addNewline();
+                lines.push(`${LEFT_PAD}${output_1.output.colors.cyan(figures.squareSmallFilled)}${SPACER}${output_1.output.colors.gray('nx run ')}${taskId}`);
+            }
+            else if (taskStatus === 'failure') {
                 output_1.output.logCommandOutput(taskId, taskStatus, terminalOutput);
                 output_1.output.addNewline();
                 lines.push(`${LEFT_PAD}${output_1.output.colors.red(figures.cross)}${SPACER}${output_1.output.colors.gray('nx run ')}${taskId}`);

package/src/tasks-runner/task-orchestrator.js

@@ -333,11 +333,14 @@ class TaskOrchestrator {
                     if (runningTask instanceof pseudo_terminal_1.PseudoTtyProcess) {
                         // This is an external of a the pseudo terminal where a task is running and can be passed to the TUI
                         this.options.lifeCycle.registerRunningTask(task.id, runningTask.getParserAndWriter());
+                        runningTask.onOutput((output) => {
+                            this.options.lifeCycle.appendTaskOutput(task.id, output, true);
+                        });
                     }
                     else {
                         this.options.lifeCycle.registerRunningTaskWithEmptyParser(task.id);
                         runningTask.onOutput((output) => {
-                            this.options.lifeCycle.appendTaskOutput(task.id, output);
+                            this.options.lifeCycle.appendTaskOutput(task.id, output, false);
                         });
                     }
                 }
@@ -391,11 +394,14 @@ class TaskOrchestrator {
                 if (runningTask instanceof pseudo_terminal_1.PseudoTtyProcess) {
                     // This is an external of a the pseudo terminal where a task is running and can be passed to the TUI
                     this.options.lifeCycle.registerRunningTask(task.id, runningTask.getParserAndWriter());
+                    runningTask.onOutput((output) => {
+                        this.options.lifeCycle.appendTaskOutput(task.id, output, true);
+                    });
                 }
                 else if ('onOutput' in runningTask) {
                     this.options.lifeCycle.registerRunningTaskWithEmptyParser(task.id);
                     runningTask.onOutput((output) => {
-                        this.options.lifeCycle.appendTaskOutput(task.id, output);
+                        this.options.lifeCycle.appendTaskOutput(task.id, output, false);
                     });
                 }
             }