nx 20.3.0-canary.20241217-ee4de0b → 20.3.0-canary.20241219-2eb5243

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nx",
-  "version": "20.3.0-canary.20241217-ee4de0b",
+  "version": "20.3.0-canary.20241219-2eb5243",
   "private": false,
   "description": "The core Nx plugin contains the core functionality of Nx like the project graph, nx commands and task orchestration.",
   "repository": {
@@ -82,16 +82,16 @@
     }
   },
   "optionalDependencies": {
-    "@nx/nx-darwin-arm64": "20.3.0-canary.20241217-ee4de0b",
-    "@nx/nx-darwin-x64": "20.3.0-canary.20241217-ee4de0b",
-    "@nx/nx-freebsd-x64": "20.3.0-canary.20241217-ee4de0b",
-    "@nx/nx-linux-arm-gnueabihf": "20.3.0-canary.20241217-ee4de0b",
-    "@nx/nx-linux-arm64-gnu": "20.3.0-canary.20241217-ee4de0b",
-    "@nx/nx-linux-arm64-musl": "20.3.0-canary.20241217-ee4de0b",
-    "@nx/nx-linux-x64-gnu": "20.3.0-canary.20241217-ee4de0b",
-    "@nx/nx-linux-x64-musl": "20.3.0-canary.20241217-ee4de0b",
-    "@nx/nx-win32-arm64-msvc": "20.3.0-canary.20241217-ee4de0b",
-    "@nx/nx-win32-x64-msvc": "20.3.0-canary.20241217-ee4de0b"
+    "@nx/nx-darwin-arm64": "20.3.0-canary.20241219-2eb5243",
+    "@nx/nx-darwin-x64": "20.3.0-canary.20241219-2eb5243",
+    "@nx/nx-freebsd-x64": "20.3.0-canary.20241219-2eb5243",
+    "@nx/nx-linux-arm-gnueabihf": "20.3.0-canary.20241219-2eb5243",
+    "@nx/nx-linux-arm64-gnu": "20.3.0-canary.20241219-2eb5243",
+    "@nx/nx-linux-arm64-musl": "20.3.0-canary.20241219-2eb5243",
+    "@nx/nx-linux-x64-gnu": "20.3.0-canary.20241219-2eb5243",
+    "@nx/nx-linux-x64-musl": "20.3.0-canary.20241219-2eb5243",
+    "@nx/nx-win32-arm64-msvc": "20.3.0-canary.20241219-2eb5243",
+    "@nx/nx-win32-x64-msvc": "20.3.0-canary.20241219-2eb5243"
   },
   "nx-migrations": {
     "migrations": "./migrations.json",

package/src/command-line/init/implementation/angular/standalone-workspace.js

@@ -50,7 +50,7 @@ function createNxJson(repoRoot, angularJson, cacheableOperations, { eslintProjec
                 ].filter(Boolean)
                 : []),
             ...(eslintProjectConfigFile
-                ? ['!{projectRoot}/.eslintrc.json', '!{projectRoot}/eslint.config.js']
+                ? ['!{projectRoot}/.eslintrc.json', '!{projectRoot}/eslint.config.cjs']
                 : []),
         ].filter(Boolean),
     };
@@ -83,8 +83,8 @@ function createNxJson(repoRoot, angularJson, cacheableOperations, { eslintProjec
         if ((0, fileutils_1.fileExists)((0, path_1.join)(repoRoot, '.eslintrc.json'))) {
             inputs.push('{workspaceRoot}/.eslintrc.json');
         }
-        if ((0, fileutils_1.fileExists)((0, path_1.join)(repoRoot, 'eslint.config.js'))) {
-            inputs.push('{workspaceRoot}/eslint.config.js');
+        if ((0, fileutils_1.fileExists)((0, path_1.join)(repoRoot, 'eslint.config.cjs'))) {
+            inputs.push('{workspaceRoot}/eslint.config.cjs');
         }
         nxJson.targetDefaults.lint = {
             ...nxJson.targetDefaults.lint,
@@ -159,7 +159,9 @@ function projectHasKarmaConfig(project) {
 }
 function projectHasEslintConfig(project) {
     return ((0, fileutils_1.fileExists)((0, path_1.join)(project.root, '.eslintrc.json')) ||
-        (0, fileutils_1.fileExists)((0, path_1.join)(project.root, 'eslint.config.js')));
+        (0, fileutils_1.fileExists)((0, path_1.join)(project.root, 'eslint.config.js')) ||
+        (0, fileutils_1.fileExists)((0, path_1.join)(project.root, 'eslint.config.mjs')) ||
+        (0, fileutils_1.fileExists)((0, path_1.join)(project.root, 'eslint.config.cjs')));
 }
 function replaceNgWithNxInPackageJsonScripts(repoRoot) {
     const packageJsonPath = (0, path_1.join)(repoRoot, 'package.json');

package/src/command-line/release/changelog.d.ts

@@ -1,5 +1,6 @@
-import { NxReleaseChangelogConfiguration, NxReleaseConfiguration } from '../../config/nx-json';
+import { NxReleaseConfiguration } from '../../config/nx-json';
 import { ChangelogOptions } from './command-object';
+import { NxReleaseConfig } from './config/config';
 import { Reference } from './utils/git';
 import { ReleaseVersion } from './utils/shared';
 export interface NxReleaseChangelogResult {
@@ -31,4 +32,4 @@ export interface ChangelogChange {
 }
 export declare const releaseChangelogCLIHandler: (args: ChangelogOptions) => Promise<number>;
 export declare function createAPI(overrideReleaseConfig: NxReleaseConfiguration): (args: ChangelogOptions) => Promise<NxReleaseChangelogResult>;
-export declare function shouldCreateGitHubRelease(changelogConfig: NxReleaseChangelogConfiguration | false | undefined, createReleaseArg?: ChangelogOptions['createRelease'] | undefined): boolean;
+export declare function shouldCreateGitHubRelease(changelogConfig: NxReleaseConfig['changelog']['workspaceChangelog'] | NxReleaseConfig['changelog']['projectChangelogs'] | NxReleaseConfig['groups'][number]['changelog'], createReleaseArg?: ChangelogOptions['createRelease'] | undefined): boolean;

package/src/command-line/release/changelog.js

@@ -74,11 +74,15 @@ function createAPI(overrideReleaseConfig) {
             });
             process.exit(1);
         }
-        const { error: filterError, releaseGroups, releaseGroupToFilteredProjects, } = (0, filter_release_groups_1.filterReleaseGroups)(projectGraph, nxReleaseConfig, args.projects, args.groups);
+        const { error: filterError, filterLog, releaseGroups, releaseGroupToFilteredProjects, } = (0, filter_release_groups_1.filterReleaseGroups)(projectGraph, nxReleaseConfig, args.projects, args.groups);
         if (filterError) {
             output_1.output.error(filterError);
             process.exit(1);
         }
+        if (filterLog &&
+            process.env.NX_RELEASE_INTERNAL_SUPPRESS_FILTER_LOG !== 'true') {
+            output_1.output.note(filterLog);
+        }
         const rawVersionPlans = await (0, version_plans_1.readRawVersionPlans)();
         await (0, version_plans_1.setResolvedVersionPlansOnGroups)(rawVersionPlans, releaseGroups, Object.keys(projectGraph.nodes), args.verbose);
         if (args.deleteVersionPlans === undefined) {
@@ -230,18 +234,7 @@ function createAPI(overrideReleaseConfig) {
         });
         if (workspaceChangelog &&
             shouldCreateGitHubRelease(nxReleaseConfig.changelog.workspaceChangelog, args.createRelease)) {
-            let hasPushed = false;
             postGitTasks.push(async (latestCommit) => {
-                if (!hasPushed) {
-                    output_1.output.logSingleLine(`Pushing to git remote`);
-                    // Before we can create/update the release we need to ensure the commit exists on the remote
-                    await (0, git_1.gitPush)({
-                        gitRemote: args.gitRemote,
-                        dryRun: args.dryRun,
-                        verbose: args.verbose,
-                    });
-                    hasPushed = true;
-                }
                 output_1.output.logSingleLine(`Creating GitHub Release`);
                 await (0, github_1.createOrUpdateGithubRelease)(nxReleaseConfig.changelog.workspaceChangelog
                     ? nxReleaseConfig.changelog.workspaceChangelog.createRelease
@@ -387,21 +380,10 @@ function createAPI(overrideReleaseConfig) {
                         nxReleaseConfig,
                         projectToAdditionalDependencyBumps,
                     });
-                    let hasPushed = false;
                     for (const [projectName, projectChangelog] of Object.entries(projectChangelogs)) {
                         if (projectChangelogs &&
                             shouldCreateGitHubRelease(releaseGroup.changelog, args.createRelease)) {
                             postGitTasks.push(async (latestCommit) => {
-                                if (!hasPushed) {
-                                    output_1.output.logSingleLine(`Pushing to git remote`);
-                                    // Before we can create/update the release we need to ensure the commit exists on the remote
-                                    await (0, git_1.gitPush)({
-                                        gitRemote: args.gitRemote,
-                                        dryRun: args.dryRun,
-                                        verbose: args.verbose,
-                                    });
-                                    hasPushed = true;
-                                }
                                 output_1.output.logSingleLine(`Creating GitHub Release`);
                                 await (0, github_1.createOrUpdateGithubRelease)(releaseGroup.changelog
                                     ? releaseGroup.changelog.createRelease
@@ -504,21 +486,10 @@ function createAPI(overrideReleaseConfig) {
                     nxReleaseConfig,
                     projectToAdditionalDependencyBumps,
                 });
-                let hasPushed = false;
                 for (const [projectName, projectChangelog] of Object.entries(projectChangelogs)) {
                     if (projectChangelogs &&
                         shouldCreateGitHubRelease(releaseGroup.changelog, args.createRelease)) {
                         postGitTasks.push(async (latestCommit) => {
-                            if (!hasPushed) {
-                                output_1.output.logSingleLine(`Pushing to git remote`);
-                                // Before we can create/update the release we need to ensure the commit exists on the remote
-                                await (0, git_1.gitPush)({
-                                    gitRemote: args.gitRemote,
-                                    dryRun: args.dryRun,
-                                    verbose: args.verbose,
-                                });
-                                hasPushed = true;
-                            }
                             output_1.output.logSingleLine(`Creating GitHub Release`);
                             await (0, github_1.createOrUpdateGithubRelease)(releaseGroup.changelog
                                 ? releaseGroup.changelog.createRelease
@@ -672,6 +643,14 @@ async function applyChangesAndExit(args, nxReleaseConfig, tree, toSHA, postGitTa
             });
         }
     }
+    if (args.gitPush ?? nxReleaseConfig.changelog.git.push) {
+        output_1.output.logSingleLine(`Pushing to git remote "${args.gitRemote}"`);
+        await (0, git_1.gitPush)({
+            gitRemote: args.gitRemote,
+            dryRun: args.dryRun,
+            verbose: args.verbose,
+        });
+    }
     // Run any post-git tasks in series
     for (const postGitTask of postGitTasks) {
         await postGitTask(latestCommit);
@@ -942,7 +921,10 @@ function shouldCreateGitHubRelease(changelogConfig, createReleaseArg = undefined
     if (createReleaseArg !== undefined) {
         return createReleaseArg === 'github';
     }
-    return (changelogConfig || {}).createRelease !== false;
+    if (changelogConfig === false) {
+        return false;
+    }
+    return changelogConfig.createRelease !== false;
 }
 async function promptForGitHubRelease() {
     try {

package/src/command-line/release/command-object.d.ts

@@ -10,7 +10,7 @@ export interface NxReleaseArgs extends BaseNxReleaseArgs {
     projects?: string[];
     dryRun?: boolean;
 }
-interface GitCommitAndTagOptions {
+interface GitOptions {
     stageChanges?: boolean;
     gitCommit?: boolean;
     gitCommitMessage?: string;
@@ -18,20 +18,21 @@ interface GitCommitAndTagOptions {
     gitTag?: boolean;
     gitTagMessage?: string;
     gitTagArgs?: string | string[];
+    gitPush?: boolean;
+    gitRemote?: string;
 }
-export type VersionOptions = NxReleaseArgs & GitCommitAndTagOptions & VersionPlanArgs & FirstReleaseArgs & {
+export type VersionOptions = NxReleaseArgs & GitOptions & VersionPlanArgs & FirstReleaseArgs & {
     specifier?: string;
     preid?: string;
     stageChanges?: boolean;
     generatorOptionsOverrides?: Record<string, unknown>;
 };
-export type ChangelogOptions = NxReleaseArgs & GitCommitAndTagOptions & VersionPlanArgs & FirstReleaseArgs & {
+export type ChangelogOptions = NxReleaseArgs & GitOptions & VersionPlanArgs & FirstReleaseArgs & {
     version?: string | null;
     versionData?: VersionData;
     to?: string;
     from?: string;
     interactive?: string;
-    gitRemote?: string;
     createRelease?: false | 'github';
 };
 export type PublishOptions = NxReleaseArgs & Partial<RunManyOptions> & {

package/src/command-line/release/command-object.js

@@ -104,7 +104,7 @@ const versionCommand = {
     command: 'version [specifier]',
     aliases: ['v'],
     describe: 'Create a version and release for one or more applications and libraries.',
-    builder: (yargs) => withFirstReleaseOptions(withGitCommitAndGitTagOptions(yargs
+    builder: (yargs) => withFirstReleaseOptions(withGitOptions(yargs
         .positional('specifier', {
         type: 'string',
         describe: 'Exact version or semver keyword to apply to the selected release group.',
@@ -131,7 +131,7 @@ const changelogCommand = {
     command: 'changelog [version]',
     aliases: ['c'],
     describe: 'Generate a changelog for one or more projects, and optionally push to Github.',
-    builder: (yargs) => withFirstReleaseOptions(withGitCommitAndGitTagOptions(yargs
+    builder: (yargs) => withFirstReleaseOptions(withGitOptions(yargs
         // Disable default meaning of yargs version for this command
         .version(false)
         .positional('version', {
@@ -152,11 +152,6 @@ const changelogCommand = {
         type: 'string',
         description: 'Interactively modify changelog markdown contents in your code editor before applying the changes. You can set it to be interactive for all changelogs, or only the workspace level, or only the project level.',
         choices: ['all', 'workspace', 'projects'],
-    })
-        .option('git-remote', {
-        type: 'string',
-        description: 'Alternate git remote in the form {user}/{repo} on which to create the Github release (useful for testing).',
-        default: 'origin',
     })
         .check((argv) => {
         if (!argv.version) {
@@ -256,7 +251,7 @@ function coerceParallelOption(args) {
         parallel: (0, shared_options_1.readParallelFromArgsAndEnv)(args),
     };
 }
-function withGitCommitAndGitTagOptions(yargs) {
+function withGitOptions(yargs) {
     return yargs
         .option('git-commit', {
         describe: 'Whether or not to automatically commit the changes made by this command.',
@@ -285,6 +280,15 @@ function withGitCommitAndGitTagOptions(yargs) {
         .option('stage-changes', {
         describe: 'Whether or not to stage the changes made by this command. Always treated as true if git-commit is true.',
         type: 'boolean',
+    })
+        .option('git-push', {
+        describe: 'Whether or not to automatically push the changes made by this command to the remote git repository.',
+        type: 'boolean',
+    })
+        .option('git-remote', {
+        type: 'string',
+        description: 'Alternate git remote to push commits and tags to (can be useful for testing).',
+        default: 'origin',
     });
 }
 function withFirstReleaseOptions(yargs) {

package/src/command-line/release/config/config.d.ts

@@ -42,7 +42,7 @@ export type NxReleaseConfig = Omit<DeepRequired<NxJsonConfiguration['release'] &
     };
 }>, 'projects'>;
 export interface CreateNxReleaseConfigError {
-    code: 'PROJECTS_AND_GROUPS_DEFINED' | 'RELEASE_GROUP_MATCHES_NO_PROJECTS' | 'RELEASE_GROUP_RELEASE_TAG_PATTERN_VERSION_PLACEHOLDER_MISSING_OR_EXCESSIVE' | 'PROJECT_MATCHES_MULTIPLE_GROUPS' | 'CONVENTIONAL_COMMITS_SHORTHAND_MIXED_WITH_OVERLAPPING_GENERATOR_OPTIONS' | 'GLOBAL_GIT_CONFIG_MIXED_WITH_GRANULAR_GIT_CONFIG' | 'CANNOT_RESOLVE_CHANGELOG_RENDERER' | 'INVALID_CHANGELOG_CREATE_RELEASE_PROVIDER' | 'INVALID_CHANGELOG_CREATE_RELEASE_HOSTNAME' | 'INVALID_CHANGELOG_CREATE_RELEASE_API_BASE_URL';
+    code: 'PROJECTS_AND_GROUPS_DEFINED' | 'RELEASE_GROUP_MATCHES_NO_PROJECTS' | 'RELEASE_GROUP_RELEASE_TAG_PATTERN_VERSION_PLACEHOLDER_MISSING_OR_EXCESSIVE' | 'PROJECT_MATCHES_MULTIPLE_GROUPS' | 'CONVENTIONAL_COMMITS_SHORTHAND_MIXED_WITH_OVERLAPPING_GENERATOR_OPTIONS' | 'GLOBAL_GIT_CONFIG_MIXED_WITH_GRANULAR_GIT_CONFIG' | 'CANNOT_RESOLVE_CHANGELOG_RENDERER' | 'INVALID_CHANGELOG_CREATE_RELEASE_PROVIDER' | 'INVALID_CHANGELOG_CREATE_RELEASE_HOSTNAME' | 'INVALID_CHANGELOG_CREATE_RELEASE_API_BASE_URL' | 'GIT_PUSH_FALSE_WITH_CREATE_RELEASE';
     data: Record<string, string | string[]>;
 }
 export declare function createNxReleaseConfig(projectGraph: ProjectGraph, projectFileMap: ProjectFileMap, userConfig?: NxJsonConfiguration['release']): Promise<{

package/src/command-line/release/config/config.js

@@ -64,19 +64,51 @@ async function createNxReleaseConfig(projectGraph, projectFileMap, userConfig =
         tagMessage: '',
         tagArgs: '',
         stageChanges: false,
+        push: false,
     };
     const versionGitDefaults = {
         ...gitDefaults,
         stageChanges: true,
     };
+    const isObjectWithCreateReleaseEnabled = (data) => typeof data === 'object' &&
+        data !== null &&
+        'createRelease' in data &&
+        (typeof data.createRelease === 'string' ||
+            (typeof data.createRelease === 'object' && data.createRelease !== null));
+    const isCreateReleaseEnabledAtTheRoot = isObjectWithCreateReleaseEnabled(userConfig.changelog?.workspaceChangelog);
+    const isCreateReleaseEnabledForProjectChangelogs = 
+    // At the root
+    isObjectWithCreateReleaseEnabled(userConfig.changelog?.projectChangelogs) ||
+        // Or any release group
+        Object.values(userConfig.groups ?? {}).some((group) => isObjectWithCreateReleaseEnabled(group.changelog));
+    const isGitPushExplicitlyDisabled = userConfig.git?.push === false ||
+        userConfig.changelog?.git?.push === false ||
+        userConfig.version?.git?.push === false;
+    if (isGitPushExplicitlyDisabled &&
+        (isCreateReleaseEnabledAtTheRoot ||
+            isCreateReleaseEnabledForProjectChangelogs)) {
+        return {
+            error: {
+                code: 'GIT_PUSH_FALSE_WITH_CREATE_RELEASE',
+                data: {},
+            },
+            nxReleaseConfig: null,
+        };
+    }
     const changelogGitDefaults = {
         ...gitDefaults,
         commit: true,
         tag: true,
+        push: 
+        // We have to perform a git push in order to create a release
+        isCreateReleaseEnabledAtTheRoot ||
+            isCreateReleaseEnabledForProjectChangelogs
+            ? true
+            : false,
     };
     const defaultFixedReleaseTagPattern = 'v{version}';
     /**
-     * TODO: in v20, make it so that this pattern is used by default when any custom groups are used
+     * TODO(v21): in v21, make it so that this pattern is used by default when any custom groups are used
      */
     const defaultFixedGroupReleaseTagPattern = '{releaseGroupName}-v{version}';
     const defaultIndependentReleaseTagPattern = '{projectName}@{version}';
@@ -596,6 +628,17 @@ async function handleNxReleaseConfigError(error) {
                 });
             }
             break;
+        case 'GIT_PUSH_FALSE_WITH_CREATE_RELEASE':
+            {
+                const nxJsonMessage = await (0, resolve_nx_json_error_message_1.resolveNxJsonConfigErrorMessage)([
+                    'release',
+                ]);
+                output_1.output.error({
+                    title: `The createRelease option for changelogs cannot be enabled when git push is explicitly disabled because the commit needs to be pushed to the remote in order to tie the release to it`,
+                    bodyLines: [nxJsonMessage],
+                });
+            }
+            break;
         default:
             throw new Error(`Unhandled error code: ${error.code}`);
     }

package/src/command-line/release/config/filter-release-groups.d.ts

@@ -10,6 +10,10 @@ export declare function filterReleaseGroups(projectGraph: ProjectGraph, nxReleas
         title: string;
         bodyLines?: string[];
     };
+    filterLog: {
+        title: string;
+        bodyLines: string[];
+    } | null;
     releaseGroups: ReleaseGroupWithName[];
     releaseGroupToFilteredProjects: Map<ReleaseGroupWithName, Set<string>>;
 };

package/src/command-line/release/config/filter-release-groups.js

@@ -2,9 +2,9 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.filterReleaseGroups = filterReleaseGroups;
 const find_matching_projects_1 = require("../../../utils/find-matching-projects");
-const output_1 = require("../../../utils/output");
 const config_1 = require("./config");
 function filterReleaseGroups(projectGraph, nxReleaseConfig, projectsFilter, groupsFilter) {
+    let filterLog = null;
     let releaseGroups = Object.entries(nxReleaseConfig.groups).map(([name, group]) => {
         return {
             ...group,
@@ -34,6 +34,7 @@ function filterReleaseGroups(projectGraph, nxReleaseConfig, projectsFilter, grou
                 error: {
                     title: `Your --projects filter "${projectsFilter}" did not match any projects in the workspace`,
                 },
+                filterLog: null,
                 releaseGroups: [],
                 releaseGroupToFilteredProjects,
             };
@@ -62,6 +63,7 @@ function filterReleaseGroups(projectGraph, nxReleaseConfig, projectsFilter, grou
                         title: `The following projects which match your projects filter "${projectsFilter}" did not match any configured release groups:`,
                         bodyLines: unmatchedProjects.map((p) => `- ${p}`),
                     },
+                    filterLog: null,
                     releaseGroups: [],
                     releaseGroupToFilteredProjects,
                 };
@@ -85,6 +87,7 @@ function filterReleaseGroups(projectGraph, nxReleaseConfig, projectsFilter, grou
                         title: `In order to release specific projects independently with --projects those projects must be configured appropriately. For example, by setting \`"projectsRelationship": "independent"\` in your nx.json config.`,
                         bodyLines: [],
                     },
+                    filterLog: null,
                     releaseGroups: [],
                     releaseGroupToFilteredProjects,
                 };
@@ -94,11 +97,12 @@ function filterReleaseGroups(projectGraph, nxReleaseConfig, projectsFilter, grou
                     title: `Your --projects filter "${projectsFilter}" matched projects in the following release groups which do not have "independent" configured for their "projectsRelationship":`,
                     bodyLines: releaseGroupsThatAreNotIndependent.map((rg) => `- ${rg.name}`),
                 },
+                filterLog: null,
                 releaseGroups: [],
                 releaseGroupToFilteredProjects,
             };
         }
-        output_1.output.note({
+        filterLog = {
             title: `Your filter "${projectsFilter}" matched the following projects:`,
             bodyLines: matchingProjectsForFilter.map((p) => {
                 const releaseGroupForProject = filteredProjectToReleaseGroup.get(p);
@@ -107,7 +111,7 @@ function filterReleaseGroups(projectGraph, nxReleaseConfig, projectsFilter, grou
                 }
                 return `- ${p} (release group "${releaseGroupForProject.name}")`;
             }),
-        });
+        };
         // Filter the releaseGroups collection appropriately
         for (const [releaseGroupWithName, matchingProjects,] of releaseGroupToFilteredProjects.entries()) {
             if (matchingProjects.size === 0) {
@@ -117,6 +121,7 @@ function filterReleaseGroups(projectGraph, nxReleaseConfig, projectsFilter, grou
         releaseGroups = releaseGroups.filter((rg) => releaseGroupToFilteredProjects.get(rg)?.size > 0);
         return {
             error: null,
+            filterLog,
             releaseGroups,
             releaseGroupToFilteredProjects,
         };
@@ -138,12 +143,14 @@ function filterReleaseGroups(projectGraph, nxReleaseConfig, projectsFilter, grou
                     : // Getting to this point should be impossible, as we should have explicitly handled any errors/invalid config by now
                         `No projects could be matched for versioning, please report this case and include your nx.json config and command line arguments`,
             },
+            filterLog: null,
             releaseGroups: [],
             releaseGroupToFilteredProjects,
         };
     }
     return {
         error: null,
+        filterLog,
         releaseGroups,
         releaseGroupToFilteredProjects,
     };

package/src/command-line/release/publish.js

@@ -54,11 +54,15 @@ function createAPI(overrideReleaseConfig) {
                 isDebug: args.printConfig === 'debug',
             });
         }
-        const { error: filterError, releaseGroups, releaseGroupToFilteredProjects, } = (0, filter_release_groups_1.filterReleaseGroups)(projectGraph, nxReleaseConfig, _args.projects, _args.groups);
+        const { error: filterError, filterLog, releaseGroups, releaseGroupToFilteredProjects, } = (0, filter_release_groups_1.filterReleaseGroups)(projectGraph, nxReleaseConfig, _args.projects, _args.groups);
         if (filterError) {
             output_1.output.error(filterError);
             process.exit(1);
         }
+        if (filterLog &&
+            process.env.NX_RELEASE_INTERNAL_SUPPRESS_FILTER_LOG !== 'true') {
+            output_1.output.note(filterLog);
+        }
         /**
          * If the user is filtering to a subset of projects or groups, we should not run the publish task
          * for dependencies, because that could cause projects outset of the filtered set to be published.

package/src/command-line/release/release.js

@@ -57,6 +57,16 @@ function createAPI(overrideReleaseConfig) {
                 isDebug: args.printConfig === 'debug',
             });
         }
+        const { error: filterError, filterLog, releaseGroups, releaseGroupToFilteredProjects, } = (0, filter_release_groups_1.filterReleaseGroups)(projectGraph, nxReleaseConfig, args.projects, args.groups);
+        if (filterError) {
+            output_1.output.error(filterError);
+            process.exit(1);
+        }
+        if (filterLog) {
+            output_1.output.note(filterLog);
+        }
+        // Do not repeat the filter log in the release subcommands
+        process.env.NX_RELEASE_INTERNAL_SUPPRESS_FILTER_LOG = 'true';
         const rawVersionPlans = await (0, version_plans_1.readRawVersionPlans)();
         if (args.specifier && rawVersionPlans.length > 0) {
             output_1.output.error({
@@ -72,6 +82,11 @@ function createAPI(overrideReleaseConfig) {
         const shouldCommit = userProvidedReleaseConfig.git?.commit ?? true;
         const shouldStage = (shouldCommit || userProvidedReleaseConfig.git?.stageChanges) ?? false;
         const shouldTag = userProvidedReleaseConfig.git?.tag ?? true;
+        const shouldCreateWorkspaceRelease = (0, changelog_1.shouldCreateGitHubRelease)(nxReleaseConfig.changelog.workspaceChangelog);
+        // If the workspace or any of the release groups specify that a github release should be created, we need to push the changes to the remote
+        const shouldPush = (shouldCreateWorkspaceRelease ||
+            releaseGroups.some((group) => (0, changelog_1.shouldCreateGitHubRelease)(group.changelog))) ??
+            false;
         const versionResult = await releaseVersion({
             ...args,
             stageChanges: shouldStage,
@@ -86,14 +101,10 @@ function createAPI(overrideReleaseConfig) {
             stageChanges: shouldStage,
             gitCommit: false,
             gitTag: false,
+            gitPush: false,
             createRelease: false,
             deleteVersionPlans: false,
         });
-        const { error: filterError, releaseGroups, releaseGroupToFilteredProjects, } = (0, filter_release_groups_1.filterReleaseGroups)(projectGraph, nxReleaseConfig, args.projects, args.groups);
-        if (filterError) {
-            output_1.output.error(filterError);
-            process.exit(1);
-        }
         await (0, version_plans_1.setResolvedVersionPlansOnGroups)(rawVersionPlans, releaseGroups, Object.keys(projectGraph.nodes), args.verbose);
         const planFiles = new Set();
         releaseGroups.forEach((group) => {
@@ -155,17 +166,20 @@ function createAPI(overrideReleaseConfig) {
                 });
             }
         }
-        const shouldCreateWorkspaceRelease = (0, changelog_1.shouldCreateGitHubRelease)(nxReleaseConfig.changelog.workspaceChangelog);
         let hasPushedChanges = false;
-        let latestCommit;
-        if (shouldCreateWorkspaceRelease && changelogResult.workspaceChangelog) {
-            output_1.output.logSingleLine(`Pushing to git remote`);
-            // Before we can create/update the release we need to ensure the commit exists on the remote
+        if (shouldPush) {
+            output_1.output.logSingleLine(`Pushing to git remote "origin"`);
             await (0, git_1.gitPush)({
                 dryRun: args.dryRun,
                 verbose: args.verbose,
             });
             hasPushedChanges = true;
+        }
+        let latestCommit;
+        if (shouldCreateWorkspaceRelease && changelogResult.workspaceChangelog) {
+            if (!hasPushedChanges) {
+                throw new Error('It is not possible to create a github release for the workspace without pushing the changes to the remote, please ensure that you have not disabled git push in your nx release config');
+            }
             output_1.output.logSingleLine(`Creating GitHub Release`);
             latestCommit = await (0, git_1.getCommitHash)('HEAD');
             await (0, github_1.createOrUpdateGithubRelease)(nxReleaseConfig.changelog.workspaceChangelog
@@ -187,13 +201,7 @@ function createAPI(overrideReleaseConfig) {
                         continue;
                     }
                     if (!hasPushedChanges) {
-                        output_1.output.logSingleLine(`Pushing to git remote`);
-                        // Before we can create/update the release we need to ensure the commit exists on the remote
-                        await (0, git_1.gitPush)({
-                            dryRun: args.dryRun,
-                            verbose: args.verbose,
-                        });
-                        hasPushedChanges = true;
+                        throw new Error('It is not possible to create a github release for the project without pushing the changes to the remote, please ensure that you have not disabled git push in your nx release config');
                     }
                     output_1.output.logSingleLine(`Creating GitHub Release`);
                     if (!latestCommit) {

package/src/command-line/release/version.js

@@ -76,11 +76,15 @@ function createAPI(overrideReleaseConfig) {
             });
             process.exit(1);
         }
-        const { error: filterError, releaseGroups, releaseGroupToFilteredProjects, } = (0, filter_release_groups_1.filterReleaseGroups)(projectGraph, nxReleaseConfig, args.projects, args.groups);
+        const { error: filterError, filterLog, releaseGroups, releaseGroupToFilteredProjects, } = (0, filter_release_groups_1.filterReleaseGroups)(projectGraph, nxReleaseConfig, args.projects, args.groups);
         if (filterError) {
             output_1.output.error(filterError);
             process.exit(1);
         }
+        if (filterLog &&
+            process.env.NX_RELEASE_INTERNAL_SUPPRESS_FILTER_LOG !== 'true') {
+            output_1.output.note(filterLog);
+        }
         if (!args.specifier) {
             const rawVersionPlans = await (0, version_plans_1.readRawVersionPlans)();
             await (0, version_plans_1.setResolvedVersionPlansOnGroups)(rawVersionPlans, releaseGroups, Object.keys(projectGraph.nodes), args.verbose);
@@ -196,6 +200,14 @@ function createAPI(overrideReleaseConfig) {
                     });
                 }
             }
+            if (args.gitPush ?? nxReleaseConfig.version.git.push) {
+                output_1.output.logSingleLine(`Pushing to git remote "${args.gitRemote}"`);
+                await (0, git_1.gitPush)({
+                    gitRemote: args.gitRemote,
+                    dryRun: args.dryRun,
+                    verbose: args.verbose,
+                });
+            }
             return {
                 // An overall workspace version cannot be relevant when filtering to independent projects
                 workspaceVersion: undefined,

package/src/config/nx-json.d.ts

@@ -124,9 +124,13 @@ export interface NxReleaseGitConfiguration {
      */
     tagMessage?: string;
     /**
-     * Additional arguments to pass to the `git tag` command invoked behind the scenes. . May be a string or array of strings.
+     * Additional arguments to pass to the `git tag` command invoked behind the scenes. May be a string or array of strings.
      */
     tagArgs?: string | string[];
+    /**
+     * Whether or not to automatically push the changes made by this command to the remote git repository.
+     */
+    push?: boolean;
 }
 export interface NxReleaseConventionalCommitsConfiguration {
     types?: Record<string, 

package/src/config/workspace-json-project-json.d.ts

@@ -125,7 +125,7 @@ export interface ProjectMetadata {
     };
     js?: {
         packageName: string;
-        packageExports: undefined | PackageJson['exports'];
+        packageExports?: PackageJson['exports'];
     };
 }
 export interface TargetMetadata {