nx 20.2.0-canary.20241114-08953af → 20.2.0-canary.20241116-8efad63

package/src/project-graph/plugins/isolation/plugin-pool.js

@@ -12,7 +12,15 @@ const pluginNames = new Map();
 const PLUGIN_TIMEOUT_HINT_TEXT = 'As a last resort, you can set NX_PLUGIN_NO_TIMEOUTS=true to bypass this timeout.';
 const MINUTES = 10;
 const MAX_MESSAGE_WAIT = process.env.NX_PLUGIN_NO_TIMEOUTS === 'true'
-    ? undefined
+    ? // Registering a timeout prevents the process from exiting
+        // if the call to a plugin happens to be the only thing
+        // keeping the process alive. As such, even if timeouts are disabled
+        // we need to register one. 2147483647 is the max timeout
+        // that Node.js allows, and is equivalent to 24.8 days....
+        // This does mean that the NX_PLUGIN_NO_TIMEOUTS env var
+        // would still timeout after 24.8 days, but that seems
+        // like a reasonable compromise.
+        2147483647
     : 1000 * 60 * MINUTES; // 10 minutes
 const nxPluginWorkerCache = (global['nxPluginWorkerCache'] ??= new Map());
 async function loadRemoteNxPlugin(plugin, root) {
@@ -35,11 +43,9 @@ async function loadRemoteNxPlugin(plugin, root) {
             payload: { plugin, root },
         });
         // logger.verbose(`[plugin-worker] started worker: ${worker.pid}`);
-        const loadTimeout = MAX_MESSAGE_WAIT
-            ? setTimeout(() => {
-                rej(new Error(`Loading "${plugin}" timed out after ${MINUTES} minutes. ${PLUGIN_TIMEOUT_HINT_TEXT}`));
-            }, MAX_MESSAGE_WAIT)
-            : undefined;
+        const loadTimeout = setTimeout(() => {
+            rej(new Error(`Loading "${typeof plugin === 'string' ? plugin : plugin.plugin}" timed out after ${MINUTES} minutes. ${PLUGIN_TIMEOUT_HINT_TEXT}`));
+        }, MAX_MESSAGE_WAIT);
         socket.on('data', (0, consume_messages_from_socket_1.consumeMessagesFromSocket)(createWorkerHandler(worker, pendingPromises, (val) => {
             if (loadTimeout)
                 clearTimeout(loadTimeout);
@@ -169,11 +175,9 @@ function registerPendingPromise(tx, pending, callback, context) {
     const promise = new Promise((res, rej) => {
         rejector = rej;
         resolver = res;
-        timeout = MAX_MESSAGE_WAIT
-            ? setTimeout(() => {
-                rej(new Error(`${context.plugin} timed out after ${MINUTES} minutes during ${context.operation}. ${PLUGIN_TIMEOUT_HINT_TEXT}`));
-            }, MAX_MESSAGE_WAIT)
-            : undefined;
+        timeout = setTimeout(() => {
+            rej(new Error(`${context.plugin} timed out after ${MINUTES} minutes during ${context.operation}. ${PLUGIN_TIMEOUT_HINT_TEXT}`));
+        }, MAX_MESSAGE_WAIT);
         callback();
     }).finally(() => {
         pending.delete(tx);