nx 20.1.0-canary.20241016-3634781 → 20.1.0-canary.20241018-f971c1b

package/src/daemon/client/client.js

@@ -416,7 +416,7 @@ class DaemonClient {
             cwd: workspace_root_1.workspaceRoot,
             stdio: ['ignore', this._out.fd, this._err.fd],
             detached: true,
-            windowsHide: true,
+            windowsHide: false,
             shell: false,
             env: {
                 ...process.env,

package/src/daemon/client/generate-help-output.js

@@ -11,7 +11,7 @@ function generateDaemonHelpOutput() {
      */
     const res = (0, child_process_1.spawnSync)(process.execPath, ['./exec-is-server-available.js'], {
         cwd: __dirname,
-        windowsHide: true,
+        windowsHide: false,
     });
     const isServerAvailable = res?.stdout?.toString().trim().indexOf('true') > -1;
     if (!isServerAvailable) {

package/src/executors/run-commands/run-commands.impl.js

@@ -220,7 +220,7 @@ function nodeProcess(commandConfig, cwd, env, readyWhenStatus, streamOutput = tr
             maxBuffer: exports.LARGE_BUFFER,
             env,
             cwd,
-            windowsHide: true,
+            windowsHide: false,
         });
         childProcesses.add(childProcess);
         childProcess.stdout.on('data', (data) => {

package/src/executors/run-script/run-script.impl.js

@@ -35,7 +35,7 @@ function nodeProcess(command, cwd, env) {
         stdio: ['inherit', 'inherit', 'inherit'],
         cwd,
         env,
-        windowsHide: true,
+        windowsHide: false,
     });
 }
 async function ptyProcess(command, cwd, env) {

package/src/nx-cloud/generators/connect-to-nx-cloud/connect-to-nx-cloud.js

@@ -32,7 +32,7 @@ function getRootPackageName(tree) {
 }
 function getNxInitDate() {
     try {
-        const nxInitIso = (0, child_process_1.execSync)('git log --diff-filter=A --follow --format=%aI -- nx.json | tail -1', { stdio: 'pipe', windowsHide: true })
+        const nxInitIso = (0, child_process_1.execSync)('git log --diff-filter=A --follow --format=%aI -- nx.json | tail -1', { stdio: 'pipe', windowsHide: false })
             .toString()
             .trim();
         const nxInitDate = new Date(nxInitIso);

package/src/plugins/js/index.js

@@ -34,7 +34,7 @@ exports.createNodes = [
             ? (0, fs_1.readFileSync)(lockFilePath).toString()
             : (0, child_process_1.execSync)(`bun ${lockFilePath}`, {
                 maxBuffer: 1024 * 1024 * 10,
-                windowsHide: true,
+                windowsHide: false,
             }).toString();
         const lockFileHash = getLockFileHash(lockFileContents);
         if (!lockFileNeedsReprocessing(lockFileHash)) {
@@ -64,7 +64,7 @@ const createDependencies = (_, ctx) => {
             ? (0, fs_1.readFileSync)(lockFilePath).toString()
             : (0, child_process_1.execSync)(`bun ${lockFilePath}`, {
                 maxBuffer: 1024 * 1024 * 10,
-                windowsHide: true,
+                windowsHide: false,
             }).toString();
         const lockFileHash = getLockFileHash(lockFileContents);
         if (!lockFileNeedsReprocessing(lockFileHash)) {

package/src/project-graph/file-utils.js

@@ -91,7 +91,7 @@ function defaultReadFileAtRevision(file, revision) {
             : (0, child_process_1.execSync)(`git show ${revision}:${filePathInGitRepository}`, {
                 maxBuffer: exports.TEN_MEGABYTES,
                 stdio: ['pipe', 'pipe', 'ignore'],
-                windowsHide: true,
+                windowsHide: false,
             })
                 .toString()
                 .trim();

package/src/tasks-runner/cache.js

@@ -187,7 +187,7 @@ class Cache {
                     stdio: 'ignore',
                     detached: true,
                     shell: false,
-                    windowsHide: true,
+                    windowsHide: false,
                 });
                 p.unref();
             }

package/src/utils/ab-testing.js

@@ -99,7 +99,7 @@ function shouldRecordStats() {
     try {
         const stdout = (0, node_child_process_1.execSync)(pmc.getRegistryUrl, {
             encoding: 'utf-8',
-            windowsHide: true,
+            windowsHide: false,
         });
         const url = new URL(stdout.trim());
         // don't record stats when testing locally

package/src/utils/command-line-utils.js

@@ -213,7 +213,7 @@ function getMergeBase(base, head = 'HEAD') {
             maxBuffer: file_utils_1.TEN_MEGABYTES,
             cwd: workspace_root_1.workspaceRoot,
             stdio: 'pipe',
-            windowsHide: true,
+            windowsHide: false,
         })
             .toString()
             .trim();
@@ -224,7 +224,7 @@ function getMergeBase(base, head = 'HEAD') {
                 maxBuffer: file_utils_1.TEN_MEGABYTES,
                 cwd: workspace_root_1.workspaceRoot,
                 stdio: 'pipe',
-                windowsHide: true,
+                windowsHide: false,
             })
                 .toString()
                 .trim();
@@ -241,7 +241,7 @@ function parseGitOutput(command) {
     return (0, child_process_1.execSync)(command, {
         maxBuffer: file_utils_1.TEN_MEGABYTES,
         cwd: workspace_root_1.workspaceRoot,
-        windowsHide: true,
+        windowsHide: false,
     })
         .toString('utf-8')
         .split('\n')

package/src/utils/default-base.js

@@ -6,7 +6,7 @@ function deduceDefaultBase() {
     const nxDefaultBase = 'main';
     try {
         return ((0, child_process_1.execSync)('git config --get init.defaultBranch', {
-            windowsHide: true,
+            windowsHide: false,
         })
             .toString()
             .trim() || nxDefaultBase);

package/src/utils/git-utils.index-filter.js

@@ -9,10 +9,10 @@ try {
     const { execSync } = require('child_process');
     // NOTE: Using env vars because Windows PowerShell has its own handling of quotes (") messes up quotes in args, even if escaped.
     const src = process.env.NX_IMPORT_SOURCE;
-    execSync('git read-tree --empty', { stdio: 'inherit', windowsHide: true });
+    execSync('git read-tree --empty', { stdio: 'inherit', windowsHide: false });
     execSync(`git reset ${process.env.GIT_COMMIT} -- "${src}"`, {
         stdio: 'inherit',
-        windowsHide: true,
+        windowsHide: false,
     });
 }
 catch (error) {

package/src/utils/git-utils.js

@@ -36,7 +36,7 @@ class GitRepository {
     getGitRootPath(cwd) {
         return (0, child_process_1.execSync)('git rev-parse --show-toplevel', {
             cwd,
-            windowsHide: true,
+            windowsHide: false,
         })
             .toString()
             .trim();
@@ -177,7 +177,7 @@ function getGithubSlugOrNull() {
     try {
         const gitRemote = (0, child_process_1.execSync)('git remote -v', {
             stdio: 'pipe',
-            windowsHide: true,
+            windowsHide: false,
         }).toString();
         // If there are no remotes, we default to github
         if (!gitRemote || gitRemote.length === 0) {
@@ -228,7 +228,7 @@ function commitChanges(commitMessage, directory) {
             stdio: 'pipe',
             input: commitMessage,
             cwd: directory,
-            windowsHide: true,
+            windowsHide: false,
         });
     }
     catch (err) {
@@ -250,7 +250,7 @@ function getLatestCommitSha() {
         return (0, child_process_1.execSync)('git rev-parse HEAD', {
             encoding: 'utf8',
             stdio: 'pipe',
-            windowsHide: true,
+            windowsHide: false,
         }).trim();
     }
     catch {

package/src/utils/git-utils.tree-filter.js

@@ -15,7 +15,7 @@ try {
     const src = process.env.NX_IMPORT_SOURCE;
     const dest = process.env.NX_IMPORT_DESTINATION;
     const files = execSync(`git ls-files -z ${src}`, {
-        windowsHide: true,
+        windowsHide: false,
     })
         .toString()
         .trim()

package/src/utils/nx-cloud-utils.js

@@ -3,12 +3,9 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.isNxCloudUsed = isNxCloudUsed;
 exports.getNxCloudUrl = getNxCloudUrl;
 function isNxCloudUsed(nxJson) {
-    if (process.env.NX_NO_CLOUD === 'true') {
+    if (process.env.NX_NO_CLOUD === 'true' || nxJson.neverConnectToCloud) {
         return false;
     }
-    if (nxJson.neverConnectToCloud) {
-        return true;
-    }
     return (!!process.env.NX_CLOUD_ACCESS_TOKEN ||
         !!nxJson.nxCloudAccessToken ||
         !!nxJson.nxCloudId ||