nx 19.6.4 → 19.6.6

package/src/daemon/server/sync-generators.d.ts

@@ -4,3 +4,7 @@ export declare function getCachedSyncGeneratorChanges(generators: string[]): Pro
 export declare function flushSyncGeneratorChangesToDisk(generators: string[]): Promise<void>;
 export declare function collectAndScheduleSyncGenerators(projectGraph: ProjectGraph): void;
 export declare function getCachedRegisteredSyncGenerators(): Promise<string[]>;
+/**
+ * @internal
+ */
+export declare function _getConflictingGeneratorGroups(results: SyncGeneratorChangesResult[]): string[][];

package/src/daemon/server/sync-generators.js

@@ -4,6 +4,7 @@ exports.getCachedSyncGeneratorChanges = getCachedSyncGeneratorChanges;
 exports.flushSyncGeneratorChangesToDisk = flushSyncGeneratorChangesToDisk;
 exports.collectAndScheduleSyncGenerators = collectAndScheduleSyncGenerators;
 exports.getCachedRegisteredSyncGenerators = getCachedRegisteredSyncGenerators;
+exports._getConflictingGeneratorGroups = _getConflictingGeneratorGroups;
 const nx_json_1 = require("../../config/nx-json");
 const tree_1 = require("../../generators/tree");
 const file_hasher_1 = require("../../hasher/file-hasher");
@@ -24,7 +25,6 @@ let storedNxJsonHash;
 const log = (...messageParts) => {
     logger_1.serverLogger.log('[SYNC]:', ...messageParts);
 };
-// TODO(leo): check conflicts and reuse the Tree where possible
 async function getCachedSyncGeneratorChanges(generators) {
     try {
         log('get sync generators changes on demand', generators);
@@ -36,51 +36,15 @@ async function getCachedSyncGeneratorChanges(generators) {
         }
         // reset the wait time
         waitPeriod = 100;
-        let projects;
-        let errored = false;
-        const getProjectsConfigurations = async () => {
-            if (projects || errored) {
-                return projects;
-            }
-            const { projectGraph, error } = await (0, project_graph_incremental_recomputation_1.getCachedSerializedProjectGraphPromise)();
-            projects = projectGraph
-                ? (0, project_graph_1.readProjectsConfigurationFromProjectGraph)(projectGraph).projects
-                : null;
-            errored = error !== undefined;
-            return projects;
-        };
-        return (await Promise.all(generators.map(async (generator) => {
-            if (scheduledGenerators.has(generator) ||
-                !syncGeneratorsCacheResultPromises.has(generator)) {
-                // it's scheduled to run (there are pending changes to process) or
-                // it's not scheduled and there's no cached result, so run it
-                const projects = await getProjectsConfigurations();
-                if (projects) {
-                    log(generator, 'already scheduled or not cached, running it now');
-                    runGenerator(generator, projects);
-                }
-                else {
-                    log(generator, 'already scheduled or not cached, project graph errored');
-                    /**
-                     * This should never happen. This is invoked imperatively, and by
-                     * the time it is invoked, the project graph would have already
-                     * been requested. If it errored, it would have been reported and
-                     * this wouldn't have been invoked. We handle it just in case.
-                     *
-                     * Since the project graph would be reported by the relevant
-                     * handlers separately, we just ignore the error, don't cache
-                     * any result and return an empty result, the next time this is
-                     * invoked the process will repeat until it eventually recovers
-                     * when the project graph is fixed.
-                     */
-                    return Promise.resolve({ changes: [], generatorName: generator });
-                }
-            }
-            else {
-                log(generator, 'not scheduled and has cached result, returning cached result');
-            }
-            return syncGeneratorsCacheResultPromises.get(generator);
-        }))).flat();
+        const results = await getFromCacheOrRunGenerators(generators);
+        const conflicts = _getConflictingGeneratorGroups(results);
+        if (!conflicts.length) {
+            // there are no conflicts
+            return results;
+        }
+        // there are conflicts, so we need to re-run the conflicting generators
+        // using the same tree
+        return await processConflictingGenerators(conflicts, results);
     }
     catch (e) {
         console.error(e);
@@ -126,7 +90,7 @@ function collectAndScheduleSyncGenerators(projectGraph) {
         }
         const { projects } = (0, project_graph_1.readProjectsConfigurationFromProjectGraph)(projectGraph);
         for (const generator of scheduledGenerators) {
-            runGenerator(generator, projects);
+            syncGeneratorsCacheResultPromises.set(generator, runGenerator(generator, projects));
         }
         await Promise.all(syncGeneratorsCacheResultPromises.values());
     }, waitPeriod);
@@ -143,6 +107,163 @@ async function getCachedRegisteredSyncGenerators() {
     }
     return [...registeredSyncGenerators];
 }
+async function getFromCacheOrRunGenerators(generators) {
+    let projects;
+    let errored = false;
+    const getProjectsConfigurations = async () => {
+        if (projects || errored) {
+            return projects;
+        }
+        const { projectGraph, error } = await (0, project_graph_incremental_recomputation_1.getCachedSerializedProjectGraphPromise)();
+        projects = projectGraph
+            ? (0, project_graph_1.readProjectsConfigurationFromProjectGraph)(projectGraph).projects
+            : null;
+        errored = error !== undefined;
+        return projects;
+    };
+    return (await Promise.all(generators.map(async (generator) => {
+        if (scheduledGenerators.has(generator) ||
+            !syncGeneratorsCacheResultPromises.has(generator)) {
+            // it's scheduled to run (there are pending changes to process) or
+            // it's not scheduled and there's no cached result, so run it
+            const projects = await getProjectsConfigurations();
+            if (projects) {
+                log(generator, 'already scheduled or not cached, running it now');
+                syncGeneratorsCacheResultPromises.set(generator, runGenerator(generator, projects));
+            }
+            else {
+                log(generator, 'already scheduled or not cached, project graph errored');
+                /**
+                 * This should never happen. This is invoked imperatively, and by
+                 * the time it is invoked, the project graph would have already
+                 * been requested. If it errored, it would have been reported and
+                 * this wouldn't have been invoked. We handle it just in case.
+                 *
+                 * Since the project graph would be reported by the relevant
+                 * handlers separately, we just ignore the error, don't cache
+                 * any result and return an empty result, the next time this is
+                 * invoked the process will repeat until it eventually recovers
+                 * when the project graph is fixed.
+                 */
+                return Promise.resolve({ changes: [], generatorName: generator });
+            }
+        }
+        else {
+            log(generator, 'not scheduled and has cached result, returning cached result');
+        }
+        return syncGeneratorsCacheResultPromises.get(generator);
+    }))).flat();
+}
+async function runConflictingGenerators(tree, generators) {
+    const { projectGraph } = await (0, project_graph_incremental_recomputation_1.getCachedSerializedProjectGraphPromise)();
+    const projects = projectGraph
+        ? (0, project_graph_1.readProjectsConfigurationFromProjectGraph)(projectGraph).projects
+        : null;
+    if (!projects) {
+        /**
+         * This should never happen. This is invoked imperatively, and by
+         * the time it is invoked, the project graph would have already
+         * been requested. If it errored, it would have been reported and
+         * this wouldn't have been invoked. We handle it just in case.
+         *
+         * Since the project graph would be reported by the relevant
+         * handlers separately, we just ignore the error.
+         */
+        return generators.map((generator) => ({
+            changes: [],
+            generatorName: generator,
+        }));
+    }
+    // we need to run conflicting generators sequentially because they use the same tree
+    const results = [];
+    for (const generator of generators) {
+        log(generator, 'running it now');
+        results.push(await runGenerator(generator, projects, tree));
+    }
+    return results;
+}
+async function processConflictingGenerators(conflicts, initialResults) {
+    const conflictRunResults = (await Promise.all(conflicts.map((generators) => {
+        const [firstGenerator, ...generatorsToRun] = generators;
+        // it must exists because the conflicts were identified from the initial results
+        const firstGeneratorResult = initialResults.find((r) => r.generatorName === firstGenerator);
+        const tree = new tree_1.FsTree(workspace_root_1.workspaceRoot, false, `running sync generators ${generators.join(',')}`);
+        // pre-apply the changes from the first generator to avoid running it
+        for (const change of firstGeneratorResult.changes) {
+            if (change.type === 'CREATE' || change.type === 'UPDATE') {
+                tree.write(change.path, change.content, change.options);
+            }
+            else if (change.type === 'DELETE') {
+                tree.delete(change.path);
+            }
+        }
+        /**
+         * We don't cache the results of conflicting generators because they
+         * use the same tree, so some files might contain results from multiple
+         * generators and we don't have guarantees that the same combination of
+         * generators will run together.
+         */
+        return runConflictingGenerators(tree, generatorsToRun);
+    }))).flat();
+    /**
+     * The order of the results from the re-run generators is important because
+     * the last result from a group of conflicting generators will contain the
+     * changes from the previous conflicting generators. So, instead of replacing
+     * in-place the initial results, we first add the results from the re-run
+     * generators, and then add the initial results that were not from a
+     * conflicting generator.
+     */
+    const results = [...conflictRunResults];
+    for (const result of initialResults) {
+        if (conflictRunResults.every((r) => r.generatorName !== result.generatorName)) {
+            // this result is not from a conflicting generator, so we add it to the
+            // results
+            results.push(result);
+        }
+    }
+    return results;
+}
+/**
+ * @internal
+ */
+function _getConflictingGeneratorGroups(results) {
+    const changedFileToGeneratorMap = new Map();
+    for (const result of results) {
+        for (const change of result.changes) {
+            if (!changedFileToGeneratorMap.has(change.path)) {
+                changedFileToGeneratorMap.set(change.path, new Set());
+            }
+            changedFileToGeneratorMap.get(change.path).add(result.generatorName);
+        }
+    }
+    const conflicts = [];
+    for (const generatorSet of changedFileToGeneratorMap.values()) {
+        if (generatorSet.size === 1) {
+            // no conflicts
+            continue;
+        }
+        if (conflicts.length === 0) {
+            // there are no conflicts yet, so we just add the first group
+            conflicts.push(new Set(generatorSet));
+            continue;
+        }
+        // identify if any of the current generator sets intersect with any of the
+        // existing conflict groups
+        const generatorsArray = Array.from(generatorSet);
+        const existingConflictGroup = conflicts.find((group) => generatorsArray.some((generator) => group.has(generator)));
+        if (existingConflictGroup) {
+            // there's an intersecting group, so we merge the two
+            for (const generator of generatorsArray) {
+                existingConflictGroup.add(generator);
+            }
+        }
+        else {
+            // there's no intersecting group, so we create a new one
+            conflicts.push(new Set(generatorsArray));
+        }
+    }
+    return conflicts.map((group) => Array.from(group));
+}
 function collectAllRegisteredSyncGenerators(projectGraph) {
     const projectGraphHash = hashProjectGraph(projectGraph);
     if (storedProjectGraphHash !== projectGraphHash) {
@@ -183,16 +304,15 @@ function collectAllRegisteredSyncGenerators(projectGraph) {
         }
     }
 }
-function runGenerator(generator, projects) {
+function runGenerator(generator, projects, tree) {
     log('running scheduled generator', generator);
     // remove it from the scheduled set
     scheduledGenerators.delete(generator);
-    const tree = new tree_1.FsTree(workspace_root_1.workspaceRoot, false, `running sync generator ${generator}`);
-    // run the generator and cache the result
-    syncGeneratorsCacheResultPromises.set(generator, (0, sync_generators_1.runSyncGenerator)(tree, generator, projects).then((result) => {
+    tree ??= new tree_1.FsTree(workspace_root_1.workspaceRoot, false, `running sync generator ${generator}`);
+    return (0, sync_generators_1.runSyncGenerator)(tree, generator, projects).then((result) => {
         log(generator, 'changes:', result.changes.map((c) => c.path).join(', '));
         return result;
-    }));
+    });
 }
 function hashProjectGraph(projectGraph) {
     const stringifiedProjects = Object.entries(projectGraph.nodes)

package/src/migrations/update-15-0-0/prefix-outputs.js

@@ -18,12 +18,7 @@ async function default_1(tree) {
             if (!target.outputs) {
                 continue;
             }
-            try {
-                (0, utils_1.validateOutputs)(target.outputs);
-            }
-            catch (e) {
-                target.outputs = (0, utils_1.transformLegacyOutputs)(project.root, e);
-            }
+            target.outputs = (0, utils_1.transformLegacyOutputs)(project.root, target.outputs);
         }
         try {
             (0, project_configuration_1.updateProjectConfiguration)(tree, projectName, project);
@@ -33,12 +28,7 @@ async function default_1(tree) {
                 (0, json_1.updateJson)(tree, (0, path_1.join)(project.root, 'package.json'), (json) => {
                     for (const target of Object.values(json.nx?.targets ?? {})) {
                         if (target.outputs) {
-                            try {
-                                (0, utils_1.validateOutputs)(target.outputs);
-                            }
-                            catch (e) {
-                                target.outputs = (0, utils_1.transformLegacyOutputs)(project.root, e);
-                            }
+                            target.outputs = (0, utils_1.transformLegacyOutputs)(project.root, target.outputs);
                         }
                     }
                     return json;
@@ -51,12 +41,7 @@ async function default_1(tree) {
             if (!target.outputs) {
                 continue;
             }
-            try {
-                (0, utils_1.validateOutputs)(target.outputs);
-            }
-            catch (e) {
-                target.outputs = (0, utils_1.transformLegacyOutputs)('{projectRoot}', e);
-            }
+            target.outputs = (0, utils_1.transformLegacyOutputs)('{projectRoot}', target.outputs);
         }
         (0, nx_json_1.updateNxJson)(tree, nxJson);
     }

package/src/native/index.d.ts

@@ -124,6 +124,8 @@ export declare export function getBinaryTarget(): string
  */
 export declare export function getFilesForOutputs(directory: string, entries: Array<string>): Array<string>
 
+export declare export function getTransformableOutputs(outputs: Array<string>): Array<string>
+
 export declare export function hashArray(input: Array<string>): string
 
 export interface HashDetails {
@@ -222,6 +224,8 @@ export interface UpdatedWorkspaceFiles {
   externalReferences: NxWorkspaceFilesExternals
 }
 
+export declare export function validateOutputs(outputs: Array<string>): void
+
 export interface WatchEvent {
   path: string
   type: EventType

package/src/native/native-bindings.js

@@ -374,10 +374,12 @@ module.exports.expandOutputs = nativeBinding.expandOutputs
 module.exports.findImports = nativeBinding.findImports
 module.exports.getBinaryTarget = nativeBinding.getBinaryTarget
 module.exports.getFilesForOutputs = nativeBinding.getFilesForOutputs
+module.exports.getTransformableOutputs = nativeBinding.getTransformableOutputs
 module.exports.hashArray = nativeBinding.hashArray
 module.exports.hashFile = nativeBinding.hashFile
 module.exports.IS_WASM = nativeBinding.IS_WASM
 module.exports.remove = nativeBinding.remove
 module.exports.testOnlyTransferFileMap = nativeBinding.testOnlyTransferFileMap
 module.exports.transferProjectGraph = nativeBinding.transferProjectGraph
+module.exports.validateOutputs = nativeBinding.validateOutputs
 module.exports.WorkspaceErrors = nativeBinding.WorkspaceErrors

package/src/native/nx.wasi-browser.js

@@ -14,7 +14,7 @@ const __wasi = new __WASI({
 const __emnapiContext = __emnapiGetDefaultContext()
 
 const __sharedMemory = new WebAssembly.Memory({
-  initial: 16384,
+  initial: 1024,
   maximum: 32768,
   shared: true,
 })
@@ -55,41 +55,44 @@ function __napi_rs_initialize_modules(__napiInstance) {
   __napiInstance.exports['__napi_register__get_files_for_outputs_1']?.()
   __napiInstance.exports['__napi_register__remove_2']?.()
   __napiInstance.exports['__napi_register__copy_3']?.()
-  __napiInstance.exports['__napi_register__hash_array_4']?.()
-  __napiInstance.exports['__napi_register__hash_file_5']?.()
-  __napiInstance.exports['__napi_register__ImportResult_struct_6']?.()
-  __napiInstance.exports['__napi_register__find_imports_7']?.()
-  __napiInstance.exports['__napi_register__transfer_project_graph_8']?.()
-  __napiInstance.exports['__napi_register__ExternalNode_struct_9']?.()
-  __napiInstance.exports['__napi_register__Target_struct_10']?.()
-  __napiInstance.exports['__napi_register__Project_struct_11']?.()
-  __napiInstance.exports['__napi_register__ProjectGraph_struct_12']?.()
-  __napiInstance.exports['__napi_register__HashPlanner_struct_13']?.()
-  __napiInstance.exports['__napi_register__HashPlanner_impl_17']?.()
-  __napiInstance.exports['__napi_register__HashDetails_struct_18']?.()
-  __napiInstance.exports['__napi_register__HasherOptions_struct_19']?.()
-  __napiInstance.exports['__napi_register__TaskHasher_struct_20']?.()
-  __napiInstance.exports['__napi_register__TaskHasher_impl_23']?.()
-  __napiInstance.exports['__napi_register__Task_struct_24']?.()
-  __napiInstance.exports['__napi_register__TaskTarget_struct_25']?.()
-  __napiInstance.exports['__napi_register__TaskGraph_struct_26']?.()
-  __napiInstance.exports['__napi_register__FileData_struct_27']?.()
-  __napiInstance.exports['__napi_register__InputsInput_struct_28']?.()
-  __napiInstance.exports['__napi_register__FileSetInput_struct_29']?.()
-  __napiInstance.exports['__napi_register__RuntimeInput_struct_30']?.()
-  __napiInstance.exports['__napi_register__EnvironmentInput_struct_31']?.()
-  __napiInstance.exports['__napi_register__ExternalDependenciesInput_struct_32']?.()
-  __napiInstance.exports['__napi_register__DepsOutputsInput_struct_33']?.()
-  __napiInstance.exports['__napi_register__NxJson_struct_34']?.()
-  __napiInstance.exports['__napi_register__WorkspaceContext_struct_35']?.()
-  __napiInstance.exports['__napi_register__WorkspaceContext_impl_44']?.()
-  __napiInstance.exports['__napi_register__WorkspaceErrors_45']?.()
-  __napiInstance.exports['__napi_register__NxWorkspaceFiles_struct_46']?.()
-  __napiInstance.exports['__napi_register__NxWorkspaceFilesExternals_struct_47']?.()
-  __napiInstance.exports['__napi_register__UpdatedWorkspaceFiles_struct_48']?.()
-  __napiInstance.exports['__napi_register__FileMap_struct_49']?.()
-  __napiInstance.exports['__napi_register____test_only_transfer_file_map_50']?.()
-  __napiInstance.exports['__napi_register__IS_WASM_51']?.()
+  __napiInstance.exports['__napi_register__validate_outputs_4']?.()
+  __napiInstance.exports['__napi_register__get_transformable_outputs_5']?.()
+  __napiInstance.exports['__napi_register__hash_array_6']?.()
+  __napiInstance.exports['__napi_register__hash_file_7']?.()
+  __napiInstance.exports['__napi_register__IS_WASM_8']?.()
+  __napiInstance.exports['__napi_register__get_binary_target_9']?.()
+  __napiInstance.exports['__napi_register__ImportResult_struct_10']?.()
+  __napiInstance.exports['__napi_register__find_imports_11']?.()
+  __napiInstance.exports['__napi_register__transfer_project_graph_12']?.()
+  __napiInstance.exports['__napi_register__ExternalNode_struct_13']?.()
+  __napiInstance.exports['__napi_register__Target_struct_14']?.()
+  __napiInstance.exports['__napi_register__Project_struct_15']?.()
+  __napiInstance.exports['__napi_register__ProjectGraph_struct_16']?.()
+  __napiInstance.exports['__napi_register__HashPlanner_struct_17']?.()
+  __napiInstance.exports['__napi_register__HashPlanner_impl_21']?.()
+  __napiInstance.exports['__napi_register__HashDetails_struct_22']?.()
+  __napiInstance.exports['__napi_register__HasherOptions_struct_23']?.()
+  __napiInstance.exports['__napi_register__TaskHasher_struct_24']?.()
+  __napiInstance.exports['__napi_register__TaskHasher_impl_27']?.()
+  __napiInstance.exports['__napi_register__Task_struct_28']?.()
+  __napiInstance.exports['__napi_register__TaskTarget_struct_29']?.()
+  __napiInstance.exports['__napi_register__TaskGraph_struct_30']?.()
+  __napiInstance.exports['__napi_register__FileData_struct_31']?.()
+  __napiInstance.exports['__napi_register__InputsInput_struct_32']?.()
+  __napiInstance.exports['__napi_register__FileSetInput_struct_33']?.()
+  __napiInstance.exports['__napi_register__RuntimeInput_struct_34']?.()
+  __napiInstance.exports['__napi_register__EnvironmentInput_struct_35']?.()
+  __napiInstance.exports['__napi_register__ExternalDependenciesInput_struct_36']?.()
+  __napiInstance.exports['__napi_register__DepsOutputsInput_struct_37']?.()
+  __napiInstance.exports['__napi_register__NxJson_struct_38']?.()
+  __napiInstance.exports['__napi_register__WorkspaceContext_struct_39']?.()
+  __napiInstance.exports['__napi_register__WorkspaceContext_impl_48']?.()
+  __napiInstance.exports['__napi_register__WorkspaceErrors_49']?.()
+  __napiInstance.exports['__napi_register__NxWorkspaceFiles_struct_50']?.()
+  __napiInstance.exports['__napi_register__NxWorkspaceFilesExternals_struct_51']?.()
+  __napiInstance.exports['__napi_register__UpdatedWorkspaceFiles_struct_52']?.()
+  __napiInstance.exports['__napi_register__FileMap_struct_53']?.()
+  __napiInstance.exports['__napi_register____test_only_transfer_file_map_54']?.()
 }
 export const HashPlanner = __napiModule.exports.HashPlanner
 export const ImportResult = __napiModule.exports.ImportResult
@@ -98,11 +101,14 @@ export const WorkspaceContext = __napiModule.exports.WorkspaceContext
 export const copy = __napiModule.exports.copy
 export const expandOutputs = __napiModule.exports.expandOutputs
 export const findImports = __napiModule.exports.findImports
+export const getBinaryTarget = __napiModule.exports.getBinaryTarget
 export const getFilesForOutputs = __napiModule.exports.getFilesForOutputs
+export const getTransformableOutputs = __napiModule.exports.getTransformableOutputs
 export const hashArray = __napiModule.exports.hashArray
 export const hashFile = __napiModule.exports.hashFile
 export const IS_WASM = __napiModule.exports.IS_WASM
 export const remove = __napiModule.exports.remove
 export const testOnlyTransferFileMap = __napiModule.exports.testOnlyTransferFileMap
 export const transferProjectGraph = __napiModule.exports.transferProjectGraph
+export const validateOutputs = __napiModule.exports.validateOutputs
 export const WorkspaceErrors = __napiModule.exports.WorkspaceErrors

package/src/native/nx.wasi.cjs

@@ -86,42 +86,44 @@ function __napi_rs_initialize_modules(__napiInstance) {
   __napiInstance.exports['__napi_register__get_files_for_outputs_1']?.()
   __napiInstance.exports['__napi_register__remove_2']?.()
   __napiInstance.exports['__napi_register__copy_3']?.()
-  __napiInstance.exports['__napi_register__hash_array_4']?.()
-  __napiInstance.exports['__napi_register__hash_file_5']?.()
-  __napiInstance.exports['__napi_register__IS_WASM_6']?.()
-  __napiInstance.exports['__napi_register__get_binary_target_7']?.()
-  __napiInstance.exports['__napi_register__ImportResult_struct_8']?.()
-  __napiInstance.exports['__napi_register__find_imports_9']?.()
-  __napiInstance.exports['__napi_register__transfer_project_graph_10']?.()
-  __napiInstance.exports['__napi_register__ExternalNode_struct_11']?.()
-  __napiInstance.exports['__napi_register__Target_struct_12']?.()
-  __napiInstance.exports['__napi_register__Project_struct_13']?.()
-  __napiInstance.exports['__napi_register__ProjectGraph_struct_14']?.()
-  __napiInstance.exports['__napi_register__HashPlanner_struct_15']?.()
-  __napiInstance.exports['__napi_register__HashPlanner_impl_19']?.()
-  __napiInstance.exports['__napi_register__HashDetails_struct_20']?.()
-  __napiInstance.exports['__napi_register__HasherOptions_struct_21']?.()
-  __napiInstance.exports['__napi_register__TaskHasher_struct_22']?.()
-  __napiInstance.exports['__napi_register__TaskHasher_impl_25']?.()
-  __napiInstance.exports['__napi_register__Task_struct_26']?.()
-  __napiInstance.exports['__napi_register__TaskTarget_struct_27']?.()
-  __napiInstance.exports['__napi_register__TaskGraph_struct_28']?.()
-  __napiInstance.exports['__napi_register__FileData_struct_29']?.()
-  __napiInstance.exports['__napi_register__InputsInput_struct_30']?.()
-  __napiInstance.exports['__napi_register__FileSetInput_struct_31']?.()
-  __napiInstance.exports['__napi_register__RuntimeInput_struct_32']?.()
-  __napiInstance.exports['__napi_register__EnvironmentInput_struct_33']?.()
-  __napiInstance.exports['__napi_register__ExternalDependenciesInput_struct_34']?.()
-  __napiInstance.exports['__napi_register__DepsOutputsInput_struct_35']?.()
-  __napiInstance.exports['__napi_register__NxJson_struct_36']?.()
-  __napiInstance.exports['__napi_register__WorkspaceContext_struct_37']?.()
-  __napiInstance.exports['__napi_register__WorkspaceContext_impl_46']?.()
-  __napiInstance.exports['__napi_register__WorkspaceErrors_47']?.()
-  __napiInstance.exports['__napi_register__NxWorkspaceFiles_struct_48']?.()
-  __napiInstance.exports['__napi_register__NxWorkspaceFilesExternals_struct_49']?.()
-  __napiInstance.exports['__napi_register__UpdatedWorkspaceFiles_struct_50']?.()
-  __napiInstance.exports['__napi_register__FileMap_struct_51']?.()
-  __napiInstance.exports['__napi_register____test_only_transfer_file_map_52']?.()
+  __napiInstance.exports['__napi_register__validate_outputs_4']?.()
+  __napiInstance.exports['__napi_register__get_transformable_outputs_5']?.()
+  __napiInstance.exports['__napi_register__hash_array_6']?.()
+  __napiInstance.exports['__napi_register__hash_file_7']?.()
+  __napiInstance.exports['__napi_register__IS_WASM_8']?.()
+  __napiInstance.exports['__napi_register__get_binary_target_9']?.()
+  __napiInstance.exports['__napi_register__ImportResult_struct_10']?.()
+  __napiInstance.exports['__napi_register__find_imports_11']?.()
+  __napiInstance.exports['__napi_register__transfer_project_graph_12']?.()
+  __napiInstance.exports['__napi_register__ExternalNode_struct_13']?.()
+  __napiInstance.exports['__napi_register__Target_struct_14']?.()
+  __napiInstance.exports['__napi_register__Project_struct_15']?.()
+  __napiInstance.exports['__napi_register__ProjectGraph_struct_16']?.()
+  __napiInstance.exports['__napi_register__HashPlanner_struct_17']?.()
+  __napiInstance.exports['__napi_register__HashPlanner_impl_21']?.()
+  __napiInstance.exports['__napi_register__HashDetails_struct_22']?.()
+  __napiInstance.exports['__napi_register__HasherOptions_struct_23']?.()
+  __napiInstance.exports['__napi_register__TaskHasher_struct_24']?.()
+  __napiInstance.exports['__napi_register__TaskHasher_impl_27']?.()
+  __napiInstance.exports['__napi_register__Task_struct_28']?.()
+  __napiInstance.exports['__napi_register__TaskTarget_struct_29']?.()
+  __napiInstance.exports['__napi_register__TaskGraph_struct_30']?.()
+  __napiInstance.exports['__napi_register__FileData_struct_31']?.()
+  __napiInstance.exports['__napi_register__InputsInput_struct_32']?.()
+  __napiInstance.exports['__napi_register__FileSetInput_struct_33']?.()
+  __napiInstance.exports['__napi_register__RuntimeInput_struct_34']?.()
+  __napiInstance.exports['__napi_register__EnvironmentInput_struct_35']?.()
+  __napiInstance.exports['__napi_register__ExternalDependenciesInput_struct_36']?.()
+  __napiInstance.exports['__napi_register__DepsOutputsInput_struct_37']?.()
+  __napiInstance.exports['__napi_register__NxJson_struct_38']?.()
+  __napiInstance.exports['__napi_register__WorkspaceContext_struct_39']?.()
+  __napiInstance.exports['__napi_register__WorkspaceContext_impl_48']?.()
+  __napiInstance.exports['__napi_register__WorkspaceErrors_49']?.()
+  __napiInstance.exports['__napi_register__NxWorkspaceFiles_struct_50']?.()
+  __napiInstance.exports['__napi_register__NxWorkspaceFilesExternals_struct_51']?.()
+  __napiInstance.exports['__napi_register__UpdatedWorkspaceFiles_struct_52']?.()
+  __napiInstance.exports['__napi_register__FileMap_struct_53']?.()
+  __napiInstance.exports['__napi_register____test_only_transfer_file_map_54']?.()
 }
 module.exports.HashPlanner = __napiModule.exports.HashPlanner
 module.exports.ImportResult = __napiModule.exports.ImportResult
@@ -132,10 +134,12 @@ module.exports.expandOutputs = __napiModule.exports.expandOutputs
 module.exports.findImports = __napiModule.exports.findImports
 module.exports.getBinaryTarget = __napiModule.exports.getBinaryTarget
 module.exports.getFilesForOutputs = __napiModule.exports.getFilesForOutputs
+module.exports.getTransformableOutputs = __napiModule.exports.getTransformableOutputs
 module.exports.hashArray = __napiModule.exports.hashArray
 module.exports.hashFile = __napiModule.exports.hashFile
 module.exports.IS_WASM = __napiModule.exports.IS_WASM
 module.exports.remove = __napiModule.exports.remove
 module.exports.testOnlyTransferFileMap = __napiModule.exports.testOnlyTransferFileMap
 module.exports.transferProjectGraph = __napiModule.exports.transferProjectGraph
+module.exports.validateOutputs = __napiModule.exports.validateOutputs
 module.exports.WorkspaceErrors = __napiModule.exports.WorkspaceErrors

package/src/project-graph/plugins/isolation/plugin-pool.js

@@ -273,7 +273,7 @@ async function startPluginWorker() {
                     socket,
                 });
             }
-            else if (attempts > 1000) {
+            else if (attempts > 10000) {
                 // daemon fails to start, the process probably exited
                 // we print the logs and exit the client
                 reject('Failed to start plugin worker.');

package/src/tasks-runner/run-command.js

@@ -118,6 +118,9 @@ async function runCommand(projectsToRun, currentProjectGraph, { nxJson }, nxArgs
 }
 async function ensureWorkspaceIsInSyncAndGetGraphs(projectGraph, nxJson, projectNames, nxArgs, overrides, extraTargetDependencies, extraOptions) {
     let taskGraph = createTaskGraphAndRunValidations(projectGraph, extraTargetDependencies ?? {}, projectNames, nxArgs, overrides, extraOptions);
+    if (nxArgs.skipSync) {
+        return { projectGraph, taskGraph };
+    }
     // collect unique syncGenerators from the tasks
     const uniqueSyncGenerators = new Set();
     for (const { target } of Object.values(taskGraph.tasks)) {
@@ -141,7 +144,7 @@ async function ensureWorkspaceIsInSyncAndGetGraphs(projectGraph, nxJson, project
     }
     const outOfSyncTitle = 'The workspace is out of sync';
     const resultBodyLines = [...(0, sync_generators_1.syncGeneratorResultsToMessageLines)(results), ''];
-    const fixMessage = 'You can manually run `nx sync` to update your workspace or you can set `sync.applyChanges` to `true` in your `nx.json` to apply the changes automatically when running tasks.';
+    const fixMessage = 'You can manually run `nx sync` to update your workspace or you can set `sync.applyChanges` to `true` in your `nx.json` to apply the changes automatically when running tasks in interactive environments.';
     const willErrorOnCiMessage = 'Please note that this will be an error on CI.';
     if ((0, is_ci_1.isCI)() || !process.stdout.isTTY) {
         // If the user is running in CI or is running in a non-TTY environment we

package/src/tasks-runner/utils.d.ts

@@ -21,14 +21,8 @@ export declare function getOutputs(p: Record<string, ProjectGraphProjectNode>, t
 export declare function normalizeTargetDependencyWithStringProjects(dependencyConfig: TargetDependencyConfig): Omit<TargetDependencyConfig, 'projects'> & {
     projects: string[];
 };
-declare class InvalidOutputsError extends Error {
-    outputs: string[];
-    invalidOutputs: Set<string>;
-    constructor(outputs: string[], invalidOutputs: Set<string>);
-    private static createMessage;
-}
 export declare function validateOutputs(outputs: string[]): void;
-export declare function transformLegacyOutputs(projectRoot: string, error: InvalidOutputsError): string[];
+export declare function transformLegacyOutputs(projectRoot: string, outputs: string[]): string[];
 /**
  * @deprecated Pass the target and overrides instead. This will be removed in v20.
  */
@@ -61,4 +55,3 @@ export declare function isCacheableTask(task: Task, options: {
     cacheableTargets?: string[] | null;
 }): boolean;
 export declare function unparse(options: Object): string[];
-export {};

package/src/tasks-runner/utils.js

@@ -37,6 +37,7 @@ const project_graph_1 = require("../project-graph/project-graph");
 const find_matching_projects_1 = require("../utils/find-matching-projects");
 const minimatch_1 = require("minimatch");
 const globs_1 = require("../utils/globs");
+const native_1 = require("../native");
 function getDependencyConfigs({ project, target }, extraTargetDependencies, projectGraph, allTargetNames) {
     const dependencyConfigs = (projectGraph.nodes[project].data?.targets[target]?.dependsOn ??
         // This is passed into `run-command` from programmatic invocations
@@ -177,19 +178,15 @@ function assertOutputsAreValidType(outputs) {
 }
 function validateOutputs(outputs) {
     assertOutputsAreValidType(outputs);
-    const invalidOutputs = new Set();
-    for (const output of outputs) {
-        if (!/^!?{[\s\S]+}/.test(output)) {
-            invalidOutputs.add(output);
-        }
-    }
-    if (invalidOutputs.size > 0) {
-        throw new InvalidOutputsError(outputs, invalidOutputs);
-    }
+    (0, native_1.validateOutputs)(outputs);
 }
-function transformLegacyOutputs(projectRoot, error) {
-    return error.outputs.map((output) => {
-        if (!error.invalidOutputs.has(output)) {
+function transformLegacyOutputs(projectRoot, outputs) {
+    const transformableOutputs = new Set((0, native_1.getTransformableOutputs)(outputs));
+    if (transformableOutputs.size === 0) {
+        return outputs;
+    }
+    return outputs.map((output) => {
+        if (!transformableOutputs.has(output)) {
             return output;
         }
         let [isNegated, outputPath] = output.startsWith('!')