nx 19.4.2 → 19.4.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nx",
-  "version": "19.4.2",
+  "version": "19.4.3",
   "private": false,
   "description": "The core Nx plugin contains the core functionality of Nx like the project graph, nx commands and task orchestration.",
   "repository": {
@@ -70,7 +70,7 @@
     "yargs-parser": "21.1.1",
     "node-machine-id": "1.1.12",
     "ora": "5.3.0",
-    "@nrwl/tao": "19.4.2"
+    "@nrwl/tao": "19.4.3"
   },
   "peerDependencies": {
     "@swc-node/register": "^1.8.0",
@@ -85,16 +85,16 @@
     }
   },
   "optionalDependencies": {
-    "@nx/nx-darwin-x64": "19.4.2",
-    "@nx/nx-darwin-arm64": "19.4.2",
-    "@nx/nx-linux-x64-gnu": "19.4.2",
-    "@nx/nx-linux-x64-musl": "19.4.2",
-    "@nx/nx-win32-x64-msvc": "19.4.2",
-    "@nx/nx-linux-arm64-gnu": "19.4.2",
-    "@nx/nx-linux-arm64-musl": "19.4.2",
-    "@nx/nx-linux-arm-gnueabihf": "19.4.2",
-    "@nx/nx-win32-arm64-msvc": "19.4.2",
-    "@nx/nx-freebsd-x64": "19.4.2"
+    "@nx/nx-darwin-x64": "19.4.3",
+    "@nx/nx-darwin-arm64": "19.4.3",
+    "@nx/nx-linux-x64-gnu": "19.4.3",
+    "@nx/nx-linux-x64-musl": "19.4.3",
+    "@nx/nx-win32-x64-msvc": "19.4.3",
+    "@nx/nx-linux-arm64-gnu": "19.4.3",
+    "@nx/nx-linux-arm64-musl": "19.4.3",
+    "@nx/nx-linux-arm-gnueabihf": "19.4.3",
+    "@nx/nx-win32-arm64-msvc": "19.4.3",
+    "@nx/nx-freebsd-x64": "19.4.3"
   },
   "nx-migrations": {
     "migrations": "./migrations.json",

package/src/command-line/report/report.js

@@ -13,6 +13,7 @@ const semver_1 = require("semver");
 const installed_plugins_1 = require("../../utils/plugins/installed-plugins");
 const installation_directory_1 = require("../../utils/installation-directory");
 const nx_json_1 = require("../../config/nx-json");
+const error_types_1 = require("../../project-graph/error-types");
 const nxPackageJson = (0, fileutils_1.readJsonFile)((0, path_1.join)(__dirname, '../../../package.json'));
 exports.packagesWeCareAbout = [
     'lerna',
@@ -93,19 +94,11 @@ exports.reportHandler = reportHandler;
 async function getReportData() {
     const pm = (0, package_manager_1.detectPackageManager)();
     const pmVersion = (0, package_manager_1.getPackageManagerVersion)(pm);
+    const { graph, error: projectGraphError } = await tryGetProjectGraph();
     const nxJson = (0, nx_json_1.readNxJson)();
-    const localPlugins = await findLocalPlugins(nxJson);
+    const localPlugins = await findLocalPlugins(graph, nxJson);
     const communityPlugins = findInstalledCommunityPlugins();
     const registeredPlugins = findRegisteredPluginsBeingUsed(nxJson);
-    let projectGraphError = null;
-    if (isNativeAvailable()) {
-        try {
-            await (0, project_graph_1.createProjectGraphAsync)();
-        }
-        catch (e) {
-            projectGraphError = e;
-        }
-    }
     const packageVersionsWeCareAbout = findInstalledPackagesWeCareAbout();
     packageVersionsWeCareAbout.unshift({
         package: 'nx',
@@ -130,9 +123,24 @@ async function getReportData() {
     };
 }
 exports.getReportData = getReportData;
-async function findLocalPlugins(nxJson) {
+async function tryGetProjectGraph() {
+    try {
+        return { graph: await (0, project_graph_1.createProjectGraphAsync)() };
+    }
+    catch (error) {
+        if (error instanceof error_types_1.ProjectGraphError) {
+            return {
+                graph: error.getPartialProjectGraph(),
+                error: error,
+            };
+        }
+        return {
+            error,
+        };
+    }
+}
+async function findLocalPlugins(projectGraph, nxJson) {
     try {
-        const projectGraph = await (0, project_graph_1.createProjectGraphAsync)({ exitOnError: true });
         const localPlugins = await (0, local_plugins_1.getLocalWorkspacePlugins)((0, project_graph_1.readProjectsConfigurationFromProjectGraph)(projectGraph), nxJson);
         return Array.from(localPlugins.keys());
     }

package/src/project-graph/plugins/internal-api.d.ts

@@ -25,5 +25,5 @@ export declare const nxPluginCache: Map<unknown, [
     Promise<LoadedNxPlugin>,
     () => void
 ]>;
-export declare function loadNxPlugins(plugins: PluginConfiguration[], root?: string): Promise<[LoadedNxPlugin[], () => void]>;
+export declare function loadNxPlugins(plugins: PluginConfiguration[], root?: string): Promise<readonly [LoadedNxPlugin[], () => void]>;
 export declare function getDefaultPlugins(root: string): Promise<string[]>;

package/src/project-graph/plugins/internal-api.js

@@ -69,18 +69,19 @@ exports.LoadedNxPlugin = LoadedNxPlugin;
 // referenced multiple times.
 exports.nxPluginCache = new Map();
 async function loadNxPlugins(plugins, root = workspace_root_1.workspaceRoot) {
-    const result = [];
+    performance.mark('loadNxPlugins:start');
     const loadingMethod = process.env.NX_ISOLATE_PLUGINS === 'true'
         ? isolation_1.loadNxPluginInIsolation
         : loader_1.loadNxPlugin;
     plugins = await normalizePlugins(plugins, root);
+    const result = new Array(plugins?.length);
     const cleanupFunctions = [];
-    for (const plugin of plugins) {
+    await Promise.all(plugins.map(async (plugin, idx) => {
         const [loadedPluginPromise, cleanup] = await loadingMethod(plugin, root);
-        result.push(loadedPluginPromise);
+        result[idx] = loadedPluginPromise;
         cleanupFunctions.push(cleanup);
-    }
-    return [
+    }));
+    const ret = [
         await Promise.all(result),
         () => {
             for (const fn of cleanupFunctions) {
@@ -91,6 +92,9 @@ async function loadNxPlugins(plugins, root = workspace_root_1.workspaceRoot) {
             }
         },
     ];
+    performance.mark('loadNxPlugins:end');
+    performance.measure('loadNxPlugins', 'loadNxPlugins:start', 'loadNxPlugins:end');
+    return ret;
 }
 exports.loadNxPlugins = loadNxPlugins;
 async function normalizePlugins(plugins, root) {

package/src/project-graph/plugins/isolation/plugin-worker.js

@@ -3,8 +3,8 @@ Object.defineProperty(exports, "__esModule", { value: true });
 const messaging_1 = require("./messaging");
 const loader_1 = require("../loader");
 const serializable_error_1 = require("../../../utils/serializable-error");
-const net_1 = require("net");
 const consume_messages_from_socket_1 = require("../../../utils/consume-messages-from-socket");
+const net_1 = require("net");
 const fs_1 = require("fs");
 if (process.env.NX_PERF_LOGGING === 'true') {
     require('../../../utils/perf-logging');

package/src/tasks-runner/task-orchestrator.js

@@ -264,6 +264,14 @@ class TaskOrchestrator {
                     });
                 }
             }
+            else if (targetConfiguration.executor === 'nx:noop') {
+                (0, fs_1.writeFileSync)(temporaryOutputPath, '');
+                results.push({
+                    task,
+                    status: 'success',
+                    terminalOutput: '',
+                });
+            }
             else {
                 // cache prep
                 const { code, terminalOutput } = await this.runTaskInForkedProcess(task, env, pipeOutput, temporaryOutputPath, streamOutput);