nx 19.4.0-beta.1 → 19.4.0-beta.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nx",
-  "version": "19.4.0-beta.1",
+  "version": "19.4.0-beta.2",
   "private": false,
   "description": "The core Nx plugin contains the core functionality of Nx like the project graph, nx commands and task orchestration.",
   "repository": {
@@ -45,8 +45,8 @@
     "cli-cursor": "3.1.0",
     "cli-spinners": "2.6.1",
     "cliui": "^8.0.1",
-    "dotenv": "~16.3.1",
-    "dotenv-expand": "~10.0.0",
+    "dotenv": "~16.4.5",
+    "dotenv-expand": "~11.0.6",
     "enquirer": "~2.3.6",
     "figures": "3.2.0",
     "flat": "^5.0.2",
@@ -70,7 +70,7 @@
     "yargs-parser": "21.1.1",
     "node-machine-id": "1.1.12",
     "ora": "5.3.0",
-    "@nrwl/tao": "19.4.0-beta.1"
+    "@nrwl/tao": "19.4.0-beta.2"
   },
   "peerDependencies": {
     "@swc-node/register": "^1.8.0",
@@ -85,16 +85,16 @@
     }
   },
   "optionalDependencies": {
-    "@nx/nx-darwin-x64": "19.4.0-beta.1",
-    "@nx/nx-darwin-arm64": "19.4.0-beta.1",
-    "@nx/nx-linux-x64-gnu": "19.4.0-beta.1",
-    "@nx/nx-linux-x64-musl": "19.4.0-beta.1",
-    "@nx/nx-win32-x64-msvc": "19.4.0-beta.1",
-    "@nx/nx-linux-arm64-gnu": "19.4.0-beta.1",
-    "@nx/nx-linux-arm64-musl": "19.4.0-beta.1",
-    "@nx/nx-linux-arm-gnueabihf": "19.4.0-beta.1",
-    "@nx/nx-win32-arm64-msvc": "19.4.0-beta.1",
-    "@nx/nx-freebsd-x64": "19.4.0-beta.1"
+    "@nx/nx-darwin-x64": "19.4.0-beta.2",
+    "@nx/nx-darwin-arm64": "19.4.0-beta.2",
+    "@nx/nx-linux-x64-gnu": "19.4.0-beta.2",
+    "@nx/nx-linux-x64-musl": "19.4.0-beta.2",
+    "@nx/nx-win32-x64-msvc": "19.4.0-beta.2",
+    "@nx/nx-linux-arm64-gnu": "19.4.0-beta.2",
+    "@nx/nx-linux-arm64-musl": "19.4.0-beta.2",
+    "@nx/nx-linux-arm-gnueabihf": "19.4.0-beta.2",
+    "@nx/nx-win32-arm64-msvc": "19.4.0-beta.2",
+    "@nx/nx-freebsd-x64": "19.4.0-beta.2"
   },
   "nx-migrations": {
     "migrations": "./migrations.json",

package/release/changelog-renderer/index.d.ts

@@ -53,6 +53,12 @@ export interface DefaultChangelogRenderOptions extends ChangelogRenderOptions {
      * section. Defaults to true.
      */
     authors?: boolean;
+    /**
+     * If authors is enabled, controls whether or not to try to map the authors to their GitHub usernames
+     * using https://ungh.cc (from https://github.com/unjs/ungh) and the email addresses found in the commits.
+     * Defaults to true.
+     */
+    mapAuthorsToGitHubUsernames?: boolean;
     /**
      * Whether or not the commit references (such as commit and/or PR links) should be included in the changelog.
      * Defaults to true.

package/release/changelog-renderer/index.js

@@ -145,7 +145,7 @@ const defaultChangelogRenderer = async ({ projectGraph, changes, releaseVersion,
             }
         }
         // Try to map authors to github usernames
-        if (repoSlug) {
+        if (repoSlug && changelogRenderOptions.mapAuthorsToGitHubUsernames) {
             await Promise.all([..._authors.keys()].map(async (authorName) => {
                 const meta = _authors.get(authorName);
                 for (const email of meta.email) {

package/src/command-line/connect/connect-to-nx-cloud.d.ts

@@ -3,6 +3,6 @@ import { NxArgs } from '../../utils/command-line-utils';
 import { MessageKey } from '../../utils/ab-testing';
 export declare function onlyDefaultRunnerIsUsed(nxJson: NxJsonConfiguration): boolean;
 export declare function connectToNxCloudIfExplicitlyAsked(opts: NxArgs): Promise<void>;
-export declare function connectToNxCloudCommand(): Promise<boolean>;
+export declare function connectToNxCloudCommand(command?: string): Promise<boolean>;
 export declare function connectToNxCloudWithPrompt(command: string): Promise<void>;
 export declare function connectExistingRepoToNxCloudPrompt(key?: MessageKey): Promise<boolean>;

package/src/command-line/connect/connect-to-nx-cloud.js

@@ -41,38 +41,29 @@ async function connectToNxCloudIfExplicitlyAsked(opts) {
     }
 }
 exports.connectToNxCloudIfExplicitlyAsked = connectToNxCloudIfExplicitlyAsked;
-async function connectToNxCloudCommand() {
+async function connectToNxCloudCommand(command) {
     const nxJson = (0, configuration_1.readNxJson)();
     if ((0, nx_cloud_utils_1.isNxCloudUsed)(nxJson)) {
-        if (process.env.NX_NEW_CLOUD_ONBOARDING !== 'true') {
-            output_1.output.log({
-                title: '✔ This workspace already has Nx Cloud set up',
-                bodyLines: [
-                    'If you have not done so already, connect your workspace to your Nx Cloud account:',
-                    `- Login at ${(0, nx_cloud_utils_1.getNxCloudUrl)(nxJson)} to connect your repository`,
-                ],
-            });
+        const token = process.env.NX_CLOUD_ACCESS_TOKEN || nxJson.nxCloudAccessToken;
+        if (!token) {
+            throw new Error(`Unable to authenticate. Either define accessToken in nx.json or set the NX_CLOUD_ACCESS_TOKEN env variable.`);
         }
-        else {
-            const token = process.env.NX_CLOUD_ACCESS_TOKEN || nxJson.nxCloudAccessToken;
-            if (!token) {
-                throw new Error(`Unable to authenticate. Either define accessToken in nx.json or set the NX_CLOUD_ACCESS_TOKEN env variable.`);
-            }
-            const connectCloudUrl = await (0, url_shorten_1.shortenedCloudUrl)('nx-connect', token);
-            output_1.output.log({
-                title: '✔ This workspace already has Nx Cloud set up',
-                bodyLines: [
-                    'If you have not done so already, connect your workspace to your Nx Cloud account:',
-                    `- Connect with Nx Cloud at: 
+        const connectCloudUrl = await (0, url_shorten_1.shortenedCloudUrl)('nx-connect', token);
+        output_1.output.log({
+            title: '✔ This workspace already has Nx Cloud set up',
+            bodyLines: [
+                'If you have not done so already, connect your workspace to your Nx Cloud account:',
+                `- Connect with Nx Cloud at: 
       
         ${connectCloudUrl}`,
-                ],
-            });
-        }
+            ],
+        });
         return false;
     }
     const tree = new tree_1.FsTree(workspace_root_1.workspaceRoot, false, 'connect-to-nx-cloud');
-    const callback = await (0, connect_to_nx_cloud_1.connectToNxCloud)(tree, {});
+    const callback = await (0, connect_to_nx_cloud_1.connectToNxCloud)(tree, {
+        installationSource: command ?? 'nx-connect',
+    });
     tree.lock();
     (0, tree_1.flushChanges)(workspace_root_1.workspaceRoot, tree.listChanges());
     await callback();
@@ -81,7 +72,7 @@ async function connectToNxCloudCommand() {
 exports.connectToNxCloudCommand = connectToNxCloudCommand;
 async function connectToNxCloudWithPrompt(command) {
     const setNxCloud = await nxCloudPrompt('setupNxCloud');
-    const useCloud = setNxCloud === 'yes' ? await connectToNxCloudCommand() : false;
+    const useCloud = setNxCloud === 'yes' ? await connectToNxCloudCommand(command) : false;
     await (0, ab_testing_1.recordStat)({
         command,
         nxVersion: versions_1.nxVersion,

package/src/command-line/graph/graph.d.ts

@@ -23,6 +23,7 @@ export interface ProjectGraphClientResponse {
     exclude: string[];
     isPartial: boolean;
     errors?: GraphError[];
+    connectedToCloud?: boolean;
 }
 export interface TaskGraphClientResponse {
     taskGraphs: Record<string, TaskGraph>;

package/src/command-line/graph/graph.js

@@ -28,6 +28,7 @@ const nx_deps_cache_1 = require("../../project-graph/nx-deps-cache");
 const create_task_hasher_1 = require("../../hasher/create-task-hasher");
 const task_hasher_1 = require("../../hasher/task-hasher");
 const error_types_1 = require("../../project-graph/error-types");
+const nx_cloud_utils_1 = require("../../utils/nx-cloud-utils");
 // maps file extention to MIME types
 const mimeType = {
     '.ico': 'image/x-icon',
@@ -478,10 +479,12 @@ async function createProjectGraphAndSourceMapClientResponse(affected = []) {
     let sourceMaps;
     let isPartial = false;
     let errors;
+    let connectedToCloud;
     try {
         const projectGraphAndSourceMaps = await (0, project_graph_1.createProjectGraphAndSourceMapsAsync)({ exitOnError: false });
         projectGraph = projectGraphAndSourceMaps.projectGraph;
         sourceMaps = projectGraphAndSourceMaps.sourceMaps;
+        connectedToCloud = (0, nx_cloud_utils_1.isNxCloudUsed)((0, configuration_1.readNxJson)());
     }
     catch (e) {
         if (e instanceof error_types_1.ProjectGraphError) {
@@ -509,7 +512,14 @@ async function createProjectGraphAndSourceMapClientResponse(affected = []) {
     const projects = Object.values(graph.nodes);
     const dependencies = graph.dependencies;
     const hasher = (0, crypto_1.createHash)('sha256');
-    hasher.update(JSON.stringify({ layout, projects, dependencies, sourceMaps, errors }));
+    hasher.update(JSON.stringify({
+        layout,
+        projects,
+        dependencies,
+        sourceMaps,
+        errors,
+        connectedToCloud,
+    }));
     const hash = hasher.digest('hex');
     perf_hooks_1.performance.mark('project graph response generation:end');
     perf_hooks_1.performance.measure('project graph watch calculation', 'project graph watch calculation:start', 'project graph watch calculation:end');
@@ -525,6 +535,7 @@ async function createProjectGraphAndSourceMapClientResponse(affected = []) {
             fileMap,
             isPartial,
             errors,
+            connectedToCloud,
         },
         sourceMapResponse: sourceMaps,
     };

package/src/command-line/init/implementation/dot-nx/add-nx-scripts.js

@@ -74,12 +74,11 @@ function writeMinimalNxJson(host, version) {
 exports.writeMinimalNxJson = writeMinimalNxJson;
 function updateGitIgnore(host) {
     let contents = host.read('.gitignore', 'utf-8') ?? '';
-    if (!contents.includes('.nx/installation')) {
-        contents = [contents, '.nx/installation'].join('\n');
-    }
-    if (!contents.includes('.nx/cache')) {
-        contents = [contents, '.nx/cache'].join('\n');
-    }
+    ['.nx/installation', '.nx/cache', '.nx/workspace-data'].forEach((file) => {
+        if (!contents.includes(file)) {
+            contents = [contents, file].join('\n');
+        }
+    });
     host.write('.gitignore', contents);
 }
 exports.updateGitIgnore = updateGitIgnore;

package/src/command-line/release/changelog.js

@@ -222,7 +222,12 @@ async function releaseChangelog(args) {
             continue;
         }
         for (const project of releaseGroup.projects) {
-            const dependentProjects = (projectsVersionData[project]?.dependentProjects || [])
+            // If the project does not have any changes, do not process its dependents
+            if (!projectsVersionData[project] ||
+                projectsVersionData[project].newVersion === null) {
+                continue;
+            }
+            const dependentProjects = (projectsVersionData[project].dependentProjects || [])
                 .map((dep) => {
                 return {
                     dependencyName: dep.source,

package/src/command-line/release/config/config.js

@@ -110,6 +110,7 @@ async function createNxReleaseConfig(projectGraph, projectFileMap, userConfig =
                     renderer: defaultRendererPath,
                     renderOptions: {
                         authors: true,
+                        mapAuthorsToGitHubUsernames: true,
                         commitReferences: true,
                         versionTitleDate: true,
                     },
@@ -123,6 +124,7 @@ async function createNxReleaseConfig(projectGraph, projectFileMap, userConfig =
                     renderer: defaultRendererPath,
                     renderOptions: {
                         authors: true,
+                        mapAuthorsToGitHubUsernames: true,
                         commitReferences: true,
                         versionTitleDate: true,
                     },
@@ -153,6 +155,7 @@ async function createNxReleaseConfig(projectGraph, projectFileMap, userConfig =
             renderer: defaultRendererPath,
             renderOptions: {
                 authors: true,
+                mapAuthorsToGitHubUsernames: true,
                 commitReferences: true,
                 versionTitleDate: true,
             },

package/src/command-line/run/command-object.js

@@ -28,8 +28,9 @@ exports.yargsNxInfixCommand = {
     command: '$0 <target> [project] [_..]',
     describe: 'Run a target for a project',
     handler: async (args) => {
-        await (0, params_1.handleErrors)(args.verbose ?? process.env.NX_VERBOSE_LOGGING === 'true', async () => {
+        const exitCode = await (0, params_1.handleErrors)(args.verbose ?? process.env.NX_VERBOSE_LOGGING === 'true', async () => {
             return (await Promise.resolve().then(() => require('./run-one'))).runOne(process.cwd(), (0, shared_options_1.withOverrides)(args, 0));
         });
+        process.exit(exitCode);
     },
 };

package/src/config/workspace-json-project-json.d.ts

@@ -105,6 +105,7 @@ export interface ProjectConfiguration {
     metadata?: ProjectMetadata;
 }
 export interface ProjectMetadata {
+    description?: string;
     technologies?: string[];
     targetGroups?: Record<string, string[]>;
 }
@@ -112,6 +113,7 @@ export interface TargetMetadata {
     [k: string]: any;
     description?: string;
     technologies?: string[];
+    nonAtomizedTarget?: string;
 }
 export interface TargetDependencyConfig {
     /**