nx 19.3.0-canary.20240606-bccb2c5 → 19.3.0-canary.20240607-7495f06

package/bin/post-install.js

@@ -14,7 +14,6 @@ const workspace_context_1 = require("../src/utils/workspace-context");
 const logger_1 = require("../src/utils/logger");
 (async () => {
     const start = new Date();
-    let errored = false;
     try {
         (0, workspace_context_1.setupWorkspaceContext)(workspace_root_1.workspaceRoot);
         if (isMainNxPackage() && (0, fileutils_1.fileExists)((0, path_1.join)(workspace_root_1.workspaceRoot, 'nx.json'))) {
@@ -39,13 +38,12 @@ const logger_1 = require("../src/utils/logger");
         }
     }
     catch (e) {
-        errored = true;
         logger_1.logger.verbose(e);
     }
     finally {
         const end = new Date();
         logger_1.logger.verbose(`Nx postinstall steps took ${end.getTime() - start.getTime()}ms`);
-        process.exit(errored ? 1 : 0);
+        process.exit(0);
     }
 })();
 function isMainNxPackage() {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nx",
-  "version": "19.3.0-canary.20240606-bccb2c5",
+  "version": "19.3.0-canary.20240607-7495f06",
   "private": false,
   "description": "The core Nx plugin contains the core functionality of Nx like the project graph, nx commands and task orchestration.",
   "repository": {
@@ -70,7 +70,7 @@
     "yargs-parser": "21.1.1",
     "node-machine-id": "1.1.12",
     "ora": "5.3.0",
-    "@nrwl/tao": "19.3.0-canary.20240606-bccb2c5"
+    "@nrwl/tao": "19.3.0-canary.20240607-7495f06"
   },
   "peerDependencies": {
     "@swc-node/register": "^1.8.0",
@@ -85,16 +85,16 @@
     }
   },
   "optionalDependencies": {
-    "@nx/nx-darwin-x64": "19.3.0-canary.20240606-bccb2c5",
-    "@nx/nx-darwin-arm64": "19.3.0-canary.20240606-bccb2c5",
-    "@nx/nx-linux-x64-gnu": "19.3.0-canary.20240606-bccb2c5",
-    "@nx/nx-linux-x64-musl": "19.3.0-canary.20240606-bccb2c5",
-    "@nx/nx-win32-x64-msvc": "19.3.0-canary.20240606-bccb2c5",
-    "@nx/nx-linux-arm64-gnu": "19.3.0-canary.20240606-bccb2c5",
-    "@nx/nx-linux-arm64-musl": "19.3.0-canary.20240606-bccb2c5",
-    "@nx/nx-linux-arm-gnueabihf": "19.3.0-canary.20240606-bccb2c5",
-    "@nx/nx-win32-arm64-msvc": "19.3.0-canary.20240606-bccb2c5",
-    "@nx/nx-freebsd-x64": "19.3.0-canary.20240606-bccb2c5"
+    "@nx/nx-darwin-x64": "19.3.0-canary.20240607-7495f06",
+    "@nx/nx-darwin-arm64": "19.3.0-canary.20240607-7495f06",
+    "@nx/nx-linux-x64-gnu": "19.3.0-canary.20240607-7495f06",
+    "@nx/nx-linux-x64-musl": "19.3.0-canary.20240607-7495f06",
+    "@nx/nx-win32-x64-msvc": "19.3.0-canary.20240607-7495f06",
+    "@nx/nx-linux-arm64-gnu": "19.3.0-canary.20240607-7495f06",
+    "@nx/nx-linux-arm64-musl": "19.3.0-canary.20240607-7495f06",
+    "@nx/nx-linux-arm-gnueabihf": "19.3.0-canary.20240607-7495f06",
+    "@nx/nx-win32-arm64-msvc": "19.3.0-canary.20240607-7495f06",
+    "@nx/nx-freebsd-x64": "19.3.0-canary.20240607-7495f06"
   },
   "nx-migrations": {
     "migrations": "./migrations.json",

package/src/command-line/init/implementation/utils.js

@@ -98,10 +98,23 @@ function updateGitIgnore(root) {
     const ignorePath = (0, path_1.join)(root, '.gitignore');
     try {
         let contents = (0, fs_1.readFileSync)(ignorePath, 'utf-8');
+        const lines = contents.split('\n');
+        let sepIncluded = false;
         if (!contents.includes('.nx/cache')) {
-            contents = [contents, '', '.nx/cache'].join('\n');
-            (0, fs_1.writeFileSync)(ignorePath, contents, 'utf-8');
+            if (!sepIncluded) {
+                lines.push('\n');
+                sepIncluded = true;
+            }
+            lines.push('.nx/cache');
+        }
+        if (!contents.includes('.nx/workspace-data')) {
+            if (!sepIncluded) {
+                lines.push('\n');
+                sepIncluded = true;
+            }
+            lines.push('.nx/workspace-data');
         }
+        (0, fs_1.writeFileSync)(ignorePath, lines.join('\n'), 'utf-8');
     }
     catch { }
 }

package/src/daemon/client/client.js

@@ -19,7 +19,6 @@ const nx_json_1 = require("../../config/nx-json");
 const daemon_socket_messenger_1 = require("./daemon-socket-messenger");
 const cache_1 = require("../cache");
 const error_types_1 = require("../../project-graph/error-types");
-const dotenv_1 = require("../../utils/dotenv");
 const get_nx_workspace_files_1 = require("../message-types/get-nx-workspace-files");
 const get_context_file_data_1 = require("../message-types/get-context-file-data");
 const get_files_in_directory_1 = require("../message-types/get-files-in-directory");
@@ -41,7 +40,6 @@ class DaemonClient {
         this._daemonReady = null;
         this._out = null;
         this._err = null;
-        (0, dotenv_1.loadRootEnvFiles)(workspace_root_1.workspaceRoot);
         try {
             this.nxJson = (0, configuration_1.readNxJson)();
         }

package/src/executors/run-commands/run-commands.impl.d.ts

@@ -42,7 +42,7 @@ export interface NormalizedRunCommandsOptions extends RunCommandsOptions {
         [k: string]: any;
     };
     unparsedCommandArgs?: {
-        [k: string]: string;
+        [k: string]: string | string[];
     };
     args?: string;
 }

package/src/executors/run-commands/run-commands.impl.js

@@ -29,7 +29,9 @@ const propKeys = [
     'command',
     'commands',
     'color',
+    'no-color',
     'parallel',
+    'no-parallel',
     'readyWhen',
     'cwd',
     'args',
@@ -131,6 +133,7 @@ function normalizeOptions(options) {
             'parse-numbers': false,
             'parse-positional-numbers': false,
             'dot-notation': false,
+            'camel-case-expansion': false,
         },
     });
     options.unknownOptions = Object.keys(options)
@@ -294,20 +297,21 @@ function interpolateArgsIntoCommand(command, opts, forwardAllArgs) {
     else if (forwardAllArgs) {
         let args = '';
         if (Object.keys(opts.unknownOptions ?? {}).length > 0) {
-            args +=
-                ' ' +
-                    Object.keys(opts.unknownOptions)
-                        .filter((k) => typeof opts.unknownOptions[k] !== 'object' &&
-                        opts.parsedArgs[k] === opts.unknownOptions[k])
-                        .map((k) => `--${k}=${opts.unknownOptions[k]}`)
-                        .map(wrapArgIntoQuotesIfNeeded)
-                        .join(' ');
+            const unknownOptionsArgs = Object.keys(opts.unknownOptions)
+                .filter((k) => typeof opts.unknownOptions[k] !== 'object' &&
+                opts.parsedArgs[k] === opts.unknownOptions[k])
+                .map((k) => `--${k}=${opts.unknownOptions[k]}`)
+                .map(wrapArgIntoQuotesIfNeeded)
+                .join(' ');
+            if (unknownOptionsArgs) {
+                args += ` ${unknownOptionsArgs}`;
+            }
         }
         if (opts.args) {
             args += ` ${opts.args}`;
         }
         if (opts.__unparsed__?.length > 0) {
-            const filterdParsedOptions = filterPropKeysFromUnParsedOptions(opts.__unparsed__, opts.unparsedCommandArgs);
+            const filterdParsedOptions = filterPropKeysFromUnParsedOptions(opts.__unparsed__, opts.parsedArgs);
             if (filterdParsedOptions.length > 0) {
                 args += ` ${filterdParsedOptions
                     .map(wrapArgIntoQuotesIfNeeded)
@@ -335,13 +339,14 @@ function parseArgs(unparsedCommandArgs, unknownOptions, args) {
  * @param unparsedCommandArgs e.g. { prop1: 'value1', prop2: 'value2', args: 'test'}
  * @returns filtered options that are not part of the propKeys array e.g. ['--prop1', 'value1', '--prop2=value2']
  */
-function filterPropKeysFromUnParsedOptions(__unparsed__, unparsedCommandArgs = {}) {
+function filterPropKeysFromUnParsedOptions(__unparsed__, parseArgs = {}) {
     const parsedOptions = [];
     for (let index = 0; index < __unparsed__.length; index++) {
         const element = __unparsed__[index];
         if (element.startsWith('--')) {
             const key = element.replace('--', '');
             if (element.includes('=')) {
+                // key can be in the format of --key=value or --key.subkey=value (e.g. env.foo=bar)
                 if (!propKeys.includes(key.split('=')[0].split('.')[0])) {
                     // check if the key is part of the propKeys array
                     parsedOptions.push(element);
@@ -351,7 +356,8 @@ function filterPropKeysFromUnParsedOptions(__unparsed__, unparsedCommandArgs = {
                 // check if the next element is a value for the key
                 if (propKeys.includes(key)) {
                     if (index + 1 < __unparsed__.length &&
-                        __unparsed__[index + 1] === unparsedCommandArgs[key]) {
+                        parseArgs[key] &&
+                        __unparsed__[index + 1].toString() === parseArgs[key].toString()) {
                         index++; // skip the next element
                     }
                 }

package/src/project-graph/utils/retrieve-workspace-files.d.ts

@@ -9,12 +9,12 @@ import { LoadedNxPlugin } from '../plugins/internal-api';
  * @param nxJson
  */
 export declare function retrieveWorkspaceFiles(workspaceRoot: string, projectRootMap: Record<string, string>): Promise<{
-    allWorkspaceFiles: import("../file-utils").FileData[];
+    allWorkspaceFiles: import("nx/src/devkit-exports").FileData[];
     fileMap: {
         projectFileMap: ProjectFiles;
-        nonProjectFiles: import("../../native").FileData[];
+        nonProjectFiles: import("nx/src/native").FileData[];
     };
-    rustReferences: import("../../native").NxWorkspaceFilesExternals;
+    rustReferences: import("nx/src/native").NxWorkspaceFilesExternals;
 }>;
 /**
  * Walk through the workspace and return `ProjectConfigurations`. Only use this if the projectFileMap is not needed.