nx 19.3.0-beta.0 → 19.3.0-beta.1

package/src/tasks-runner/create-task-graph.js

@@ -64,7 +64,26 @@ class ProcessTasks {
                 ? overrides
                 : { __overrides_unparsed__: [] };
             if (dependencyConfig.projects) {
-                this.processTasksForMatchingProjects(dependencyConfig, projectUsedToDeriveDependencies, configuration, task, taskOverrides, overrides);
+                /** LERNA SUPPORT START - Remove in v20 */
+                // Lerna uses `dependencies` in `prepNxOptions`, so we need to maintain
+                // support for it until lerna can be updated to use the syntax.
+                //
+                // This should have been removed in v17, but the updates to lerna had not
+                // been made yet.
+                //
+                // TODO(@agentender): Remove this part in v20
+                if (typeof dependencyConfig.projects === 'string') {
+                    if (dependencyConfig.projects === 'self') {
+                        this.processTasksForSingleProject(task, task.target.project, dependencyConfig, configuration, taskOverrides, overrides);
+                        continue;
+                    }
+                    else if (dependencyConfig.projects === 'dependencies') {
+                        this.processTasksForDependencies(projectUsedToDeriveDependencies, dependencyConfig, configuration, task, taskOverrides, overrides);
+                        continue;
+                    }
+                }
+                /** LERNA SUPPORT END - Remove in v17 */
+                this.processTasksForMatchingProjects(dependencyConfig, configuration, task, taskOverrides, overrides);
             }
             else if (dependencyConfig.dependencies) {
                 this.processTasksForDependencies(projectUsedToDeriveDependencies, dependencyConfig, configuration, task, taskOverrides, overrides);
@@ -74,41 +93,21 @@ class ProcessTasks {
             }
         }
     }
-    processTasksForMatchingProjects(dependencyConfig, projectUsedToDeriveDependencies, configuration, task, taskOverrides, overrides) {
+    processTasksForMatchingProjects(dependencyConfig, configuration, task, taskOverrides, overrides) {
         const targetProjectSpecifiers = typeof dependencyConfig.projects === 'string'
             ? [dependencyConfig.projects]
             : dependencyConfig.projects;
-        for (const projectSpecifier of targetProjectSpecifiers) {
-            // Lerna uses `dependencies` in `prepNxOptions`, so we need to maintain
-            // support for it until lerna can be updated to use the syntax.
-            // TODO(@agentender): Remove this part in v17
-            if (projectSpecifier === 'dependencies' &&
-                !this.projectGraph.nodes[projectSpecifier]) {
-                this.processTasksForDependencies(projectUsedToDeriveDependencies, dependencyConfig, configuration, task, taskOverrides, overrides);
-            }
-            else {
-                // Since we need to maintain support for dependencies, it is more coherent
-                // that we also support self.
-                // TODO(@agentender): Remove this part in v17
-                const matchingProjects = 
-                /** LERNA SUPPORT START - Remove in v17 */
-                projectSpecifier === 'self' &&
-                    !this.projectGraph.nodes[projectSpecifier]
-                    ? [task.target.project]
-                    : /** LERNA SUPPORT END */
-                        (0, find_matching_projects_1.findMatchingProjects)([projectSpecifier], this.projectGraph.nodes);
-                if (matchingProjects.length === 0) {
-                    output_1.output.warn({
-                        title: `\`dependsOn\` is misconfigured for ${task.target.project}:${task.target.target}`,
-                        bodyLines: [
-                            `Project pattern "${projectSpecifier}" does not match any projects.`,
-                        ],
-                    });
-                }
-                for (const projectName of matchingProjects) {
-                    this.processTasksForSingleProject(task, projectName, dependencyConfig, configuration, taskOverrides, overrides);
-                }
-            }
+        const matchingProjects = (0, find_matching_projects_1.findMatchingProjects)(targetProjectSpecifiers, this.projectGraph.nodes);
+        if (matchingProjects.length === 0) {
+            output_1.output.warn({
+                title: `\`dependsOn\` is misconfigured for ${task.target.project}:${task.target.target}`,
+                bodyLines: [
+                    `Project patterns "${targetProjectSpecifiers}" does not match any projects.`,
+                ],
+            });
+        }
+        for (const projectName of matchingProjects) {
+            this.processTasksForSingleProject(task, projectName, dependencyConfig, configuration, taskOverrides, overrides);
         }
     }
     processTasksForSingleProject(task, projectName, dependencyConfig, configuration, taskOverrides, overrides) {

package/src/utils/ab-testing.d.ts

@@ -31,7 +31,7 @@ declare const messageOptions: {
     }];
 };
 export type MessageKey = keyof typeof messageOptions;
-export type MessageData = typeof messageOptions[MessageKey][number];
+export type MessageData = (typeof messageOptions)[MessageKey][number];
 export declare class PromptMessages {
     private selectedMessages;
     getPrompt(key: MessageKey): MessageData;

package/src/utils/find-matching-projects.js

@@ -22,6 +22,15 @@ function findMatchingProjects(patterns = [], projects) {
     }
     const projectNames = Object.keys(projects);
     const matchedProjects = new Set();
+    // If the first pattern is an exclude pattern,
+    // we add a wildcard pattern at the first to select
+    // all projects, except the ones that match the exclude pattern.
+    // e.g. ['!tag:someTag', 'project2'] will match all projects except
+    // the ones with the tag 'someTag', and also match the project 'project2',
+    // regardless of its tags.
+    if (isExcludePattern(patterns[0])) {
+        patterns.unshift('*');
+    }
     for (const stringPattern of patterns) {
         if (!stringPattern.length) {
             continue;
@@ -139,8 +148,11 @@ function addMatchingProjectsByTag(projectNames, projects, pattern, matchedProjec
         }
     }
 }
+function isExcludePattern(pattern) {
+    return pattern.startsWith('!');
+}
 function parseStringPattern(pattern, projects) {
-    const isExclude = pattern.startsWith('!');
+    const isExclude = isExcludePattern(pattern);
     // Support for things like: `!{type}:value`
     if (isExclude) {
         pattern = pattern.substring(1);

package/src/utils/package-json.d.ts

@@ -1,6 +1,7 @@
 import { InputDefinition, ProjectMetadata, TargetConfiguration } from '../config/workspace-json-project-json';
 import { PackageManagerCommands } from './package-manager';
 export interface NxProjectPackageJsonConfiguration {
+    name?: string;
     implicitDependencies?: string[];
     tags?: string[];
     namedInputs?: {