nx 19.2.0-canary.20240528-7f11a1d → 19.2.0-canary.20240531-2cb7ecb

package/src/plugins/js/project-graph/build-dependencies/target-project-locator.js

@@ -1,36 +1,65 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.TargetProjectLocator = void 0;
-const typescript_1 = require("../../utils/typescript");
+exports.TargetProjectLocator = exports.isBuiltinModuleImport = void 0;
+const node_module_1 = require("node:module");
+const node_path_1 = require("node:path");
+const find_project_for_path_1 = require("../../../../project-graph/utils/find-project-for-path");
 const fileutils_1 = require("../../../../utils/fileutils");
-const path_1 = require("path");
 const workspace_root_1 = require("../../../../utils/workspace-root");
-const module_1 = require("module");
-const find_project_for_path_1 = require("../../../../project-graph/utils/find-project-for-path");
+const resolve_relative_to_dir_1 = require("../../utils/resolve-relative-to-dir");
+const typescript_1 = require("../../utils/typescript");
+/**
+ * Use a shared cache to avoid repeated npm package resolution work within the TargetProjectLocator.
+ */
+const defaultNpmResolutionCache = new Map();
 const builtInModuleSet = new Set([
-    ...module_1.builtinModules,
-    ...module_1.builtinModules.map((x) => `node:${x}`),
+    ...node_module_1.builtinModules,
+    ...node_module_1.builtinModules.map((x) => `node:${x}`),
 ]);
+function isBuiltinModuleImport(importExpr) {
+    const packageName = parsePackageNameFromImportExpression(importExpr);
+    return builtInModuleSet.has(packageName);
+}
+exports.isBuiltinModuleImport = isBuiltinModuleImport;
 class TargetProjectLocator {
-    constructor(nodes, externalNodes) {
+    constructor(nodes, externalNodes = {}, npmResolutionCache = defaultNpmResolutionCache) {
         this.nodes = nodes;
         this.externalNodes = externalNodes;
+        this.npmResolutionCache = npmResolutionCache;
         this.projectRootMappings = (0, find_project_for_path_1.createProjectRootMappings)(this.nodes);
-        this.npmProjects = filterRootExternalDependencies(this.externalNodes);
         this.tsConfig = this.getRootTsConfig();
         this.paths = this.tsConfig.config?.compilerOptions?.paths;
         this.typescriptResolutionCache = new Map();
-        this.npmResolutionCache = new Map();
+        /**
+         * Only the npm external nodes should be included.
+         *
+         * Unlike the raw externalNodes, ensure that there is always copy of the node where the version
+         * is set in the key for optimal lookup.
+         */
+        this.npmProjects = Object.values(this.externalNodes).reduce((acc, node) => {
+            if (node.type === 'npm') {
+                const keyWithVersion = `npm:${node.data.packageName}@${node.data.version}`;
+                if (!acc[node.name]) {
+                    acc[node.name] = node;
+                }
+                // The node.name may have already contained the version
+                if (!acc[keyWithVersion]) {
+                    acc[keyWithVersion] = node;
+                }
+            }
+            return acc;
+        }, {});
     }
     /**
-     * Find a project based on its import
+     * Resolve any workspace or external project that matches the given import expression,
+     * originating from the given filePath.
      *
      * @param importExpr
      * @param filePath
      */
-    findProjectWithImport(importExpr, filePath) {
+    findProjectFromImport(importExpr, filePath) {
         if ((0, fileutils_1.isRelativePath)(importExpr)) {
-            const resolvedModule = path_1.posix.join((0, path_1.dirname)(filePath), importExpr);
+            const resolvedModule = node_path_1.posix.join((0, node_path_1.dirname)(filePath), importExpr);
             return this.findProjectOfResolvedModule(resolvedModule);
         }
         // find project using tsconfig paths
@@ -39,7 +68,7 @@ class TargetProjectLocator {
             const [path, paths] = results;
             for (let p of paths) {
                 const r = p.endsWith('/*')
-                    ? (0, path_1.join)((0, path_1.dirname)(p), (0, path_1.relative)(path.replace(/\*$/, ''), importExpr))
+                    ? (0, node_path_1.join)((0, node_path_1.dirname)(p), (0, node_path_1.relative)(path.replace(/\*$/, ''), importExpr))
                     : p;
                 const maybeResolvedProject = this.findProjectOfResolvedModule(r);
                 if (maybeResolvedProject) {
@@ -47,14 +76,14 @@ class TargetProjectLocator {
                 }
             }
         }
-        if (builtInModuleSet.has(importExpr)) {
+        if (isBuiltinModuleImport(importExpr)) {
             this.npmResolutionCache.set(importExpr, null);
             return null;
         }
         // try to find npm package before using expensive typescript resolution
-        const npmProject = this.findNpmPackage(importExpr);
-        if (npmProject) {
-            return npmProject;
+        const externalProject = this.findNpmProjectFromImport(importExpr, filePath);
+        if (externalProject) {
+            return externalProject;
         }
         if (this.tsConfig.config) {
             // TODO(meeroslav): this block is probably obsolete
@@ -74,6 +103,55 @@ class TargetProjectLocator {
         this.npmResolutionCache.set(importExpr, null);
         return null;
     }
+    /**
+     * Resolve any external project that matches the given import expression,
+     * relative to the given file path.
+     *
+     * @param importExpr
+     * @param projectRoot
+     */
+    findNpmProjectFromImport(importExpr, fromFilePath) {
+        const packageName = parsePackageNameFromImportExpression(importExpr);
+        let fullFilePath = fromFilePath;
+        let workspaceRelativeFilePath = fromFilePath;
+        if (fromFilePath.startsWith(workspace_root_1.workspaceRoot)) {
+            workspaceRelativeFilePath = fromFilePath.replace(workspace_root_1.workspaceRoot, '');
+        }
+        else {
+            fullFilePath = (0, node_path_1.join)(workspace_root_1.workspaceRoot, fromFilePath);
+        }
+        const fullDirPath = (0, node_path_1.dirname)(fullFilePath);
+        const workspaceRelativeDirPath = (0, node_path_1.dirname)(workspaceRelativeFilePath);
+        const npmImportForProject = `${packageName}__${workspaceRelativeDirPath}`;
+        if (this.npmResolutionCache.has(npmImportForProject)) {
+            return this.npmResolutionCache.get(npmImportForProject);
+        }
+        try {
+            // package.json refers to an external package, we do not match against the version found in there, we instead try and resolve the relevant package how node would
+            const externalPackageJson = this.readPackageJson(packageName, fullDirPath);
+            // The external package.json path might be not be resolvable, e.g. if a reference has been added to a project package.json, but the install command has not been run yet.
+            if (!externalPackageJson) {
+                // Try and fall back to resolving an external node from the graph by name
+                const externalNode = this.npmProjects[`npm:${packageName}`];
+                const externalNodeName = externalNode?.name || null;
+                this.npmResolutionCache.set(npmImportForProject, externalNodeName);
+                return externalNodeName;
+            }
+            const npmProjectKey = `npm:${externalPackageJson.name}@${externalPackageJson.version}`;
+            const matchingExternalNode = this.npmProjects[npmProjectKey];
+            if (!matchingExternalNode) {
+                return null;
+            }
+            this.npmResolutionCache.set(npmImportForProject, matchingExternalNode.name);
+            return matchingExternalNode.name;
+        }
+        catch (e) {
+            if (process.env.NX_VERBOSE_LOGGING === 'true') {
+                console.error(e);
+            }
+            return null;
+        }
+    }
     /**
      * Return file paths matching the import relative to the repo root
      * @param normalizedImportExpr
@@ -113,23 +191,10 @@ class TargetProjectLocator {
         return;
     }
     resolveImportWithRequire(normalizedImportExpr, filePath) {
-        return path_1.posix.relative(workspace_root_1.workspaceRoot, require.resolve(normalizedImportExpr, {
-            paths: [(0, path_1.dirname)(filePath)],
+        return node_path_1.posix.relative(workspace_root_1.workspaceRoot, require.resolve(normalizedImportExpr, {
+            paths: [(0, node_path_1.dirname)(filePath)],
         }));
     }
-    findNpmPackage(npmImport) {
-        if (this.npmResolutionCache.has(npmImport)) {
-            return this.npmResolutionCache.get(npmImport);
-        }
-        else {
-            const pkg = this.npmProjects.find((pkg) => npmImport === pkg.data.packageName ||
-                npmImport.startsWith(`${pkg.data.packageName}/`));
-            if (pkg) {
-                this.npmResolutionCache.set(npmImport, pkg.name);
-                return pkg.name;
-            }
-        }
-    }
     findProjectOfResolvedModule(resolvedModule) {
         if (resolvedModule.startsWith('node_modules/') ||
             resolvedModule.includes('/node_modules/')) {
@@ -142,7 +207,7 @@ class TargetProjectLocator {
         return importedProject ? importedProject.name : void 0;
     }
     getAbsolutePath(path) {
-        return (0, path_1.join)(workspace_root_1.workspaceRoot, path);
+        return (0, node_path_1.join)(workspace_root_1.workspaceRoot, path);
     }
     getRootTsConfig() {
         const path = (0, typescript_1.getRootTsConfigFileName)();
@@ -164,20 +229,54 @@ class TargetProjectLocator {
         const project = (0, find_project_for_path_1.findProjectForPath)(file, this.projectRootMappings);
         return this.nodes[project];
     }
+    /**
+     * In many cases the package.json will be directly resolvable, so we try that first.
+     * If, however, package exports are used and the package.json is not defined, we will
+     * need to resolve the main entry point of the package and traverse upwards to find the
+     * package.json.
+     *
+     * In some cases, such as when multiple module formats are published, the resolved package.json
+     * might only contain the "type" field - no "name" or "version", so in such cases we keep traversing
+     * until we find a package.json that contains the "name" and "version" fields.
+     */
+    readPackageJson(packageName, relativeToDir) {
+        // The package.json is directly resolvable
+        const packageJsonPath = (0, resolve_relative_to_dir_1.resolveRelativeToDir)((0, node_path_1.join)(packageName, 'package.json'), relativeToDir);
+        if (packageJsonPath) {
+            return (0, fileutils_1.readJsonFile)(packageJsonPath);
+        }
+        try {
+            // Resolve the main entry point of the package
+            const mainPath = (0, resolve_relative_to_dir_1.resolveRelativeToDir)(packageName, relativeToDir);
+            let dir = (0, node_path_1.dirname)(mainPath);
+            while (dir !== (0, node_path_1.parse)(dir).root) {
+                const packageJsonPath = (0, node_path_1.join)(dir, 'package.json');
+                try {
+                    const parsedPackageJson = (0, fileutils_1.readJsonFile)(packageJsonPath);
+                    // Ensure the package.json contains the "name" and "version" fields
+                    if (parsedPackageJson.name && parsedPackageJson.version) {
+                        return parsedPackageJson;
+                    }
+                }
+                catch {
+                    // Package.json doesn't exist, keep traversing
+                }
+                dir = (0, node_path_1.dirname)(dir);
+            }
+            return null;
+        }
+        catch {
+            return null;
+        }
+    }
 }
 exports.TargetProjectLocator = TargetProjectLocator;
-// matches `npm:@scope/name`, `npm:name` but not `npm:@scope/name@version` and `npm:name@version`
-const ROOT_VERSION_PACKAGE_NAME_REGEX = /^npm:(?!.+@.+)/;
-function filterRootExternalDependencies(externalNodes) {
-    if (!externalNodes) {
-        return [];
-    }
-    const keys = Object.keys(externalNodes);
-    const nodes = [];
-    for (let i = 0; i < keys.length; i++) {
-        if (keys[i].match(ROOT_VERSION_PACKAGE_NAME_REGEX)) {
-            nodes.push(externalNodes[keys[i]]);
-        }
+function parsePackageNameFromImportExpression(importExpression) {
+    // Check if the package is scoped
+    if (importExpression.startsWith('@')) {
+        // For scoped packages, the package name is up to the second '/'
+        return importExpression.split('/').slice(0, 2).join('/');
     }
-    return nodes;
+    // For unscoped packages, the package name is up to the first '/'
+    return importExpression.split('/')[0];
 }

package/src/plugins/js/utils/resolve-relative-to-dir.d.ts

@@ -0,0 +1,5 @@
+/**
+ * NOTE: This function is in its own file because it is not possible to mock
+ * require.resolve directly in jest https://github.com/jestjs/jest/issues/9543
+ */
+export declare function resolveRelativeToDir(path: string, relativeToDir: any): string;

package/src/plugins/js/utils/resolve-relative-to-dir.js

@@ -0,0 +1,18 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.resolveRelativeToDir = void 0;
+/**
+ * NOTE: This function is in its own file because it is not possible to mock
+ * require.resolve directly in jest https://github.com/jestjs/jest/issues/9543
+ */
+function resolveRelativeToDir(path, relativeToDir) {
+    try {
+        return require.resolve(path, {
+            paths: [relativeToDir],
+        });
+    }
+    catch {
+        return null;
+    }
+}
+exports.resolveRelativeToDir = resolveRelativeToDir;

package/src/project-graph/error-types.d.ts

@@ -1,10 +1,10 @@
-import { CreateNodesResultWithContext } from './plugins/internal-api';
 import { ConfigurationResult, ConfigurationSourceMaps } from './utils/project-configuration-utils';
 import { ProjectConfiguration } from '../config/workspace-json-project-json';
 import { ProjectGraph } from '../config/project-graph';
+import { CreateNodesFunctionV2 } from './plugins';
 export declare class ProjectGraphError extends Error {
     #private;
-    constructor(errors: Array<CreateNodesError | MergeNodesError | ProjectsWithNoNameError | MultipleProjectsWithSameNameError | ProcessDependenciesError | ProcessProjectGraphError | CreateMetadataError | WorkspaceValidityError>, partialProjectGraph: ProjectGraph, partialSourceMaps: ConfigurationSourceMaps);
+    constructor(errors: Array<AggregateCreateNodesError | MergeNodesError | ProjectsWithNoNameError | MultipleProjectsWithSameNameError | ProcessDependenciesError | ProcessProjectGraphError | CreateMetadataError | WorkspaceValidityError>, partialProjectGraph: ProjectGraph, partialSourceMaps: ConfigurationSourceMaps);
     /**
      * The daemon cannot throw errors which contain methods as they are not serializable.
      *
@@ -18,7 +18,7 @@ export declare class ProjectGraphError extends Error {
      */
     getPartialProjectGraph(): ProjectGraph;
     getPartialSourcemaps(): ConfigurationSourceMaps;
-    getErrors(): (CreateNodesError | MergeNodesError | ProjectsWithNoNameError | MultipleProjectsWithSameNameError | CreateMetadataError | ProcessDependenciesError | ProcessProjectGraphError | WorkspaceValidityError)[];
+    getErrors(): (AggregateCreateNodesError | MergeNodesError | CreateMetadataError | ProjectsWithNoNameError | MultipleProjectsWithSameNameError | ProcessDependenciesError | ProcessProjectGraphError | WorkspaceValidityError)[];
 }
 export declare class MultipleProjectsWithSameNameError extends Error {
     conflicts: Map<string, string[]>;
@@ -44,25 +44,44 @@ export declare class ProjectWithNoNameError extends Error {
 }
 export declare function isProjectWithNoNameError(e: unknown): e is ProjectWithNoNameError;
 export declare class ProjectConfigurationsError extends Error {
-    readonly errors: Array<MergeNodesError | CreateNodesError | ProjectsWithNoNameError | MultipleProjectsWithSameNameError>;
+    readonly errors: Array<MergeNodesError | AggregateCreateNodesError | ProjectsWithNoNameError | MultipleProjectsWithSameNameError>;
     readonly partialProjectConfigurationsResult: ConfigurationResult;
-    constructor(errors: Array<MergeNodesError | CreateNodesError | ProjectsWithNoNameError | MultipleProjectsWithSameNameError>, partialProjectConfigurationsResult: ConfigurationResult);
+    constructor(errors: Array<MergeNodesError | AggregateCreateNodesError | ProjectsWithNoNameError | MultipleProjectsWithSameNameError>, partialProjectConfigurationsResult: ConfigurationResult);
 }
 export declare function isProjectConfigurationsError(e: unknown): e is ProjectConfigurationsError;
-export declare class CreateNodesError extends Error {
-    file: string;
-    pluginName: string;
-    constructor({ file, pluginName, error, }: {
-        file: string;
-        pluginName: string;
-        error: Error;
-    });
-}
+/**
+ * This error should be thrown when a `createNodesV2` function hits a recoverable error.
+ * It allows Nx to recieve partial results and continue processing for better UX.
+ */
 export declare class AggregateCreateNodesError extends Error {
-    readonly pluginName: string;
-    readonly errors: Array<CreateNodesError>;
-    readonly partialResults: Array<CreateNodesResultWithContext>;
-    constructor(pluginName: string, errors: Array<CreateNodesError>, partialResults: Array<CreateNodesResultWithContext>);
+    readonly errors: Array<[file: string | null, error: Error]>;
+    readonly partialResults: Awaited<ReturnType<CreateNodesFunctionV2>>;
+    /**
+     * Throwing this error from a `createNodesV2` function will allow Nx to continue processing and recieve partial results from your plugin.
+     * @example
+     * export async function createNodesV2(
+     *  files: string[],
+     * ) {
+     *   const partialResults = [];
+     *   const errors = [];
+     *   await Promise.all(files.map(async (file) => {
+     *     try {
+     *        const result = await createNodes(file);
+     *        partialResults.push(result);
+     *     } catch (e) {
+     *        errors.push([file, e]);
+     *     }
+     *   }));
+     *  if (errors.length > 0) {
+     *     throw new AggregateCreateNodesError(errors, partialResults);
+     *   }
+     *   return partialResults;
+     * }
+     *
+     * @param errors An array of tuples that represent errors encountered when processing a given file. An example entry might look like ['path/to/project.json', [Error: 'Invalid JSON. Unexpected token 'a' in JSON at position 0]]
+     * @param partialResults The partial results of the `createNodesV2` function. This should be the results for each file that didn't encounter an issue.
+     */
+    constructor(errors: Array<[file: string | null, error: Error]>, partialResults: Awaited<ReturnType<CreateNodesFunctionV2>>);
 }
 export declare class MergeNodesError extends Error {
     file: string;
@@ -102,7 +121,6 @@ export declare class AggregateProjectGraphError extends Error {
 }
 export declare function isAggregateProjectGraphError(e: unknown): e is AggregateProjectGraphError;
 export declare function isCreateMetadataError(e: unknown): e is CreateMetadataError;
-export declare function isCreateNodesError(e: unknown): e is CreateNodesError;
 export declare function isAggregateCreateNodesError(e: unknown): e is AggregateCreateNodesError;
 export declare function isMergeNodesError(e: unknown): e is MergeNodesError;
 export declare class DaemonProjectGraphError extends Error {

package/src/project-graph/error-types.js

@@ -1,7 +1,7 @@
 "use strict";
 var _ProjectGraphError_errors, _ProjectGraphError_partialProjectGraph, _ProjectGraphError_partialSourceMaps;
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.LoadPluginError = exports.DaemonProjectGraphError = exports.isMergeNodesError = exports.isAggregateCreateNodesError = exports.isCreateNodesError = exports.isCreateMetadataError = exports.isAggregateProjectGraphError = exports.AggregateProjectGraphError = exports.ProcessProjectGraphError = exports.isWorkspaceValidityError = exports.WorkspaceValidityError = exports.ProcessDependenciesError = exports.CreateMetadataError = exports.MergeNodesError = exports.AggregateCreateNodesError = exports.CreateNodesError = exports.isProjectConfigurationsError = exports.ProjectConfigurationsError = exports.isProjectWithNoNameError = exports.ProjectWithNoNameError = exports.isProjectsWithNoNameError = exports.ProjectsWithNoNameError = exports.isMultipleProjectsWithSameNameError = exports.isProjectWithExistingNameError = exports.ProjectWithExistingNameError = exports.MultipleProjectsWithSameNameError = exports.ProjectGraphError = void 0;
+exports.LoadPluginError = exports.DaemonProjectGraphError = exports.isMergeNodesError = exports.isAggregateCreateNodesError = exports.isCreateMetadataError = exports.isAggregateProjectGraphError = exports.AggregateProjectGraphError = exports.ProcessProjectGraphError = exports.isWorkspaceValidityError = exports.WorkspaceValidityError = exports.ProcessDependenciesError = exports.CreateMetadataError = exports.MergeNodesError = exports.AggregateCreateNodesError = exports.isProjectConfigurationsError = exports.ProjectConfigurationsError = exports.isProjectWithNoNameError = exports.ProjectWithNoNameError = exports.isProjectsWithNoNameError = exports.ProjectsWithNoNameError = exports.isMultipleProjectsWithSameNameError = exports.isProjectWithExistingNameError = exports.ProjectWithExistingNameError = exports.MultipleProjectsWithSameNameError = exports.ProjectGraphError = void 0;
 const tslib_1 = require("tslib");
 class ProjectGraphError extends Error {
     constructor(errors, partialProjectGraph, partialSourceMaps) {
@@ -126,21 +126,38 @@ function isProjectConfigurationsError(e) {
             e?.name === ProjectConfigurationsError.name));
 }
 exports.isProjectConfigurationsError = isProjectConfigurationsError;
-class CreateNodesError extends Error {
-    constructor({ file, pluginName, error, }) {
-        const msg = `The "${pluginName}" plugin threw an error while creating nodes from ${file}:`;
-        super(msg, { cause: error });
-        this.name = this.constructor.name;
-        this.file = file;
-        this.pluginName = pluginName;
-        this.stack = `${this.message}\n  ${error.stack.split('\n').join('\n  ')}`;
-    }
-}
-exports.CreateNodesError = CreateNodesError;
+/**
+ * This error should be thrown when a `createNodesV2` function hits a recoverable error.
+ * It allows Nx to recieve partial results and continue processing for better UX.
+ */
 class AggregateCreateNodesError extends Error {
-    constructor(pluginName, errors, partialResults) {
+    /**
+     * Throwing this error from a `createNodesV2` function will allow Nx to continue processing and recieve partial results from your plugin.
+     * @example
+     * export async function createNodesV2(
+     *  files: string[],
+     * ) {
+     *   const partialResults = [];
+     *   const errors = [];
+     *   await Promise.all(files.map(async (file) => {
+     *     try {
+     *        const result = await createNodes(file);
+     *        partialResults.push(result);
+     *     } catch (e) {
+     *        errors.push([file, e]);
+     *     }
+     *   }));
+     *  if (errors.length > 0) {
+     *     throw new AggregateCreateNodesError(errors, partialResults);
+     *   }
+     *   return partialResults;
+     * }
+     *
+     * @param errors An array of tuples that represent errors encountered when processing a given file. An example entry might look like ['path/to/project.json', [Error: 'Invalid JSON. Unexpected token 'a' in JSON at position 0]]
+     * @param partialResults The partial results of the `createNodesV2` function. This should be the results for each file that didn't encounter an issue.
+     */
+    constructor(errors, partialResults) {
         super('Failed to create nodes');
-        this.pluginName = pluginName;
         this.errors = errors;
         this.partialResults = partialResults;
         this.name = this.constructor.name;
@@ -230,11 +247,6 @@ function isCreateMetadataError(e) {
             e?.name === CreateMetadataError.name));
 }
 exports.isCreateMetadataError = isCreateMetadataError;
-function isCreateNodesError(e) {
-    return (e instanceof CreateNodesError ||
-        (typeof e === 'object' && 'name' in e && e?.name === CreateNodesError.name));
-}
-exports.isCreateNodesError = isCreateNodesError;
 function isAggregateCreateNodesError(e) {
     return (e instanceof AggregateCreateNodesError ||
         (typeof e === 'object' &&

package/src/project-graph/plugins/index.d.ts

@@ -1,2 +1,3 @@
 export * from './public-api';
 export { readPluginPackageJson, registerPluginTSTranspiler } from './loader';
+export { createNodesFromFiles } from './utils';

package/src/project-graph/plugins/index.js

@@ -1,8 +1,10 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.registerPluginTSTranspiler = exports.readPluginPackageJson = void 0;
+exports.createNodesFromFiles = exports.registerPluginTSTranspiler = exports.readPluginPackageJson = void 0;
 const tslib_1 = require("tslib");
 tslib_1.__exportStar(require("./public-api"), exports);
 var loader_1 = require("./loader");
 Object.defineProperty(exports, "readPluginPackageJson", { enumerable: true, get: function () { return loader_1.readPluginPackageJson; } });
 Object.defineProperty(exports, "registerPluginTSTranspiler", { enumerable: true, get: function () { return loader_1.registerPluginTSTranspiler; } });
+var utils_1 = require("./utils");
+Object.defineProperty(exports, "createNodesFromFiles", { enumerable: true, get: function () { return utils_1.createNodesFromFiles; } });

package/src/project-graph/plugins/internal-api.d.ts

@@ -1,12 +1,12 @@
 import { PluginConfiguration } from '../../config/nx-json';
 import { NxPluginV1 } from '../../utils/nx-plugin.deprecated';
-import { CreateDependencies, CreateDependenciesContext, CreateMetadata, CreateMetadataContext, CreateNodesContext, CreateNodesResult, NxPluginV2 } from './public-api';
+import { CreateDependencies, CreateDependenciesContext, CreateMetadata, CreateMetadataContext, CreateNodesContextV2, CreateNodesResult, NxPluginV2 } from './public-api';
 import { ProjectGraph, ProjectGraphProcessor } from '../../config/project-graph';
 export declare class LoadedNxPlugin {
     readonly name: string;
     readonly createNodes?: [
         filePattern: string,
-        fn: (matchedFiles: string[], context: CreateNodesContext) => Promise<CreateNodesResultWithContext[]>
+        fn: (matchedFiles: string[], context: CreateNodesContextV2) => Promise<Array<readonly [plugin: string, file: string, result: CreateNodesResult]>>
     ];
     readonly createDependencies?: (context: CreateDependenciesContext) => ReturnType<CreateDependencies>;
     readonly createMetadata?: (graph: ProjectGraph, context: CreateMetadataContext) => ReturnType<CreateMetadata>;

package/src/project-graph/plugins/internal-api.js

@@ -6,9 +6,10 @@ exports.getDefaultPlugins = exports.loadNxPlugins = exports.nxPluginCache = expo
 const path_1 = require("path");
 const workspace_root_1 = require("../../utils/workspace-root");
 const angular_json_1 = require("../../adapter/angular-json");
-const utils_1 = require("./utils");
 const isolation_1 = require("./isolation");
 const loader_1 = require("./loader");
+const utils_1 = require("./utils");
+const error_types_1 = require("../error-types");
 class LoadedNxPlugin {
     constructor(plugin, pluginDefinition) {
         this.name = plugin.name;
@@ -17,12 +18,41 @@ class LoadedNxPlugin {
             this.include = pluginDefinition.include;
             this.exclude = pluginDefinition.exclude;
         }
-        if (plugin.createNodes) {
+        if (plugin.createNodes && !plugin.createNodesV2) {
             this.createNodes = [
                 plugin.createNodes[0],
-                (files, context) => (0, utils_1.runCreateNodesInParallel)(files, plugin, this.options, context),
+                (configFiles, context) => (0, utils_1.createNodesFromFiles)(plugin.createNodes[1], configFiles, this.options, context).then((results) => results.map((r) => [this.name, r[0], r[1]])),
+            ];
+        }
+        if (plugin.createNodesV2) {
+            this.createNodes = [
+                plugin.createNodesV2[0],
+                async (configFiles, context) => {
+                    const result = await plugin.createNodesV2[1](configFiles, this.options, context);
+                    return result.map((r) => [this.name, r[0], r[1]]);
+                },
             ];
         }
+        if (this.createNodes) {
+            const inner = this.createNodes[1];
+            this.createNodes[1] = async (...args) => {
+                performance.mark(`${plugin.name}:createNodes - start`);
+                try {
+                    return await inner(...args);
+                }
+                catch (e) {
+                    if ((0, error_types_1.isAggregateCreateNodesError)(e)) {
+                        throw e;
+                    }
+                    // The underlying plugin errored out. We can't know any partial results.
+                    throw new error_types_1.AggregateCreateNodesError([null, e], []);
+                }
+                finally {
+                    performance.mark(`${plugin.name}:createNodes - end`);
+                    performance.measure(`${plugin.name}:createNodes`, `${plugin.name}:createNodes - start`, `${plugin.name}:createNodes - end`);
+                }
+            };
+        }
         if (plugin.createDependencies) {
             this.createDependencies = (context) => plugin.createDependencies(this.options, context);
         }

package/src/project-graph/plugins/public-api.d.ts

@@ -6,19 +6,23 @@ import { RawProjectGraphDependency } from '../project-graph-builder';
 /**
  * Context for {@link CreateNodesFunction}
  */
-export interface CreateNodesContext {
-    readonly nxJsonConfiguration: NxJsonConfiguration;
-    readonly workspaceRoot: string;
+export interface CreateNodesContext extends CreateNodesContextV2 {
     /**
      * The subset of configuration files which match the createNodes pattern
      */
     readonly configFiles: readonly string[];
 }
+export interface CreateNodesContextV2 {
+    readonly nxJsonConfiguration: NxJsonConfiguration;
+    readonly workspaceRoot: string;
+}
 /**
  * A function which parses a configuration file into a set of nodes.
  * Used for creating nodes for the {@link ProjectGraph}
  */
 export type CreateNodesFunction<T = unknown> = (projectConfigurationFile: string, options: T | undefined, context: CreateNodesContext) => CreateNodesResult | Promise<CreateNodesResult>;
+export type CreateNodesResultV2 = Array<readonly [configFileSource: string, result: CreateNodesResult]>;
+export type CreateNodesFunctionV2<T = unknown> = (projectConfigurationFiles: readonly string[], options: T | undefined, context: CreateNodesContextV2) => CreateNodesResultV2 | Promise<CreateNodesResultV2>;
 export type Optional<T, K extends keyof T> = Omit<T, K> & Partial<Pick<T, K>>;
 export interface CreateNodesResult {
     /**
@@ -32,11 +36,29 @@ export interface CreateNodesResult {
 }
 /**
  * A pair of file patterns and {@link CreateNodesFunction}
+ *
+ * Nx 19.2+: Both original `CreateNodes` and `CreateNodesV2` are supported. Nx will only invoke `CreateNodesV2` if it is present.
+ * Nx 20.X : The `CreateNodesV2` will be the only supported API. This typing will still exist, but be identical to `CreateNodesV2`.
+             Nx **will not** invoke the original `plugin.createNodes` callback. This should give plugin authors a window to transition.
+             Plugin authors should update their plugin's `createNodes` function to align with `CreateNodesV2` / the updated `CreateNodes`.
+             The plugin should contain something like: `export createNodes = createNodesV2;` during this period. This will allow the plugin
+             to maintain compatibility with Nx 19.2 and up.
+ * Nx 21.X : The `CreateNodesV2` typing will be removed, as it has replaced `CreateNodes`.
+ *
+ * @deprecated Use {@link CreateNodesV2} instead. CreateNodesV2 will replace this API. Read more about the transition above.
  */
 export type CreateNodes<T = unknown> = readonly [
     projectFilePattern: string,
     createNodesFunction: CreateNodesFunction<T>
 ];
+/**
+ * A pair of file patterns and {@link CreateNodesFunctionV2}
+ * In Nx 20 {@link CreateNodes} will be replaced with this type. In Nx 21, this type will be removed.
+ */
+export type CreateNodesV2<T = unknown> = readonly [
+    projectFilePattern: string,
+    createNodesFunction: CreateNodesFunctionV2<T>
+];
 /**
  * Context for {@link CreateDependencies}
  */
@@ -82,8 +104,17 @@ export type NxPluginV2<TOptions = unknown> = {
     /**
      * Provides a file pattern and function that retrieves configuration info from
      * those files. e.g. { '**\/*.csproj': buildProjectsFromCsProjFile }
+     *
+     * @deprecated Use {@link createNodesV2} instead. In Nx 20 support for calling createNodes with a single file for the first argument will be removed.
      */
     createNodes?: CreateNodes<TOptions>;
+    /**
+     * Provides a file pattern and function that retrieves configuration info from
+     * those files. e.g. { '**\/*.csproj': buildProjectsFromCsProjFiles }
+     *
+     * In Nx 20 {@link createNodes} will be replaced with this property. In Nx 21, this property will be removed.
+     */
+    createNodesV2?: CreateNodesV2<TOptions>;
     /**
      * Provides a function to analyze files to create dependencies for the {@link ProjectGraph}
      */

package/src/project-graph/plugins/utils.d.ts

@@ -1,7 +1,8 @@
 import type { NxPluginV1 } from '../../utils/nx-plugin.deprecated';
-import type { CreateNodesResultWithContext, LoadedNxPlugin, NormalizedPlugin } from './internal-api';
-import { type CreateNodesContext, type NxPlugin, type NxPluginV2 } from './public-api';
+import type { LoadedNxPlugin, NormalizedPlugin } from './internal-api';
+import { CreateNodesContextV2, CreateNodesFunction, CreateNodesResult, type NxPlugin, type NxPluginV2 } from './public-api';
 export declare function isNxPluginV2(plugin: NxPlugin): plugin is NxPluginV2;
 export declare function isNxPluginV1(plugin: NxPlugin | LoadedNxPlugin): plugin is NxPluginV1;
 export declare function normalizeNxPlugin(plugin: NxPlugin): NormalizedPlugin;
-export declare function runCreateNodesInParallel(configFiles: readonly string[], plugin: NormalizedPlugin, options: unknown, context: CreateNodesContext): Promise<CreateNodesResultWithContext[]>;
+export type AsyncFn<T extends Function> = T extends (...args: infer A) => infer R ? (...args: A) => Promise<Awaited<R>> : never;
+export declare function createNodesFromFiles<T = unknown>(createNodes: CreateNodesFunction, configFiles: readonly string[], options: T, context: CreateNodesContextV2): Promise<[file: string, value: CreateNodesResult][]>;