nx 19.1.0-canary.20240523-261b0ff → 19.1.0-canary.20240524-12c6a73

package/bin/init-local.js

@@ -132,7 +132,7 @@ function handleAngularCLIFallbacks(workspace) {
     else if (process.argv[2] === 'cache') {
         console.log(`"ng cache" is not natively supported by Nx.
 To clear the cache, you can delete the ".angular/cache" directory (or the directory configured by "cli.cache.path" in the "nx.json" file).
-To update the cache configuration, you can directly update the relevant options in your "nx.json" file (https://angular.io/guide/workspace-config#cache-options).`);
+To update the cache configuration, you can directly update the relevant options in your "nx.json" file (https://angular.dev/reference/configs/workspace-config#cache-options).`);
     }
     else {
         try {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nx",
-  "version": "19.1.0-canary.20240523-261b0ff",
+  "version": "19.1.0-canary.20240524-12c6a73",
   "private": false,
   "description": "The core Nx plugin contains the core functionality of Nx like the project graph, nx commands and task orchestration.",
   "repository": {
@@ -69,7 +69,7 @@
     "yargs-parser": "21.1.1",
     "node-machine-id": "1.1.12",
     "ora": "5.3.0",
-    "@nrwl/tao": "19.1.0-canary.20240523-261b0ff"
+    "@nrwl/tao": "19.1.0-canary.20240524-12c6a73"
   },
   "peerDependencies": {
     "@swc-node/register": "^1.8.0",
@@ -84,16 +84,16 @@
     }
   },
   "optionalDependencies": {
-    "@nx/nx-darwin-x64": "19.1.0-canary.20240523-261b0ff",
-    "@nx/nx-darwin-arm64": "19.1.0-canary.20240523-261b0ff",
-    "@nx/nx-linux-x64-gnu": "19.1.0-canary.20240523-261b0ff",
-    "@nx/nx-linux-x64-musl": "19.1.0-canary.20240523-261b0ff",
-    "@nx/nx-win32-x64-msvc": "19.1.0-canary.20240523-261b0ff",
-    "@nx/nx-linux-arm64-gnu": "19.1.0-canary.20240523-261b0ff",
-    "@nx/nx-linux-arm64-musl": "19.1.0-canary.20240523-261b0ff",
-    "@nx/nx-linux-arm-gnueabihf": "19.1.0-canary.20240523-261b0ff",
-    "@nx/nx-win32-arm64-msvc": "19.1.0-canary.20240523-261b0ff",
-    "@nx/nx-freebsd-x64": "19.1.0-canary.20240523-261b0ff"
+    "@nx/nx-darwin-x64": "19.1.0-canary.20240524-12c6a73",
+    "@nx/nx-darwin-arm64": "19.1.0-canary.20240524-12c6a73",
+    "@nx/nx-linux-x64-gnu": "19.1.0-canary.20240524-12c6a73",
+    "@nx/nx-linux-x64-musl": "19.1.0-canary.20240524-12c6a73",
+    "@nx/nx-win32-x64-msvc": "19.1.0-canary.20240524-12c6a73",
+    "@nx/nx-linux-arm64-gnu": "19.1.0-canary.20240524-12c6a73",
+    "@nx/nx-linux-arm64-musl": "19.1.0-canary.20240524-12c6a73",
+    "@nx/nx-linux-arm-gnueabihf": "19.1.0-canary.20240524-12c6a73",
+    "@nx/nx-win32-arm64-msvc": "19.1.0-canary.20240524-12c6a73",
+    "@nx/nx-freebsd-x64": "19.1.0-canary.20240524-12c6a73"
   },
   "nx-migrations": {
     "migrations": "./migrations.json",

package/release/changelog-renderer/index.d.ts

@@ -7,6 +7,15 @@ import type { ProjectGraph } from '../../src/config/project-graph';
  * from the user's nx.json configuration and passed as is into the ChangelogRenderer function.
  */
 export type ChangelogRenderOptions = Record<string, unknown>;
+/**
+ * When versioning projects independently and enabling `"updateDependents": "always"`, there could
+ * be additional dependency bump information that is not captured in the commit data, but that nevertheless
+ * should be included in the rendered changelog.
+ */
+export type DependencyBump = {
+    dependencyName: string;
+    newVersion: string;
+};
 /**
  * A ChangelogRenderer function takes in the extracted commits and other relevant metadata
  * and returns a string, or a Promise of a string of changelog contents (usually markdown).
@@ -18,6 +27,7 @@ export type ChangelogRenderOptions = Record<string, unknown>;
  * @param {string | null} config.project The name of specific project to generate a changelog for, or `null` if the overall workspace changelog
  * @param {string | false} config.entryWhenNoChanges The (already interpolated) string to use as the changelog entry when there are no changes, or `false` if no entry should be generated
  * @param {ChangelogRenderOptions} config.changelogRenderOptions The options specific to the ChangelogRenderer implementation
+ * @param {DependencyBump[]} config.dependencyBumps Optional list of additional dependency bumps that occurred as part of the release, outside of the commit data
  */
 export type ChangelogRenderer = (config: {
     projectGraph: ProjectGraph;
@@ -26,6 +36,7 @@ export type ChangelogRenderer = (config: {
     project: string | null;
     entryWhenNoChanges: string | false;
     changelogRenderOptions: DefaultChangelogRenderOptions;
+    dependencyBumps?: DependencyBump[];
     repoSlug?: RepoSlug;
     conventionalCommitsConfig: NxReleaseConfig['conventionalCommits'];
 }) => Promise<string> | string;

package/release/changelog-renderer/index.js

@@ -10,7 +10,7 @@ const axios = _axios;
  * The default ChangelogRenderer implementation that nx exports for the common case of generating markdown
  * from the given commits and other metadata.
  */
-const defaultChangelogRenderer = async ({ projectGraph, commits, releaseVersion, project, entryWhenNoChanges, changelogRenderOptions, repoSlug, conventionalCommitsConfig, }) => {
+const defaultChangelogRenderer = async ({ projectGraph, commits, releaseVersion, project, entryWhenNoChanges, changelogRenderOptions, dependencyBumps, repoSlug, conventionalCommitsConfig, }) => {
     const commitTypes = conventionalCommitsConfig.types;
     const markdownLines = [];
     const breakingChanges = [];
@@ -30,7 +30,15 @@ const defaultChangelogRenderer = async ({ projectGraph, commits, releaseVersion,
     if (project === null) {
         // No changes for the workspace
         if (commits.length === 0) {
-            if (entryWhenNoChanges) {
+            if (dependencyBumps?.length) {
+                applyAdditionalDependencyBumps({
+                    markdownLines,
+                    dependencyBumps,
+                    releaseVersion,
+                    changelogRenderOptions,
+                });
+            }
+            else if (entryWhenNoChanges) {
                 markdownLines.push('', `${createVersionTitle(releaseVersion, changelogRenderOptions)}\n\n${entryWhenNoChanges}`, '');
             }
             return markdownLines.join('\n').trim();
@@ -71,7 +79,15 @@ const defaultChangelogRenderer = async ({ projectGraph, commits, releaseVersion,
         const relevantCommits = await (0, shared_1.getCommitsRelevantToProjects)(projectGraph, commits, [project]);
         // Generating for a named project, but that project has no relevant changes in the current set of commits, exit early
         if (relevantCommits.length === 0) {
-            if (entryWhenNoChanges) {
+            if (dependencyBumps?.length) {
+                applyAdditionalDependencyBumps({
+                    markdownLines,
+                    dependencyBumps,
+                    releaseVersion,
+                    changelogRenderOptions,
+                });
+            }
+            else if (entryWhenNoChanges) {
                 markdownLines.push('', `${createVersionTitle(releaseVersion, changelogRenderOptions)}\n\n${entryWhenNoChanges}`, '');
             }
             return markdownLines.join('\n').trim();
@@ -102,6 +118,14 @@ const defaultChangelogRenderer = async ({ projectGraph, commits, releaseVersion,
     if (breakingChanges.length > 0) {
         markdownLines.push('', '#### ⚠️  Breaking Changes', '', ...breakingChanges);
     }
+    if (dependencyBumps?.length) {
+        applyAdditionalDependencyBumps({
+            markdownLines,
+            dependencyBumps,
+            releaseVersion,
+            changelogRenderOptions,
+        });
+    }
     if (changelogRenderOptions.authors) {
         const _authors = new Map();
         for (const commit of commits) {
@@ -163,6 +187,19 @@ const defaultChangelogRenderer = async ({ projectGraph, commits, releaseVersion,
     return markdownLines.join('\n').trim();
 };
 exports.default = defaultChangelogRenderer;
+function applyAdditionalDependencyBumps({ markdownLines, dependencyBumps, releaseVersion, changelogRenderOptions, }) {
+    if (markdownLines.length === 0) {
+        markdownLines.push('', `${createVersionTitle(releaseVersion, changelogRenderOptions)}\n`, '');
+    }
+    else {
+        markdownLines.push('');
+    }
+    markdownLines.push('### 🧱 Updated Dependencies\n');
+    dependencyBumps.forEach(({ dependencyName, newVersion }) => {
+        markdownLines.push(`- Updated ${dependencyName} to ${newVersion}`);
+    });
+    markdownLines.push('');
+}
 function formatName(name = '') {
     return name
         .split(' ')

package/src/command-line/init/implementation/angular/legacy-angular-versions.js

@@ -15,9 +15,10 @@ const connect_to_nx_cloud_1 = require("../../../connect/connect-to-nx-cloud");
 // key is major Angular version and value is Nx version to use
 const nxAngularLegacyVersionMap = {
     14: '~17.0.0',
+    15: '~19.0.0',
 };
 // min major angular version supported in latest Nx
-const minMajorAngularVersionSupported = 15;
+const minMajorAngularVersionSupported = 16;
 // version when the Nx CLI changed from @nrwl/tao & @nrwl/cli to nx
 const versionWithConsolidatedPackages = '13.9.0';
 // version when packages were rescoped from @nrwl/* to @nx/*

package/src/command-line/init/implementation/angular/standalone-workspace.js

@@ -98,8 +98,6 @@ function createNxJson(repoRoot, angularJson, cacheableOperations, { eslintProjec
             inputs: ['default', '^production'],
         };
     }
-    // Angular 15 workspaces still support defaultProject. Support was removed in Angular 16.
-    nxJson.defaultProject = angularJson.defaultProject;
     (0, fileutils_1.writeJsonFile)((0, path_1.join)(repoRoot, 'nx.json'), nxJson);
 }
 function updateProjectOutputs(repoRoot, project) {

package/src/command-line/release/changelog.js

@@ -120,7 +120,7 @@ async function releaseChangelog(args) {
         if (useAutomaticFromRef) {
             workspaceChangelogFromRef = await (0, git_1.getFirstGitCommit)();
             if (args.verbose) {
-                console.log(`Determined workspace --from ref from the first commit in workspace: ${workspaceChangelogFromRef}`);
+                console.log(`Determined workspace --from ref from the first commit in the workspace: ${workspaceChangelogFromRef}`);
             }
         }
         else {
@@ -149,6 +149,30 @@ async function releaseChangelog(args) {
             await (0, github_1.createOrUpdateGithubRelease)(workspaceChangelog.releaseVersion, workspaceChangelog.contents, latestCommit, { dryRun: args.dryRun });
         });
     }
+    /**
+     * Compute any additional dependency bumps up front because there could be cases of circular dependencies,
+     * and figuring them out during the main iteration would be too late.
+     */
+    const projectToAdditionalDependencyBumps = new Map();
+    for (const releaseGroup of releaseGroups) {
+        if (releaseGroup.projectsRelationship !== 'independent') {
+            continue;
+        }
+        for (const project of releaseGroup.projects) {
+            if (projectToAdditionalDependencyBumps.has(project)) {
+                continue;
+            }
+            const dependentProjects = (projectsVersionData[project]?.dependentProjects || [])
+                .map((dep) => {
+                return {
+                    dependencyName: dep.source,
+                    newVersion: projectsVersionData[dep.source].newVersion,
+                };
+            })
+                .filter((b) => b.newVersion !== null);
+            projectToAdditionalDependencyBumps.set(project, dependentProjects);
+        }
+    }
     const allProjectChangelogs = {};
     for (const releaseGroup of releaseGroups) {
         const config = releaseGroup.changelog;
@@ -157,8 +181,13 @@ async function releaseChangelog(args) {
             continue;
         }
         const projects = args.projects?.length
-            ? // If the user has passed a list of projects, we need to use the filtered list of projects within the release group
-                Array.from(releaseGroupToFilteredProjects.get(releaseGroup))
+            ? // If the user has passed a list of projects, we need to use the filtered list of projects within the release group, plus any dependents
+                Array.from(releaseGroupToFilteredProjects.get(releaseGroup)).flatMap((project) => {
+                    return [
+                        project,
+                        ...(projectToAdditionalDependencyBumps.get(project) || []).map((d) => d.dependencyName),
+                    ];
+                })
             : // Otherwise, we use the full list of projects within the release group
                 releaseGroup.projects;
         const projectNodes = projects.map((name) => projectGraph.nodes[name]);
@@ -171,13 +200,14 @@ async function releaseChangelog(args) {
                 let commits = null;
                 if (!fromRef && useAutomaticFromRef) {
                     const firstCommit = await (0, git_1.getFirstGitCommit)();
-                    const allCommits = await getCommits(firstCommit, toSHA, nxReleaseConfig.conventionalCommits);
-                    const commitsForProject = allCommits.filter((c) => c.affectedFiles.find((f) => f.startsWith(project.data.root)));
+                    const allRawCommits = await (0, git_1.getGitDiff)(firstCommit, toSHA);
+                    const allParsedCommits = (0, git_1.parseCommits)(allRawCommits);
+                    const commitsForProject = allParsedCommits.filter((c) => c.affectedFiles.find((f) => f.startsWith(project.data.root)));
                     fromRef = commitsForProject[0]?.shortHash;
                     if (args.verbose) {
                         console.log(`Determined --from ref for ${project.name} from the first commit in which it exists: ${fromRef}`);
                     }
-                    commits = commitsForProject;
+                    commits = commitsForProject.filter((c) => applyConventionalCommitsConfigFilter(c, nxReleaseConfig.conventionalCommits));
                 }
                 if (!fromRef && !commits) {
                     throw new Error(`Unable to determine the previous git tag. If this is the first release of your workspace, use the --first-release option or set the "release.changelog.automaticFromRef" config property in nx.json to generate a changelog from the first commit. Otherwise, be sure to configure the "release.releaseTagPattern" property in nx.json to match the structure of your repository's git tags.`);
@@ -185,7 +215,7 @@ async function releaseChangelog(args) {
                 if (!commits) {
                     commits = await getCommits(fromRef, toSHA, nxReleaseConfig.conventionalCommits);
                 }
-                const projectChangelogs = await generateChangelogForProjects(tree, args, projectGraph, commits, projectsVersionData, releaseGroup, [project], nxReleaseConfig);
+                const projectChangelogs = await generateChangelogForProjects(tree, args, projectGraph, commits, projectsVersionData, releaseGroup, [project], nxReleaseConfig, projectToAdditionalDependencyBumps);
                 let hasPushed = false;
                 for (const [projectName, projectChangelog] of Object.entries(projectChangelogs)) {
                     if (projectChangelogs &&
@@ -210,15 +240,23 @@ async function releaseChangelog(args) {
             }
         }
         else {
-            const fromRef = args.from ||
+            let fromRef = args.from ||
                 (await (0, git_1.getLatestGitTagForPattern)(releaseGroup.releaseTagPattern))?.tag;
             if (!fromRef) {
-                throw new Error(`Unable to determine the previous git tag, please provide an explicit git reference using --from`);
+                if (useAutomaticFromRef) {
+                    fromRef = await (0, git_1.getFirstGitCommit)();
+                    if (args.verbose) {
+                        console.log(`Determined release group --from ref from the first commit in the workspace: ${fromRef}`);
+                    }
+                }
+                else {
+                    throw new Error(`Unable to determine the previous git tag. If this is the first release of your release group, use the --first-release option or set the "release.changelog.automaticFromRef" config property in nx.json to generate a changelog from the first commit. Otherwise, be sure to configure the "release.releaseTagPattern" property in nx.json to match the structure of your repository's git tags.`);
+                }
             }
             // Make sure that the fromRef is actually resolvable
             const fromSHA = await (0, git_1.getCommitHash)(fromRef);
             const commits = await getCommits(fromSHA, toSHA, nxReleaseConfig.conventionalCommits);
-            const projectChangelogs = await generateChangelogForProjects(tree, args, projectGraph, commits, projectsVersionData, releaseGroup, projectNodes, nxReleaseConfig);
+            const projectChangelogs = await generateChangelogForProjects(tree, args, projectGraph, commits, projectsVersionData, releaseGroup, projectNodes, nxReleaseConfig, projectToAdditionalDependencyBumps);
             let hasPushed = false;
             for (const [projectName, projectChangelog] of Object.entries(projectChangelogs)) {
                 if (projectChangelogs &&
@@ -377,7 +415,7 @@ async function generateChangelogForWorkspace(tree, args, projectGraph, nxRelease
         output_1.output.warn({
             title: `Workspace changelog is enabled, but you have multiple release groups configured. This is not supported, so workspace changelog will be disabled.`,
             bodyLines: [
-                `A single workspace version cannot be determined when defining multiple release groups because versions differ between each group.`,
+                `A single workspace version cannot be determined when defining multiple release groups because versions can differ between each group.`,
                 `Project level changelogs can be enabled with the "release.changelog.projectChangelogs" property.`,
             ],
         });
@@ -388,7 +426,7 @@ async function generateChangelogForWorkspace(tree, args, projectGraph, nxRelease
         output_1.output.warn({
             title: `Workspace changelog is enabled, but you have configured an independent projects relationship. This is not supported, so workspace changelog will be disabled.`,
             bodyLines: [
-                `A single workspace version cannot be determined when using independent projects because versions differ between each project.`,
+                `A single workspace version cannot be determined when using independent projects because versions can differ between each project.`,
                 `Project level changelogs can be enabled with the "release.changelog.projectChangelogs" property.`,
             ],
         });
@@ -469,7 +507,7 @@ async function generateChangelogForWorkspace(tree, args, projectGraph, nxRelease
         contents,
     };
 }
-async function generateChangelogForProjects(tree, args, projectGraph, commits, projectsVersionData, releaseGroup, projects, nxReleaseConfig) {
+async function generateChangelogForProjects(tree, args, projectGraph, commits, projectsVersionData, releaseGroup, projects, nxReleaseConfig, projectToAdditionalDependencyBumps) {
     const config = releaseGroup.changelog;
     // The entire feature is disabled at the release group level, exit early
     if (config === false) {
@@ -526,6 +564,7 @@ async function generateChangelogForProjects(tree, args, projectGraph, commits, p
                 : false,
             changelogRenderOptions: config.renderOptions,
             conventionalCommitsConfig: nxReleaseConfig.conventionalCommits,
+            dependencyBumps: projectToAdditionalDependencyBumps.get(project.name),
         });
         /**
          * If interactive mode, make the changelog contents available for the user to modify in their editor of choice,
@@ -587,15 +626,21 @@ function checkChangelogFilesEnabled(nxReleaseConfig) {
 async function getCommits(fromSHA, toSHA, conventionalCommitsConfig) {
     const rawCommits = await (0, git_1.getGitDiff)(fromSHA, toSHA);
     // Parse as conventional commits
-    return (0, git_1.parseCommits)(rawCommits).filter((c) => {
-        const type = c.type;
-        const typeConfig = conventionalCommitsConfig.types[type];
-        if (!typeConfig) {
-            // don't include commits with unknown types
-            return false;
-        }
-        return !typeConfig.changelog.hidden;
-    });
+    const parsedCommits = (0, git_1.parseCommits)(rawCommits);
+    if (conventionalCommitsConfig === null) {
+        return parsedCommits;
+    }
+    // Apply filtering based on the conventional commits configuration
+    return parsedCommits.filter((c) => applyConventionalCommitsConfigFilter(c, conventionalCommitsConfig));
+}
+function applyConventionalCommitsConfigFilter(commit, conventionalCommitsConfig) {
+    const type = commit.type;
+    const typeConfig = conventionalCommitsConfig.types[type];
+    if (!typeConfig) {
+        // don't include commits with unknown types
+        return false;
+    }
+    return !typeConfig.changelog.hidden;
 }
 function shouldCreateGitHubRelease(changelogConfig, createReleaseArg = undefined) {
     if (createReleaseArg !== undefined) {

package/src/command-line/release/publish.js

@@ -137,6 +137,8 @@ async function runPublishOnProjects(args, projectGraph, nxJson, projectNames, is
         targets: [requiredTargetName],
         outputStyle: 'static',
         ...args,
+        // It is possible for workspaces to have circular dependencies between packages and still release them to a registry
+        nxIgnoreCycles: true,
     }, overrides, null, {}, extraOptions);
     if (status !== 0) {
         // In order to not add noise to the overall CLI output, do not throw an additional error

package/src/command-line/release/utils/git.js

@@ -66,11 +66,18 @@ async function getLatestGitTagForPattern(releaseTagPattern, additionalInterpolat
 }
 exports.getLatestGitTagForPattern = getLatestGitTagForPattern;
 async function getGitDiff(from, to = 'HEAD') {
+    let range = '';
+    if (!from || from === to) {
+        range = to;
+    }
+    else {
+        range = `${from}..${to}`;
+    }
     // https://git-scm.com/docs/pretty-formats
     const r = await (0, exec_command_1.execCommand)('git', [
         '--no-pager',
         'log',
-        `${from ? `${from}...` : ''}${to}`,
+        range,
         '--pretty="----%n%s|%h|%an|%ae%n%b"',
         '--name-status',
     ]);

package/src/command-line/release/utils/shared.d.ts

@@ -18,6 +18,10 @@ export type VersionData = Record<string, {
      */
     newVersion: string | null;
     currentVersion: string;
+    /**
+     * The list of projects which depend upon the current project.
+     * TODO: investigate generic type for this once more ecosystems are explored
+     */
     dependentProjects: any[];
 }>;
 export declare class ReleaseVersion {

package/src/command-line/release/version.d.ts

@@ -23,6 +23,11 @@ export interface ReleaseVersionGeneratorSchema {
     installArgs?: string;
     installIgnoreScripts?: boolean;
     conventionalCommitsConfig?: NxReleaseConfig['conventionalCommits'];
+    /**
+     * 'auto' allows users to opt into dependents being updated (a patch version bump) when a dependency is versioned.
+     * This is only applicable to independently released projects.
+     */
+    updateDependents?: 'never' | 'auto';
 }
 export interface NxReleaseVersionResult {
     /**

package/src/command-line/release/version.js

@@ -76,8 +76,12 @@ async function releaseVersion(args) {
     const tree = new tree_1.FsTree(workspace_root_1.workspaceRoot, args.verbose);
     const versionData = {};
     const commitMessage = args.gitCommitMessage || nxReleaseConfig.version.git.commitMessage;
-    const additionalChangedFiles = new Set();
     const generatorCallbacks = [];
+    /**
+     * additionalChangedFiles are files which need to be updated as a side-effect of versioning (such as package manager lock files),
+     * and need to get staged and committed as part of the existing commit, if applicable.
+     */
+    const additionalChangedFiles = new Set();
     if (args.projects?.length) {
         /**
          * Run versioning for all remaining release groups and filtered projects within them
@@ -256,7 +260,7 @@ function appendVersionData(existingVersionData, newVersionData) {
     // Mutate the existing version data
     for (const [key, value] of Object.entries(newVersionData)) {
         if (existingVersionData[key]) {
-            throw new Error(`Version data key "${key}" already exists in version data. This is likely a bug.`);
+            throw new Error(`Version data key "${key}" already exists in version data. This is likely a bug, please report your use-case on https://github.com/nrwl/nx`);
         }
         existingVersionData[key] = value;
     }

package/src/generators/tree.d.ts

@@ -1,5 +1,4 @@
 /// <reference types="node" />
-/// <reference types="@types/node/ts4.8/fs" />
 /// <reference types="node" />
 import type { Mode } from 'fs';
 /**

package/src/project-graph/utils/project-configuration-utils.js

@@ -277,6 +277,10 @@ plugins) {
                 sourceInfo[0] = result[symbols_1.OVERRIDE_SOURCE_FILE];
             }
             for (const node in projectNodes) {
+                // Handles `{projects: {'libs/foo': undefined}}`.
+                if (!projectNodes[node]) {
+                    continue;
+                }
                 const project = {
                     root: node,
                     ...projectNodes[node],

package/src/utils/fileutils.d.ts

@@ -1,5 +1,4 @@
 /// <reference types="node" />
-/// <reference types="@types/node/ts4.8/fs" />
 import type { JsonParseOptions, JsonSerializeOptions } from './json';
 import { PathLike } from 'fs';
 export interface JsonReadOptions extends JsonParseOptions {

package/src/utils/package-json.d.ts

@@ -1,4 +1,5 @@
 import { InputDefinition, TargetConfiguration } from '../config/workspace-json-project-json';
+import { PackageManagerCommands } from './package-manager';
 export interface NxProjectPackageJsonConfiguration {
     implicitDependencies?: string[];
     tags?: string[];
@@ -65,7 +66,7 @@ export declare function normalizePackageGroup(packageGroup: PackageGroup): Array
 export declare function readNxMigrateConfig(json: Partial<PackageJson>): NxMigrationsConfiguration & {
     packageGroup?: ArrayPackageGroup;
 };
-export declare function buildTargetFromScript(script: string, scripts?: Record<string, string>): TargetConfiguration;
+export declare function buildTargetFromScript(script: string, scripts: Record<string, string>, packageManagerCommand: PackageManagerCommands): TargetConfiguration;
 export declare function readTargetsFromPackageJson(packageJson: PackageJson): Record<string, TargetConfiguration<any>>;
 /**
  * Uses `require.resolve` to read the package.json for a module.

package/src/utils/package-json.js

@@ -39,8 +39,7 @@ function readNxMigrateConfig(json) {
     };
 }
 exports.readNxMigrateConfig = readNxMigrateConfig;
-function buildTargetFromScript(script, scripts = {}) {
-    const packageManagerCommand = (0, package_manager_1.getPackageManagerCommand)();
+function buildTargetFromScript(script, scripts = {}, packageManagerCommand) {
     return {
         executor: 'nx:run-script',
         options: {
@@ -53,13 +52,14 @@ function buildTargetFromScript(script, scripts = {}) {
     };
 }
 exports.buildTargetFromScript = buildTargetFromScript;
+let packageManagerCommand;
 function readTargetsFromPackageJson(packageJson) {
     const { scripts, nx, private: isPrivate } = packageJson ?? {};
     const res = {};
     const includedScripts = nx?.includedScripts || Object.keys(scripts ?? {});
-    //
+    packageManagerCommand ??= (0, package_manager_1.getPackageManagerCommand)();
     for (const script of includedScripts) {
-        res[script] = buildTargetFromScript(script, scripts);
+        res[script] = buildTargetFromScript(script, scripts, packageManagerCommand);
     }
     for (const targetName in nx?.targets) {
         res[targetName] = (0, project_configuration_utils_1.mergeTargetConfigurations)(nx?.targets[targetName], res[targetName]);