nx 19.1.0-canary.20240521-1255603 → 19.1.0-canary.20240523-261b0ff

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nx",
-  "version": "19.1.0-canary.20240521-1255603",
+  "version": "19.1.0-canary.20240523-261b0ff",
   "private": false,
   "description": "The core Nx plugin contains the core functionality of Nx like the project graph, nx commands and task orchestration.",
   "repository": {
@@ -20,7 +20,11 @@
     "Nest",
     "Jest",
     "Cypress",
-    "CLI"
+    "CLI",
+    "Testing",
+    "Front-end",
+    "Backend",
+    "Mobile"
   ],
   "bin": {
     "nx": "./bin/nx.js",
@@ -65,7 +69,7 @@
     "yargs-parser": "21.1.1",
     "node-machine-id": "1.1.12",
     "ora": "5.3.0",
-    "@nrwl/tao": "19.1.0-canary.20240521-1255603"
+    "@nrwl/tao": "19.1.0-canary.20240523-261b0ff"
   },
   "peerDependencies": {
     "@swc-node/register": "^1.8.0",
@@ -80,16 +84,16 @@
     }
   },
   "optionalDependencies": {
-    "@nx/nx-darwin-x64": "19.1.0-canary.20240521-1255603",
-    "@nx/nx-darwin-arm64": "19.1.0-canary.20240521-1255603",
-    "@nx/nx-linux-x64-gnu": "19.1.0-canary.20240521-1255603",
-    "@nx/nx-linux-x64-musl": "19.1.0-canary.20240521-1255603",
-    "@nx/nx-win32-x64-msvc": "19.1.0-canary.20240521-1255603",
-    "@nx/nx-linux-arm64-gnu": "19.1.0-canary.20240521-1255603",
-    "@nx/nx-linux-arm64-musl": "19.1.0-canary.20240521-1255603",
-    "@nx/nx-linux-arm-gnueabihf": "19.1.0-canary.20240521-1255603",
-    "@nx/nx-win32-arm64-msvc": "19.1.0-canary.20240521-1255603",
-    "@nx/nx-freebsd-x64": "19.1.0-canary.20240521-1255603"
+    "@nx/nx-darwin-x64": "19.1.0-canary.20240523-261b0ff",
+    "@nx/nx-darwin-arm64": "19.1.0-canary.20240523-261b0ff",
+    "@nx/nx-linux-x64-gnu": "19.1.0-canary.20240523-261b0ff",
+    "@nx/nx-linux-x64-musl": "19.1.0-canary.20240523-261b0ff",
+    "@nx/nx-win32-x64-msvc": "19.1.0-canary.20240523-261b0ff",
+    "@nx/nx-linux-arm64-gnu": "19.1.0-canary.20240523-261b0ff",
+    "@nx/nx-linux-arm64-musl": "19.1.0-canary.20240523-261b0ff",
+    "@nx/nx-linux-arm-gnueabihf": "19.1.0-canary.20240523-261b0ff",
+    "@nx/nx-win32-arm64-msvc": "19.1.0-canary.20240523-261b0ff",
+    "@nx/nx-freebsd-x64": "19.1.0-canary.20240523-261b0ff"
   },
   "nx-migrations": {
     "migrations": "./migrations.json",

package/schemas/nx-schema.json

@@ -366,7 +366,7 @@
         "packageManager": {
           "type": "string",
           "description": "The default package manager to use.",
-          "enum": ["yarn", "pnpm", "npm"]
+          "enum": ["yarn", "pnpm", "npm", "bun"]
         }
       }
     },

package/src/command-line/format/format.js

@@ -1,23 +1,23 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.format = void 0;
-const child_process_1 = require("child_process");
-const path = require("path");
+const node_child_process_1 = require("node:child_process");
+const path = require("node:path");
+const file_utils_1 = require("../../project-graph/file-utils");
 const command_line_utils_1 = require("../../utils/command-line-utils");
-const ignore_1 = require("../../utils/ignore");
 const fileutils_1 = require("../../utils/fileutils");
-const file_utils_1 = require("../../project-graph/file-utils");
+const ignore_1 = require("../../utils/ignore");
 const prettier = require("prettier");
-const object_sort_1 = require("../../utils/object-sort");
-const package_json_1 = require("../../utils/package-json");
+const configuration_1 = require("../../config/configuration");
 const typescript_1 = require("../../plugins/js/utils/typescript");
-const project_graph_1 = require("../../project-graph/project-graph");
 const affected_project_graph_1 = require("../../project-graph/affected/affected-project-graph");
-const configuration_1 = require("../../config/configuration");
-const chunkify_1 = require("../../utils/chunkify");
+const project_graph_1 = require("../../project-graph/project-graph");
 const all_file_data_1 = require("../../utils/all-file-data");
-const workspace_root_1 = require("../../utils/workspace-root");
+const chunkify_1 = require("../../utils/chunkify");
+const object_sort_1 = require("../../utils/object-sort");
 const output_1 = require("../../utils/output");
+const package_json_1 = require("../../utils/package-json");
+const workspace_root_1 = require("../../utils/workspace-root");
 const PRETTIER_PATH = getPrettierPath();
 async function format(command, args) {
     const { nxArgs } = (0, command_line_utils_1.splitArgsIntoNxArgsAndOverrides)(args, 'affected', { printWarnings: false }, (0, configuration_1.readNxJson)());
@@ -33,12 +33,31 @@ async function format(command, args) {
             addRootConfigFiles(chunkList, nxArgs);
             chunkList.forEach((chunk) => write(chunk));
             break;
-        case 'check':
-            const pass = chunkList.reduce((pass, chunk) => check(chunk) && pass, true);
-            if (!pass) {
+        case 'check': {
+            const filesWithDifferentFormatting = [];
+            for (const chunk of chunkList) {
+                const files = await check(chunk);
+                filesWithDifferentFormatting.push(...files);
+            }
+            if (filesWithDifferentFormatting.length > 0) {
+                if (nxArgs.verbose) {
+                    output_1.output.error({
+                        title: 'The following files are not formatted correctly based on your Prettier configuration',
+                        bodyLines: [
+                            '- Run "nx format:write" and commit the resulting diff to fix these files.',
+                            '- Please note, Prettier does not support a native way to diff the output of its check logic (https://github.com/prettier/prettier/issues/6885).',
+                            '',
+                            ...filesWithDifferentFormatting,
+                        ],
+                    });
+                }
+                else {
+                    console.log(filesWithDifferentFormatting.join('\n'));
+                }
                 process.exit(1);
             }
             break;
+        }
     }
 }
 exports.format = format;
@@ -113,29 +132,32 @@ function write(patterns) {
             result[pattern.includes('.swcrc') ? 0 : 1].push(pattern);
             return result;
         }, [[], []]);
-        (0, child_process_1.execSync)(`node "${PRETTIER_PATH}" --write --list-different ${regularPatterns.join(' ')}`, {
+        (0, node_child_process_1.execSync)(`node "${PRETTIER_PATH}" --write --list-different ${regularPatterns.join(' ')}`, {
             stdio: [0, 1, 2],
         });
         if (swcrcPatterns.length > 0) {
-            (0, child_process_1.execSync)(`node "${PRETTIER_PATH}" --write --list-different ${swcrcPatterns.join(' ')} --parser json`, {
+            (0, node_child_process_1.execSync)(`node "${PRETTIER_PATH}" --write --list-different ${swcrcPatterns.join(' ')} --parser json`, {
                 stdio: [0, 1, 2],
             });
         }
     }
 }
-function check(patterns) {
+async function check(patterns) {
     if (patterns.length === 0) {
-        return true;
+        return [];
     }
-    try {
-        (0, child_process_1.execSync)(`node "${PRETTIER_PATH}" --list-different ${patterns.join(' ')}`, {
-            stdio: [0, 1, 2],
+    return new Promise((resolve) => {
+        (0, node_child_process_1.exec)(`node "${PRETTIER_PATH}" --list-different ${patterns.join(' ')}`, { encoding: 'utf-8' }, (error, stdout) => {
+            if (error) {
+                // The command failed so there are files with different formatting. Prettier writes them to stdout, newline separated.
+                resolve(stdout.trim().split('\n'));
+            }
+            else {
+                // The command succeeded so there are no files with different formatting
+                resolve([]);
+            }
         });
-        return true;
-    }
-    catch {
-        return false;
-    }
+    });
 }
 function sortTsConfig() {
     try {

package/src/command-line/init/implementation/react/index.js

@@ -155,6 +155,7 @@ function moveFilesToTempWorkspace(options) {
         options.packageManager === 'yarn' ? 'yarn.lock' : null,
         options.packageManager === 'pnpm' ? 'pnpm-lock.yaml' : null,
         options.packageManager === 'npm' ? 'package-lock.json' : null,
+        options.packageManager === 'bun' ? 'bun.lockb' : null,
     ];
     const optionalCraFiles = ['README.md'];
     const filesToMove = [...requiredCraFiles, ...optionalCraFiles].filter(Boolean);

package/src/command-line/migrate/migrate.js

@@ -874,7 +874,14 @@ function runInstall() {
     (0, child_process_1.execSync)(pmCommands.install, { stdio: [0, 1, 2] });
 }
 async function executeMigrations(root, migrations, isVerbose, shouldCreateCommits, commitPrefix) {
-    const depsBeforeMigrations = getStringifiedPackageJsonDeps(root);
+    let initialDeps = getStringifiedPackageJsonDeps(root);
+    const installDepsIfChanged = () => {
+        const currentDeps = getStringifiedPackageJsonDeps(root);
+        if (initialDeps !== currentDeps) {
+            runInstall();
+        }
+        initialDeps = currentDeps;
+    };
     const migrationsWithNoChanges = [];
     const sortedMigrations = migrations.sort((a, b) => {
         // special case for the split configuration migration to run first
@@ -915,6 +922,7 @@ async function executeMigrations(root, migrations, isVerbose, shouldCreateCommit
                 loggingQueue.forEach((log) => logger_1.logger.info('  ' + log));
             }
             if (shouldCreateCommits) {
+                installDepsIfChanged();
                 const commitMessage = `${commitPrefix}${m.name}`;
                 try {
                     const committedSha = commitChanges(commitMessage);
@@ -938,9 +946,8 @@ async function executeMigrations(root, migrations, isVerbose, shouldCreateCommit
             throw e;
         }
     }
-    const depsAfterMigrations = getStringifiedPackageJsonDeps(root);
-    if (depsBeforeMigrations !== depsAfterMigrations) {
-        runInstall();
+    if (!shouldCreateCommits) {
+        installDepsIfChanged();
     }
     return migrationsWithNoChanges;
 }

package/src/command-line/release/utils/shared.js

@@ -162,9 +162,11 @@ function createGitTagValues(releaseGroups, releaseGroupToFilteredProjects, versi
         }
         // For fixed groups we want one tag for the overall group
         const projectVersionData = versionData[releaseGroupProjectNames[0]]; // all at the same version, so we can just pick the first one
-        tags.push((0, utils_1.interpolate)(releaseGroup.releaseTagPattern, {
-            version: projectVersionData.newVersion,
-        }));
+        if (projectVersionData.newVersion !== null) {
+            tags.push((0, utils_1.interpolate)(releaseGroup.releaseTagPattern, {
+                version: projectVersionData.newVersion,
+            }));
+        }
     }
     return tags;
 }

package/src/config/workspace-json-project-json.d.ts

@@ -109,6 +109,7 @@ export interface ProjectMetadata {
     targetGroups?: Record<string, string[]>;
 }
 export interface TargetMetadata {
+    [k: string]: any;
     description?: string;
     technologies?: string[];
 }