nx 19.1.0-canary.20240516-d581cef → 19.1.0-canary.20240518-3523720

package/src/daemon/server/server.js

@@ -198,7 +198,7 @@ const handleWorkspaceChanges = async (err, changeEvents) => {
             });
             return;
         }
-        if (err || !changeEvents || !changeEvents.length) {
+        if (err) {
             let error = typeof err === 'string' ? new Error(err) : err;
             logger_1.serverLogger.watcherLog('Unexpected workspace watcher error', error.message);
             console.error(error);

package/src/generators/utils/json.js

@@ -30,7 +30,8 @@ exports.readJson = readJson;
  * @param options Optional JSON Serialize Options
  */
 function writeJson(tree, path, value, options) {
-    tree.write(path, (0, json_1.serializeJson)(value, options));
+    const serialized = (0, json_1.serializeJson)(value, options);
+    tree.write(path, `${serialized}\n`);
 }
 exports.writeJson = writeJson;
 /**

package/src/utils/find-matching-projects.js

@@ -22,15 +22,6 @@ function findMatchingProjects(patterns = [], projects) {
     }
     const projectNames = Object.keys(projects);
     const matchedProjects = new Set();
-    // If the first pattern is an exclude pattern,
-    // we add a wildcard pattern at the first to select
-    // all projects, except the ones that match the exclude pattern.
-    // e.g. ['!tag:someTag', 'project2'] will match all projects except
-    // the ones with the tag 'someTag', and also match the project 'project2',
-    // regardless of its tags.
-    if (isExcludePattern(patterns[0])) {
-        patterns.unshift('*');
-    }
     for (const stringPattern of patterns) {
         if (!stringPattern.length) {
             continue;
@@ -148,11 +139,8 @@ function addMatchingProjectsByTag(projectNames, projects, pattern, matchedProjec
         }
     }
 }
-function isExcludePattern(pattern) {
-    return pattern.startsWith('!');
-}
 function parseStringPattern(pattern, projects) {
-    const isExclude = isExcludePattern(pattern);
+    const isExclude = pattern.startsWith('!');
     // Support for things like: `!{type}:value`
     if (isExclude) {
         pattern = pattern.substring(1);

package/src/utils/json.js

@@ -57,6 +57,6 @@ function formatParseError(input, parseError) {
  * @returns the formatted JSON representation of the object
  */
 function serializeJson(input, options) {
-    return JSON.stringify(input, null, options?.spaces ?? 2) + '\n';
+    return JSON.stringify(input, null, options?.spaces ?? 2);
 }
 exports.serializeJson = serializeJson;

package/src/utils/package-manager.js

@@ -254,11 +254,20 @@ async function resolvePackageVersionUsingRegistry(packageName, version) {
         if (!result) {
             throw new Error(`Unable to resolve version ${packageName}@${version}.`);
         }
-        // get the last line of the output, strip the package version and quotes
-        const resolvedVersion = result
-            .split('\n')
-            .pop()
-            .split(' ')
+        const lines = result.split('\n');
+        if (lines.length === 1) {
+            return lines[0];
+        }
+        /**
+         * The output contains multiple lines ordered by release date, so the last
+         * version might not be the last one in the list. We need to sort it. Each
+         * line looks like:
+         *
+         * <package>@<version> '<version>'
+         */
+        const resolvedVersion = lines
+            .map((line) => line.split(' ')[1])
+            .sort()
             .pop()
             .replace(/'/g, '');
         return resolvedVersion;