nx 19.1.0-canary.20240508-fd78152 → 19.1.0-canary.20240509-8f705e3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nx",
-  "version": "19.1.0-canary.20240508-fd78152",
+  "version": "19.1.0-canary.20240509-8f705e3",
   "private": false,
   "description": "The core Nx plugin contains the core functionality of Nx like the project graph, nx commands and task orchestration.",
   "repository": {
@@ -66,7 +66,7 @@
     "yargs-parser": "21.1.1",
     "node-machine-id": "1.1.12",
     "ora": "5.3.0",
-    "@nrwl/tao": "19.1.0-canary.20240508-fd78152"
+    "@nrwl/tao": "19.1.0-canary.20240509-8f705e3"
   },
   "peerDependencies": {
     "@swc-node/register": "^1.8.0",
@@ -81,16 +81,16 @@
     }
   },
   "optionalDependencies": {
-    "@nx/nx-darwin-x64": "19.1.0-canary.20240508-fd78152",
-    "@nx/nx-darwin-arm64": "19.1.0-canary.20240508-fd78152",
-    "@nx/nx-linux-x64-gnu": "19.1.0-canary.20240508-fd78152",
-    "@nx/nx-linux-x64-musl": "19.1.0-canary.20240508-fd78152",
-    "@nx/nx-win32-x64-msvc": "19.1.0-canary.20240508-fd78152",
-    "@nx/nx-linux-arm64-gnu": "19.1.0-canary.20240508-fd78152",
-    "@nx/nx-linux-arm64-musl": "19.1.0-canary.20240508-fd78152",
-    "@nx/nx-linux-arm-gnueabihf": "19.1.0-canary.20240508-fd78152",
-    "@nx/nx-win32-arm64-msvc": "19.1.0-canary.20240508-fd78152",
-    "@nx/nx-freebsd-x64": "19.1.0-canary.20240508-fd78152"
+    "@nx/nx-darwin-x64": "19.1.0-canary.20240509-8f705e3",
+    "@nx/nx-darwin-arm64": "19.1.0-canary.20240509-8f705e3",
+    "@nx/nx-linux-x64-gnu": "19.1.0-canary.20240509-8f705e3",
+    "@nx/nx-linux-x64-musl": "19.1.0-canary.20240509-8f705e3",
+    "@nx/nx-win32-x64-msvc": "19.1.0-canary.20240509-8f705e3",
+    "@nx/nx-linux-arm64-gnu": "19.1.0-canary.20240509-8f705e3",
+    "@nx/nx-linux-arm64-musl": "19.1.0-canary.20240509-8f705e3",
+    "@nx/nx-linux-arm-gnueabihf": "19.1.0-canary.20240509-8f705e3",
+    "@nx/nx-win32-arm64-msvc": "19.1.0-canary.20240509-8f705e3",
+    "@nx/nx-freebsd-x64": "19.1.0-canary.20240509-8f705e3"
   },
   "nx-migrations": {
     "migrations": "./migrations.json",

package/schemas/nx-schema.json

@@ -19,7 +19,7 @@
         }
       },
       "additionalProperties": false,
-      "deprecated": "Use `defaultBase` instead. Support for setting `defaultBase` in `affected` will be removed in Nx 19."
+      "deprecated": "Use `defaultBase` instead. Support for setting `defaultBase` in `affected` will be removed in Nx 20."
     },
     "defaultBase": {
       "type": "string",

package/src/command-line/affected/affected.js

@@ -4,7 +4,6 @@ exports.getAffectedGraphNodes = exports.affected = void 0;
 const file_utils_1 = require("../../project-graph/file-utils");
 const run_command_1 = require("../../tasks-runner/run-command");
 const output_1 = require("../../utils/output");
-const print_affected_1 = require("./print-affected");
 const connect_to_nx_cloud_1 = require("../connect/connect-to-nx-cloud");
 const command_line_utils_1 = require("../../utils/command-line-utils");
 const perf_hooks_1 = require("perf_hooks");
@@ -16,8 +15,6 @@ const workspace_configuration_check_1 = require("../../utils/workspace-configura
 const find_matching_projects_1 = require("../../utils/find-matching-projects");
 const graph_1 = require("../graph/graph");
 const all_file_data_1 = require("../../utils/all-file-data");
-const logger_1 = require("../../utils/logger");
-const command_object_1 = require("./command-object");
 async function affected(command, args, extraTargetDependencies = {}) {
     perf_hooks_1.performance.mark('code-loading:end');
     perf_hooks_1.performance.measure('code-loading', 'init-local', 'code-loading:end');
@@ -34,19 +31,6 @@ async function affected(command, args, extraTargetDependencies = {}) {
     const projects = await getAffectedGraphNodes(nxArgs, projectGraph);
     try {
         switch (command) {
-            case 'graph':
-                logger_1.logger.warn([logger_1.NX_PREFIX, command_object_1.affectedGraphDeprecationMessage].join(' '));
-                const projectNames = projects.map((p) => p.name);
-                await (0, graph_1.generateGraph)(args, projectNames);
-                break;
-            case 'print-affected':
-                if (nxArgs.targets && nxArgs.targets.length > 0) {
-                    await (0, print_affected_1.printAffected)(allProjectsWithTarget(projects, nxArgs), projectGraph, { nxJson }, nxArgs, overrides);
-                }
-                else {
-                    await (0, print_affected_1.printAffected)(projects, projectGraph, { nxJson }, nxArgs, overrides);
-                }
-                break;
             case 'affected': {
                 const projectsWithTarget = allProjectsWithTarget(projects, nxArgs);
                 if (nxArgs.graph) {

package/src/command-line/affected/command-object.d.ts

@@ -4,13 +4,3 @@ export declare const yargsAffectedTestCommand: CommandModule;
 export declare const yargsAffectedBuildCommand: CommandModule;
 export declare const yargsAffectedLintCommand: CommandModule;
 export declare const yargsAffectedE2ECommand: CommandModule;
-export declare const affectedGraphDeprecationMessage = "Use `nx graph --affected`, or `nx affected --graph` instead depending on which best suits your use case. The `affected:graph` command will be removed in Nx 19.";
-/**
- * @deprecated 'Use `nx graph --affected`, or` nx affected --graph` instead depending on which best suits your use case. The `affected:graph` command will be removed in Nx 19.'
- */
-export declare const yargsAffectedGraphCommand: CommandModule;
-export declare const printAffectedDeprecationMessage = "Use `nx show projects --affected`, `nx affected --graph -t build` or `nx graph --affected` depending on which best suits your use case. The `print-affected` command will be removed in Nx 19.";
-/**
- * @deprecated 'Use `nx show --affected`, `nx affected --graph` or `nx graph --affected` depending on which best suits your use case. The `print-affected` command will be removed in Nx 19.'
- */
-export declare const yargsPrintAffectedCommand: CommandModule;

package/src/command-line/affected/command-object.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.yargsPrintAffectedCommand = exports.printAffectedDeprecationMessage = exports.yargsAffectedGraphCommand = exports.affectedGraphDeprecationMessage = exports.yargsAffectedE2ECommand = exports.yargsAffectedLintCommand = exports.yargsAffectedBuildCommand = exports.yargsAffectedTestCommand = exports.yargsAffectedCommand = void 0;
+exports.yargsAffectedE2ECommand = exports.yargsAffectedLintCommand = exports.yargsAffectedBuildCommand = exports.yargsAffectedTestCommand = exports.yargsAffectedCommand = void 0;
 const documentation_1 = require("../yargs-utils/documentation");
 const shared_options_1 = require("../yargs-utils/shared-options");
 const params_1 = require("../../utils/params");
@@ -75,46 +75,3 @@ exports.yargsAffectedE2ECommand = {
         });
     },
 };
-exports.affectedGraphDeprecationMessage = 'Use `nx graph --affected`, or `nx affected --graph` instead depending on which best suits your use case. The `affected:graph` command will be removed in Nx 19.';
-/**
- * @deprecated 'Use `nx graph --affected`, or` nx affected --graph` instead depending on which best suits your use case. The `affected:graph` command will be removed in Nx 19.'
- */
-exports.yargsAffectedGraphCommand = {
-    command: 'affected:graph',
-    describe: 'Graph dependencies affected by changes',
-    aliases: ['affected:dep-graph'],
-    builder: (yargs) => (0, documentation_1.linkToNxDevAndExamples)((0, shared_options_1.withAffectedOptions)((0, shared_options_1.withDepGraphOptions)(yargs)), 'affected:graph'),
-    handler: async (args) => {
-        return (0, params_1.handleErrors)(args.verbose ?? process.env.NX_VERBOSE_LOGGING === 'true', async () => {
-            return await (await Promise.resolve().then(() => require('./affected'))).affected('graph', {
-                ...args,
-            });
-        });
-    },
-    deprecated: exports.affectedGraphDeprecationMessage,
-};
-exports.printAffectedDeprecationMessage = 'Use `nx show projects --affected`, `nx affected --graph -t build` or `nx graph --affected` depending on which best suits your use case. The `print-affected` command will be removed in Nx 19.';
-/**
- * @deprecated 'Use `nx show --affected`, `nx affected --graph` or `nx graph --affected` depending on which best suits your use case. The `print-affected` command will be removed in Nx 19.'
- */
-exports.yargsPrintAffectedCommand = {
-    command: 'print-affected',
-    describe: 'Prints information about the projects and targets affected by changes',
-    builder: (yargs) => (0, documentation_1.linkToNxDevAndExamples)((0, shared_options_1.withAffectedOptions)((0, shared_options_1.withTargetAndConfigurationOption)(yargs, false)), 'print-affected')
-        .option('select', {
-        type: 'string',
-        describe: 'Select the subset of the returned json document (e.g., --select=projects)',
-    })
-        .option('type', {
-        type: 'string',
-        choices: ['app', 'lib'],
-        describe: 'Select the type of projects to be returned (e.g., --type=app)',
-    }),
-    handler: async (args) => {
-        return (0, params_1.handleErrors)(args.verbose ?? process.env.NX_VERBOSE_LOGGING === 'true', async () => {
-            await (await Promise.resolve().then(() => require('./affected'))).affected('print-affected', (0, shared_options_1.withOverrides)(args));
-            process.exit(0);
-        });
-    },
-    deprecated: exports.printAffectedDeprecationMessage,
-};

package/src/command-line/graph/graph.js

@@ -267,18 +267,7 @@ async function generateGraph(args, affectedProjects) {
         else if (ext === '.json') {
             (0, fs_extra_1.ensureDirSync)((0, path_1.dirname)(fullFilePath));
             const json = await createJsonOutput(prunedGraph, rawGraph, args.projects, args.targets);
-            json.affectedProjects = affectedProjects;
-            json.criticalPath = affectedProjects;
             (0, fileutils_1.writeJsonFile)(fullFilePath, json);
-            output_1.output.warn({
-                title: 'JSON output contains deprecated fields:',
-                bodyLines: [
-                    '- affectedProjects',
-                    '- criticalPath',
-                    '',
-                    'These fields will be removed in Nx 19. If you need to see which projects were affected, use `nx show projects --affected`.',
-                ],
-            });
             output_1.output.success({
                 title: `JSON output created in ${fileFolderPath}`,
                 bodyLines: [fullFilePath],

package/src/command-line/migrate/command-object.js

@@ -128,8 +128,8 @@ function nxCliPath() {
             });
             // if it's berry ensure we set the node_linker to node-modules
             if (packageManager === 'yarn' && pmc.ciInstall.includes('immutable')) {
-                (0, child_process_2.execSync)(pmc.preInstall, {
-                    cwd: 'yarn config set nodeLinker node-modules',
+                (0, child_process_2.execSync)('yarn config set nodeLinker node-modules', {
+                    cwd: tmpDir,
                     stdio: ['ignore', 'ignore', 'ignore'],
                 });
             }

package/src/command-line/nx-commands.js

@@ -43,7 +43,6 @@ exports.commandsObject = yargs
     .command(command_object_1.yargsAffectedBuildCommand)
     .command(command_object_1.yargsAffectedCommand)
     .command(command_object_1.yargsAffectedE2ECommand)
-    .command(command_object_1.yargsAffectedGraphCommand)
     .command(command_object_1.yargsAffectedLintCommand)
     .command(command_object_1.yargsAffectedTestCommand)
     .command(command_object_2.yargsConnectCommand)
@@ -58,7 +57,6 @@ exports.commandsObject = yargs
     .command(command_object_9.yargsListCommand)
     .command(command_object_10.yargsMigrateCommand)
     .command(command_object_11.yargsNewCommand)
-    .command(command_object_1.yargsPrintAffectedCommand)
     .command(command_object_19.yargsReleaseCommand)
     .command(command_object_12.yargsRepairCommand)
     .command(command_object_13.yargsReportCommand)

package/src/command-line/release/changelog.js

@@ -8,7 +8,6 @@ const semver_1 = require("semver");
 const tmp_1 = require("tmp");
 const nx_json_1 = require("../../config/nx-json");
 const tree_1 = require("../../generators/tree");
-const register_1 = require("../../plugins/js/utils/register");
 const file_map_utils_1 = require("../../project-graph/file-map-utils");
 const project_graph_1 = require("../../project-graph/project-graph");
 const utils_1 = require("../../tasks-runner/utils");
@@ -24,9 +23,9 @@ const github_1 = require("./utils/github");
 const launch_editor_1 = require("./utils/launch-editor");
 const markdown_1 = require("./utils/markdown");
 const print_changes_1 = require("./utils/print-changes");
+const resolve_changelog_renderer_1 = require("./utils/resolve-changelog-renderer");
 const resolve_nx_json_error_message_1 = require("./utils/resolve-nx-json-error-message");
 const shared_1 = require("./utils/shared");
-const typescript_1 = require("../../plugins/js/utils/typescript");
 const releaseChangelogCLIHandler = (args) => (0, params_1.handleErrors)(args.verbose, () => releaseChangelog(args));
 exports.releaseChangelogCLIHandler = releaseChangelogCLIHandler;
 /**
@@ -360,28 +359,6 @@ async function applyChangesAndExit(args, nxReleaseConfig, tree, toSHA, postGitTa
     }
     return;
 }
-function resolveChangelogRenderer(changelogRendererPath) {
-    const interpolatedChangelogRendererPath = (0, utils_1.interpolate)(changelogRendererPath, {
-        workspaceRoot: workspace_root_1.workspaceRoot,
-    });
-    // Try and load the provided (or default) changelog renderer
-    let changelogRenderer;
-    let cleanupTranspiler = () => { };
-    try {
-        const rootTsconfigPath = (0, typescript_1.getRootTsConfigPath)();
-        if (rootTsconfigPath) {
-            cleanupTranspiler = (0, register_1.registerTsProject)(rootTsconfigPath);
-        }
-        const r = require(interpolatedChangelogRendererPath);
-        changelogRenderer = r.default || r;
-    }
-    catch {
-    }
-    finally {
-        cleanupTranspiler();
-    }
-    return changelogRenderer;
-}
 async function generateChangelogForWorkspace(tree, args, projectGraph, nxReleaseConfig, workspaceChangelogVersion, commits) {
     const config = nxReleaseConfig.changelog.workspaceChangelog;
     // The entire feature is disabled at the workspace level, exit early
@@ -421,7 +398,7 @@ async function generateChangelogForWorkspace(tree, args, projectGraph, nxRelease
     const interactive = args.interactive === 'all' || args.interactive === 'workspace';
     const dryRun = !!args.dryRun;
     const gitRemote = args.gitRemote;
-    const changelogRenderer = resolveChangelogRenderer(config.renderer);
+    const changelogRenderer = (0, resolve_changelog_renderer_1.resolveChangelogRenderer)(config.renderer);
     let interpolatedTreePath = config.file || '';
     if (interpolatedTreePath) {
         interpolatedTreePath = (0, utils_1.interpolate)(interpolatedTreePath, {
@@ -502,7 +479,7 @@ async function generateChangelogForProjects(tree, args, projectGraph, commits, p
     const interactive = args.interactive === 'all' || args.interactive === 'projects';
     const dryRun = !!args.dryRun;
     const gitRemote = args.gitRemote;
-    const changelogRenderer = resolveChangelogRenderer(config.renderer);
+    const changelogRenderer = (0, resolve_changelog_renderer_1.resolveChangelogRenderer)(config.renderer);
     const projectChangelogs = {};
     for (const project of projects) {
         let interpolatedTreePath = config.file || '';

package/src/command-line/release/config/config.js

@@ -14,11 +14,12 @@ exports.handleNxReleaseConfigError = exports.createNxReleaseConfig = exports.IMP
  * defaults and user overrides, as well as handling common errors, up front to produce a single, consistent,
  * and easy to consume config object for all the `nx release` command implementations.
  */
-const path_1 = require("path");
+const node_path_1 = require("node:path");
 const fileutils_1 = require("../../../utils/fileutils");
 const find_matching_projects_1 = require("../../../utils/find-matching-projects");
 const output_1 = require("../../../utils/output");
 const workspace_root_1 = require("../../../utils/workspace-root");
+const resolve_changelog_renderer_1 = require("../utils/resolve-changelog-renderer");
 const resolve_nx_json_error_message_1 = require("../utils/resolve-nx-json-error-message");
 const conventional_commits_1 = require("./conventional-commits");
 exports.IMPLICIT_DEFAULT_RELEASE_GROUP = '__default__';
@@ -84,7 +85,7 @@ async function createNxReleaseConfig(projectGraph, projectFileMap, userConfig =
             userGroups[0].projectsRelationship === 'independent') ||
         (userConfig.projectsRelationship === 'independent' &&
             !userGroups.some((g) => g.projectsRelationship === 'fixed'));
-    const defaultRendererPath = (0, path_1.join)(__dirname, '../../../../release/changelog-renderer');
+    const defaultRendererPath = (0, node_path_1.join)(__dirname, '../../../../release/changelog-renderer');
     const WORKSPACE_DEFAULTS = {
         // By default all projects in all groups are released together
         projectsRelationship: workspaceProjectsRelationship,
@@ -318,6 +319,7 @@ async function createNxReleaseConfig(projectGraph, projectFileMap, userConfig =
         }
         releaseGroups[releaseGroupName] = finalReleaseGroup;
     }
+    ensureChangelogRenderersAreResolvable(releaseGroups, rootChangelogConfig);
     return {
         error: null,
         nxReleaseConfig: {
@@ -613,12 +615,12 @@ async function getDefaultProjects(projectGraph, projectFileMap) {
 }
 function isProjectPublic(project, projectGraph, projectFileMap) {
     const projectNode = projectGraph.nodes[project];
-    const packageJsonPath = (0, path_1.join)(projectNode.data.root, 'package.json');
+    const packageJsonPath = (0, node_path_1.join)(projectNode.data.root, 'package.json');
     if (!projectFileMap[project]?.find((f) => f.file === packageJsonPath)) {
         return false;
     }
     try {
-        const fullPackageJsonPath = (0, path_1.join)(workspace_root_1.workspaceRoot, packageJsonPath);
+        const fullPackageJsonPath = (0, node_path_1.join)(workspace_root_1.workspaceRoot, packageJsonPath);
         const packageJson = (0, fileutils_1.readJsonFile)(fullPackageJsonPath);
         return !(packageJson.private === true);
     }
@@ -628,3 +630,42 @@ function isProjectPublic(project, projectGraph, projectFileMap) {
         return false;
     }
 }
+function ensureChangelogRenderersAreResolvable(releaseGroups, rootChangelogConfig) {
+    /**
+     * If any form of changelog config is enabled, ensure that any provided changelog renderers are resolvable
+     * up front so that we do not end up erroring only after the versioning step has been completed.
+     */
+    const uniqueRendererPaths = new Set();
+    if (rootChangelogConfig.workspaceChangelog &&
+        typeof rootChangelogConfig.workspaceChangelog !== 'boolean' &&
+        rootChangelogConfig.workspaceChangelog.renderer?.length) {
+        uniqueRendererPaths.add(rootChangelogConfig.workspaceChangelog.renderer);
+    }
+    if (rootChangelogConfig.projectChangelogs &&
+        typeof rootChangelogConfig.projectChangelogs !== 'boolean' &&
+        rootChangelogConfig.projectChangelogs.renderer?.length) {
+        uniqueRendererPaths.add(rootChangelogConfig.projectChangelogs.renderer);
+    }
+    for (const group of Object.values(releaseGroups)) {
+        if (group.changelog &&
+            typeof group.changelog !== 'boolean' &&
+            group.changelog.renderer?.length) {
+            uniqueRendererPaths.add(group.changelog.renderer);
+        }
+    }
+    if (!uniqueRendererPaths.size) {
+        return;
+    }
+    for (const rendererPath of uniqueRendererPaths) {
+        try {
+            (0, resolve_changelog_renderer_1.resolveChangelogRenderer)(rendererPath);
+        }
+        catch (e) {
+            const workspaceRelativePath = (0, node_path_1.relative)(workspace_root_1.workspaceRoot, rendererPath);
+            output_1.output.error({
+                title: `There was an error when resolving the configured changelog renderer at path: ${workspaceRelativePath}`,
+            });
+            throw e;
+        }
+    }
+}

package/src/command-line/release/utils/resolve-changelog-renderer.d.ts

@@ -0,0 +1,2 @@
+import type { ChangelogRenderer } from '../../../../release/changelog-renderer';
+export declare function resolveChangelogRenderer(changelogRendererPath: string): ChangelogRenderer;

package/src/command-line/release/utils/resolve-changelog-renderer.js

@@ -0,0 +1,31 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.resolveChangelogRenderer = void 0;
+const register_1 = require("../../../plugins/js/utils/register");
+const typescript_1 = require("../../../plugins/js/utils/typescript");
+const utils_1 = require("../../../tasks-runner/utils");
+const workspace_root_1 = require("../../../utils/workspace-root");
+function resolveChangelogRenderer(changelogRendererPath) {
+    const interpolatedChangelogRendererPath = (0, utils_1.interpolate)(changelogRendererPath, {
+        workspaceRoot: workspace_root_1.workspaceRoot,
+    });
+    // Try and load the provided (or default) changelog renderer
+    let changelogRenderer;
+    let cleanupTranspiler = () => { };
+    try {
+        const rootTsconfigPath = (0, typescript_1.getRootTsConfigPath)();
+        if (rootTsconfigPath) {
+            cleanupTranspiler = (0, register_1.registerTsProject)(rootTsconfigPath);
+        }
+        const r = require(interpolatedChangelogRendererPath);
+        changelogRenderer = r.default || r;
+    }
+    catch (err) {
+        throw err;
+    }
+    finally {
+        cleanupTranspiler();
+    }
+    return changelogRenderer;
+}
+exports.resolveChangelogRenderer = resolveChangelogRenderer;

package/src/command-line/show/command-object.d.ts

@@ -20,6 +20,7 @@ export type ShowProjectsOptions = NxShowArgs & {
 export type ShowProjectOptions = NxShowArgs & {
     projectName: string;
     web?: boolean;
-    verbose: boolean;
+    open?: boolean;
+    verbose?: boolean;
 };
 export declare const yargsShowCommand: CommandModule<Record<string, unknown>, NxShowArgs>;

package/src/command-line/show/command-object.js

@@ -75,7 +75,7 @@ const showProjectsCommand = {
 const showProjectCommand = {
     command: 'project <projectName>',
     describe: 'Shows resolved project configuration for a given project.',
-    builder: (yargs) => yargs
+    builder: (yargs) => (0, shared_options_1.withVerbose)(yargs)
         .positional('projectName', {
         type: 'string',
         alias: 'p',
@@ -86,12 +86,17 @@ const showProjectCommand = {
         type: 'boolean',
         description: 'Show project details in the browser',
     })
-        .option('verbose', {
+        .option('open', {
         type: 'boolean',
-        description: 'Prints additional information about the commands (e.g., stack traces)',
+        description: 'Set to false to prevent the browser from opening when using --web',
+        implies: 'web',
+    })
+        .check((argv) => {
+        if (argv.web) {
+            argv.json = false;
+        }
+        return true;
     })
-        .conflicts('json', 'web')
-        .conflicts('web', 'json')
         .example('$0 show project my-app', 'View project information for my-app in JSON format')
         .example('$0 show project my-app --web', 'View project information for my-app in the browser'),
     handler: (args) => {

package/src/command-line/show/project.js

@@ -19,7 +19,7 @@ async function showProjectHandler(args) {
             view: 'project-details',
             focus: node.name,
             watch: true,
-            open: true,
+            open: args.open ?? true,
         }, []);
     }
     else {

package/src/config/project-graph.d.ts

@@ -111,7 +111,7 @@ export interface ProjectGraphDependency {
 }
 /**
  * Additional information to be used to process a project graph
- * @deprecated The {@link ProjectGraphProcessor} is deprecated. This will be removed in Nx 19.
+ * @deprecated The {@link ProjectGraphProcessor} is deprecated. This will be removed in Nx 20.
  */
 export interface ProjectGraphProcessorContext {
     /**
@@ -132,6 +132,6 @@ export interface ProjectGraphProcessorContext {
 }
 /**
  * A function that produces an updated ProjectGraph
- * @deprecated Use {@link CreateNodes} and {@link CreateDependencies} instead. This will be removed in Nx 19.
+ * @deprecated Use {@link CreateNodes} and {@link CreateDependencies} instead. This will be removed in Nx 20.
  */
 export type ProjectGraphProcessor = (currentGraph: ProjectGraph, context: ProjectGraphProcessorContext) => ProjectGraph | Promise<ProjectGraph>;

package/src/plugins/js/project-graph/build-dependencies/strip-source-code.d.ts

@@ -1,6 +1,6 @@
 import type { Scanner } from 'typescript';
 /**
- * @deprecated This is deprecated and will be removed in Nx 19.
+ * @deprecated This is deprecated and will be removed in Nx 20.
  * This was not intended to be exposed.
  * Please talk to us if you need this.
  */

package/src/plugins/js/project-graph/build-dependencies/strip-source-code.js

@@ -3,7 +3,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.stripSourceCode = void 0;
 let SyntaxKind;
 /**
- * @deprecated This is deprecated and will be removed in Nx 19.
+ * @deprecated This is deprecated and will be removed in Nx 20.
  * This was not intended to be exposed.
  * Please talk to us if you need this.
  */

package/src/plugins/js/project-graph/build-dependencies/typescript-import-locator.d.ts

@@ -1,6 +1,6 @@
 import { DependencyType } from '../../../../config/project-graph';
 /**
- * @deprecated This is deprecated and will be removed in Nx 19.
+ * @deprecated This is deprecated and will be removed in Nx 20.
  * This was not intended to be exposed.
  * Please talk to us if you need this.
  */

package/src/plugins/js/project-graph/build-dependencies/typescript-import-locator.js

@@ -7,7 +7,7 @@ const file_utils_1 = require("../../../../project-graph/file-utils");
 const strip_source_code_1 = require("./strip-source-code");
 let tsModule;
 /**
- * @deprecated This is deprecated and will be removed in Nx 19.
+ * @deprecated This is deprecated and will be removed in Nx 20.
  * This was not intended to be exposed.
  * Please talk to us if you need this.
  */

package/src/project-graph/project-graph-builder.d.ts

@@ -5,7 +5,7 @@ import { DependencyType, FileMap, ProjectFileMap, ProjectGraph, ProjectGraphExte
 import { CreateDependenciesContext } from './plugins';
 /**
  * A class which builds up a project graph
- * @deprecated The {@link ProjectGraphProcessor} has been deprecated. Use a {@link CreateNodes} and/or a {@link CreateDependencies} instead. This will be removed in Nx 19.
+ * @deprecated The {@link ProjectGraphProcessor} has been deprecated. Use a {@link CreateNodes} and/or a {@link CreateDependencies} instead. This will be removed in Nx 20.
  */
 export declare class ProjectGraphBuilder {
     readonly graph: ProjectGraph;

package/src/project-graph/project-graph-builder.js

@@ -8,7 +8,7 @@ const project_graph_1 = require("../config/project-graph");
 const build_project_graph_1 = require("./build-project-graph");
 /**
  * A class which builds up a project graph
- * @deprecated The {@link ProjectGraphProcessor} has been deprecated. Use a {@link CreateNodes} and/or a {@link CreateDependencies} instead. This will be removed in Nx 19.
+ * @deprecated The {@link ProjectGraphProcessor} has been deprecated. Use a {@link CreateNodes} and/or a {@link CreateDependencies} instead. This will be removed in Nx 20.
  */
 class ProjectGraphBuilder {
     constructor(graph, projectFileMap, nonProjectFiles) {

package/src/tasks-runner/init-tasks-runner.js

@@ -21,7 +21,7 @@ async function initTasksRunner(nxArgs) {
     return {
         invoke: async (opts) => {
             perf_hooks_1.performance.mark('code-loading:end');
-            // TODO: This polyfills the outputs if someone doesn't pass a task with outputs. Remove this in Nx 19
+            // TODO: This polyfills the outputs if someone doesn't pass a task with outputs. Remove this in Nx 20
             opts.tasks.forEach((t) => {
                 if (!t.outputs) {
                     t.outputs = (0, utils_1.getOutputs)(projectGraph.nodes, t.target, t.overrides);

package/src/tasks-runner/utils.d.ts

@@ -18,7 +18,7 @@ declare class InvalidOutputsError extends Error {
 export declare function validateOutputs(outputs: string[]): void;
 export declare function transformLegacyOutputs(projectRoot: string, error: InvalidOutputsError): string[];
 /**
- * @deprecated Pass the target and overrides instead. This will be removed in v19.
+ * @deprecated Pass the target and overrides instead. This will be removed in v20.
  */
 export declare function getOutputsForTargetAndConfiguration(task: Task, node: ProjectGraphProjectNode): string[];
 export declare function getOutputsForTargetAndConfiguration(target: Task['target'] | Task, overrides: Task['overrides'] | ProjectGraphProjectNode, node: ProjectGraphProjectNode): string[];

package/src/utils/async-iterator.d.ts

@@ -1,2 +1,2 @@
 export declare function isAsyncIterator<T>(v: any): v is AsyncIterableIterator<T>;
-export declare function getLastValueFromAsyncIterableIterator<T>(i: AsyncIterableIterator<T>): Promise<T>;
+export declare function getLastValueFromAsyncIterableIterator<T>(i: AsyncIterable<T> | AsyncIterableIterator<T>): Promise<T>;

package/src/utils/async-iterator.js

@@ -8,9 +8,11 @@ exports.isAsyncIterator = isAsyncIterator;
 async function getLastValueFromAsyncIterableIterator(i) {
     let prev;
     let current;
+    const generator = i[Symbol.asyncIterator] || i[Symbol.iterator];
+    const iterator = generator.call(i);
     do {
         prev = current;
-        current = await i.next();
+        current = await iterator.next();
     } while (!current.done);
     return current.value !== undefined || !prev ? current.value : prev.value;
 }

package/src/utils/nx-plugin.deprecated.d.ts

@@ -2,26 +2,26 @@ import { ProjectGraphProcessor } from '../config/project-graph';
 import { TargetConfiguration } from '../config/workspace-json-project-json';
 import { NxPluginV2 } from '../project-graph/plugins';
 /**
- * @deprecated Add targets to the projects in a {@link CreateNodes} function instead. This will be removed in Nx 19
+ * @deprecated Add targets to the projects in a {@link CreateNodes} function instead. This will be removed in Nx 20
  */
 export type ProjectTargetConfigurator = (file: string) => Record<string, TargetConfiguration>;
 /**
- * @deprecated Use {@link NxPluginV2} instead. This will be removed in Nx 19
+ * @deprecated Use {@link NxPluginV2} instead. This will be removed in Nx 20
  */
 export type NxPluginV1 = {
     name: string;
     /**
-     * @deprecated Use {@link CreateNodes} and {@link CreateDependencies} instead. This will be removed in Nx 19
+     * @deprecated Use {@link CreateNodes} and {@link CreateDependencies} instead. This will be removed in Nx 20
      */
     processProjectGraph?: ProjectGraphProcessor;
     /**
-     * @deprecated Add targets to the projects inside of {@link CreateNodes} instead. This will be removed in Nx 19
+     * @deprecated Add targets to the projects inside of {@link CreateNodes} instead. This will be removed in Nx 20
      */
     registerProjectTargets?: ProjectTargetConfigurator;
     /**
      * A glob pattern to search for non-standard project files.
      * @example: ["*.csproj", "pom.xml"]
-     * @deprecated Use {@link CreateNodes} instead. This will be removed in Nx 19
+     * @deprecated Use {@link CreateNodes} instead. This will be removed in Nx 20
      */
     projectFilePatterns?: string[];
 };

package/src/command-line/affected/print-affected.d.ts

@@ -1,11 +0,0 @@
-import * as yargs from 'yargs';
-import type { NxArgs } from '../../utils/command-line-utils';
-import { ProjectGraph, ProjectGraphProjectNode } from '../../config/project-graph';
-import { NxJsonConfiguration } from '../../config/nx-json';
-/**
- * @deprecated Use showProjectsHandler, generateGraph, or affected (without the print-affected mode) instead.
- */
-export declare function printAffected(affectedProjects: ProjectGraphProjectNode[], projectGraph: ProjectGraph, { nxJson }: {
-    nxJson: NxJsonConfiguration;
-}, nxArgs: NxArgs, overrides: yargs.Arguments): Promise<void>;
-export declare function selectPrintAffected(wholeJson: any, wholeSelect: string): any;

package/src/command-line/affected/print-affected.js

@@ -1,108 +0,0 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.selectPrintAffected = exports.printAffected = void 0;
-const utils_1 = require("../../tasks-runner/utils");
-const create_task_graph_1 = require("../../tasks-runner/create-task-graph");
-const task_hasher_1 = require("../../hasher/task-hasher");
-const hash_task_1 = require("../../hasher/hash-task");
-const package_manager_1 = require("../../utils/package-manager");
-const command_object_1 = require("./command-object");
-const logger_1 = require("../../utils/logger");
-const task_env_1 = require("../../tasks-runner/task-env");
-const build_project_graph_1 = require("../../project-graph/build-project-graph");
-const client_1 = require("../../daemon/client/client");
-/**
- * @deprecated Use showProjectsHandler, generateGraph, or affected (without the print-affected mode) instead.
- */
-async function printAffected(affectedProjects, projectGraph, { nxJson }, nxArgs, overrides) {
-    logger_1.logger.warn([logger_1.NX_PREFIX, command_object_1.printAffectedDeprecationMessage].join(' '));
-    const projectsForType = affectedProjects.filter((p) => nxArgs.type ? p.type === nxArgs.type : true);
-    const projectNames = projectsForType.map((p) => p.name);
-    const tasksJson = nxArgs.targets && nxArgs.targets.length > 0
-        ? await createTasks(projectsForType, projectGraph, nxArgs, nxJson, overrides)
-        : [];
-    const result = {
-        tasks: tasksJson,
-        projects: projectNames,
-        projectGraph: serializeProjectGraph(projectGraph),
-    };
-    if (nxArgs.select) {
-        console.log(selectPrintAffected(result, nxArgs.select));
-    }
-    else {
-        console.log(JSON.stringify(selectPrintAffected(result, null), null, 2));
-    }
-}
-exports.printAffected = printAffected;
-async function createTasks(affectedProjectsWithTargetAndConfig, projectGraph, nxArgs, nxJson, overrides) {
-    const defaultDependencyConfigs = (0, create_task_graph_1.mapTargetDefaultsToDependencies)(nxJson.targetDefaults);
-    const taskGraph = (0, create_task_graph_1.createTaskGraph)(projectGraph, defaultDependencyConfigs, affectedProjectsWithTargetAndConfig.map((p) => p.name), nxArgs.targets, nxArgs.configuration, overrides);
-    let hasher;
-    if (client_1.daemonClient.enabled()) {
-        hasher = new task_hasher_1.DaemonBasedTaskHasher(client_1.daemonClient, {});
-    }
-    else {
-        const { fileMap, allWorkspaceFiles, rustReferences } = (0, build_project_graph_1.getFileMap)();
-        hasher = new task_hasher_1.InProcessTaskHasher(fileMap?.projectFileMap, allWorkspaceFiles, projectGraph, nxJson, rustReferences, {});
-    }
-    const execCommand = (0, package_manager_1.getPackageManagerCommand)().exec;
-    const tasks = Object.values(taskGraph.tasks);
-    await Promise.all(tasks.map((t) => (0, hash_task_1.hashTask)(hasher, projectGraph, taskGraph, t, 
-    // This loads dotenv files for the task
-    (0, task_env_1.getTaskSpecificEnv)(t))));
-    return tasks.map((task) => ({
-        id: task.id,
-        overrides,
-        target: task.target,
-        hash: task.hash,
-        command: (0, utils_1.getCommandAsString)(execCommand, task),
-        outputs: task.outputs,
-    }));
-}
-function serializeProjectGraph(projectGraph) {
-    const nodes = Object.values(projectGraph.nodes).map((n) => n.name);
-    const dependencies = {};
-    // we don't need external dependencies' dependencies for print-affected
-    // having them included makes the output unreadable
-    Object.keys(projectGraph.dependencies).forEach((key) => {
-        if (!key.startsWith('npm:')) {
-            dependencies[key] = projectGraph.dependencies[key];
-        }
-    });
-    return { nodes, dependencies };
-}
-function selectPrintAffected(wholeJson, wholeSelect) {
-    if (!wholeSelect)
-        return wholeJson;
-    return _select(wholeJson, wholeSelect);
-    function _select(json, select) {
-        if (select.indexOf('.') > -1) {
-            const [firstKey, ...restKeys] = select.split('.');
-            const first = json[firstKey];
-            throwIfEmpty(wholeSelect, first);
-            const rest = restKeys.join('.');
-            if (Array.isArray(first)) {
-                return first.map((q) => _select(q, rest)).join(', ');
-            }
-            else {
-                return _select(first, rest);
-            }
-        }
-        else {
-            const res = json[select];
-            throwIfEmpty(wholeSelect, res);
-            if (Array.isArray(res)) {
-                return res.join(', ');
-            }
-            else {
-                return res;
-            }
-        }
-    }
-}
-exports.selectPrintAffected = selectPrintAffected;
-function throwIfEmpty(select, value) {
-    if (value === undefined) {
-        throw new Error(`Cannot select '${select}' in the results of print-affected.`);
-    }
-}