nx 19.1.0-canary.20240507-1fe262a → 19.1.0-canary.20240508-fd78152

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nx",
-  "version": "19.1.0-canary.20240507-1fe262a",
+  "version": "19.1.0-canary.20240508-fd78152",
   "private": false,
   "description": "The core Nx plugin contains the core functionality of Nx like the project graph, nx commands and task orchestration.",
   "repository": {
@@ -66,7 +66,7 @@
     "yargs-parser": "21.1.1",
     "node-machine-id": "1.1.12",
     "ora": "5.3.0",
-    "@nrwl/tao": "19.1.0-canary.20240507-1fe262a"
+    "@nrwl/tao": "19.1.0-canary.20240508-fd78152"
   },
   "peerDependencies": {
     "@swc-node/register": "^1.8.0",
@@ -81,16 +81,16 @@
     }
   },
   "optionalDependencies": {
-    "@nx/nx-darwin-x64": "19.1.0-canary.20240507-1fe262a",
-    "@nx/nx-darwin-arm64": "19.1.0-canary.20240507-1fe262a",
-    "@nx/nx-linux-x64-gnu": "19.1.0-canary.20240507-1fe262a",
-    "@nx/nx-linux-x64-musl": "19.1.0-canary.20240507-1fe262a",
-    "@nx/nx-win32-x64-msvc": "19.1.0-canary.20240507-1fe262a",
-    "@nx/nx-linux-arm64-gnu": "19.1.0-canary.20240507-1fe262a",
-    "@nx/nx-linux-arm64-musl": "19.1.0-canary.20240507-1fe262a",
-    "@nx/nx-linux-arm-gnueabihf": "19.1.0-canary.20240507-1fe262a",
-    "@nx/nx-win32-arm64-msvc": "19.1.0-canary.20240507-1fe262a",
-    "@nx/nx-freebsd-x64": "19.1.0-canary.20240507-1fe262a"
+    "@nx/nx-darwin-x64": "19.1.0-canary.20240508-fd78152",
+    "@nx/nx-darwin-arm64": "19.1.0-canary.20240508-fd78152",
+    "@nx/nx-linux-x64-gnu": "19.1.0-canary.20240508-fd78152",
+    "@nx/nx-linux-x64-musl": "19.1.0-canary.20240508-fd78152",
+    "@nx/nx-win32-x64-msvc": "19.1.0-canary.20240508-fd78152",
+    "@nx/nx-linux-arm64-gnu": "19.1.0-canary.20240508-fd78152",
+    "@nx/nx-linux-arm64-musl": "19.1.0-canary.20240508-fd78152",
+    "@nx/nx-linux-arm-gnueabihf": "19.1.0-canary.20240508-fd78152",
+    "@nx/nx-win32-arm64-msvc": "19.1.0-canary.20240508-fd78152",
+    "@nx/nx-freebsd-x64": "19.1.0-canary.20240508-fd78152"
   },
   "nx-migrations": {
     "migrations": "./migrations.json",

package/src/command-line/migrate/migrate.js

@@ -746,19 +746,6 @@ async function generateMigrationsJsonAndUpdatePackageJson(root, opts) {
         const originalNxJson = (0, configuration_1.readNxJson)();
         const from = originalNxJson.installation?.version ??
             readNxVersion(originalPackageJson);
-        try {
-            if (['nx', '@nrwl/workspace'].includes(opts.targetPackage) &&
-                (await isMigratingToNewMajor(from, opts.targetVersion)) &&
-                !(0, is_ci_1.isCI)() &&
-                !(0, nx_cloud_utils_1.isNxCloudUsed)(originalNxJson)) {
-                await (0, connect_to_nx_cloud_1.connectToNxCloudWithPrompt)('migrate');
-                originalPackageJson = (0, fileutils_1.readJsonFile)((0, path_1.join)(root, 'package.json'));
-            }
-        }
-        catch {
-            // The above code is to remind folks when updating to a new major and not currently using Nx cloud.
-            // If for some reason it fails, it shouldn't affect the overall migration process
-        }
         logger_1.logger.info(`Fetching meta data about packages.`);
         logger_1.logger.info(`It may take a few minutes.`);
         const migrator = new Migrator({
@@ -789,6 +776,28 @@ async function generateMigrationsJsonAndUpdatePackageJson(root, opts) {
                     : `- There are no migrations to run, so migrations.json has not been created.`,
             ],
         });
+        try {
+            if (['nx', '@nrwl/workspace'].includes(opts.targetPackage) &&
+                (await isMigratingToNewMajor(from, opts.targetVersion)) &&
+                !(0, is_ci_1.isCI)() &&
+                !(0, nx_cloud_utils_1.isNxCloudUsed)(originalNxJson)) {
+                output_1.output.success({
+                    title: 'Connect to Nx Cloud',
+                    bodyLines: [
+                        'Nx Cloud is a first-party CI companion for Nx projects. It improves critical aspects of CI:',
+                        '- Speed: 30% - 70% faster CI',
+                        '- Cost: 40% - 75% reduction in CI costs',
+                        '- Reliability: by automatically identifying flaky tasks and re-running them',
+                    ],
+                });
+                await (0, connect_to_nx_cloud_1.connectToNxCloudWithPrompt)('migrate');
+                originalPackageJson = (0, fileutils_1.readJsonFile)((0, path_1.join)(root, 'package.json'));
+            }
+        }
+        catch {
+            // The above code is to remind folks when updating to a new major and not currently using Nx cloud.
+            // If for some reason it fails, it shouldn't affect the overall migration process
+        }
         output_1.output.log({
             title: 'Next steps:',
             bodyLines: [

package/src/command-line/show/command-object.d.ts

@@ -4,17 +4,18 @@ export interface NxShowArgs {
     json?: boolean;
 }
 export type ShowProjectsOptions = NxShowArgs & {
-    exclude: string;
-    files: string;
-    uncommitted: any;
-    untracked: any;
-    base: string;
-    head: string;
-    affected: boolean;
-    type: ProjectGraphProjectNode['type'];
-    projects: string[];
-    withTarget: string[];
-    verbose: boolean;
+    exclude?: string[];
+    files?: string;
+    uncommitted?: any;
+    untracked?: any;
+    base?: string;
+    head?: string;
+    affected?: boolean;
+    type?: ProjectGraphProjectNode['type'];
+    projects?: string[];
+    withTarget?: string[];
+    verbose?: boolean;
+    sep?: string;
 };
 export type ShowProjectOptions = NxShowArgs & {
     projectName: string;

package/src/command-line/show/command-object.js

@@ -47,12 +47,18 @@ const showProjectsCommand = {
         type: 'string',
         description: 'Select only projects of the given type',
         choices: ['app', 'lib', 'e2e'],
+    })
+        .option('sep', {
+        type: 'string',
+        description: 'Outputs projects with the specified seperator',
     })
         .implies('untracked', 'affected')
         .implies('uncommitted', 'affected')
         .implies('files', 'affected')
         .implies('base', 'affected')
         .implies('head', 'affected')
+        .conflicts('sep', 'json')
+        .conflicts('json', 'sep')
         .example('$0 show projects --projects "apps/*"', 'Show all projects in the apps directory')
         .example('$0 show projects --projects "shared-*"', 'Show all projects that start with "shared-"')
         .example('$0 show projects --affected', 'Show affected projects in the workspace')
@@ -60,7 +66,9 @@ const showProjectsCommand = {
         .example('$0 show projects --affected --exclude=*-e2e', 'Show affected projects in the workspace, excluding end-to-end projects'),
     handler: (args) => {
         return (0, params_1.handleErrors)(args.verbose ?? process.env.NX_VERBOSE_LOGGING === 'true', async () => {
-            return (await Promise.resolve().then(() => require('./show'))).showProjectsHandler(args);
+            const { showProjectsHandler } = await Promise.resolve().then(() => require('./projects'));
+            await showProjectsHandler(args);
+            process.exit(0);
         });
     },
 };
@@ -82,16 +90,15 @@ const showProjectCommand = {
         type: 'boolean',
         description: 'Prints additional information about the commands (e.g., stack traces)',
     })
-        .check((argv) => {
-        if (argv.web) {
-            argv.json = false;
-        }
-        return true;
-    })
-        .example('$0 show project my-app', 'View project information for my-app in JSON format'),
+        .conflicts('json', 'web')
+        .conflicts('web', 'json')
+        .example('$0 show project my-app', 'View project information for my-app in JSON format')
+        .example('$0 show project my-app --web', 'View project information for my-app in the browser'),
     handler: (args) => {
         return (0, params_1.handleErrors)(args.verbose ?? process.env.NX_VERBOSE_LOGGING === 'true', async () => {
-            return (await Promise.resolve().then(() => require('./show'))).showProjectHandler(args);
+            const { showProjectHandler } = await Promise.resolve().then(() => require('./project'));
+            await showProjectHandler(args);
+            process.exit(0);
         });
     },
 };

package/src/command-line/show/project.d.ts

@@ -0,0 +1,2 @@
+import { ShowProjectOptions } from './command-object';
+export declare function showProjectHandler(args: ShowProjectOptions): Promise<void>;

package/src/command-line/show/project.js

@@ -0,0 +1,55 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.showProjectHandler = void 0;
+const output_1 = require("../../utils/output");
+const project_graph_1 = require("../../project-graph/project-graph");
+const graph_1 = require("../graph/graph");
+async function showProjectHandler(args) {
+    const graph = await (0, project_graph_1.createProjectGraphAsync)();
+    const node = graph.nodes[args.projectName];
+    if (!node) {
+        console.log(`Could not find project ${args.projectName}`);
+        process.exit(1);
+    }
+    if (args.json) {
+        console.log(JSON.stringify(node.data));
+    }
+    else if (args.web) {
+        await (0, graph_1.generateGraph)({
+            view: 'project-details',
+            focus: node.name,
+            watch: true,
+            open: true,
+        }, []);
+    }
+    else {
+        const chalk = require('chalk');
+        const logIfExists = (label, key) => {
+            if (node.data[key]) {
+                console.log(`${chalk.bold(label)}: ${node.data[key]}`);
+            }
+        };
+        logIfExists('Name', 'name');
+        logIfExists('Root', 'root');
+        logIfExists('Source Root', 'sourceRoot');
+        logIfExists('Tags', 'tags');
+        logIfExists('Implicit Dependencies', 'implicitDependencies');
+        const targets = Object.entries(node.data.targets ?? {});
+        const maxTargetNameLength = Math.max(...targets.map(([t]) => t.length));
+        const maxExecutorNameLength = Math.max(...targets.map(([, t]) => t?.executor?.length ?? 0));
+        if (targets.length > 0) {
+            console.log(`${chalk.bold('Targets')}: `);
+            for (const [target, targetConfig] of targets) {
+                console.log(`- ${chalk.bold((target + ':').padEnd(maxTargetNameLength + 2))} ${(targetConfig?.executor ?? '').padEnd(maxExecutorNameLength + 2)} ${(() => {
+                    const configurations = Object.keys(targetConfig.configurations ?? {});
+                    if (configurations.length) {
+                        return chalk.dim(configurations.join(', '));
+                    }
+                    return '';
+                })()}`);
+            }
+        }
+    }
+    await output_1.output.drain();
+}
+exports.showProjectHandler = showProjectHandler;

package/src/command-line/show/projects.d.ts

@@ -0,0 +1,2 @@
+import { ShowProjectsOptions } from './command-object';
+export declare function showProjectsHandler(args: ShowProjectsOptions): Promise<void>;

package/src/command-line/show/{show.js → projects.js}

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.showProjectHandler = exports.showProjectsHandler = void 0;
+exports.showProjectsHandler = void 0;
 const output_1 = require("../../utils/output");
 const nx_json_1 = require("../../config/nx-json");
 const affected_project_graph_1 = require("../../project-graph/affected/affected-project-graph");
@@ -10,7 +10,6 @@ const project_graph_1 = require("../../project-graph/project-graph");
 const all_file_data_1 = require("../../utils/all-file-data");
 const command_line_utils_1 = require("../../utils/command-line-utils");
 const find_matching_projects_1 = require("../../utils/find-matching-projects");
-const graph_1 = require("../graph/graph");
 async function showProjectsHandler(args) {
     let graph = await (0, project_graph_1.createProjectGraphAsync)();
     const nxJson = (0, nx_json_1.readNxJson)();
@@ -52,64 +51,17 @@ async function showProjectsHandler(args) {
     if (args.json) {
         console.log(JSON.stringify(Array.from(selectedProjects)));
     }
+    else if (args.sep) {
+        console.log(Array.from(selectedProjects.values()).join(args.sep));
+    }
     else {
         for (const project of selectedProjects) {
             console.log(project);
         }
     }
     await output_1.output.drain();
-    process.exit(0);
 }
 exports.showProjectsHandler = showProjectsHandler;
-async function showProjectHandler(args) {
-    const graph = await (0, project_graph_1.createProjectGraphAsync)();
-    const node = graph.nodes[args.projectName];
-    if (!node) {
-        console.log(`Could not find project ${args.projectName}`);
-        process.exit(1);
-    }
-    if (args.json) {
-        console.log(JSON.stringify(node.data));
-    }
-    else if (args.web) {
-        await (0, graph_1.generateGraph)({
-            view: 'project-details',
-            focus: node.name,
-            watch: true,
-            open: true,
-        }, []);
-    }
-    else {
-        const chalk = require('chalk');
-        const logIfExists = (label, key) => {
-            if (node.data[key]) {
-                console.log(`${chalk.bold(label)}: ${node.data[key]}`);
-            }
-        };
-        logIfExists('Name', 'name');
-        logIfExists('Root', 'root');
-        logIfExists('Source Root', 'sourceRoot');
-        logIfExists('Tags', 'tags');
-        logIfExists('Implicit Dependencies', 'implicitDependencies');
-        const targets = Object.entries(node.data.targets ?? {});
-        const maxTargetNameLength = Math.max(...targets.map(([t]) => t.length));
-        const maxExecutorNameLength = Math.max(...targets.map(([, t]) => t?.executor?.length ?? 0));
-        if (targets.length > 0) {
-            console.log(`${chalk.bold('Targets')}: `);
-            for (const [target, targetConfig] of targets) {
-                console.log(`- ${chalk.bold((target + ':').padEnd(maxTargetNameLength + 2))} ${(targetConfig?.executor ?? '').padEnd(maxExecutorNameLength + 2)} ${(() => {
-                    const configurations = Object.keys(targetConfig.configurations ?? {});
-                    if (configurations.length) {
-                        return chalk.dim(configurations.join(', '));
-                    }
-                    return '';
-                })()}`);
-            }
-        }
-    }
-    process.exit(0);
-}
-exports.showProjectHandler = showProjectHandler;
 function getGraphNodesMatchingPatterns(graph, patterns) {
     const nodes = {};
     const matches = (0, find_matching_projects_1.findMatchingProjects)(patterns, graph.nodes);

package/src/project-graph/utils/retrieve-workspace-files.d.ts

@@ -9,12 +9,12 @@ import { LoadedNxPlugin } from '../plugins/internal-api';
  * @param nxJson
  */
 export declare function retrieveWorkspaceFiles(workspaceRoot: string, projectRootMap: Record<string, string>): Promise<{
-    allWorkspaceFiles: import("nx/src/devkit-exports").FileData[];
+    allWorkspaceFiles: import("../file-utils").FileData[];
     fileMap: {
         projectFileMap: ProjectFiles;
-        nonProjectFiles: import("nx/src/native").FileData[];
+        nonProjectFiles: import("../../native").FileData[];
     };
-    rustReferences: import("nx/src/native").NxWorkspaceFilesExternals;
+    rustReferences: import("../../native").NxWorkspaceFilesExternals;
 }>;
 /**
  * Walk through the workspace and return `ProjectConfigurations`. Only use this if the projectFileMap is not needed.

package/src/utils/ab-testing.d.ts

@@ -11,7 +11,7 @@ declare const messageOptions: {
             readonly value: "skip";
             readonly name: "Skip for now";
         }];
-        readonly footer: "\nRead more about remote cache at https://nx.dev/ci/features/remote-cache";
+        readonly footer: "\nWatch a short video on Nx Cloud at https://nx.dev/ci/intro/why-nx-cloud";
         readonly hint: "\n(it's free and can be disabled any time)";
     }];
     readonly setupViewLogs: readonly [{

package/src/utils/ab-testing.js

@@ -12,7 +12,7 @@ const messageOptions = {
                 { value: 'yes', name: 'Yes' },
                 { value: 'skip', name: 'Skip for now' },
             ],
-            footer: '\nRead more about remote cache at https://nx.dev/ci/features/remote-cache',
+            footer: '\nWatch a short video on Nx Cloud at https://nx.dev/ci/intro/why-nx-cloud',
             hint: `\n(it's free and can be disabled any time)`,
         },
     ],
@@ -67,7 +67,7 @@ async function recordStat(opts) {
         if (process.env.NX_VERBOSE_LOGGING === 'true') {
             console.log(`Record stat. Major: ${major}`);
         }
-        if (major < 10 || major > 16)
+        if (major < 10 || major > 19)
             return; // test version, skip it
         const axios = require('axios');
         await (axios['default'] ?? axios)

package/src/command-line/show/show.d.ts

@@ -1,3 +0,0 @@
-import { ShowProjectOptions, ShowProjectsOptions } from './command-object';
-export declare function showProjectsHandler(args: ShowProjectsOptions): Promise<void>;
-export declare function showProjectHandler(args: ShowProjectOptions): Promise<void>;