nx 19.0.6 → 19.0.7

package/bin/init-local.js

@@ -132,7 +132,7 @@ function handleAngularCLIFallbacks(workspace) {
     else if (process.argv[2] === 'cache') {
         console.log(`"ng cache" is not natively supported by Nx.
 To clear the cache, you can delete the ".angular/cache" directory (or the directory configured by "cli.cache.path" in the "nx.json" file).
-To update the cache configuration, you can directly update the relevant options in your "nx.json" file (https://angular.io/guide/workspace-config#cache-options).`);
+To update the cache configuration, you can directly update the relevant options in your "nx.json" file (https://angular.dev/reference/configs/workspace-config#cache-options).`);
     }
     else {
         try {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nx",
-  "version": "19.0.6",
+  "version": "19.0.7",
   "private": false,
   "description": "The core Nx plugin contains the core functionality of Nx like the project graph, nx commands and task orchestration.",
   "repository": {
@@ -20,7 +20,11 @@
     "Nest",
     "Jest",
     "Cypress",
-    "CLI"
+    "CLI",
+    "Testing",
+    "Front-end",
+    "Backend",
+    "Mobile"
   ],
   "bin": {
     "nx": "./bin/nx.js",
@@ -65,7 +69,7 @@
     "yargs-parser": "21.1.1",
     "node-machine-id": "1.1.12",
     "ora": "5.3.0",
-    "@nrwl/tao": "19.0.6"
+    "@nrwl/tao": "19.0.7"
   },
   "peerDependencies": {
     "@swc-node/register": "^1.8.0",
@@ -80,16 +84,16 @@
     }
   },
   "optionalDependencies": {
-    "@nx/nx-darwin-x64": "19.0.6",
-    "@nx/nx-darwin-arm64": "19.0.6",
-    "@nx/nx-linux-x64-gnu": "19.0.6",
-    "@nx/nx-linux-x64-musl": "19.0.6",
-    "@nx/nx-win32-x64-msvc": "19.0.6",
-    "@nx/nx-linux-arm64-gnu": "19.0.6",
-    "@nx/nx-linux-arm64-musl": "19.0.6",
-    "@nx/nx-linux-arm-gnueabihf": "19.0.6",
-    "@nx/nx-win32-arm64-msvc": "19.0.6",
-    "@nx/nx-freebsd-x64": "19.0.6"
+    "@nx/nx-darwin-x64": "19.0.7",
+    "@nx/nx-darwin-arm64": "19.0.7",
+    "@nx/nx-linux-x64-gnu": "19.0.7",
+    "@nx/nx-linux-x64-musl": "19.0.7",
+    "@nx/nx-win32-x64-msvc": "19.0.7",
+    "@nx/nx-linux-arm64-gnu": "19.0.7",
+    "@nx/nx-linux-arm64-musl": "19.0.7",
+    "@nx/nx-linux-arm-gnueabihf": "19.0.7",
+    "@nx/nx-win32-arm64-msvc": "19.0.7",
+    "@nx/nx-freebsd-x64": "19.0.7"
   },
   "nx-migrations": {
     "migrations": "./migrations.json",

package/src/command-line/format/format.js

@@ -1,23 +1,23 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.format = void 0;
-const child_process_1 = require("child_process");
-const path = require("path");
+const node_child_process_1 = require("node:child_process");
+const path = require("node:path");
+const file_utils_1 = require("../../project-graph/file-utils");
 const command_line_utils_1 = require("../../utils/command-line-utils");
-const ignore_1 = require("../../utils/ignore");
 const fileutils_1 = require("../../utils/fileutils");
-const file_utils_1 = require("../../project-graph/file-utils");
+const ignore_1 = require("../../utils/ignore");
 const prettier = require("prettier");
-const object_sort_1 = require("../../utils/object-sort");
-const package_json_1 = require("../../utils/package-json");
+const configuration_1 = require("../../config/configuration");
 const typescript_1 = require("../../plugins/js/utils/typescript");
-const project_graph_1 = require("../../project-graph/project-graph");
 const affected_project_graph_1 = require("../../project-graph/affected/affected-project-graph");
-const configuration_1 = require("../../config/configuration");
-const chunkify_1 = require("../../utils/chunkify");
+const project_graph_1 = require("../../project-graph/project-graph");
 const all_file_data_1 = require("../../utils/all-file-data");
-const workspace_root_1 = require("../../utils/workspace-root");
+const chunkify_1 = require("../../utils/chunkify");
+const object_sort_1 = require("../../utils/object-sort");
 const output_1 = require("../../utils/output");
+const package_json_1 = require("../../utils/package-json");
+const workspace_root_1 = require("../../utils/workspace-root");
 const PRETTIER_PATH = getPrettierPath();
 async function format(command, args) {
     const { nxArgs } = (0, command_line_utils_1.splitArgsIntoNxArgsAndOverrides)(args, 'affected', { printWarnings: false }, (0, configuration_1.readNxJson)());
@@ -33,12 +33,31 @@ async function format(command, args) {
             addRootConfigFiles(chunkList, nxArgs);
             chunkList.forEach((chunk) => write(chunk));
             break;
-        case 'check':
-            const pass = chunkList.reduce((pass, chunk) => check(chunk) && pass, true);
-            if (!pass) {
+        case 'check': {
+            const filesWithDifferentFormatting = [];
+            for (const chunk of chunkList) {
+                const files = await check(chunk);
+                filesWithDifferentFormatting.push(...files);
+            }
+            if (filesWithDifferentFormatting.length > 0) {
+                if (nxArgs.verbose) {
+                    output_1.output.error({
+                        title: 'The following files are not formatted correctly based on your Prettier configuration',
+                        bodyLines: [
+                            '- Run "nx format:write" and commit the resulting diff to fix these files.',
+                            '- Please note, Prettier does not support a native way to diff the output of its check logic (https://github.com/prettier/prettier/issues/6885).',
+                            '',
+                            ...filesWithDifferentFormatting,
+                        ],
+                    });
+                }
+                else {
+                    console.log(filesWithDifferentFormatting.join('\n'));
+                }
                 process.exit(1);
             }
             break;
+        }
     }
 }
 exports.format = format;
@@ -113,29 +132,32 @@ function write(patterns) {
             result[pattern.includes('.swcrc') ? 0 : 1].push(pattern);
             return result;
         }, [[], []]);
-        (0, child_process_1.execSync)(`node "${PRETTIER_PATH}" --write --list-different ${regularPatterns.join(' ')}`, {
+        (0, node_child_process_1.execSync)(`node "${PRETTIER_PATH}" --write --list-different ${regularPatterns.join(' ')}`, {
             stdio: [0, 1, 2],
         });
         if (swcrcPatterns.length > 0) {
-            (0, child_process_1.execSync)(`node "${PRETTIER_PATH}" --write --list-different ${swcrcPatterns.join(' ')} --parser json`, {
+            (0, node_child_process_1.execSync)(`node "${PRETTIER_PATH}" --write --list-different ${swcrcPatterns.join(' ')} --parser json`, {
                 stdio: [0, 1, 2],
             });
         }
     }
 }
-function check(patterns) {
+async function check(patterns) {
     if (patterns.length === 0) {
-        return true;
+        return [];
     }
-    try {
-        (0, child_process_1.execSync)(`node "${PRETTIER_PATH}" --list-different ${patterns.join(' ')}`, {
-            stdio: [0, 1, 2],
+    return new Promise((resolve) => {
+        (0, node_child_process_1.exec)(`node "${PRETTIER_PATH}" --list-different ${patterns.join(' ')}`, { encoding: 'utf-8' }, (error, stdout) => {
+            if (error) {
+                // The command failed so there are files with different formatting. Prettier writes them to stdout, newline separated.
+                resolve(stdout.trim().split('\n'));
+            }
+            else {
+                // The command succeeded so there are no files with different formatting
+                resolve([]);
+            }
         });
-        return true;
-    }
-    catch {
-        return false;
-    }
+    });
 }
 function sortTsConfig() {
     try {

package/src/utils/package-json.d.ts

@@ -1,4 +1,5 @@
 import { InputDefinition, TargetConfiguration } from '../config/workspace-json-project-json';
+import { PackageManagerCommands } from './package-manager';
 export interface NxProjectPackageJsonConfiguration {
     implicitDependencies?: string[];
     tags?: string[];
@@ -65,7 +66,7 @@ export declare function normalizePackageGroup(packageGroup: PackageGroup): Array
 export declare function readNxMigrateConfig(json: Partial<PackageJson>): NxMigrationsConfiguration & {
     packageGroup?: ArrayPackageGroup;
 };
-export declare function buildTargetFromScript(script: string, scripts?: Record<string, string>): TargetConfiguration;
+export declare function buildTargetFromScript(script: string, scripts: Record<string, string>, packageManagerCommand: PackageManagerCommands): TargetConfiguration;
 export declare function readTargetsFromPackageJson(packageJson: PackageJson): Record<string, TargetConfiguration<any>>;
 /**
  * Uses `require.resolve` to read the package.json for a module.

package/src/utils/package-json.js

@@ -39,8 +39,7 @@ function readNxMigrateConfig(json) {
     };
 }
 exports.readNxMigrateConfig = readNxMigrateConfig;
-function buildTargetFromScript(script, scripts = {}) {
-    const packageManagerCommand = (0, package_manager_1.getPackageManagerCommand)();
+function buildTargetFromScript(script, scripts = {}, packageManagerCommand) {
     return {
         executor: 'nx:run-script',
         options: {
@@ -57,9 +56,9 @@ function readTargetsFromPackageJson(packageJson) {
     const { scripts, nx, private: isPrivate } = packageJson ?? {};
     const res = {};
     const includedScripts = nx?.includedScripts || Object.keys(scripts ?? {});
-    //
+    const packageManagerCommand = (0, package_manager_1.getPackageManagerCommand)();
     for (const script of includedScripts) {
-        res[script] = buildTargetFromScript(script, scripts);
+        res[script] = buildTargetFromScript(script, scripts, packageManagerCommand);
     }
     for (const targetName in nx?.targets) {
         res[targetName] = (0, project_configuration_utils_1.mergeTargetConfigurations)(nx?.targets[targetName], res[targetName]);