nx 19.0.3 → 19.0.5

package/.eslintrc.json

@@ -100,7 +100,8 @@
               "events", // This is coming from @storybook/builder-manager since it uses the browser polyfill
               "process", // This is coming from @storybook/builder-manager since it uses the browser polyfill
               "prettier", // This is coming from @storybook/builder-manager since it uses the browser polyfill
-              "util" // This is coming from @storybook/builder-manager since it uses the browser polyfill
+              "util", // This is coming from @storybook/builder-manager since it uses the browser polyfill
+              "js-yaml" // The rule is failing with alias dependencies
             ]
           }
         ]

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nx",
-  "version": "19.0.3",
+  "version": "19.0.5",
   "private": false,
   "description": "The core Nx plugin contains the core functionality of Nx like the project graph, nx commands and task orchestration.",
   "repository": {
@@ -35,7 +35,6 @@
   "dependencies": {
     "@yarnpkg/lockfile": "^1.1.0",
     "@yarnpkg/parsers": "3.0.0-rc.46",
-    "@zkochan/js-yaml": "0.0.6",
     "axios": "^1.6.0",
     "chalk": "^4.1.0",
     "cli-cursor": "3.1.0",
@@ -49,7 +48,7 @@
     "fs-extra": "^11.1.0",
     "ignore": "^5.0.4",
     "jest-diff": "^29.4.1",
-    "js-yaml": "4.1.0",
+    "js-yaml": "npm:@zkochan/js-yaml@0.0.7",
     "jsonc-parser": "3.2.0",
     "lines-and-columns": "~2.0.3",
     "minimatch": "9.0.3",
@@ -66,7 +65,7 @@
     "yargs-parser": "21.1.1",
     "node-machine-id": "1.1.12",
     "ora": "5.3.0",
-    "@nrwl/tao": "19.0.3"
+    "@nrwl/tao": "19.0.5"
   },
   "peerDependencies": {
     "@swc-node/register": "^1.8.0",
@@ -81,16 +80,16 @@
     }
   },
   "optionalDependencies": {
-    "@nx/nx-darwin-x64": "19.0.3",
-    "@nx/nx-darwin-arm64": "19.0.3",
-    "@nx/nx-linux-x64-gnu": "19.0.3",
-    "@nx/nx-linux-x64-musl": "19.0.3",
-    "@nx/nx-win32-x64-msvc": "19.0.3",
-    "@nx/nx-linux-arm64-gnu": "19.0.3",
-    "@nx/nx-linux-arm64-musl": "19.0.3",
-    "@nx/nx-linux-arm-gnueabihf": "19.0.3",
-    "@nx/nx-win32-arm64-msvc": "19.0.3",
-    "@nx/nx-freebsd-x64": "19.0.3"
+    "@nx/nx-darwin-x64": "19.0.5",
+    "@nx/nx-darwin-arm64": "19.0.5",
+    "@nx/nx-linux-x64-gnu": "19.0.5",
+    "@nx/nx-linux-x64-musl": "19.0.5",
+    "@nx/nx-win32-x64-msvc": "19.0.5",
+    "@nx/nx-linux-arm64-gnu": "19.0.5",
+    "@nx/nx-linux-arm64-musl": "19.0.5",
+    "@nx/nx-linux-arm-gnueabihf": "19.0.5",
+    "@nx/nx-win32-arm64-msvc": "19.0.5",
+    "@nx/nx-freebsd-x64": "19.0.5"
   },
   "nx-migrations": {
     "migrations": "./migrations.json",

package/src/adapter/ngcli-adapter.js

@@ -791,12 +791,10 @@ async function getWrappedWorkspaceNodeModulesArchitectHost(workspace, root, proj
             const [packageName, builderName] = builderStr.split(':');
             const { executorsFilePath, executorConfig } = this.readExecutorsJson(packageName, builderName);
             const builderInfo = this.readExecutor(packageName, builderName);
-            const { builders, executors } = (0, fileutils_1.readJsonFile)(executorsFilePath);
             return {
                 name: builderStr,
                 builderName,
-                description: builders?.[builderName]?.description ??
-                    executors?.[builderName]?.description,
+                description: executorConfig.description,
                 optionSchema: builderInfo.schema,
                 import: (0, schema_utils_1.resolveImplementation)(executorConfig.implementation, (0, path_1.dirname)(executorsFilePath)),
             };
@@ -813,6 +811,11 @@ async function getWrappedWorkspaceNodeModulesArchitectHost(workspace, root, proj
             if (!executorConfig) {
                 throw new Error(`Cannot find builder '${builder}' in ${executorsFilePath}.`);
             }
+            if (typeof executorConfig === 'string') {
+                // Angular CLI can have a builder pointing to another package:builder
+                const [packageName, executorName] = executorConfig.split(':');
+                return this.readExecutorsJson(packageName, executorName);
+            }
             return { executorsFilePath, executorConfig, isNgCompat: true };
         }
         readExecutor(nodeModule, executor) {

package/src/command-line/affected/affected.d.ts

@@ -3,5 +3,8 @@ import { ProjectGraph, ProjectGraphProjectNode } from '../../config/project-grap
 import { TargetDependencyConfig } from '../../config/workspace-json-project-json';
 export declare function affected(command: 'graph' | 'print-affected' | 'affected', args: {
     [k: string]: any;
-}, extraTargetDependencies?: Record<string, (TargetDependencyConfig | string)[]>): Promise<void>;
+}, extraTargetDependencies?: Record<string, (TargetDependencyConfig | string)[]>, extraOptions?: {
+    excludeTaskDependencies: boolean;
+    loadDotEnvFiles: boolean;
+}): Promise<void>;
 export declare function getAffectedGraphNodes(nxArgs: NxArgs, projectGraph: ProjectGraph): Promise<ProjectGraphProjectNode[]>;

package/src/command-line/affected/affected.js

@@ -15,7 +15,10 @@ const workspace_configuration_check_1 = require("../../utils/workspace-configura
 const find_matching_projects_1 = require("../../utils/find-matching-projects");
 const graph_1 = require("../graph/graph");
 const all_file_data_1 = require("../../utils/all-file-data");
-async function affected(command, args, extraTargetDependencies = {}) {
+async function affected(command, args, extraTargetDependencies = {}, extraOptions = {
+    excludeTaskDependencies: false,
+    loadDotEnvFiles: process.env.NX_LOAD_DOT_ENV_FILES !== 'false',
+}) {
     perf_hooks_1.performance.mark('code-loading:end');
     perf_hooks_1.performance.measure('code-loading', 'init-local', 'code-loading:end');
     (0, workspace_configuration_check_1.workspaceConfigurationCheck)();
@@ -46,7 +49,7 @@ async function affected(command, args, extraTargetDependencies = {}) {
                     }, projectNames);
                 }
                 else {
-                    const status = await (0, run_command_1.runCommand)(projectsWithTarget, projectGraph, { nxJson }, nxArgs, overrides, null, extraTargetDependencies, { excludeTaskDependencies: false, loadDotEnvFiles: true });
+                    const status = await (0, run_command_1.runCommand)(projectsWithTarget, projectGraph, { nxJson }, nxArgs, overrides, null, extraTargetDependencies, extraOptions);
                     process.exit(status);
                 }
                 break;

package/src/command-line/graph/graph.js

@@ -255,7 +255,7 @@ async function generateGraph(args, affectedProjects) {
             const environmentJs = buildEnvironmentJs(args.exclude || [], args.watch, !!args.file && args.file.endsWith('html') ? 'build' : 'serve', projectGraphClientResponse, taskGraphClientResponse, taskInputsReponse, sourceMaps);
             html = html.replace(/src="/g, 'src="static/');
             html = html.replace(/href="styles/g, 'href="static/styles');
-            html = html.replace('<base href="/" />', '');
+            html = html.replace(/<base href="\/".*>/g, '');
             html = html.replace(/type="module"/g, '');
             (0, fs_1.writeFileSync)(fullFilePath, html);
             (0, fs_1.writeFileSync)((0, path_1.join)(assetsFolder, 'environment.js'), environmentJs);

package/src/command-line/migrate/migrate.js

@@ -377,9 +377,9 @@ const LEGACY_NRWL_PACKAGE_GROUP = [
 ];
 async function normalizeVersionWithTagCheck(pkg, version) {
     // This doesn't seem like a valid version, lets check if its a tag on the registry.
-    if (version && !(0, semver_1.coerce)(version)) {
+    if (version && !(0, semver_1.parse)(version)) {
         try {
-            return (0, package_manager_1.packageRegistryView)(pkg, version, 'version');
+            return (0, package_manager_1.resolvePackageVersionUsingRegistry)(pkg, version);
         }
         catch {
             // fall through to old logic
@@ -634,6 +634,9 @@ async function getPackageMigrationsUsingInstall(packageName, packageVersion) {
         }
         result = { ...migrations, packageGroup, version: packageJson.version };
     }
+    catch (e) {
+        logger_1.logger.warn(`Unable to fetch migrations for ${packageName}@${packageVersion}: ${e.message}`);
+    }
     finally {
         await cleanup();
     }
@@ -871,7 +874,14 @@ function runInstall() {
     (0, child_process_1.execSync)(pmCommands.install, { stdio: [0, 1, 2] });
 }
 async function executeMigrations(root, migrations, isVerbose, shouldCreateCommits, commitPrefix) {
-    const depsBeforeMigrations = getStringifiedPackageJsonDeps(root);
+    let initialDeps = getStringifiedPackageJsonDeps(root);
+    const installDepsIfChanged = () => {
+        const currentDeps = getStringifiedPackageJsonDeps(root);
+        if (initialDeps !== currentDeps) {
+            runInstall();
+        }
+        initialDeps = currentDeps;
+    };
     const migrationsWithNoChanges = [];
     const sortedMigrations = migrations.sort((a, b) => {
         // special case for the split configuration migration to run first
@@ -912,6 +922,7 @@ async function executeMigrations(root, migrations, isVerbose, shouldCreateCommit
                 loggingQueue.forEach((log) => logger_1.logger.info('  ' + log));
             }
             if (shouldCreateCommits) {
+                installDepsIfChanged();
                 const commitMessage = `${commitPrefix}${m.name}`;
                 try {
                     const committedSha = commitChanges(commitMessage);
@@ -935,9 +946,8 @@ async function executeMigrations(root, migrations, isVerbose, shouldCreateCommit
             throw e;
         }
     }
-    const depsAfterMigrations = getStringifiedPackageJsonDeps(root);
-    if (depsBeforeMigrations !== depsAfterMigrations) {
-        runInstall();
+    if (!shouldCreateCommits) {
+        installDepsIfChanged();
     }
     return migrationsWithNoChanges;
 }

package/src/command-line/release/publish.js

@@ -54,7 +54,10 @@ async function releasePublish(args, isCLI = false) {
          * Run publishing for all remaining release groups and filtered projects within them
          */
         for (const releaseGroup of releaseGroups) {
-            const status = await runPublishOnProjects(_args, projectGraph, nxJson, Array.from(releaseGroupToFilteredProjects.get(releaseGroup)), shouldExcludeTaskDependencies, isCLI);
+            const status = await runPublishOnProjects(_args, projectGraph, nxJson, Array.from(releaseGroupToFilteredProjects.get(releaseGroup)), isCLI, {
+                excludeTaskDependencies: shouldExcludeTaskDependencies,
+                loadDotEnvFiles: process.env.NX_LOAD_DOT_ENV_FILES !== 'false',
+            });
             if (status !== 0) {
                 overallExitStatus = status || 1;
             }
@@ -65,7 +68,10 @@ async function releasePublish(args, isCLI = false) {
      * Run publishing for all remaining release groups
      */
     for (const releaseGroup of releaseGroups) {
-        const status = await runPublishOnProjects(_args, projectGraph, nxJson, releaseGroup.projects, shouldExcludeTaskDependencies, isCLI);
+        const status = await runPublishOnProjects(_args, projectGraph, nxJson, releaseGroup.projects, isCLI, {
+            excludeTaskDependencies: shouldExcludeTaskDependencies,
+            loadDotEnvFiles: process.env.NX_LOAD_DOT_ENV_FILES !== 'false',
+        });
         if (status !== 0) {
             overallExitStatus = status || 1;
         }
@@ -73,7 +79,7 @@ async function releasePublish(args, isCLI = false) {
     return overallExitStatus;
 }
 exports.releasePublish = releasePublish;
-async function runPublishOnProjects(args, projectGraph, nxJson, projectNames, shouldExcludeTaskDependencies, isCLI) {
+async function runPublishOnProjects(args, projectGraph, nxJson, projectNames, isCLI, extraOptions) {
     const projectsToRun = projectNames.map((projectName) => projectGraph.nodes[projectName]);
     const overrides = (0, command_line_utils_1.createOverrides)(args.__overrides_unparsed__);
     if (args.registry) {
@@ -131,10 +137,7 @@ async function runPublishOnProjects(args, projectGraph, nxJson, projectNames, sh
         targets: [requiredTargetName],
         outputStyle: 'static',
         ...args,
-    }, overrides, null, {}, {
-        excludeTaskDependencies: shouldExcludeTaskDependencies,
-        loadDotEnvFiles: true,
-    });
+    }, overrides, null, {}, extraOptions);
     if (status !== 0) {
         // In order to not add noise to the overall CLI output, do not throw an additional error
         if (isCLI) {

package/src/command-line/release/utils/github.js

@@ -223,7 +223,7 @@ async function resolveGithubToken() {
     const ghCLIPath = (0, path_1.joinPathFragments)(process.env.XDG_CONFIG_HOME || (0, path_1.joinPathFragments)((0, node_os_1.homedir)(), '.config'), 'gh', 'hosts.yml');
     if ((0, node_fs_1.existsSync)(ghCLIPath)) {
         const yamlContents = await node_fs_1.promises.readFile(ghCLIPath, 'utf8');
-        const { load } = require('@zkochan/js-yaml');
+        const { load } = require('js-yaml');
         const ghCLIConfig = load(yamlContents);
         if (ghCLIConfig['github.com']) {
             // Web based session (the token is already embedded in the config)

package/src/command-line/release/utils/shared.js

@@ -162,9 +162,11 @@ function createGitTagValues(releaseGroups, releaseGroupToFilteredProjects, versi
         }
         // For fixed groups we want one tag for the overall group
         const projectVersionData = versionData[releaseGroupProjectNames[0]]; // all at the same version, so we can just pick the first one
-        tags.push((0, utils_1.interpolate)(releaseGroup.releaseTagPattern, {
-            version: projectVersionData.newVersion,
-        }));
+        if (projectVersionData.newVersion !== null) {
+            tags.push((0, utils_1.interpolate)(releaseGroup.releaseTagPattern, {
+                version: projectVersionData.newVersion,
+            }));
+        }
     }
     return tags;
 }

package/src/command-line/reset/reset.js

@@ -5,6 +5,7 @@ const fs_extra_1 = require("fs-extra");
 const client_1 = require("../../daemon/client/client");
 const cache_directory_1 = require("../../utils/cache-directory");
 const output_1 = require("../../utils/output");
+const native_file_cache_location_1 = require("../../native/native-file-cache-location");
 async function resetHandler() {
     output_1.output.note({
         title: 'Resetting the Nx workspace cache and stopping the Nx Daemon.',
@@ -12,6 +13,12 @@ async function resetHandler() {
     });
     await client_1.daemonClient.stop();
     output_1.output.log({ title: 'Daemon Server - Stopped' });
+    try {
+        (0, fs_extra_1.rmSync)(native_file_cache_location_1.nativeFileCacheLocation, { recursive: true, force: true });
+    }
+    catch (e) {
+        // ignore, deleting the native file cache is not critical and can fail if another process is locking the file
+    }
     (0, fs_extra_1.rmSync)(cache_directory_1.cacheDir, { recursive: true, force: true });
     if (cache_directory_1.projectGraphCacheDirectory !== cache_directory_1.cacheDir) {
         (0, fs_extra_1.rmSync)(cache_directory_1.projectGraphCacheDirectory, { recursive: true, force: true });

package/src/command-line/run/executor-utils.js

@@ -68,6 +68,11 @@ function readExecutorJson(nodeModule, executor, root, projects) {
     if (!executorConfig) {
         throw new Error(`Cannot find executor '${executor}' in ${executorsFilePath}.`);
     }
+    if (typeof executorConfig === 'string') {
+        // Angular CLI can have a builder pointing to another package:builder
+        const [packageName, executorName] = executorConfig.split(':');
+        return readExecutorJson(packageName, executorName, root, projects);
+    }
     const isNgCompat = !executorsJson.executors?.[executor];
     return { executorsFilePath, executorConfig, isNgCompat };
 }

package/src/command-line/run/run-one.js

@@ -13,7 +13,10 @@ const configuration_1 = require("../../config/configuration");
 const calculate_default_project_name_1 = require("../../config/calculate-default-project-name");
 const workspace_configuration_check_1 = require("../../utils/workspace-configuration-check");
 const graph_1 = require("../graph/graph");
-async function runOne(cwd, args, extraTargetDependencies = {}, extraOptions = { excludeTaskDependencies: false, loadDotEnvFiles: true }) {
+async function runOne(cwd, args, extraTargetDependencies = {}, extraOptions = {
+    excludeTaskDependencies: false,
+    loadDotEnvFiles: process.env.NX_LOAD_DOT_ENV_FILES !== 'false',
+}) {
     perf_hooks_1.performance.mark('code-loading:end');
     perf_hooks_1.performance.measure('code-loading', 'init-local', 'code-loading:end');
     (0, workspace_configuration_check_1.workspaceConfigurationCheck)();

package/src/command-line/run/run.js

@@ -1,6 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.run = exports.printTargetRunHelp = exports.runExecutor = exports.validateProject = exports.printRunHelp = void 0;
+const npm_run_path_1 = require("npm-run-path");
 const params_1 = require("../../utils/params");
 const print_help_1 = require("../../utils/print-help");
 const path_1 = require("path");
@@ -68,17 +69,24 @@ async function printTargetRunHelpInternal({ project, target }, root, projectsCon
         targetConfig.options.command) {
         const command = targetConfig.options.command.split(' ')[0];
         const helpCommand = `${command} --help`;
+        const localEnv = (0, npm_run_path_1.env)();
+        const env = {
+            ...process.env,
+            ...localEnv,
+        };
         if (pseudo_terminal_1.PseudoTerminal.isSupported()) {
             const terminal = (0, pseudo_terminal_1.getPseudoTerminal)();
             await new Promise(() => {
-                const cp = terminal.runCommand(helpCommand);
+                const cp = terminal.runCommand(helpCommand, { jsEnv: env });
                 cp.onExit((code) => {
                     process.exit(code);
                 });
             });
         }
         else {
-            const cp = (0, child_process_1.exec)(helpCommand);
+            const cp = (0, child_process_1.exec)(helpCommand, {
+                env,
+            });
             cp.on('exit', (code) => {
                 process.exit(code);
             });

package/src/command-line/run-many/run-many.js

@@ -13,7 +13,10 @@ const output_1 = require("../../utils/output");
 const find_matching_projects_1 = require("../../utils/find-matching-projects");
 const workspace_configuration_check_1 = require("../../utils/workspace-configuration-check");
 const graph_1 = require("../graph/graph");
-async function runMany(args, extraTargetDependencies = {}, extraOptions = { excludeTaskDependencies: false, loadDotEnvFiles: true }) {
+async function runMany(args, extraTargetDependencies = {}, extraOptions = {
+    excludeTaskDependencies: false,
+    loadDotEnvFiles: process.env.NX_LOAD_DOT_ENV_FILES !== 'false',
+}) {
     perf_hooks_1.performance.mark('code-loading:end');
     perf_hooks_1.performance.measure('code-loading', 'init-local', 'code-loading:end');
     (0, workspace_configuration_check_1.workspaceConfigurationCheck)();

package/src/config/misc-interfaces.d.ts

@@ -25,13 +25,14 @@ export interface GeneratorsJsonEntry {
     'x-use-standalone-layout'?: boolean;
 }
 export type OutputCaptureMethod = 'direct-nodejs' | 'pipe';
-export interface ExecutorsJsonEntry {
+export interface ExecutorJsonEntryConfig {
     schema: string;
     implementation: string;
     batchImplementation?: string;
     description?: string;
     hasher?: string;
 }
+export type ExecutorsJsonEntry = string | ExecutorJsonEntryConfig;
 export type Dependencies = 'dependencies' | 'devDependencies';
 export interface PackageJsonUpdateForPackage {
     version: string;