nx 19.0.0-canary.20240425-cec57c4 → 19.0.0-canary.20240426-ac9ad35

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nx",
-  "version": "19.0.0-canary.20240425-cec57c4",
+  "version": "19.0.0-canary.20240426-ac9ad35",
   "private": false,
   "description": "The core Nx plugin contains the core functionality of Nx like the project graph, nx commands and task orchestration.",
   "repository": {
@@ -66,7 +66,7 @@
     "yargs-parser": "21.1.1",
     "node-machine-id": "1.1.12",
     "ora": "5.3.0",
-    "@nrwl/tao": "19.0.0-canary.20240425-cec57c4"
+    "@nrwl/tao": "19.0.0-canary.20240426-ac9ad35"
   },
   "peerDependencies": {
     "@swc-node/register": "^1.8.0",
@@ -81,16 +81,16 @@
     }
   },
   "optionalDependencies": {
-    "@nx/nx-darwin-x64": "19.0.0-canary.20240425-cec57c4",
-    "@nx/nx-darwin-arm64": "19.0.0-canary.20240425-cec57c4",
-    "@nx/nx-linux-x64-gnu": "19.0.0-canary.20240425-cec57c4",
-    "@nx/nx-linux-x64-musl": "19.0.0-canary.20240425-cec57c4",
-    "@nx/nx-win32-x64-msvc": "19.0.0-canary.20240425-cec57c4",
-    "@nx/nx-linux-arm64-gnu": "19.0.0-canary.20240425-cec57c4",
-    "@nx/nx-linux-arm64-musl": "19.0.0-canary.20240425-cec57c4",
-    "@nx/nx-linux-arm-gnueabihf": "19.0.0-canary.20240425-cec57c4",
-    "@nx/nx-win32-arm64-msvc": "19.0.0-canary.20240425-cec57c4",
-    "@nx/nx-freebsd-x64": "19.0.0-canary.20240425-cec57c4"
+    "@nx/nx-darwin-x64": "19.0.0-canary.20240426-ac9ad35",
+    "@nx/nx-darwin-arm64": "19.0.0-canary.20240426-ac9ad35",
+    "@nx/nx-linux-x64-gnu": "19.0.0-canary.20240426-ac9ad35",
+    "@nx/nx-linux-x64-musl": "19.0.0-canary.20240426-ac9ad35",
+    "@nx/nx-win32-x64-msvc": "19.0.0-canary.20240426-ac9ad35",
+    "@nx/nx-linux-arm64-gnu": "19.0.0-canary.20240426-ac9ad35",
+    "@nx/nx-linux-arm64-musl": "19.0.0-canary.20240426-ac9ad35",
+    "@nx/nx-linux-arm-gnueabihf": "19.0.0-canary.20240426-ac9ad35",
+    "@nx/nx-win32-arm64-msvc": "19.0.0-canary.20240426-ac9ad35",
+    "@nx/nx-freebsd-x64": "19.0.0-canary.20240426-ac9ad35"
   },
   "nx-migrations": {
     "migrations": "./migrations.json",

package/src/project-graph/plugins/isolation/plugin-worker.js

@@ -3,6 +3,9 @@ Object.defineProperty(exports, "__esModule", { value: true });
 const messaging_1 = require("./messaging");
 const loader_1 = require("../loader");
 const serializable_error_1 = require("../../../utils/serializable-error");
+if (process.env.NX_PERF_LOGGING === 'true') {
+    require('../../../utils/perf-logging');
+}
 global.NX_GRAPH_CREATION = true;
 let plugin;
 process.on('message', async (message) => {

package/src/project-graph/plugins/public-api.d.ts

@@ -12,7 +12,7 @@ export interface CreateNodesContext {
     /**
      * The subset of configuration files which match the createNodes pattern
      */
-    readonly configFiles: string[];
+    readonly configFiles: readonly string[];
 }
 /**
  * A function which parses a configuration file into a set of nodes.

package/src/project-graph/plugins/utils.d.ts

@@ -1,7 +1,7 @@
 import type { NxPluginV1 } from '../../utils/nx-plugin.deprecated';
 import type { CreateNodesResultWithContext, LoadedNxPlugin, NormalizedPlugin } from './internal-api';
-import type { CreateNodesContext, NxPlugin, NxPluginV2 } from './public-api';
+import { type CreateNodesContext, type NxPlugin, type NxPluginV2 } from './public-api';
 export declare function isNxPluginV2(plugin: NxPlugin): plugin is NxPluginV2;
 export declare function isNxPluginV1(plugin: NxPlugin | LoadedNxPlugin): plugin is NxPluginV1;
 export declare function normalizeNxPlugin(plugin: NxPlugin): NormalizedPlugin;
-export declare function runCreateNodesInParallel(configFiles: string[], plugin: NormalizedPlugin, options: unknown, context: CreateNodesContext): Promise<CreateNodesResultWithContext[]>;
+export declare function runCreateNodesInParallel(configFiles: readonly string[], plugin: NormalizedPlugin, options: unknown, context: CreateNodesContext): Promise<CreateNodesResultWithContext[]>;

package/src/project-graph/plugins/utils.js

@@ -43,30 +43,29 @@ async function runCreateNodesInParallel(configFiles, plugin, options, context) {
     performance.mark(`${plugin.name}:createNodes - start`);
     const errors = [];
     const results = [];
-    const promises = configFiles.map((file) => {
+    const promises = configFiles.map(async (file) => {
         performance.mark(`${plugin.name}:createNodes:${file} - start`);
-        // Result is either static or a promise, using Promise.resolve lets us
-        // handle both cases with same logic
-        const value = Promise.resolve(plugin.createNodes[1](file, options, context));
-        return value
-            .catch((e) => {
-            performance.mark(`${plugin.name}:createNodes:${file} - end`);
+        try {
+            const value = await plugin.createNodes[1](file, options, context);
+            if (value) {
+                results.push({
+                    ...value,
+                    file,
+                    pluginName: plugin.name,
+                });
+            }
+        }
+        catch (e) {
             errors.push(new error_types_1.CreateNodesError({
                 error: e,
                 pluginName: plugin.name,
                 file,
             }));
-            return null;
-        })
-            .then((r) => {
+        }
+        finally {
             performance.mark(`${plugin.name}:createNodes:${file} - end`);
             performance.measure(`${plugin.name}:createNodes:${file}`, `${plugin.name}:createNodes:${file} - start`, `${plugin.name}:createNodes:${file} - end`);
-            // Existing behavior is to ignore null results of
-            // createNodes function.
-            if (r) {
-                results.push({ ...r, file, pluginName: plugin.name });
-            }
-        });
+        }
     });
     await Promise.all(promises).then(() => {
         performance.mark(`${plugin.name}:createNodes - end`);

package/src/project-graph/utils/retrieve-workspace-files.d.ts

@@ -9,12 +9,12 @@ import { LoadedNxPlugin } from '../plugins/internal-api';
  * @param nxJson
  */
 export declare function retrieveWorkspaceFiles(workspaceRoot: string, projectRootMap: Record<string, string>): Promise<{
-    allWorkspaceFiles: import("../file-utils").FileData[];
+    allWorkspaceFiles: import("nx/src/devkit-exports").FileData[];
     fileMap: {
         projectFileMap: ProjectFiles;
-        nonProjectFiles: import("../../native").FileData[];
+        nonProjectFiles: import("nx/src/native").FileData[];
     };
-    rustReferences: import("../../native").NxWorkspaceFilesExternals;
+    rustReferences: import("nx/src/native").NxWorkspaceFilesExternals;
 }>;
 /**
  * Walk through the workspace and return `ProjectConfigurations`. Only use this if the projectFileMap is not needed.

package/src/utils/perf-logging.js

@@ -1,7 +1,9 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 const perf_hooks_1 = require("perf_hooks");
-if (process.env.NX_PERF_LOGGING === 'true') {
+let initialized = false;
+if (process.env.NX_PERF_LOGGING === 'true' && !initialized) {
+    initialized = true;
     const obs = new perf_hooks_1.PerformanceObserver((list) => {
         for (const entry of list.getEntries()) {
             console.log(`Time for '${entry.name}'`, entry.duration);