nx 18.3.0-canary.20240412-d1584f8 → 18.3.0-canary.20240416-2ee9650

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nx",
-  "version": "18.3.0-canary.20240412-d1584f8",
+  "version": "18.3.0-canary.20240416-2ee9650",
   "private": false,
   "description": "The core Nx plugin contains the core functionality of Nx like the project graph, nx commands and task orchestration.",
   "repository": {
@@ -66,7 +66,7 @@
     "yargs-parser": "21.1.1",
     "node-machine-id": "1.1.12",
     "ora": "5.3.0",
-    "@nrwl/tao": "18.3.0-canary.20240412-d1584f8"
+    "@nrwl/tao": "18.3.0-canary.20240416-2ee9650"
   },
   "peerDependencies": {
     "@swc-node/register": "^1.8.0",
@@ -81,16 +81,16 @@
     }
   },
   "optionalDependencies": {
-    "@nx/nx-darwin-x64": "18.3.0-canary.20240412-d1584f8",
-    "@nx/nx-darwin-arm64": "18.3.0-canary.20240412-d1584f8",
-    "@nx/nx-linux-x64-gnu": "18.3.0-canary.20240412-d1584f8",
-    "@nx/nx-linux-x64-musl": "18.3.0-canary.20240412-d1584f8",
-    "@nx/nx-win32-x64-msvc": "18.3.0-canary.20240412-d1584f8",
-    "@nx/nx-linux-arm64-gnu": "18.3.0-canary.20240412-d1584f8",
-    "@nx/nx-linux-arm64-musl": "18.3.0-canary.20240412-d1584f8",
-    "@nx/nx-linux-arm-gnueabihf": "18.3.0-canary.20240412-d1584f8",
-    "@nx/nx-win32-arm64-msvc": "18.3.0-canary.20240412-d1584f8",
-    "@nx/nx-freebsd-x64": "18.3.0-canary.20240412-d1584f8"
+    "@nx/nx-darwin-x64": "18.3.0-canary.20240416-2ee9650",
+    "@nx/nx-darwin-arm64": "18.3.0-canary.20240416-2ee9650",
+    "@nx/nx-linux-x64-gnu": "18.3.0-canary.20240416-2ee9650",
+    "@nx/nx-linux-x64-musl": "18.3.0-canary.20240416-2ee9650",
+    "@nx/nx-win32-x64-msvc": "18.3.0-canary.20240416-2ee9650",
+    "@nx/nx-linux-arm64-gnu": "18.3.0-canary.20240416-2ee9650",
+    "@nx/nx-linux-arm64-musl": "18.3.0-canary.20240416-2ee9650",
+    "@nx/nx-linux-arm-gnueabihf": "18.3.0-canary.20240416-2ee9650",
+    "@nx/nx-win32-arm64-msvc": "18.3.0-canary.20240416-2ee9650",
+    "@nx/nx-freebsd-x64": "18.3.0-canary.20240416-2ee9650"
   },
   "nx-migrations": {
     "migrations": "./migrations.json",

package/src/command-line/init/implementation/add-nx-to-monorepo.js

@@ -63,7 +63,7 @@ async function addNxToMonorepo(options) {
     (0, utils_1.createNxJsonFile)(repoRoot, targetDefaults, cacheableOperations, scriptOutputs);
     if (!options.legacy) {
         packageJsonFiles.forEach((packageJsonPath) => {
-            (0, utils_1.markPackageJsonAsNxProject)((0, path_1.join)(repoRoot, packageJsonPath), cacheableOperations);
+            (0, utils_1.markPackageJsonAsNxProject)((0, path_1.join)(repoRoot, packageJsonPath));
         });
     }
     (0, utils_1.updateGitIgnore)(repoRoot);

package/src/command-line/init/implementation/add-nx-to-npm-repo.js

@@ -57,7 +57,7 @@ async function addNxToNpmRepo(options) {
         (0, utils_1.markRootPackageJsonAsNxProjectLegacy)(repoRoot, cacheableOperations, pmc);
     }
     else {
-        (0, utils_1.markPackageJsonAsNxProject)((0, path_1.join)(repoRoot, 'package.json'), cacheableOperations);
+        (0, utils_1.markPackageJsonAsNxProject)((0, path_1.join)(repoRoot, 'package.json'));
     }
     output_1.output.log({ title: '📦 Installing dependencies' });
     (0, utils_1.runInstall)(repoRoot, pmc);

package/src/command-line/init/implementation/utils.d.ts

@@ -9,7 +9,7 @@ export declare function runInstall(repoRoot: string, pmc?: PackageManagerCommand
 export declare function initCloud(repoRoot: string, installationSource: 'nx-init-angular' | 'nx-init-cra' | 'nx-init-monorepo' | 'nx-init-nest' | 'nx-init-npm-repo'): void;
 export declare function addVsCodeRecommendedExtensions(repoRoot: string, extensions: string[]): void;
 export declare function markRootPackageJsonAsNxProjectLegacy(repoRoot: string, cacheableScripts: string[], pmc: PackageManagerCommands): void;
-export declare function markPackageJsonAsNxProject(packageJsonPath: string, cacheableScripts: string[]): void;
+export declare function markPackageJsonAsNxProject(packageJsonPath: string): void;
 export declare function printFinalMessage({ learnMoreLink, bodyLines, }: {
     learnMoreLink?: string;
     bodyLines?: string[];

package/src/command-line/init/implementation/utils.js

@@ -154,17 +154,12 @@ function markRootPackageJsonAsNxProjectLegacy(repoRoot, cacheableScripts, pmc) {
     (0, fileutils_1.writeJsonFile)(`package.json`, json);
 }
 exports.markRootPackageJsonAsNxProjectLegacy = markRootPackageJsonAsNxProjectLegacy;
-function markPackageJsonAsNxProject(packageJsonPath, cacheableScripts) {
+function markPackageJsonAsNxProject(packageJsonPath) {
     const json = (0, fileutils_1.readJsonFile)(packageJsonPath);
     if (!json.scripts) {
         return;
     }
-    json.nx = { includedScripts: [] };
-    for (let script of cacheableScripts) {
-        if (json.scripts[script]) {
-            json.nx.includedScripts.push(script);
-        }
-    }
+    json.nx = {};
     (0, fileutils_1.writeJsonFile)(packageJsonPath, json);
 }
 exports.markPackageJsonAsNxProject = markPackageJsonAsNxProject;

package/src/command-line/init/init-v2.js

@@ -17,7 +17,6 @@ const workspace_context_1 = require("../../utils/workspace-context");
 const connect_to_nx_cloud_1 = require("../connect/connect-to-nx-cloud");
 const add_nx_to_npm_repo_1 = require("./implementation/add-nx-to-npm-repo");
 const add_nx_to_monorepo_1 = require("./implementation/add-nx-to-monorepo");
-const path_1 = require("path");
 async function initHandler(options) {
     process.env.NX_RUNNING_NX_INIT = 'true';
     const version = process.env.NX_VERSION ?? ((0, semver_1.prerelease)(versions_1.nxVersion) ? 'next' : 'latest');
@@ -52,29 +51,29 @@ async function initHandler(options) {
     }
     output_1.output.log({ title: '🧐 Checking dependencies' });
     const { plugins, updatePackageScripts } = await detectPlugins();
-    if (!plugins.length) {
-        // If no plugins are detected/chosen, guide users to setup
-        // their targetDefaults correctly so their package scripts will work.
-        const packageJson = (0, fileutils_1.readJsonFile)('package.json');
-        if ((0, utils_1.isMonorepo)(packageJson)) {
-            await (0, add_nx_to_monorepo_1.addNxToMonorepo)({ interactive: options.interactive });
-        }
-        else {
-            await (0, add_nx_to_npm_repo_1.addNxToNpmRepo)({ interactive: options.interactive });
-        }
+    const packageJson = (0, fileutils_1.readJsonFile)('package.json');
+    if ((0, utils_1.isMonorepo)(packageJson)) {
+        await (0, add_nx_to_monorepo_1.addNxToMonorepo)({
+            interactive: options.interactive,
+            nxCloud: false,
+        });
     }
     else {
-        const useNxCloud = options.nxCloud ??
-            (options.interactive
-                ? await (0, connect_to_nx_cloud_1.connectExistingRepoToNxCloudPrompt)()
-                : false);
-        const repoRoot = process.cwd();
-        const pmc = (0, package_manager_1.getPackageManagerCommand)();
-        (0, utils_1.createNxJsonFile)(repoRoot, [], [], {});
-        (0, utils_1.updateGitIgnore)(repoRoot);
-        (0, utils_1.addDepsToPackageJson)(repoRoot, plugins);
-        output_1.output.log({ title: '📦 Installing Nx' });
-        (0, utils_1.runInstall)(repoRoot, pmc);
+        await (0, add_nx_to_npm_repo_1.addNxToNpmRepo)({
+            interactive: options.interactive,
+            nxCloud: false,
+        });
+    }
+    const useNxCloud = options.nxCloud ??
+        (options.interactive ? await (0, connect_to_nx_cloud_1.connectExistingRepoToNxCloudPrompt)() : false);
+    const repoRoot = process.cwd();
+    const pmc = (0, package_manager_1.getPackageManagerCommand)();
+    (0, utils_1.createNxJsonFile)(repoRoot, [], [], {});
+    (0, utils_1.updateGitIgnore)(repoRoot);
+    (0, utils_1.addDepsToPackageJson)(repoRoot, plugins);
+    output_1.output.log({ title: '📦 Installing Nx' });
+    (0, utils_1.runInstall)(repoRoot, pmc);
+    if (plugins.length > 0) {
         output_1.output.log({ title: '🔨 Configuring plugins' });
         for (const plugin of plugins) {
             (0, child_process_2.execSync)(`${pmc.exec} nx g ${plugin}:init --keepExistingVersions ${updatePackageScripts ? '--updatePackageScripts' : ''} --no-interactive`, {
@@ -82,19 +81,13 @@ async function initHandler(options) {
                 cwd: repoRoot,
             });
         }
-        if (!updatePackageScripts) {
-            const rootPackageJsonPath = (0, path_1.join)(repoRoot, 'package.json');
-            const json = (0, fileutils_1.readJsonFile)(rootPackageJsonPath);
-            json.nx = { includedScripts: [] };
-            (0, fileutils_1.writeJsonFile)(rootPackageJsonPath, json);
-        }
-        if (useNxCloud) {
-            output_1.output.log({ title: '🛠️ Setting up Nx Cloud' });
-            (0, child_process_2.execSync)(`${pmc.exec} nx g nx:connect-to-nx-cloud --installationSource=nx-init --quiet --hideFormatLogs --no-interactive`, {
-                stdio: [0, 1, 2],
-                cwd: repoRoot,
-            });
-        }
+    }
+    if (useNxCloud) {
+        output_1.output.log({ title: '🛠️ Setting up Nx Cloud' });
+        (0, child_process_2.execSync)(`${pmc.exec} nx g nx:connect-to-nx-cloud --installationSource=nx-init --quiet --hideFormatLogs --no-interactive`, {
+            stdio: [0, 1, 2],
+            cwd: repoRoot,
+        });
     }
     output_1.output.log({
         title: '👀 Explore Your Workspace',
@@ -170,9 +163,8 @@ async function detectPlugins() {
         {
             name: 'plugins',
             type: 'multiselect',
-            message: `Which plugins would you like to add?`,
+            message: `Which plugins would you like to add? Press <Space> to select and <Enter> to submit.`,
             choices: plugins.map((p) => ({ name: p, value: p })),
-            initial: plugins.map((_, i) => i), // casting to avoid type error due to bad d.ts file from enquirer
         },
     ]).then((r) => r.plugins);
     if (pluginsToInstall?.length === 0)

package/src/command-line/release/command-object.js

@@ -107,7 +107,7 @@ const versionCommand = {
     })
         .option('preid', {
         type: 'string',
-        describe: 'The optional prerelease identifier to apply to the version, in the case that specifier has been set to prerelease.',
+        describe: 'The optional prerelease identifier to apply to the version, in the case that the specifier argument has been set to `prerelease`.',
         default: '',
     })
         .option('stage-changes', {

package/src/devkit-internals.d.ts

@@ -17,4 +17,7 @@ export { splitByColons } from './utils/split-target';
 export { hashObject } from './hasher/file-hasher';
 export { hashWithWorkspaceContext } from './utils/workspace-context';
 export { createProjectRootMappingsFromProjectConfigurations, findProjectForPath, } from './project-graph/utils/find-project-for-path';
+export { retrieveProjectConfigurations } from './project-graph/utils/retrieve-workspace-files';
+export { LoadedNxPlugin } from './project-graph/plugins/internal-api';
+export * from './project-graph/error-types';
 export { registerTsProject } from './plugins/js/utils/register';

package/src/devkit-internals.js

@@ -1,6 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.registerTsProject = exports.findProjectForPath = exports.createProjectRootMappingsFromProjectConfigurations = exports.hashWithWorkspaceContext = exports.hashObject = exports.splitByColons = exports.readModulePackageJson = exports.stripIndent = exports.sortObjectByKeys = exports.combineOptionsForExecutor = exports.splitTarget = exports.retrieveProjectConfigurationsWithAngularProjects = exports.calculateDefaultProjectName = exports.readNxJsonFromDisk = exports.getExecutorInformation = exports.createTempNpmDirectory = void 0;
+exports.registerTsProject = exports.LoadedNxPlugin = exports.retrieveProjectConfigurations = exports.findProjectForPath = exports.createProjectRootMappingsFromProjectConfigurations = exports.hashWithWorkspaceContext = exports.hashObject = exports.splitByColons = exports.readModulePackageJson = exports.stripIndent = exports.sortObjectByKeys = exports.combineOptionsForExecutor = exports.splitTarget = exports.retrieveProjectConfigurationsWithAngularProjects = exports.calculateDefaultProjectName = exports.readNxJsonFromDisk = exports.getExecutorInformation = exports.createTempNpmDirectory = void 0;
+const tslib_1 = require("tslib");
 /**
  * Note to developers: STOP! These exports are available via requireNx in @nx/devkit.
  *
@@ -35,5 +36,10 @@ Object.defineProperty(exports, "hashWithWorkspaceContext", { enumerable: true, g
 var find_project_for_path_1 = require("./project-graph/utils/find-project-for-path");
 Object.defineProperty(exports, "createProjectRootMappingsFromProjectConfigurations", { enumerable: true, get: function () { return find_project_for_path_1.createProjectRootMappingsFromProjectConfigurations; } });
 Object.defineProperty(exports, "findProjectForPath", { enumerable: true, get: function () { return find_project_for_path_1.findProjectForPath; } });
+var retrieve_workspace_files_2 = require("./project-graph/utils/retrieve-workspace-files");
+Object.defineProperty(exports, "retrieveProjectConfigurations", { enumerable: true, get: function () { return retrieve_workspace_files_2.retrieveProjectConfigurations; } });
+var internal_api_1 = require("./project-graph/plugins/internal-api");
+Object.defineProperty(exports, "LoadedNxPlugin", { enumerable: true, get: function () { return internal_api_1.LoadedNxPlugin; } });
+tslib_1.__exportStar(require("./project-graph/error-types"), exports);
 var register_1 = require("./plugins/js/utils/register");
 Object.defineProperty(exports, "registerTsProject", { enumerable: true, get: function () { return register_1.registerTsProject; } });

package/src/project-graph/error-types.d.ts

@@ -1,9 +1,20 @@
 import { CreateNodesResultWithContext } from './plugins/internal-api';
 import { ConfigurationResult } from './utils/project-configuration-utils';
+import { ProjectConfiguration } from '../config/workspace-json-project-json';
+export declare class ProjectsWithConflictingNamesError extends Error {
+    projects: Record<string, ProjectConfiguration>;
+    constructor(conflicts: Map<string, string[]>, projects: Record<string, ProjectConfiguration>);
+}
+export declare function isProjectsWithConflictingNamesError(e: unknown): e is ProjectsWithConflictingNamesError;
+export declare class ProjectsWithNoNameError extends Error {
+    projects: Record<string, ProjectConfiguration>;
+    constructor(projectRoots: string[], projects: Record<string, ProjectConfiguration>);
+}
+export declare function isProjectsWithNoNameError(e: unknown): e is ProjectsWithNoNameError;
 export declare class ProjectConfigurationsError extends Error {
-    readonly errors: Array<MergeNodesError | CreateNodesError>;
+    readonly errors: Array<MergeNodesError | CreateNodesError | ProjectsWithNoNameError | ProjectsWithConflictingNamesError>;
     readonly partialProjectConfigurationsResult: ConfigurationResult;
-    constructor(errors: Array<MergeNodesError | CreateNodesError>, partialProjectConfigurationsResult: ConfigurationResult);
+    constructor(errors: Array<MergeNodesError | CreateNodesError | ProjectsWithNoNameError | ProjectsWithConflictingNamesError>, partialProjectConfigurationsResult: ConfigurationResult);
 }
 export declare class CreateNodesError extends Error {
     file: string;

package/src/project-graph/error-types.js

@@ -1,6 +1,41 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.isMergeNodesError = exports.isAggregateCreateNodesError = exports.isCreateNodesError = exports.MergeNodesError = exports.AggregateCreateNodesError = exports.CreateNodesError = exports.ProjectConfigurationsError = void 0;
+exports.isMergeNodesError = exports.isAggregateCreateNodesError = exports.isCreateNodesError = exports.MergeNodesError = exports.AggregateCreateNodesError = exports.CreateNodesError = exports.ProjectConfigurationsError = exports.isProjectsWithNoNameError = exports.ProjectsWithNoNameError = exports.isProjectsWithConflictingNamesError = exports.ProjectsWithConflictingNamesError = void 0;
+class ProjectsWithConflictingNamesError extends Error {
+    constructor(conflicts, projects) {
+        super([
+            `The following projects are defined in multiple locations:`,
+            ...Array.from(conflicts.entries()).map(([project, roots]) => [`- ${project}: `, ...roots.map((r) => `  - ${r}`)].join('\n')),
+            '',
+            "To fix this, set a unique name for each project in a project.json inside the project's root. If the project does not currently have a project.json, you can create one that contains only a name.",
+        ].join('\n'));
+        this.projects = projects;
+        this.name = this.constructor.name;
+    }
+}
+exports.ProjectsWithConflictingNamesError = ProjectsWithConflictingNamesError;
+function isProjectsWithConflictingNamesError(e) {
+    return (e instanceof ProjectsWithConflictingNamesError ||
+        (typeof e === 'object' &&
+            'name' in e &&
+            e?.name === ProjectsWithConflictingNamesError.prototype.name));
+}
+exports.isProjectsWithConflictingNamesError = isProjectsWithConflictingNamesError;
+class ProjectsWithNoNameError extends Error {
+    constructor(projectRoots, projects) {
+        super(`The projects in the following directories have no name provided:\n  - ${projectRoots.join('\n  - ')}`);
+        this.projects = projects;
+        this.name = this.constructor.name;
+    }
+}
+exports.ProjectsWithNoNameError = ProjectsWithNoNameError;
+function isProjectsWithNoNameError(e) {
+    return (e instanceof ProjectsWithNoNameError ||
+        (typeof e === 'object' &&
+            'name' in e &&
+            e?.name === ProjectsWithNoNameError.prototype.name));
+}
+exports.isProjectsWithNoNameError = isProjectsWithNoNameError;
 class ProjectConfigurationsError extends Error {
     constructor(errors, partialProjectConfigurationsResult) {
         super('Failed to create project configurations');

package/src/project-graph/plugins/utils.js

@@ -41,6 +41,8 @@ function normalizeNxPlugin(plugin) {
 exports.normalizeNxPlugin = normalizeNxPlugin;
 async function runCreateNodesInParallel(configFiles, plugin, options, context) {
     performance.mark(`${plugin.name}:createNodes - start`);
+    const errors = [];
+    const results = [];
     const promises = configFiles.map((file) => {
         performance.mark(`${plugin.name}:createNodes:${file} - start`);
         // Result is either static or a promise, using Promise.resolve lets us
@@ -49,40 +51,30 @@ async function runCreateNodesInParallel(configFiles, plugin, options, context) {
         return value
             .catch((e) => {
             performance.mark(`${plugin.name}:createNodes:${file} - end`);
-            return new error_types_1.CreateNodesError({
+            errors.push(new error_types_1.CreateNodesError({
                 error: e,
                 pluginName: plugin.name,
                 file,
-            });
+            }));
+            return null;
         })
             .then((r) => {
             performance.mark(`${plugin.name}:createNodes:${file} - end`);
             performance.measure(`${plugin.name}:createNodes:${file}`, `${plugin.name}:createNodes:${file} - start`, `${plugin.name}:createNodes:${file} - end`);
-            return { ...r, pluginName: plugin.name, file };
+            // Existing behavior is to ignore null results of
+            // createNodes function.
+            if (r) {
+                results.push(r);
+            }
         });
     });
-    const results = await Promise.all(promises).then((results) => {
+    await Promise.all(promises).then(() => {
         performance.mark(`${plugin.name}:createNodes - end`);
         performance.measure(`${plugin.name}:createNodes`, `${plugin.name}:createNodes - start`, `${plugin.name}:createNodes - end`);
-        return results;
     });
-    const [errors, successful] = partition(results, (r) => r instanceof error_types_1.CreateNodesError);
     if (errors.length > 0) {
-        throw new error_types_1.AggregateCreateNodesError(plugin.name, errors, successful);
+        throw new error_types_1.AggregateCreateNodesError(plugin.name, errors, results);
     }
     return results;
 }
 exports.runCreateNodesInParallel = runCreateNodesInParallel;
-function partition(arr, test) {
-    const pass = [];
-    const fail = [];
-    for (const item of arr) {
-        if (test(item)) {
-            pass.push(item);
-        }
-        else {
-            fail.push(item);
-        }
-    }
-    return [pass, fail];
-}

package/src/project-graph/project-graph.d.ts

@@ -2,7 +2,7 @@ import { ProcessDependenciesError, ProcessProjectGraphError } from './build-proj
 import { ProjectGraph } from '../config/project-graph';
 import { ProjectConfiguration, ProjectsConfigurations } from '../config/workspace-json-project-json';
 import { ConfigurationSourceMaps } from './utils/project-configuration-utils';
-import { CreateNodesError, MergeNodesError } from './error-types';
+import { CreateNodesError, MergeNodesError, ProjectsWithNoNameError, ProjectsWithConflictingNamesError } from './error-types';
 import { DaemonProjectGraphError } from '../daemon/daemon-project-graph-error';
 /**
  * Synchronously reads the latest cached copy of the workspace's ProjectGraph.
@@ -20,7 +20,7 @@ export declare function buildProjectGraphAndSourceMapsWithoutDaemon(): Promise<{
 }>;
 export declare class ProjectGraphError extends Error {
     #private;
-    constructor(errors: Array<CreateNodesError | MergeNodesError | ProcessDependenciesError | ProcessProjectGraphError>, partialProjectGraph: ProjectGraph, partialSourceMaps: ConfigurationSourceMaps);
+    constructor(errors: Array<CreateNodesError | MergeNodesError | ProjectsWithNoNameError | ProjectsWithConflictingNamesError | ProcessDependenciesError | ProcessProjectGraphError>, partialProjectGraph: ProjectGraph, partialSourceMaps: ConfigurationSourceMaps);
     /**
      * The daemon cannot throw errors which contain methods as they are not serializable.
      *
@@ -34,7 +34,7 @@ export declare class ProjectGraphError extends Error {
      */
     getPartialProjectGraph(): ProjectGraph;
     getPartialSourcemaps(): ConfigurationSourceMaps;
-    getErrors(): (CreateNodesError | ProcessDependenciesError | ProcessProjectGraphError)[];
+    getErrors(): (ProjectsWithConflictingNamesError | ProjectsWithNoNameError | MergeNodesError | CreateNodesError | ProcessDependenciesError | ProcessProjectGraphError)[];
 }
 /**
  * Computes and returns a ProjectGraph.

package/src/project-graph/utils/project-configuration-utils.js

@@ -291,7 +291,20 @@ plugins) {
             }
             Object.assign(externalNodes, pluginExternalNodes);
         }
-        const projects = readProjectConfigurationsFromRootMap(projectRootMap);
+        let projects;
+        try {
+            projects = readProjectConfigurationsFromRootMap(projectRootMap);
+        }
+        catch (e) {
+            if ((0, error_types_1.isProjectsWithNoNameError)(e) ||
+                (0, error_types_1.isProjectsWithConflictingNamesError)(e)) {
+                projects = e.projects;
+                errors.push(e);
+            }
+            else {
+                throw e;
+            }
+        }
         const rootMap = createRootMap(projectRootMap);
         perf_hooks_1.performance.mark('createNodes:merge - end');
         perf_hooks_1.performance.measure('createNodes:merge', 'createNodes:merge - start', 'createNodes:merge - end');
@@ -321,7 +334,8 @@ function readProjectConfigurationsFromRootMap(projectRootMap) {
     // If there are projects that have the same name, that is an error.
     // This object tracks name -> (all roots of projects with that name)
     // to provide better error messaging.
-    const errors = new Map();
+    const conflicts = new Map();
+    const projectRootsWithNoName = [];
     for (const [root, configuration] of projectRootMap.entries()) {
         // We're setting `// targets` as a comment `targets` is empty due to Project Crystal.
         // Strip it before returning configuration for usage.
@@ -333,27 +347,26 @@ function readProjectConfigurationsFromRootMap(projectRootMap) {
                 configuration.name = name;
             }
             catch {
-                throw new Error(`Project at ${root} has no name provided.`);
+                projectRootsWithNoName.push(root);
             }
         }
         if (configuration.name in projects) {
-            let rootErrors = errors.get(configuration.name) ?? [
+            let rootErrors = conflicts.get(configuration.name) ?? [
                 projects[configuration.name].root,
             ];
             rootErrors.push(root);
-            errors.set(configuration.name, rootErrors);
+            conflicts.set(configuration.name, rootErrors);
+            projects[configuration.name] = configuration;
         }
         else {
             projects[configuration.name] = configuration;
         }
     }
-    if (errors.size > 0) {
-        throw new Error([
-            `The following projects are defined in multiple locations:`,
-            ...Array.from(errors.entries()).map(([project, roots]) => [`- ${project}: `, ...roots.map((r) => `  - ${r}`)].join('\n')),
-            '',
-            "To fix this, set a unique name for each project in a project.json inside the project's root. If the project does not currently have a project.json, you can create one that contains only a name.",
-        ].join('\n'));
+    if (conflicts.size > 0) {
+        throw new error_types_1.ProjectsWithConflictingNamesError(conflicts, projects);
+    }
+    if (projectRootsWithNoName.length > 0) {
+        throw new error_types_1.ProjectsWithNoNameError(projectRootsWithNoName, projects);
     }
     return projects;
 }

package/src/project-graph/utils/retrieve-workspace-files.d.ts

@@ -9,12 +9,12 @@ import { LoadedNxPlugin } from '../plugins/internal-api';
  * @param nxJson
  */
 export declare function retrieveWorkspaceFiles(workspaceRoot: string, projectRootMap: Record<string, string>): Promise<{
-    allWorkspaceFiles: import("nx/src/devkit-exports").FileData[];
+    allWorkspaceFiles: import("../file-utils").FileData[];
     fileMap: {
         projectFileMap: ProjectFiles;
-        nonProjectFiles: import("nx/src/native").FileData[];
+        nonProjectFiles: import("../../native").FileData[];
     };
-    rustReferences: import("nx/src/native").NxWorkspaceFilesExternals;
+    rustReferences: import("../../native").NxWorkspaceFilesExternals;
 }>;
 /**
  * Walk through the workspace and return `ProjectConfigurations`. Only use this if the projectFileMap is not needed.

package/src/project-graph/utils/retrieve-workspace-files.js

@@ -36,9 +36,10 @@ exports.retrieveWorkspaceFiles = retrieveWorkspaceFiles;
 /**
  * Walk through the workspace and return `ProjectConfigurations`. Only use this if the projectFileMap is not needed.
  */
-async function retrieveProjectConfigurations(plugins, workspaceRoot, nxJson) {
-    const projects = await _retrieveProjectConfigurations(workspaceRoot, nxJson, plugins);
-    return projects;
+function retrieveProjectConfigurations(plugins, workspaceRoot, nxJson) {
+    const globPatterns = configurationGlobs(plugins);
+    const workspaceFiles = (0, workspace_context_1.globWithWorkspaceContext)(workspaceRoot, globPatterns);
+    return (0, project_configuration_utils_1.createProjectConfigurations)(workspaceRoot, nxJson, workspaceFiles, plugins);
 }
 exports.retrieveProjectConfigurations = retrieveProjectConfigurations;
 async function retrieveProjectConfigurationsWithAngularProjects(workspaceRoot, nxJson) {
@@ -49,16 +50,11 @@ async function retrieveProjectConfigurationsWithAngularProjects(workspaceRoot, n
         pluginsToLoad.push((0, path_1.join)(__dirname, '../../adapter/angular-json'));
     }
     const [plugins, cleanup] = await (0, internal_api_1.loadNxPlugins)(nxJson?.plugins ?? [], workspaceRoot);
-    const res = _retrieveProjectConfigurations(workspaceRoot, nxJson, plugins);
+    const res = retrieveProjectConfigurations(plugins, workspaceRoot, nxJson);
     cleanup();
     return res;
 }
 exports.retrieveProjectConfigurationsWithAngularProjects = retrieveProjectConfigurationsWithAngularProjects;
-function _retrieveProjectConfigurations(workspaceRoot, nxJson, plugins) {
-    const globPatterns = configurationGlobs(plugins);
-    const workspaceFiles = (0, workspace_context_1.globWithWorkspaceContext)(workspaceRoot, globPatterns);
-    return (0, project_configuration_utils_1.createProjectConfigurations)(workspaceRoot, nxJson, workspaceFiles, plugins);
-}
 function retrieveProjectConfigurationPaths(root, plugins) {
     const projectGlobPatterns = configurationGlobs(plugins);
     return (0, workspace_context_1.globWithWorkspaceContext)(root, projectGlobPatterns);

package/src/utils/is-ci.js

@@ -2,7 +2,7 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.isCI = void 0;
 function isCI() {
-    return (process.env.CI === 'true' ||
+    return ((process.env.CI && process.env.CI !== 'false') ||
         process.env.TF_BUILD === 'true' ||
         process.env.GITHUB_ACTIONS === 'true' ||
         process.env.BUILDKITE === 'true' ||