nx 18.3.0-beta.0 → 18.3.0-beta.2

package/src/project-graph/plugins/utils.js

@@ -0,0 +1,80 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.runCreateNodesInParallel = exports.normalizeNxPlugin = exports.isNxPluginV1 = exports.isNxPluginV2 = void 0;
+const node_path_1 = require("node:path");
+const workspaces_1 = require("../../config/workspaces");
+const globs_1 = require("../../utils/globs");
+const error_types_1 = require("../error-types");
+function isNxPluginV2(plugin) {
+    return 'createNodes' in plugin || 'createDependencies' in plugin;
+}
+exports.isNxPluginV2 = isNxPluginV2;
+function isNxPluginV1(plugin) {
+    return 'processProjectGraph' in plugin || 'projectFilePatterns' in plugin;
+}
+exports.isNxPluginV1 = isNxPluginV1;
+function normalizeNxPlugin(plugin) {
+    if (isNxPluginV2(plugin)) {
+        return plugin;
+    }
+    if (isNxPluginV1(plugin) && plugin.projectFilePatterns) {
+        return {
+            ...plugin,
+            createNodes: [
+                `*/**/${(0, globs_1.combineGlobPatterns)(plugin.projectFilePatterns)}`,
+                (configFilePath) => {
+                    const root = (0, node_path_1.dirname)(configFilePath);
+                    return {
+                        projects: {
+                            [root]: {
+                                name: (0, workspaces_1.toProjectName)(configFilePath),
+                                targets: plugin.registerProjectTargets?.(configFilePath),
+                            },
+                        },
+                    };
+                },
+            ],
+        };
+    }
+    return plugin;
+}
+exports.normalizeNxPlugin = normalizeNxPlugin;
+async function runCreateNodesInParallel(configFiles, plugin, options, context) {
+    performance.mark(`${plugin.name}:createNodes - start`);
+    const errors = [];
+    const results = [];
+    const promises = configFiles.map((file) => {
+        performance.mark(`${plugin.name}:createNodes:${file} - start`);
+        // Result is either static or a promise, using Promise.resolve lets us
+        // handle both cases with same logic
+        const value = Promise.resolve(plugin.createNodes[1](file, options, context));
+        return value
+            .catch((e) => {
+            performance.mark(`${plugin.name}:createNodes:${file} - end`);
+            errors.push(new error_types_1.CreateNodesError({
+                error: e,
+                pluginName: plugin.name,
+                file,
+            }));
+            return null;
+        })
+            .then((r) => {
+            performance.mark(`${plugin.name}:createNodes:${file} - end`);
+            performance.measure(`${plugin.name}:createNodes:${file}`, `${plugin.name}:createNodes:${file} - start`, `${plugin.name}:createNodes:${file} - end`);
+            // Existing behavior is to ignore null results of
+            // createNodes function.
+            if (r) {
+                results.push(r);
+            }
+        });
+    });
+    await Promise.all(promises).then(() => {
+        performance.mark(`${plugin.name}:createNodes - end`);
+        performance.measure(`${plugin.name}:createNodes`, `${plugin.name}:createNodes - start`, `${plugin.name}:createNodes - end`);
+    });
+    if (errors.length > 0) {
+        throw new error_types_1.AggregateCreateNodesError(plugin.name, errors, results);
+    }
+    return results;
+}
+exports.runCreateNodesInParallel = runCreateNodesInParallel;

package/src/project-graph/project-graph-builder.d.ts

@@ -2,7 +2,7 @@
  * Builder for adding nodes and dependencies to a {@link ProjectGraph}
  */
 import { DependencyType, FileMap, ProjectFileMap, ProjectGraph, ProjectGraphExternalNode, ProjectGraphProjectNode } from '../config/project-graph';
-import { CreateDependenciesContext } from '../utils/nx-plugin';
+import { CreateDependenciesContext } from './plugins';
 /**
  * A class which builds up a project graph
  * @deprecated The {@link ProjectGraphProcessor} has been deprecated. Use a {@link CreateNodes} and/or a {@link CreateDependencies} instead. This will be removed in Nx 19.

package/src/project-graph/project-graph.d.ts

@@ -1,7 +1,8 @@
 import { ProcessDependenciesError, ProcessProjectGraphError } from './build-project-graph';
 import { ProjectGraph } from '../config/project-graph';
 import { ProjectConfiguration, ProjectsConfigurations } from '../config/workspace-json-project-json';
-import { ConfigurationSourceMaps, CreateNodesError, MergeNodesError } from './utils/project-configuration-utils';
+import { ConfigurationSourceMaps } from './utils/project-configuration-utils';
+import { CreateNodesError, MergeNodesError, ProjectsWithNoNameError, ProjectsWithConflictingNamesError } from './error-types';
 import { DaemonProjectGraphError } from '../daemon/daemon-project-graph-error';
 /**
  * Synchronously reads the latest cached copy of the workspace's ProjectGraph.
@@ -19,7 +20,7 @@ export declare function buildProjectGraphAndSourceMapsWithoutDaemon(): Promise<{
 }>;
 export declare class ProjectGraphError extends Error {
     #private;
-    constructor(errors: Array<CreateNodesError | MergeNodesError | ProcessDependenciesError | ProcessProjectGraphError>, partialProjectGraph: ProjectGraph, partialSourceMaps: ConfigurationSourceMaps);
+    constructor(errors: Array<CreateNodesError | MergeNodesError | ProjectsWithNoNameError | ProjectsWithConflictingNamesError | ProcessDependenciesError | ProcessProjectGraphError>, partialProjectGraph: ProjectGraph, partialSourceMaps: ConfigurationSourceMaps);
     /**
      * The daemon cannot throw errors which contain methods as they are not serializable.
      *
@@ -33,7 +34,7 @@ export declare class ProjectGraphError extends Error {
      */
     getPartialProjectGraph(): ProjectGraph;
     getPartialSourcemaps(): ConfigurationSourceMaps;
-    getErrors(): (ProcessDependenciesError | ProcessProjectGraphError | CreateNodesError)[];
+    getErrors(): (ProjectsWithConflictingNamesError | ProjectsWithNoNameError | MergeNodesError | CreateNodesError | ProcessDependenciesError | ProcessProjectGraphError)[];
 }
 /**
  * Computes and returns a ProjectGraph.

package/src/project-graph/project-graph.js

@@ -14,8 +14,8 @@ const workspace_root_1 = require("../utils/workspace-root");
 const perf_hooks_1 = require("perf_hooks");
 const retrieve_workspace_files_1 = require("./utils/retrieve-workspace-files");
 const nx_json_1 = require("../config/nx-json");
-const nx_plugin_1 = require("../utils/nx-plugin");
-const project_configuration_utils_1 = require("./utils/project-configuration-utils");
+const error_types_1 = require("./error-types");
+const internal_api_1 = require("./plugins/internal-api");
 /**
  * Synchronously reads the latest cached copy of the workspace's ProjectGraph.
  * @throws {Error} if there is no cached ProjectGraph to read from
@@ -69,17 +69,17 @@ function readProjectsConfigurationFromProjectGraph(projectGraph) {
 }
 exports.readProjectsConfigurationFromProjectGraph = readProjectsConfigurationFromProjectGraph;
 async function buildProjectGraphAndSourceMapsWithoutDaemon() {
-    // Set this globally to allow plugins to know if they are being called from the project graph creation
     global.NX_GRAPH_CREATION = true;
     const nxJson = (0, nx_json_1.readNxJson)();
     perf_hooks_1.performance.mark('retrieve-project-configurations:start');
     let configurationResult;
     let projectConfigurationsError;
+    const [plugins, cleanup] = await (0, internal_api_1.loadNxPlugins)(nxJson.plugins);
     try {
-        configurationResult = await (0, retrieve_workspace_files_1.retrieveProjectConfigurations)(workspace_root_1.workspaceRoot, nxJson);
+        configurationResult = await (0, retrieve_workspace_files_1.retrieveProjectConfigurations)(plugins, workspace_root_1.workspaceRoot, nxJson);
     }
     catch (e) {
-        if (e instanceof project_configuration_utils_1.ProjectConfigurationsError) {
+        if (e instanceof error_types_1.ProjectConfigurationsError) {
             projectConfigurationsError = e;
             configurationResult = e.partialProjectConfigurationsResult;
         }
@@ -97,7 +97,7 @@ async function buildProjectGraphAndSourceMapsWithoutDaemon() {
     let createDependenciesError;
     let projectGraphResult;
     try {
-        projectGraphResult = await (0, build_project_graph_1.buildProjectGraphUsingProjectFileMap)(projects, externalNodes, fileMap, allWorkspaceFiles, rustReferences, cacheEnabled ? (0, nx_deps_cache_1.readFileMapCache)() : null);
+        projectGraphResult = await (0, build_project_graph_1.buildProjectGraphUsingProjectFileMap)(projects, externalNodes, fileMap, allWorkspaceFiles, rustReferences, cacheEnabled ? (0, nx_deps_cache_1.readFileMapCache)() : null, plugins);
     }
     catch (e) {
         if (e instanceof build_project_graph_1.CreateDependenciesError) {
@@ -111,9 +111,11 @@ async function buildProjectGraphAndSourceMapsWithoutDaemon() {
             throw e;
         }
     }
+    finally {
+        cleanup();
+    }
     const { projectGraph, projectFileMapCache } = projectGraphResult;
     perf_hooks_1.performance.mark('build-project-graph-using-project-file-map:end');
-    (0, nx_plugin_1.unregisterPluginTSTranspiler)();
     delete global.NX_GRAPH_CREATION;
     const errors = [
         ...(projectConfigurationsError?.errors ?? []),

package/src/project-graph/utils/normalize-project-nodes.d.ts

@@ -1,7 +1,7 @@
 import { ProjectGraphProjectNode } from '../../config/project-graph';
 import { ProjectGraphBuilder } from '../project-graph-builder';
 import { ProjectConfiguration, TargetConfiguration } from '../../config/workspace-json-project-json';
-import { CreateDependenciesContext } from '../../utils/nx-plugin';
+import { CreateDependenciesContext } from '../plugins';
 export declare function normalizeProjectNodes(ctx: CreateDependenciesContext, builder: ProjectGraphBuilder): Promise<void>;
 /**
  * Apply target defaults and normalization

package/src/project-graph/utils/project-configuration-utils.d.ts

@@ -1,8 +1,8 @@
 import { NxJsonConfiguration, TargetDefaults } from '../../config/nx-json';
 import { ProjectGraphExternalNode } from '../../config/project-graph';
 import { ProjectConfiguration, TargetConfiguration } from '../../config/workspace-json-project-json';
-import { LoadedNxPlugin } from '../../utils/nx-plugin';
-import { ONLY_MODIFIES_EXISTING_TARGET } from '../../plugins/target-defaults/target-defaults-plugin';
+import { ONLY_MODIFIES_EXISTING_TARGET } from '../../plugins/target-defaults/symbols';
+import { LoadedNxPlugin } from '../plugins/internal-api';
 export type SourceInformation = [file: string, plugin: string];
 export type ConfigurationSourceMaps = Record<string, Record<string, SourceInformation>>;
 export declare function mergeProjectConfigurationIntoRootMap(projectRootMap: Map<string, ProjectConfiguration>, project: ProjectConfiguration & {
@@ -24,32 +24,9 @@ export type ConfigurationResult = {
  * @param workspaceFiles A list of non-ignored workspace files
  * @param plugins The plugins that should be used to infer project configuration
  */
-export declare function createProjectConfigurations(root: string, nxJson: NxJsonConfiguration, workspaceFiles: string[], // making this parameter allows devkit to pick up newly created projects
+export declare function createProjectConfigurations(root: string, nxJson: NxJsonConfiguration, projectFiles: string[], // making this parameter allows devkit to pick up newly created projects
 plugins: LoadedNxPlugin[]): Promise<ConfigurationResult>;
 export declare function readProjectConfigurationsFromRootMap(projectRootMap: Map<string, ProjectConfiguration>): Record<string, ProjectConfiguration>;
-export declare class ProjectConfigurationsError extends Error {
-    readonly errors: Array<MergeNodesError | CreateNodesError>;
-    readonly partialProjectConfigurationsResult: ConfigurationResult;
-    constructor(errors: Array<MergeNodesError | CreateNodesError>, partialProjectConfigurationsResult: ConfigurationResult);
-}
-export declare class CreateNodesError extends Error {
-    file: string;
-    pluginName: string;
-    constructor({ file, pluginName, error, }: {
-        file: string;
-        pluginName: string;
-        error: Error;
-    });
-}
-export declare class MergeNodesError extends Error {
-    file: string;
-    pluginName: string;
-    constructor({ file, pluginName, error, }: {
-        file: string;
-        pluginName: string;
-        error: Error;
-    });
-}
 /**
  * Merges two targets.
  *

package/src/project-graph/utils/project-configuration-utils.js

@@ -1,13 +1,14 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.readTargetDefaultsForTarget = exports.resolveNxTokensInOptions = exports.isCompatibleTarget = exports.mergeTargetConfigurations = exports.MergeNodesError = exports.CreateNodesError = exports.ProjectConfigurationsError = exports.readProjectConfigurationsFromRootMap = exports.createProjectConfigurations = exports.mergeProjectConfigurationIntoRootMap = void 0;
+exports.readTargetDefaultsForTarget = exports.resolveNxTokensInOptions = exports.isCompatibleTarget = exports.mergeTargetConfigurations = exports.readProjectConfigurationsFromRootMap = exports.createProjectConfigurations = exports.mergeProjectConfigurationIntoRootMap = void 0;
 const logger_1 = require("../../utils/logger");
 const fileutils_1 = require("../../utils/fileutils");
 const workspace_root_1 = require("../../utils/workspace-root");
-const target_defaults_plugin_1 = require("../../plugins/target-defaults/target-defaults-plugin");
+const symbols_1 = require("../../plugins/target-defaults/symbols");
 const minimatch_1 = require("minimatch");
 const path_1 = require("path");
 const perf_hooks_1 = require("perf_hooks");
+const error_types_1 = require("../error-types");
 function mergeProjectConfigurationIntoRootMap(projectRootMap, project, configurationSourceMaps, sourceInformation, 
 // This function is used when reading project configuration
 // in generators, where we don't want to do this.
@@ -119,12 +120,12 @@ skipCommandNormalization) {
             // Always set source map info for the target, but don't overwrite info already there
             // if augmenting an existing target.
             const target = project.targets?.[targetName];
-            if (sourceMap && !target?.[target_defaults_plugin_1.ONLY_MODIFIES_EXISTING_TARGET]) {
+            if (sourceMap && !target?.[symbols_1.ONLY_MODIFIES_EXISTING_TARGET]) {
                 sourceMap[`targets.${targetName}`] = sourceInformation;
             }
             // If ONLY_MODIFIES_EXISTING_TARGET is true, and its not on the matching project
             // we shouldn't merge its info into the graph
-            if (target?.[target_defaults_plugin_1.ONLY_MODIFIES_EXISTING_TARGET] &&
+            if (target?.[symbols_1.ONLY_MODIFIES_EXISTING_TARGET] &&
                 !matchingProject.targets?.[targetName]) {
                 continue;
             }
@@ -132,8 +133,8 @@ skipCommandNormalization) {
                 ? target
                 : resolveCommandSyntacticSugar(target, project.root), matchingProject.targets?.[targetName], sourceMap, sourceInformation, `targets.${targetName}`);
             // We don't want the symbol to live on past the merge process
-            if (mergedTarget?.[target_defaults_plugin_1.ONLY_MODIFIES_EXISTING_TARGET])
-                delete mergedTarget?.[target_defaults_plugin_1.ONLY_MODIFIES_EXISTING_TARGET];
+            if (mergedTarget?.[symbols_1.ONLY_MODIFIES_EXISTING_TARGET])
+                delete mergedTarget?.[symbols_1.ONLY_MODIFIES_EXISTING_TARGET];
             updatedProjectConfiguration.targets[targetName] = mergedTarget;
         }
     }
@@ -217,21 +218,19 @@ function mergeMetadata(sourceMap, sourceInformation, baseSourceMapPath, metadata
  * @param workspaceFiles A list of non-ignored workspace files
  * @param plugins The plugins that should be used to infer project configuration
  */
-function createProjectConfigurations(root = workspace_root_1.workspaceRoot, nxJson, workspaceFiles, // making this parameter allows devkit to pick up newly created projects
+async function createProjectConfigurations(root = workspace_root_1.workspaceRoot, nxJson, projectFiles, // making this parameter allows devkit to pick up newly created projects
 plugins) {
     perf_hooks_1.performance.mark('build-project-configs:start');
     const results = [];
     const errors = [];
     // We iterate over plugins first - this ensures that plugins specified first take precedence.
-    for (const { plugin, options, include, exclude } of plugins) {
-        const [pattern, createNodes] = plugin.createNodes ?? [];
-        const pluginResults = [];
-        perf_hooks_1.performance.mark(`${plugin.name}:createNodes - start`);
+    for (const { name: pluginName, createNodes: createNodesTuple, include, exclude, } of plugins) {
+        const [pattern, createNodes] = createNodesTuple ?? [];
         if (!pattern) {
             continue;
         }
         const matchingConfigFiles = [];
-        for (const file of workspaceFiles) {
+        for (const file of projectFiles) {
             if ((0, minimatch_1.minimatch)(file, pattern, { dot: true })) {
                 if (include) {
                     const included = include.some((includedPattern) => (0, minimatch_1.minimatch)(file, includedPattern, { dot: true }));
@@ -240,7 +239,7 @@ plugins) {
                     }
                 }
                 if (exclude) {
-                    const excluded = include.some((excludedPattern) => (0, minimatch_1.minimatch)(file, excludedPattern, { dot: true }));
+                    const excluded = exclude.some((excludedPattern) => (0, minimatch_1.minimatch)(file, excludedPattern, { dot: true }));
                     if (excluded) {
                         continue;
                     }
@@ -248,56 +247,20 @@ plugins) {
                 matchingConfigFiles.push(file);
             }
         }
-        for (const file of matchingConfigFiles) {
-            perf_hooks_1.performance.mark(`${plugin.name}:createNodes:${file} - start`);
-            try {
-                let r = createNodes(file, options, {
-                    nxJsonConfiguration: nxJson,
-                    workspaceRoot: root,
-                    configFiles: matchingConfigFiles,
-                });
-                if (r instanceof Promise) {
-                    pluginResults.push(r
-                        .catch((error) => {
-                        perf_hooks_1.performance.mark(`${plugin.name}:createNodes:${file} - end`);
-                        errors.push(new CreateNodesError({
-                            file,
-                            pluginName: plugin.name,
-                            error,
-                        }));
-                        return {
-                            projects: {},
-                        };
-                    })
-                        .then((r) => {
-                        perf_hooks_1.performance.mark(`${plugin.name}:createNodes:${file} - end`);
-                        perf_hooks_1.performance.measure(`${plugin.name}:createNodes:${file}`, `${plugin.name}:createNodes:${file} - start`, `${plugin.name}:createNodes:${file} - end`);
-                        return { ...r, file, pluginName: plugin.name };
-                    }));
-                }
-                else {
-                    perf_hooks_1.performance.mark(`${plugin.name}:createNodes:${file} - end`);
-                    perf_hooks_1.performance.measure(`${plugin.name}:createNodes:${file}`, `${plugin.name}:createNodes:${file} - start`, `${plugin.name}:createNodes:${file} - end`);
-                    pluginResults.push({
-                        ...r,
-                        file,
-                        pluginName: plugin.name,
-                    });
-                }
+        let r = createNodes(matchingConfigFiles, {
+            nxJsonConfiguration: nxJson,
+            workspaceRoot: root,
+            configFiles: matchingConfigFiles,
+        }).catch((e) => {
+            if ((0, error_types_1.isAggregateCreateNodesError)(e)) {
+                errors.push(...e.errors);
+                return e.partialResults;
             }
-            catch (error) {
-                errors.push(new CreateNodesError({
-                    file,
-                    pluginName: plugin.name,
-                    error,
-                }));
+            else {
+                throw e;
             }
-        }
-        results.push(Promise.all(pluginResults).then((results) => {
-            perf_hooks_1.performance.mark(`${plugin.name}:createNodes - end`);
-            perf_hooks_1.performance.measure(`${plugin.name}:createNodes`, `${plugin.name}:createNodes - start`, `${plugin.name}:createNodes - end`);
-            return results;
-        }));
+        });
+        results.push(r);
     }
     return Promise.all(results).then((results) => {
         perf_hooks_1.performance.mark('createNodes:merge - start');
@@ -307,8 +270,8 @@ plugins) {
         for (const result of results.flat()) {
             const { projects: projectNodes, externalNodes: pluginExternalNodes, file, pluginName, } = result;
             const sourceInfo = [file, pluginName];
-            if (result[target_defaults_plugin_1.OVERRIDE_SOURCE_FILE]) {
-                sourceInfo[0] = result[target_defaults_plugin_1.OVERRIDE_SOURCE_FILE];
+            if (result[symbols_1.OVERRIDE_SOURCE_FILE]) {
+                sourceInfo[0] = result[symbols_1.OVERRIDE_SOURCE_FILE];
             }
             for (const node in projectNodes) {
                 const project = {
@@ -319,7 +282,7 @@ plugins) {
                     mergeProjectConfigurationIntoRootMap(projectRootMap, project, configurationSourceMaps, sourceInfo);
                 }
                 catch (error) {
-                    errors.push(new MergeNodesError({
+                    errors.push(new error_types_1.MergeNodesError({
                         file,
                         pluginName,
                         error,
@@ -328,7 +291,20 @@ plugins) {
             }
             Object.assign(externalNodes, pluginExternalNodes);
         }
-        const projects = readProjectConfigurationsFromRootMap(projectRootMap);
+        let projects;
+        try {
+            projects = readProjectConfigurationsFromRootMap(projectRootMap);
+        }
+        catch (e) {
+            if ((0, error_types_1.isProjectsWithNoNameError)(e) ||
+                (0, error_types_1.isProjectsWithConflictingNamesError)(e)) {
+                projects = e.projects;
+                errors.push(e);
+            }
+            else {
+                throw e;
+            }
+        }
         const rootMap = createRootMap(projectRootMap);
         perf_hooks_1.performance.mark('createNodes:merge - end');
         perf_hooks_1.performance.measure('createNodes:merge', 'createNodes:merge - start', 'createNodes:merge - end');
@@ -343,7 +319,7 @@ plugins) {
             };
         }
         else {
-            throw new ProjectConfigurationsError(errors, {
+            throw new error_types_1.ProjectConfigurationsError(errors, {
                 projects,
                 externalNodes,
                 projectRootMap: rootMap,
@@ -358,7 +334,8 @@ function readProjectConfigurationsFromRootMap(projectRootMap) {
     // If there are projects that have the same name, that is an error.
     // This object tracks name -> (all roots of projects with that name)
     // to provide better error messaging.
-    const errors = new Map();
+    const conflicts = new Map();
+    const projectRootsWithNoName = [];
     for (const [root, configuration] of projectRootMap.entries()) {
         // We're setting `// targets` as a comment `targets` is empty due to Project Crystal.
         // Strip it before returning configuration for usage.
@@ -370,62 +347,30 @@ function readProjectConfigurationsFromRootMap(projectRootMap) {
                 configuration.name = name;
             }
             catch {
-                throw new Error(`Project at ${root} has no name provided.`);
+                projectRootsWithNoName.push(root);
             }
         }
         if (configuration.name in projects) {
-            let rootErrors = errors.get(configuration.name) ?? [
+            let rootErrors = conflicts.get(configuration.name) ?? [
                 projects[configuration.name].root,
             ];
             rootErrors.push(root);
-            errors.set(configuration.name, rootErrors);
+            conflicts.set(configuration.name, rootErrors);
+            projects[configuration.name] = configuration;
         }
         else {
             projects[configuration.name] = configuration;
         }
     }
-    if (errors.size > 0) {
-        throw new Error([
-            `The following projects are defined in multiple locations:`,
-            ...Array.from(errors.entries()).map(([project, roots]) => [`- ${project}: `, ...roots.map((r) => `  - ${r}`)].join('\n')),
-            '',
-            "To fix this, set a unique name for each project in a project.json inside the project's root. If the project does not currently have a project.json, you can create one that contains only a name.",
-        ].join('\n'));
+    if (conflicts.size > 0) {
+        throw new error_types_1.ProjectsWithConflictingNamesError(conflicts, projects);
+    }
+    if (projectRootsWithNoName.length > 0) {
+        throw new error_types_1.ProjectsWithNoNameError(projectRootsWithNoName, projects);
     }
     return projects;
 }
 exports.readProjectConfigurationsFromRootMap = readProjectConfigurationsFromRootMap;
-class ProjectConfigurationsError extends Error {
-    constructor(errors, partialProjectConfigurationsResult) {
-        super('Failed to create project configurations');
-        this.errors = errors;
-        this.partialProjectConfigurationsResult = partialProjectConfigurationsResult;
-        this.name = this.constructor.name;
-    }
-}
-exports.ProjectConfigurationsError = ProjectConfigurationsError;
-class CreateNodesError extends Error {
-    constructor({ file, pluginName, error, }) {
-        const msg = `The "${pluginName}" plugin threw an error while creating nodes from ${file}:`;
-        super(msg, { cause: error });
-        this.name = this.constructor.name;
-        this.file = file;
-        this.pluginName = pluginName;
-        this.stack = `${this.message}\n  ${error.stack.split('\n').join('\n  ')}`;
-    }
-}
-exports.CreateNodesError = CreateNodesError;
-class MergeNodesError extends Error {
-    constructor({ file, pluginName, error, }) {
-        const msg = `The nodes created from ${file} by the "${pluginName}" could not be merged into the project graph:`;
-        super(msg, { cause: error });
-        this.name = this.constructor.name;
-        this.file = file;
-        this.pluginName = pluginName;
-        this.stack = `${this.message}\n  ${error.stack.split('\n').join('\n  ')}`;
-    }
-}
-exports.MergeNodesError = MergeNodesError;
 /**
  * Merges two targets.
  *
@@ -448,7 +393,7 @@ function mergeTargetConfigurations(target, baseTarget, projectConfigSourceMap, s
     // with the new one. However, we have a special case for targets that have the
     // ONLY_MODIFIES_EXISTING_TARGET symbol set. This prevents the merged target
     // equaling info that should have only been used to modify the existing target.
-    if (!isCompatible && target[target_defaults_plugin_1.ONLY_MODIFIES_EXISTING_TARGET]) {
+    if (!isCompatible && target[symbols_1.ONLY_MODIFIES_EXISTING_TARGET]) {
         return baseTarget;
     }
     if (!isCompatible && projectConfigSourceMap) {

package/src/project-graph/utils/retrieve-workspace-files.d.ts

@@ -1,7 +1,7 @@
 import { ProjectConfiguration } from '../../config/workspace-json-project-json';
 import { NxJsonConfiguration } from '../../config/nx-json';
 import { ConfigurationResult } from './project-configuration-utils';
-import { LoadedNxPlugin } from '../../utils/nx-plugin';
+import { LoadedNxPlugin } from '../plugins/internal-api';
 /**
  * Walks the workspace directory to create the `projectFileMap`, `ProjectConfigurations` and `allWorkspaceFiles`
  * @throws
@@ -9,21 +9,22 @@ import { LoadedNxPlugin } from '../../utils/nx-plugin';
  * @param nxJson
  */
 export declare function retrieveWorkspaceFiles(workspaceRoot: string, projectRootMap: Record<string, string>): Promise<{
-    allWorkspaceFiles: import("nx/src/devkit-exports").FileData[];
+    allWorkspaceFiles: import("../file-utils").FileData[];
     fileMap: {
         projectFileMap: ProjectFiles;
-        nonProjectFiles: import("nx/src/native").FileData[];
+        nonProjectFiles: import("../../native").FileData[];
     };
-    rustReferences: import("nx/src/native").NxWorkspaceFilesExternals;
+    rustReferences: import("../../native").NxWorkspaceFilesExternals;
 }>;
 /**
  * Walk through the workspace and return `ProjectConfigurations`. Only use this if the projectFileMap is not needed.
- *
- * @param workspaceRoot
- * @param nxJson
  */
-export declare function retrieveProjectConfigurations(workspaceRoot: string, nxJson: NxJsonConfiguration): Promise<ConfigurationResult>;
+export declare function retrieveProjectConfigurations(plugins: LoadedNxPlugin[], workspaceRoot: string, nxJson: NxJsonConfiguration): Promise<ConfigurationResult>;
 export declare function retrieveProjectConfigurationsWithAngularProjects(workspaceRoot: string, nxJson: NxJsonConfiguration): Promise<ConfigurationResult>;
-export declare function retrieveProjectConfigurationPaths(root: string, plugins: LoadedNxPlugin[]): string[];
+export declare function retrieveProjectConfigurationPaths(root: string, plugins: Array<{
+    createNodes?: readonly [string, ...unknown[]];
+} & unknown>): string[];
 export declare function retrieveProjectConfigurationsWithoutPluginInference(root: string): Promise<Record<string, ProjectConfiguration>>;
-export declare function configurationGlobs(plugins: LoadedNxPlugin[]): string[];
+export declare function configurationGlobs(plugins: Array<{
+    createNodes?: readonly [string, ...unknown[]];
+}>): string[];

package/src/project-graph/utils/retrieve-workspace-files.js

@@ -2,15 +2,13 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.configurationGlobs = exports.retrieveProjectConfigurationsWithoutPluginInference = exports.retrieveProjectConfigurationPaths = exports.retrieveProjectConfigurationsWithAngularProjects = exports.retrieveProjectConfigurations = exports.retrieveWorkspaceFiles = void 0;
 const perf_hooks_1 = require("perf_hooks");
-const installation_directory_1 = require("../../utils/installation-directory");
 const angular_json_1 = require("../../adapter/angular-json");
 const nx_json_1 = require("../../config/nx-json");
-const package_json_workspaces_1 = require("../../plugins/package-json-workspaces");
 const project_configuration_utils_1 = require("./project-configuration-utils");
-const nx_plugin_1 = require("../../utils/nx-plugin");
-const project_json_1 = require("../../plugins/project-json/build-nodes/project-json");
+const internal_api_1 = require("../plugins/internal-api");
 const workspace_context_1 = require("../../utils/workspace-context");
 const build_all_workspace_files_1 = require("./build-all-workspace-files");
+const path_1 = require("path");
 /**
  * Walks the workspace directory to create the `projectFileMap`, `ProjectConfigurations` and `allWorkspaceFiles`
  * @throws
@@ -37,29 +35,26 @@ async function retrieveWorkspaceFiles(workspaceRoot, projectRootMap) {
 exports.retrieveWorkspaceFiles = retrieveWorkspaceFiles;
 /**
  * Walk through the workspace and return `ProjectConfigurations`. Only use this if the projectFileMap is not needed.
- *
- * @param workspaceRoot
- * @param nxJson
  */
-async function retrieveProjectConfigurations(workspaceRoot, nxJson) {
-    const plugins = await (0, nx_plugin_1.loadNxPlugins)(nxJson?.plugins ?? [], (0, installation_directory_1.getNxRequirePaths)(workspaceRoot), workspaceRoot);
-    return _retrieveProjectConfigurations(workspaceRoot, nxJson, plugins);
+function retrieveProjectConfigurations(plugins, workspaceRoot, nxJson) {
+    const globPatterns = configurationGlobs(plugins);
+    const workspaceFiles = (0, workspace_context_1.globWithWorkspaceContext)(workspaceRoot, globPatterns);
+    return (0, project_configuration_utils_1.createProjectConfigurations)(workspaceRoot, nxJson, workspaceFiles, plugins);
 }
 exports.retrieveProjectConfigurations = retrieveProjectConfigurations;
 async function retrieveProjectConfigurationsWithAngularProjects(workspaceRoot, nxJson) {
-    const plugins = await (0, nx_plugin_1.loadNxPlugins)(nxJson?.plugins ?? [], (0, installation_directory_1.getNxRequirePaths)(workspaceRoot), workspaceRoot);
+    const pluginsToLoad = nxJson?.plugins ?? [];
     if ((0, angular_json_1.shouldMergeAngularProjects)(workspaceRoot, true) &&
-        !plugins.some((p) => p.plugin.name === angular_json_1.NX_ANGULAR_JSON_PLUGIN_NAME)) {
-        plugins.push({ plugin: angular_json_1.NxAngularJsonPlugin });
+        !pluginsToLoad.some((p) => p === angular_json_1.NX_ANGULAR_JSON_PLUGIN_NAME ||
+            (typeof p === 'object' && p.plugin === angular_json_1.NX_ANGULAR_JSON_PLUGIN_NAME))) {
+        pluginsToLoad.push((0, path_1.join)(__dirname, '../../adapter/angular-json'));
     }
-    return _retrieveProjectConfigurations(workspaceRoot, nxJson, plugins);
+    const [plugins, cleanup] = await (0, internal_api_1.loadNxPlugins)(nxJson?.plugins ?? [], workspaceRoot);
+    const res = retrieveProjectConfigurations(plugins, workspaceRoot, nxJson);
+    cleanup();
+    return res;
 }
 exports.retrieveProjectConfigurationsWithAngularProjects = retrieveProjectConfigurationsWithAngularProjects;
-function _retrieveProjectConfigurations(workspaceRoot, nxJson, plugins) {
-    const globPatterns = configurationGlobs(plugins);
-    const workspaceFiles = (0, workspace_context_1.globWithWorkspaceContext)(workspaceRoot, globPatterns);
-    return (0, project_configuration_utils_1.createProjectConfigurations)(workspaceRoot, nxJson, workspaceFiles, plugins);
-}
 function retrieveProjectConfigurationPaths(root, plugins) {
     const projectGlobPatterns = configurationGlobs(plugins);
     return (0, workspace_context_1.globWithWorkspaceContext)(root, projectGlobPatterns);
@@ -69,25 +64,23 @@ const projectsWithoutPluginCache = new Map();
 // TODO: This function is called way too often, it should be optimized without this cache
 async function retrieveProjectConfigurationsWithoutPluginInference(root) {
     const nxJson = (0, nx_json_1.readNxJson)(root);
-    const plugins = await (0, nx_plugin_1.getDefaultPlugins)(root);
+    const [plugins, cleanup] = await (0, internal_api_1.loadNxPlugins)([]); // only load default plugins
     const projectGlobPatterns = retrieveProjectConfigurationPaths(root, plugins);
     const cacheKey = root + ',' + projectGlobPatterns.join(',');
     if (projectsWithoutPluginCache.has(cacheKey)) {
         return projectsWithoutPluginCache.get(cacheKey);
     }
     const projectFiles = (0, workspace_context_1.globWithWorkspaceContext)(root, projectGlobPatterns) ?? [];
-    const { projects } = await (0, project_configuration_utils_1.createProjectConfigurations)(root, nxJson, projectFiles, [
-        { plugin: (0, package_json_workspaces_1.getNxPackageJsonWorkspacesPlugin)(root) },
-        { plugin: project_json_1.ProjectJsonProjectsPlugin },
-    ]);
+    const { projects } = await (0, project_configuration_utils_1.createProjectConfigurations)(root, nxJson, projectFiles, plugins);
     projectsWithoutPluginCache.set(cacheKey, projects);
+    cleanup();
     return projects;
 }
 exports.retrieveProjectConfigurationsWithoutPluginInference = retrieveProjectConfigurationsWithoutPluginInference;
 function configurationGlobs(plugins) {
     const globPatterns = [];
-    for (const { plugin } of plugins) {
-        if (plugin.createNodes) {
+    for (const plugin of plugins) {
+        if ('createNodes' in plugin && plugin.createNodes) {
             globPatterns.push(plugin.createNodes[0]);
         }
     }