nx 18.1.0-canary.20240221-abc0cf8 → 18.1.0-canary.20240222-5d6abe4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nx",
-  "version": "18.1.0-canary.20240221-abc0cf8",
+  "version": "18.1.0-canary.20240222-5d6abe4",
   "private": false,
   "description": "The core Nx plugin contains the core functionality of Nx like the project graph, nx commands and task orchestration.",
   "repository": {
@@ -66,7 +66,7 @@
     "yargs-parser": "21.1.1",
     "node-machine-id": "1.1.12",
     "ora": "5.3.0",
-    "@nrwl/tao": "18.1.0-canary.20240221-abc0cf8"
+    "@nrwl/tao": "18.1.0-canary.20240222-5d6abe4"
   },
   "peerDependencies": {
     "@swc-node/register": "^1.8.0",
@@ -81,16 +81,16 @@
     }
   },
   "optionalDependencies": {
-    "@nx/nx-darwin-x64": "18.1.0-canary.20240221-abc0cf8",
-    "@nx/nx-darwin-arm64": "18.1.0-canary.20240221-abc0cf8",
-    "@nx/nx-linux-x64-gnu": "18.1.0-canary.20240221-abc0cf8",
-    "@nx/nx-linux-x64-musl": "18.1.0-canary.20240221-abc0cf8",
-    "@nx/nx-win32-x64-msvc": "18.1.0-canary.20240221-abc0cf8",
-    "@nx/nx-linux-arm64-gnu": "18.1.0-canary.20240221-abc0cf8",
-    "@nx/nx-linux-arm64-musl": "18.1.0-canary.20240221-abc0cf8",
-    "@nx/nx-linux-arm-gnueabihf": "18.1.0-canary.20240221-abc0cf8",
-    "@nx/nx-win32-arm64-msvc": "18.1.0-canary.20240221-abc0cf8",
-    "@nx/nx-freebsd-x64": "18.1.0-canary.20240221-abc0cf8"
+    "@nx/nx-darwin-x64": "18.1.0-canary.20240222-5d6abe4",
+    "@nx/nx-darwin-arm64": "18.1.0-canary.20240222-5d6abe4",
+    "@nx/nx-linux-x64-gnu": "18.1.0-canary.20240222-5d6abe4",
+    "@nx/nx-linux-x64-musl": "18.1.0-canary.20240222-5d6abe4",
+    "@nx/nx-win32-x64-msvc": "18.1.0-canary.20240222-5d6abe4",
+    "@nx/nx-linux-arm64-gnu": "18.1.0-canary.20240222-5d6abe4",
+    "@nx/nx-linux-arm64-musl": "18.1.0-canary.20240222-5d6abe4",
+    "@nx/nx-linux-arm-gnueabihf": "18.1.0-canary.20240222-5d6abe4",
+    "@nx/nx-win32-arm64-msvc": "18.1.0-canary.20240222-5d6abe4",
+    "@nx/nx-freebsd-x64": "18.1.0-canary.20240222-5d6abe4"
   },
   "nx-migrations": {
     "migrations": "./migrations.json",
@@ -126,6 +126,7 @@
       "@nrwl/next",
       "@nx/node",
       "@nrwl/node",
+      "@nx/nuxt",
       "@nx/playwright",
       "@nx/plugin",
       "@nrwl/nx-plugin",

package/src/command-line/graph/graph.js

@@ -266,7 +266,7 @@ async function generateGraph(args, affectedProjects) {
         const { app, url } = await startServer(html, environmentJs, args.host || '127.0.0.1', args.port || 4211, args.watch, affectedProjects, args.focus, args.groupByFolder, args.exclude);
         url.pathname = args.view;
         if (args.focus) {
-            url.pathname += '/' + args.focus;
+            url.pathname += '/' + encodeURIComponent(args.focus);
         }
         if (target) {
             url.pathname += '/' + target;

package/src/command-line/release/changelog.js

@@ -2,6 +2,7 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.shouldCreateGitHubRelease = exports.releaseChangelog = exports.releaseChangelogCLIHandler = void 0;
 const chalk = require("chalk");
+const enquirer_1 = require("enquirer");
 const node_fs_1 = require("node:fs");
 const semver_1 = require("semver");
 const tmp_1 = require("tmp");
@@ -10,6 +11,7 @@ const tree_1 = require("../../generators/tree");
 const register_1 = require("../../plugins/js/utils/register");
 const project_graph_1 = require("../../project-graph/project-graph");
 const utils_1 = require("../../tasks-runner/utils");
+const is_ci_1 = require("../../utils/is-ci");
 const output_1 = require("../../utils/output");
 const params_1 = require("../../utils/params");
 const path_1 = require("../../utils/path");
@@ -302,6 +304,25 @@ async function applyChangesAndExit(args, nxReleaseConfig, tree, toSHA, postGitTa
                 `No changes were detected for any changelog files, so no changelog entries will be generated.`,
             ],
         });
+        if (!postGitTasks.length) {
+            // no GitHub releases to create so we can just exit
+            return;
+        }
+        if ((0, is_ci_1.isCI)()) {
+            output_1.output.warn({
+                title: `Skipped GitHub release creation because no changes were detected for any changelog files.`,
+            });
+            return;
+        }
+        // prompt the user to see if they want to create a GitHub release anyway
+        // we know that the user has configured GitHub releases because we have postGitTasks
+        const shouldCreateGitHubReleaseAnyway = await promptForGitHubRelease();
+        if (!shouldCreateGitHubReleaseAnyway) {
+            return;
+        }
+        for (const postGitTask of postGitTasks) {
+            await postGitTask(latestCommit);
+        }
         return;
     }
     // Generate a new commit for the changes, if configured to do so
@@ -600,3 +621,19 @@ function shouldCreateGitHubRelease(changelogConfig, createReleaseArg = undefined
     return (changelogConfig || {}).createRelease === 'github';
 }
 exports.shouldCreateGitHubRelease = shouldCreateGitHubRelease;
+async function promptForGitHubRelease() {
+    try {
+        const result = await (0, enquirer_1.prompt)([
+            {
+                name: 'confirmation',
+                message: 'Do you want to create a GitHub release anyway?',
+                type: 'confirm',
+            },
+        ]);
+        return result.confirmation;
+    }
+    catch (e) {
+        // Handle the case where the user exits the prompt with ctrl+c
+        return false;
+    }
+}

package/src/tasks-runner/task-orchestrator.js

@@ -9,6 +9,7 @@ const utils_1 = require("./utils");
 const tasks_schedule_1 = require("./tasks-schedule");
 const hash_task_1 = require("../hasher/hash-task");
 const task_env_1 = require("./task-env");
+const os = require("os");
 class TaskOrchestrator {
     // endregion internal state
     constructor(hasher, initiatingProject, projectGraph, taskGraph, options, bail, daemon) {
@@ -216,8 +217,10 @@ class TaskOrchestrator {
     }
     async runTaskInForkedProcess(task, env, pipeOutput, temporaryOutputPath, streamOutput) {
         try {
+            let usePtyFork = process.env.NX_NATIVE_COMMAND_RUNNER !== 'false' &&
+                supportedPtyPlatform();
             // execution
-            const { code, terminalOutput } = process.env.NX_NATIVE_COMMAND_RUNNER !== 'false'
+            const { code, terminalOutput } = usePtyFork
                 ? await this.forkedProcessTaskRunner.forkProcess(task, {
                     temporaryOutputPath,
                     streamOutput,
@@ -373,3 +376,22 @@ class TaskOrchestrator {
     }
 }
 exports.TaskOrchestrator = TaskOrchestrator;
+function supportedPtyPlatform() {
+    if (process.platform !== 'win32') {
+        return true;
+    }
+    let windowsVersion = os.release().split('.');
+    let windowsBuild = windowsVersion[2];
+    if (!windowsBuild) {
+        return false;
+    }
+    // Mininum supported Windows version:
+    // https://en.wikipedia.org/wiki/Windows_10,_version_1809
+    // https://learn.microsoft.com/en-us/windows/console/createpseudoconsole#requirements
+    if (+windowsBuild < 17763) {
+        return false;
+    }
+    else {
+        return true;
+    }
+}

package/src/utils/plugins/core-plugins.js

@@ -53,6 +53,10 @@ function fetchCorePlugins() {
             name: '@nx/node',
             capabilities: 'executors,generators',
         },
+        {
+            name: '@nx/nuxt',
+            capabilities: 'generators',
+        },
         {
             name: 'nx',
             capabilities: 'executors',