nx 18.0.3 → 18.0.4

package/src/executors/run-commands/run-commands.impl.js

@@ -65,7 +65,7 @@ async function runInParallel(options, context) {
     if (options.readyWhen) {
         const r = await Promise.race(procs);
         if (!r.result) {
-            process.stderr.write(`Warning: run-commands command "${r.command}" exited with non-zero status code`);
+            process.stderr.write(`Warning: command "${r.command}" exited with non-zero status code`);
             return false;
         }
         else {
@@ -77,7 +77,7 @@ async function runInParallel(options, context) {
         const failed = r.filter((v) => !v.result);
         if (failed.length > 0) {
             failed.forEach((f) => {
-                process.stderr.write(`Warning: run-commands command "${f.command}" exited with non-zero status code`);
+                process.stderr.write(`Warning: command "${f.command}" exited with non-zero status code`);
             });
             return false;
         }
@@ -107,7 +107,7 @@ async function runSerially(options, context) {
     for (const c of options.commands) {
         const success = await createProcess(c, undefined, options.color, calculateCwd(options.cwd, context), options.env ?? {}, false);
         if (!success) {
-            process.stderr.write(`Warning: run-commands command "${c.command}" exited with non-zero status code`);
+            process.stderr.write(`Warning: command "${c.command}" exited with non-zero status code`);
             return false;
         }
     }

package/src/plugins/js/utils/register.d.ts

@@ -21,14 +21,10 @@ export declare function registerTsProject(tsConfigPath: string): () => void;
  * @returns cleanup function
  * @deprecated This signature will be removed in Nx v19. You should pass the full path to the tsconfig in the first argument.
  */
-export declare function registerTsProject(path: string, configFilename: string, 
-/**
- * @deprecated Do not use this.. it's a 1-off exception
- */
-useForSwcEnvironmentVariable?: boolean): any;
-export declare function getSwcTranspiler(compilerOptions: CompilerOptions, tsConfigPath?: string): (...args: unknown[]) => unknown;
+export declare function registerTsProject(path: string, configFilename: string): any;
+export declare function getSwcTranspiler(compilerOptions: CompilerOptions): (...args: unknown[]) => unknown;
 export declare function getTsNodeTranspiler(compilerOptions: CompilerOptions): (...args: unknown[]) => unknown;
-export declare function getTranspiler(compilerOptions: CompilerOptions, tsConfigPath?: string): () => (...args: unknown[]) => unknown;
+export declare function getTranspiler(compilerOptions: CompilerOptions): () => (...args: unknown[]) => unknown;
 /**
  * Register ts-node or swc-node given a set of compiler options.
  *
@@ -37,7 +33,7 @@ export declare function getTranspiler(compilerOptions: CompilerOptions, tsConfig
  *
  * @returns cleanup method
  */
-export declare function registerTranspiler(compilerOptions: CompilerOptions, tsConfigPath?: string): () => void;
+export declare function registerTranspiler(compilerOptions: CompilerOptions): () => void;
 /**
  * @param tsConfigPath Adds the paths from a tsconfig file into node resolutions
  * @returns cleanup function

package/src/plugins/js/utils/register.js

@@ -3,22 +3,16 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.getTsNodeCompilerOptions = exports.registerTsConfigPaths = exports.registerTranspiler = exports.getTranspiler = exports.getTsNodeTranspiler = exports.getSwcTranspiler = exports.registerTsProject = void 0;
 const path_1 = require("path");
 const logger_1 = require("../../../utils/logger");
-const fs_1 = require("fs");
-const workspace_root_1 = require("../../../utils/workspace-root");
 const swcNodeInstalled = packageIsInstalled('@swc-node/register');
 const tsNodeInstalled = packageIsInstalled('ts-node/register');
 let ts;
 let isTsEsmLoaderRegistered = false;
-function registerTsProject(path, configFilename, 
-/**
- * @deprecated Do not use this.. it's a 1-off exception
- */
-useForSwcEnvironmentVariable) {
+function registerTsProject(path, configFilename) {
     const tsConfigPath = configFilename ? (0, path_1.join)(path, configFilename) : path;
     const compilerOptions = readCompilerOptions(tsConfigPath);
     const cleanupFunctions = [
         registerTsConfigPaths(tsConfigPath),
-        registerTranspiler(compilerOptions, useForSwcEnvironmentVariable ? tsConfigPath : undefined),
+        registerTranspiler(compilerOptions),
     ];
     // Add ESM support for `.ts` files.
     // NOTE: There is no cleanup function for this, as it's not possible to unregister the loader.
@@ -39,19 +33,10 @@ useForSwcEnvironmentVariable) {
     };
 }
 exports.registerTsProject = registerTsProject;
-function getSwcTranspiler(compilerOptions, tsConfigPath) {
+function getSwcTranspiler(compilerOptions) {
     // These are requires to prevent it from registering when it shouldn't
     const register = require('@swc-node/register/register')
         .register;
-    if (tsConfigPath) {
-        process.env.SWC_NODE_PROJECT = tsConfigPath;
-    }
-    else {
-        let rootTsConfig = (0, path_1.join)(workspace_root_1.workspaceRoot, 'tsconfig.base.json');
-        if ((0, fs_1.existsSync)(rootTsConfig)) {
-            process.env.SWC_NODE_PROJECT = rootTsConfig;
-        }
-    }
     const cleanupFn = register(compilerOptions);
     return typeof cleanupFn === 'function' ? cleanupFn : () => { };
 }
@@ -75,7 +60,7 @@ function getTsNodeTranspiler(compilerOptions) {
     };
 }
 exports.getTsNodeTranspiler = getTsNodeTranspiler;
-function getTranspiler(compilerOptions, tsConfigPath) {
+function getTranspiler(compilerOptions) {
     const preferTsNode = process.env.NX_PREFER_TS_NODE === 'true';
     if (!ts) {
         ts = require('typescript');
@@ -86,7 +71,7 @@ function getTranspiler(compilerOptions, tsConfigPath) {
     compilerOptions.inlineSourceMap = true;
     compilerOptions.skipLibCheck = true;
     if (swcNodeInstalled && !preferTsNode) {
-        return () => getSwcTranspiler(compilerOptions, tsConfigPath);
+        return () => getSwcTranspiler(compilerOptions);
     }
     // We can fall back on ts-node if it's available
     if (tsNodeInstalled) {
@@ -102,9 +87,9 @@ exports.getTranspiler = getTranspiler;
  *
  * @returns cleanup method
  */
-function registerTranspiler(compilerOptions, tsConfigPath) {
+function registerTranspiler(compilerOptions) {
     // Function to register transpiler that returns cleanup function
-    const transpiler = getTranspiler(compilerOptions, tsConfigPath);
+    const transpiler = getTranspiler(compilerOptions);
     if (!transpiler) {
         warnNoTranspiler();
         return () => { };

package/src/tasks-runner/life-cycles/static-run-one-terminal-output-life-cycle.d.ts

@@ -19,6 +19,7 @@ export declare class StaticRunOneTerminalOutputLifeCycle implements LifeCycle {
     constructor(initiatingProject: string, projectNames: string[], tasks: Task[], args: {
         targets?: string[];
         configuration?: string;
+        verbose?: boolean;
     });
     startCommand(): void;
     endCommand(): void;

package/src/tasks-runner/life-cycles/static-run-one-terminal-output-life-cycle.js

@@ -78,12 +78,20 @@ class StaticRunOneTerminalOutputLifeCycle {
         }
     }
     printTaskTerminalOutput(task, status, terminalOutput) {
-        if (status === 'success' ||
+        const args = (0, utils_1.getPrintableCommandArgsForTask)(task);
+        if (this.args.verbose ||
+            status === 'success' ||
             status === 'failure' ||
             task.target.project === this.initiatingProject) {
-            const args = (0, utils_1.getPrintableCommandArgsForTask)(task);
             output_1.output.logCommandOutput(args.join(' '), status, terminalOutput);
         }
+        else {
+            /**
+             * Do not show the terminal output in the case where it is not the initiating project and verbose is not set,
+             * but still print the command that was run and its status (so that cache hits can still be traced).
+             */
+            output_1.output.logCommandOutput(args.join(' '), status, '');
+        }
     }
 }
 exports.StaticRunOneTerminalOutputLifeCycle = StaticRunOneTerminalOutputLifeCycle;