nx 17.3.0 → 17.3.2

package/src/tasks-runner/run-command.js

@@ -140,7 +140,7 @@ async function invokeTasksRunner({ tasks, projectGraph, taskGraph, lifeCycle, nx
                         title: `TaskGraph is now required as an argument to hashTask`,
                         bodyLines: [
                             `The TaskGraph object can be retrieved from the context`,
-                            'This will result in an error in Nx 18',
+                            'This will result in an error in Nx 19',
                         ],
                     });
                     taskGraph_ = taskGraph;
@@ -150,7 +150,7 @@ async function invokeTasksRunner({ tasks, projectGraph, taskGraph, lifeCycle, nx
                         title: `The environment variables are now required as an argument to hashTask`,
                         bodyLines: [
                             `Please pass the environment variables used when running the task`,
-                            'This will result in an error in Nx 18',
+                            'This will result in an error in Nx 19',
                         ],
                     });
                     env = process.env;
@@ -163,7 +163,7 @@ async function invokeTasksRunner({ tasks, projectGraph, taskGraph, lifeCycle, nx
                         title: `TaskGraph is now required as an argument to hashTasks`,
                         bodyLines: [
                             `The TaskGraph object can be retrieved from the context`,
-                            'This will result in an error in Nx 18',
+                            'This will result in an error in Nx 19',
                         ],
                     });
                     taskGraph_ = taskGraph;
@@ -173,7 +173,7 @@ async function invokeTasksRunner({ tasks, projectGraph, taskGraph, lifeCycle, nx
                         title: `The environment variables are now required as an argument to hashTasks`,
                         bodyLines: [
                             `Please pass the environment variables used when running the tasks`,
-                            'This will result in an error in Nx 18',
+                            'This will result in an error in Nx 19',
                         ],
                     });
                     env = process.env;

package/src/tasks-runner/task-env.js

@@ -35,8 +35,7 @@ function getEnvVariablesForTask(task, taskSpecificEnv, forceColor, skipNxCache,
         delete res.NX_STREAM_OUTPUT;
         delete res.NX_PREFIX_OUTPUT;
     }
-    delete res.NX_BASE;
-    delete res.NX_HEAD;
+    // we don't reset NX_BASE or NX_HEAD because those are set by the user and should be preserved
     delete res.NX_SET_CLI;
     return res;
 }

package/src/tasks-runner/utils.d.ts

@@ -18,7 +18,7 @@ declare class InvalidOutputsError extends Error {
 export declare function validateOutputs(outputs: string[]): void;
 export declare function transformLegacyOutputs(projectRoot: string, error: InvalidOutputsError): string[];
 /**
- * @deprecated Pass the target and overrides instead. This will be removed in v18.
+ * @deprecated Pass the target and overrides instead. This will be removed in v19.
  */
 export declare function getOutputsForTargetAndConfiguration(task: Task, node: ProjectGraphProjectNode): string[];
 export declare function getOutputsForTargetAndConfiguration(target: Task['target'] | Task, overrides: Task['overrides'] | ProjectGraphProjectNode, node: ProjectGraphProjectNode): string[];

package/src/utils/nx-plugin.deprecated.d.ts

@@ -2,30 +2,30 @@ import { ProjectGraphProcessor } from '../config/project-graph';
 import { TargetConfiguration } from '../config/workspace-json-project-json';
 import { LoadedNxPlugin } from './nx-plugin';
 /**
- * @deprecated Add targets to the projects in a {@link CreateNodes} function instead. This will be removed in Nx 18
+ * @deprecated Add targets to the projects in a {@link CreateNodes} function instead. This will be removed in Nx 19
  */
 export type ProjectTargetConfigurator = (file: string) => Record<string, TargetConfiguration>;
 /**
- * @deprecated Use {@link NxPluginV2} instead. This will be removed in Nx 18
+ * @deprecated Use {@link NxPluginV2} instead. This will be removed in Nx 19
  */
 export type NxPluginV1 = {
     name: string;
     /**
-     * @deprecated Use {@link CreateNodes} and {@link CreateDependencies} instead. This will be removed in Nx 18
+     * @deprecated Use {@link CreateNodes} and {@link CreateDependencies} instead. This will be removed in Nx 19
      */
     processProjectGraph?: ProjectGraphProcessor;
     /**
-     * @deprecated Add targets to the projects inside of {@link CreateNodes} instead. This will be removed in Nx 18
+     * @deprecated Add targets to the projects inside of {@link CreateNodes} instead. This will be removed in Nx 19
      */
     registerProjectTargets?: ProjectTargetConfigurator;
     /**
      * A glob pattern to search for non-standard project files.
      * @example: ["*.csproj", "pom.xml"]
-     * @deprecated Use {@link CreateNodes} instead. This will be removed in Nx 18
+     * @deprecated Use {@link CreateNodes} instead. This will be removed in Nx 19
      */
     projectFilePatterns?: string[];
 };
 /**
- * @todo(@agentender) v18: Remove this fn when we remove readWorkspaceConfig
+ * @todo(@agentender) v19: Remove this fn when we remove readWorkspaceConfig
  */
 export declare function getDefaultPluginsSync(root: string): LoadedNxPlugin[];

package/src/utils/nx-plugin.deprecated.js

@@ -6,7 +6,7 @@ const project_json_1 = require("../plugins/project-json/build-nodes/project-json
 const target_defaults_plugin_1 = require("../plugins/target-defaults/target-defaults-plugin");
 const package_json_workspaces_1 = require("../plugins/package-json-workspaces");
 /**
- * @todo(@agentender) v18: Remove this fn when we remove readWorkspaceConfig
+ * @todo(@agentender) v19: Remove this fn when we remove readWorkspaceConfig
  */
 function getDefaultPluginsSync(root) {
     const plugins = [

package/src/utils/output.d.ts

@@ -58,6 +58,9 @@ declare class CLIOutput {
     success({ title, bodyLines }: CLISuccessMessageConfig): void;
     logSingleLine(message: string): void;
     logCommand(message: string, taskStatus?: TaskStatus): void;
+    logCommandOutput(message: string, taskStatus: TaskStatus, output: string): void;
+    private getCommandWithStatus;
+    private getStatusIcon;
     private normalizeMessage;
     private addTaskStatus;
     log({ title, bodyLines, color }: CLIWarnMessageConfig & {

package/src/utils/output.js

@@ -5,6 +5,8 @@ const chalk = require("chalk");
 const os_1 = require("os");
 const readline = require("readline");
 const is_ci_1 = require("./is-ci");
+const GH_GROUP_PREFIX = '::group::';
+const GH_GROUP_SUFFIX = '::endgroup::';
 /**
  * Automatically disable styling applied by chalk if CI=true
  */
@@ -152,11 +154,42 @@ class CLIOutput {
     }
     logCommand(message, taskStatus) {
         this.addNewline();
-        const commandOutput = chalk.dim('> ') + this.formatCommand(this.normalizeMessage(message));
-        const commandOutputWithStatus = this.addTaskStatus(taskStatus, commandOutput);
+        this.writeToStdOut(this.getCommandWithStatus(message, taskStatus));
+        this.addNewline();
+        this.addNewline();
+    }
+    logCommandOutput(message, taskStatus, output) {
+        let commandOutputWithStatus = this.getCommandWithStatus(message, taskStatus);
+        if (process.env.GITHUB_ACTIONS) {
+            const icon = this.getStatusIcon(taskStatus);
+            commandOutputWithStatus = `${GH_GROUP_PREFIX}${icon} ${commandOutputWithStatus}`;
+        }
+        this.addNewline();
         this.writeToStdOut(commandOutputWithStatus);
         this.addNewline();
         this.addNewline();
+        this.writeToStdOut(output);
+        if (process.env.GITHUB_ACTIONS) {
+            this.writeToStdOut(GH_GROUP_SUFFIX);
+        }
+    }
+    getCommandWithStatus(message, taskStatus) {
+        const commandOutput = chalk.dim('> ') + this.formatCommand(this.normalizeMessage(message));
+        return this.addTaskStatus(taskStatus, commandOutput);
+    }
+    getStatusIcon(taskStatus) {
+        switch (taskStatus) {
+            case 'success':
+                return '✔️';
+            case 'failure':
+                return '❌';
+            case 'skipped':
+            case 'local-cache-kept-existing':
+                return '⏩';
+            case 'local-cache':
+            case 'remote-cache':
+                return '🔁';
+        }
     }
     normalizeMessage(message) {
         if (message.startsWith('nx run ')) {

package/src/utils/package-json.d.ts

@@ -1,12 +1,11 @@
 import { InputDefinition, TargetConfiguration } from '../config/workspace-json-project-json';
-export type PackageJsonTargetConfiguration = Omit<TargetConfiguration, 'executor'>;
 export interface NxProjectPackageJsonConfiguration {
     implicitDependencies?: string[];
     tags?: string[];
     namedInputs?: {
         [inputName: string]: (string | InputDefinition)[];
     };
-    targets?: Record<string, PackageJsonTargetConfiguration>;
+    targets?: Record<string, TargetConfiguration>;
     includedScripts?: string[];
 }
 export type ArrayPackageGroup = {

package/src/utils/typescript.js

@@ -1,5 +1,5 @@
 "use strict";
-// TODO(v18): Nx Devkit 15 depends on this file. Remove this when we no longer support Nx Devkit 15
+// TODO(v19): Nx Devkit 15 depends on this file. Remove this when we no longer support Nx Devkit 15
 Object.defineProperty(exports, "__esModule", { value: true });
 const tslib_1 = require("tslib");
 tslib_1.__exportStar(require("../plugins/js/utils/typescript"), exports);

package/src/utils/workspace-configuration-check.js

@@ -6,7 +6,7 @@ const fs_1 = require("fs");
 const path_1 = require("path");
 const output_1 = require("./output");
 const fileutils_1 = require("../utils/fileutils");
-//TODO: vsavkin remove after Nx 18
+//TODO: vsavkin remove after Nx 19
 function workspaceConfigurationCheck() {
     if ((0, fs_1.existsSync)((0, path_1.join)(workspace_root_1.workspaceRoot, 'workspace.json'))) {
         output_1.output.warn({