nx 17.3.0-rc.1 → 17.3.1

package/bin/run-executor.js

@@ -60,7 +60,7 @@ process.on('message', async (message) => {
         process.exit(statusCode);
     }
     catch (e) {
-        console.error(`Could not find 'nx' module in this workspace.`, e);
+        console.error(e);
         process.exit(1);
     }
 });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nx",
-  "version": "17.3.0-rc.1",
+  "version": "17.3.1",
   "private": false,
   "description": "The core Nx plugin contains the core functionality of Nx like the project graph, nx commands and task orchestration.",
   "repository": {
@@ -66,7 +66,7 @@
     "yargs-parser": "21.1.1",
     "node-machine-id": "1.1.12",
     "ora": "5.3.0",
-    "@nrwl/tao": "17.3.0-rc.1"
+    "@nrwl/tao": "17.3.1"
   },
   "peerDependencies": {
     "@swc-node/register": "^1.6.7",
@@ -81,16 +81,16 @@
     }
   },
   "optionalDependencies": {
-    "@nx/nx-darwin-x64": "17.3.0-rc.1",
-    "@nx/nx-darwin-arm64": "17.3.0-rc.1",
-    "@nx/nx-linux-x64-gnu": "17.3.0-rc.1",
-    "@nx/nx-linux-x64-musl": "17.3.0-rc.1",
-    "@nx/nx-win32-x64-msvc": "17.3.0-rc.1",
-    "@nx/nx-linux-arm64-gnu": "17.3.0-rc.1",
-    "@nx/nx-linux-arm64-musl": "17.3.0-rc.1",
-    "@nx/nx-linux-arm-gnueabihf": "17.3.0-rc.1",
-    "@nx/nx-win32-arm64-msvc": "17.3.0-rc.1",
-    "@nx/nx-freebsd-x64": "17.3.0-rc.1"
+    "@nx/nx-darwin-x64": "17.3.1",
+    "@nx/nx-darwin-arm64": "17.3.1",
+    "@nx/nx-linux-x64-gnu": "17.3.1",
+    "@nx/nx-linux-x64-musl": "17.3.1",
+    "@nx/nx-win32-x64-msvc": "17.3.1",
+    "@nx/nx-linux-arm64-gnu": "17.3.1",
+    "@nx/nx-linux-arm64-musl": "17.3.1",
+    "@nx/nx-linux-arm-gnueabihf": "17.3.1",
+    "@nx/nx-win32-arm64-msvc": "17.3.1",
+    "@nx/nx-freebsd-x64": "17.3.1"
   },
   "nx-migrations": {
     "migrations": "./migrations.json",

package/src/adapter/compat.d.ts

@@ -1,2 +1,2 @@
-export declare const allowedProjectExtensions: readonly ["tags", "implicitDependencies", "configFilePath", "$schema", "generators", "namedInputs", "name", "files", "root", "sourceRoot", "projectType", "release"];
+export declare const allowedProjectExtensions: readonly ["tags", "implicitDependencies", "configFilePath", "$schema", "generators", "namedInputs", "name", "files", "root", "sourceRoot", "projectType", "release", "includedScripts"];
 export declare const allowedWorkspaceExtensions: readonly ["implicitDependencies", "affected", "tasksRunnerOptions", "workspaceLayout", "plugins", "targetDefaults", "files", "generators", "namedInputs", "extends", "cli", "pluginsConfig", "defaultProject", "installation", "release", "nxCloudAccessToken", "nxCloudUrl", "nxCloudEncryptionKey", "parallel", "cacheDirectory", "useDaemonProcess"];

package/src/adapter/compat.js

@@ -27,6 +27,7 @@ exports.allowedProjectExtensions = [
     'sourceRoot',
     'projectType',
     'release',
+    'includedScripts',
 ];
 // If we pass props on the workspace that angular doesn't know about,
 // it throws a warning that users see. We want to pass them still,

package/src/command-line/affected/command-object.d.ts

@@ -4,13 +4,13 @@ export declare const yargsAffectedTestCommand: CommandModule;
 export declare const yargsAffectedBuildCommand: CommandModule;
 export declare const yargsAffectedLintCommand: CommandModule;
 export declare const yargsAffectedE2ECommand: CommandModule;
-export declare const affectedGraphDeprecationMessage = "Use `nx graph --affected`, or `nx affected --graph` instead depending on which best suits your use case. The `affected:graph` command will be removed in Nx 18.";
+export declare const affectedGraphDeprecationMessage = "Use `nx graph --affected`, or `nx affected --graph` instead depending on which best suits your use case. The `affected:graph` command will be removed in Nx 19.";
 /**
- * @deprecated 'Use `nx graph --affected`, or` nx affected --graph` instead depending on which best suits your use case. The `affected:graph` command will be removed in Nx 18.'
+ * @deprecated 'Use `nx graph --affected`, or` nx affected --graph` instead depending on which best suits your use case. The `affected:graph` command will be removed in Nx 19.'
  */
 export declare const yargsAffectedGraphCommand: CommandModule;
-export declare const printAffectedDeprecationMessage = "Use `nx show projects --affected`, `nx affected --graph -t build` or `nx graph --affected` depending on which best suits your use case. The `print-affected` command will be removed in Nx 18.";
+export declare const printAffectedDeprecationMessage = "Use `nx show projects --affected`, `nx affected --graph -t build` or `nx graph --affected` depending on which best suits your use case. The `print-affected` command will be removed in Nx 19.";
 /**
- * @deprecated 'Use `nx show --affected`, `nx affected --graph` or `nx graph --affected` depending on which best suits your use case. The `print-affected` command will be removed in Nx 18.'
+ * @deprecated 'Use `nx show --affected`, `nx affected --graph` or `nx graph --affected` depending on which best suits your use case. The `print-affected` command will be removed in Nx 19.'
  */
 export declare const yargsPrintAffectedCommand: CommandModule;

package/src/command-line/affected/command-object.js

@@ -54,9 +54,9 @@ exports.yargsAffectedE2ECommand = {
         target: 'e2e',
     }),
 };
-exports.affectedGraphDeprecationMessage = 'Use `nx graph --affected`, or `nx affected --graph` instead depending on which best suits your use case. The `affected:graph` command will be removed in Nx 18.';
+exports.affectedGraphDeprecationMessage = 'Use `nx graph --affected`, or `nx affected --graph` instead depending on which best suits your use case. The `affected:graph` command will be removed in Nx 19.';
 /**
- * @deprecated 'Use `nx graph --affected`, or` nx affected --graph` instead depending on which best suits your use case. The `affected:graph` command will be removed in Nx 18.'
+ * @deprecated 'Use `nx graph --affected`, or` nx affected --graph` instead depending on which best suits your use case. The `affected:graph` command will be removed in Nx 19.'
  */
 exports.yargsAffectedGraphCommand = {
     command: 'affected:graph',
@@ -68,9 +68,9 @@ exports.yargsAffectedGraphCommand = {
     }),
     deprecated: exports.affectedGraphDeprecationMessage,
 };
-exports.printAffectedDeprecationMessage = 'Use `nx show projects --affected`, `nx affected --graph -t build` or `nx graph --affected` depending on which best suits your use case. The `print-affected` command will be removed in Nx 18.';
+exports.printAffectedDeprecationMessage = 'Use `nx show projects --affected`, `nx affected --graph -t build` or `nx graph --affected` depending on which best suits your use case. The `print-affected` command will be removed in Nx 19.';
 /**
- * @deprecated 'Use `nx show --affected`, `nx affected --graph` or `nx graph --affected` depending on which best suits your use case. The `print-affected` command will be removed in Nx 18.'
+ * @deprecated 'Use `nx show --affected`, `nx affected --graph` or `nx graph --affected` depending on which best suits your use case. The `print-affected` command will be removed in Nx 19.'
  */
 exports.yargsPrintAffectedCommand = {
     command: 'print-affected',

package/src/command-line/graph/graph.js

@@ -244,7 +244,7 @@ async function generateGraph(args, affectedProjects) {
                     '- affectedProjects',
                     '- criticalPath',
                     '',
-                    'These fields will be removed in Nx 18. If you need to see which projects were affected, use `nx show projects --affected`.',
+                    'These fields will be removed in Nx 19. If you need to see which projects were affected, use `nx show projects --affected`.',
                 ],
             });
             output_1.output.success({

package/src/command-line/release/publish.d.ts

@@ -5,4 +5,4 @@ export declare const releasePublishCLIHandler: (args: PublishOptions) => Promise
  * of Nx. We intentionally do not wrap the implementation with handleErrors because users need
  * to have control over their own error handling when using the API.
  */
-export declare function releasePublish(args: PublishOptions, isCLI?: boolean): Promise<void>;
+export declare function releasePublish(args: PublishOptions, isCLI?: boolean): Promise<number>;

package/src/command-line/release/publish.js

@@ -48,25 +48,32 @@ async function releasePublish(args, isCLI = false) {
      * for dependencies, because that could cause projects outset of the filtered set to be published.
      */
     const shouldExcludeTaskDependencies = _args.projects?.length > 0 || _args.groups?.length > 0;
+    let overallExitStatus = 0;
     if (args.projects?.length) {
         /**
          * Run publishing for all remaining release groups and filtered projects within them
          */
         for (const releaseGroup of releaseGroups) {
-            await runPublishOnProjects(_args, projectGraph, nxJson, Array.from(releaseGroupToFilteredProjects.get(releaseGroup)), shouldExcludeTaskDependencies, isCLI);
+            const status = await runPublishOnProjects(_args, projectGraph, nxJson, Array.from(releaseGroupToFilteredProjects.get(releaseGroup)), shouldExcludeTaskDependencies, isCLI);
+            if (status !== 0) {
+                overallExitStatus = status || 1;
+            }
         }
-        return process.exit(0);
+        return overallExitStatus;
     }
     /**
      * Run publishing for all remaining release groups
      */
     for (const releaseGroup of releaseGroups) {
-        await runPublishOnProjects(_args, projectGraph, nxJson, releaseGroup.projects, shouldExcludeTaskDependencies, isCLI);
+        const status = await runPublishOnProjects(_args, projectGraph, nxJson, releaseGroup.projects, shouldExcludeTaskDependencies, isCLI);
+        if (status !== 0) {
+            overallExitStatus = status || 1;
+        }
     }
     if (_args.dryRun) {
         logger_1.logger.warn(`\nNOTE: The "dryRun" flag means no projects were actually published.`);
     }
-    process.exit(0);
+    return overallExitStatus;
 }
 exports.releasePublish = releasePublish;
 async function runPublishOnProjects(args, projectGraph, nxJson, projectNames, shouldExcludeTaskDependencies, isCLI) {
@@ -99,7 +106,7 @@ async function runPublishOnProjects(args, projectGraph, nxJson, projectNames, sh
     if (args.graph) {
         const file = (0, command_line_utils_1.readGraphFileFromGraphArg)(args);
         const projectNames = projectsToRun.map((t) => t.name);
-        return await (0, graph_1.generateGraph)({
+        await (0, graph_1.generateGraph)({
             watch: false,
             all: false,
             open: true,
@@ -108,12 +115,21 @@ async function runPublishOnProjects(args, projectGraph, nxJson, projectNames, sh
             projects: projectNames,
             file,
         }, projectNames);
+        return 0;
+    }
+    const requiredTargetName = 'nx-release-publish';
+    const projectsWithTarget = projectsToRun.filter((project) => (0, project_graph_utils_1.projectHasTarget)(project, requiredTargetName));
+    if (projectsWithTarget.length === 0) {
+        throw new Error(`Based on your config, the following projects were matched for publishing but do not have the "${requiredTargetName}" target specified:\n${[
+            ...projectsToRun.map((p) => `- ${p.name}`),
+            '',
+            `This is usually caused by not having an appropriate plugin, such as "@nx/js" installed, which will add the appropriate "${requiredTargetName}" target for you automatically.`,
+        ].join('\n')}\n`);
     }
-    ensureAllProjectsHaveTarget(projectsToRun);
     /**
      * Run the relevant nx-release-publish executor on each of the selected projects.
      */
-    const status = await (0, run_command_1.runCommand)(projectsToRun, projectGraph, { nxJson }, {
+    const status = await (0, run_command_1.runCommand)(projectsWithTarget, projectGraph, { nxJson }, {
         targets,
         outputStyle: 'static',
         ...args,
@@ -129,16 +145,5 @@ async function runPublishOnProjects(args, projectGraph, nxJson, projectNames, sh
         // Throw an additional error for programmatic API usage
         throw new Error('One or more of the selected projects could not be published');
     }
-}
-function ensureAllProjectsHaveTarget(projectsToRun) {
-    const requiredTargetName = 'nx-release-publish';
-    const projectsMissingTarget = projectsToRun.filter((project) => !(0, project_graph_utils_1.projectHasTarget)(project, requiredTargetName));
-    if (projectsMissingTarget.length === 0) {
-        return;
-    }
-    throw new Error(`Based on your config, the following projects were matched for publishing but do not have the "${requiredTargetName}" target specified:\n${[
-        ...projectsMissingTarget.map((p) => `- ${p.name}`),
-        '',
-        'There are a few possible reasons for this: (1) The projects may be private (2) You may not have an appropriate plugin (such as `@nx/js`) installed which adds the target automatically to public projects (3) You intended to configure the target manually, or exclude those projects via config in nx.json',
-    ].join('\n')}\n`);
+    return 0;
 }

package/src/command-line/report/report.js

@@ -180,7 +180,7 @@ function findInstalledCommunityPlugins() {
 exports.findInstalledCommunityPlugins = findInstalledCommunityPlugins;
 function findInstalledPackagesWeCareAbout() {
     const packagesWeMayCareAbout = {};
-    // TODO (v18): Remove workaround for hiding @nrwl packages when matching @nx package is found.
+    // TODO (v19): Remove workaround for hiding @nrwl packages when matching @nx package is found.
     const packageChangeMap = {
         '@nrwl/nx-plugin': '@nx/plugin',
         '@nx/plugin': '@nrwl/nx-plugin',

package/src/command-line/run/run.js

@@ -7,8 +7,10 @@ const path_1 = require("path");
 const serialize_overrides_into_command_line_1 = require("../../utils/serialize-overrides-into-command-line");
 const project_graph_1 = require("../../project-graph/project-graph");
 const configuration_1 = require("../../config/configuration");
+const native_1 = require("../../native");
 const async_iterator_1 = require("../../utils/async-iterator");
 const executor_utils_1 = require("./executor-utils");
+const child_process_1 = require("../../utils/child-process");
 function printRunHelp(opts, schema, plugin) {
     (0, print_help_1.printHelp)(`run ${opts.project}:${opts.target}`, schema, {
         mode: 'run',
@@ -45,7 +47,7 @@ async function iteratorToProcessStatusCode(i) {
         clearInterval(keepProcessAliveInterval);
     }
 }
-async function parseExecutorAndTarget({ project, target, configuration }, root, projectsConfigurations, nxJsonConfiguration) {
+async function parseExecutorAndTarget({ project, target }, root, projectsConfigurations) {
     const proj = projectsConfigurations.projects[project];
     const targetConfig = proj.targets?.[target];
     if (!targetConfig) {
@@ -55,17 +57,30 @@ async function parseExecutorAndTarget({ project, target, configuration }, root,
     const { schema, implementationFactory } = (0, executor_utils_1.getExecutorInformation)(nodeModule, executor, root, projectsConfigurations.projects);
     return { executor, implementationFactory, nodeModule, schema, targetConfig };
 }
-async function printTargetRunHelpInternal({ project, target, configuration }, root, projectsConfigurations, nxJsonConfiguration) {
-    const { executor, nodeModule, schema } = await parseExecutorAndTarget({ project, target, configuration }, root, projectsConfigurations, nxJsonConfiguration);
+async function printTargetRunHelpInternal({ project, target }, root, projectsConfigurations) {
+    const { executor, nodeModule, schema, targetConfig } = await parseExecutorAndTarget({ project, target }, root, projectsConfigurations);
     printRunHelp({ project, target }, schema, {
         plugin: nodeModule,
         entity: executor,
     });
-    process.exit(0);
+    if (nodeModule === 'nx' &&
+        executor === 'run-commands' &&
+        targetConfig.options.command) {
+        const command = targetConfig.options.command.split(' ')[0];
+        await new Promise(() => {
+            const cp = new child_process_1.PseudoTtyProcess((0, native_1.runCommand)(`${command} --help`));
+            cp.onExit((code) => {
+                process.exit(code);
+            });
+        });
+    }
+    else {
+        process.exit(0);
+    }
 }
 async function runExecutorInternal({ project, target, configuration }, overrides, root, cwd, projectsConfigurations, nxJsonConfiguration, projectGraph, taskGraph, isVerbose) {
     validateProject(projectsConfigurations, project);
-    const { executor, implementationFactory, nodeModule, schema, targetConfig } = await parseExecutorAndTarget({ project, target, configuration }, root, projectsConfigurations, nxJsonConfiguration);
+    const { executor, implementationFactory, nodeModule, schema, targetConfig } = await parseExecutorAndTarget({ project, target, configuration }, root, projectsConfigurations);
     configuration ??= targetConfig.defaultConfiguration;
     const combinedOptions = (0, params_1.combineOptionsForExecutor)(overrides, configuration, targetConfig, schema, project, (0, path_1.relative)(root, cwd), isVerbose);
     if ((0, executor_utils_1.getExecutorInformation)(nodeModule, executor, root, projectsConfigurations.projects).isNxExecutor) {
@@ -143,8 +158,7 @@ function printTargetRunHelp(targetDescription, root) {
     const projectGraph = (0, project_graph_1.readCachedProjectGraph)();
     return (0, params_1.handleErrors)(false, async () => {
         const projectsConfigurations = (0, project_graph_1.readProjectsConfigurationFromProjectGraph)(projectGraph);
-        const nxJsonConfiguration = (0, configuration_1.readNxJson)();
-        printTargetRunHelpInternal(targetDescription, root, projectsConfigurations, nxJsonConfiguration);
+        await printTargetRunHelpInternal(targetDescription, root, projectsConfigurations);
     });
 }
 exports.printTargetRunHelp = printTargetRunHelp;

package/src/config/project-graph.d.ts

@@ -111,7 +111,7 @@ export interface ProjectGraphDependency {
 }
 /**
  * Additional information to be used to process a project graph
- * @deprecated The {@link ProjectGraphProcessor} is deprecated. This will be removed in Nx 18.
+ * @deprecated The {@link ProjectGraphProcessor} is deprecated. This will be removed in Nx 19.
  */
 export interface ProjectGraphProcessorContext {
     /**
@@ -132,6 +132,6 @@ export interface ProjectGraphProcessorContext {
 }
 /**
  * A function that produces an updated ProjectGraph
- * @deprecated Use {@link CreateNodes} and {@link CreateDependencies} instead. This will be removed in Nx 18.
+ * @deprecated Use {@link CreateNodes} and {@link CreateDependencies} instead. This will be removed in Nx 19.
  */
 export type ProjectGraphProcessor = (currentGraph: ProjectGraph, context: ProjectGraphProcessorContext) => ProjectGraph | Promise<ProjectGraph>;

package/src/config/workspaces.d.ts

@@ -1,7 +1,7 @@
 import type { NxJsonConfiguration } from './nx-json';
 import { ProjectsConfigurations } from './workspace-json-project-json';
 /**
- * @deprecated This will be removed in v18. Use {@link readProjectsConfigurationFromProjectGraph} instead.
+ * @deprecated This will be removed in v19. Use {@link readProjectsConfigurationFromProjectGraph} instead.
  */
 export declare class Workspaces {
     private root;

package/src/config/workspaces.js

@@ -4,9 +4,9 @@ exports.toProjectName = exports.Workspaces = void 0;
 const path_1 = require("path");
 const project_graph_1 = require("../project-graph/project-graph");
 const nx_json_1 = require("./nx-json");
-// TODO(v18): remove this class
+// TODO(v19): remove this class
 /**
- * @deprecated This will be removed in v18. Use {@link readProjectsConfigurationFromProjectGraph} instead.
+ * @deprecated This will be removed in v19. Use {@link readProjectsConfigurationFromProjectGraph} instead.
  */
 class Workspaces {
     constructor(root) {