nx 17.0.2 → 17.0.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nx",
-  "version": "17.0.2",
+  "version": "17.0.3",
   "private": false,
   "description": "The core Nx plugin contains the core functionality of Nx like the project graph, nx commands and task orchestration.",
   "repository": {
@@ -67,7 +67,7 @@
     "yargs": "^17.6.2",
     "yargs-parser": "21.1.1",
     "node-machine-id": "1.1.12",
-    "@nrwl/tao": "17.0.2"
+    "@nrwl/tao": "17.0.3"
   },
   "peerDependencies": {
     "@swc-node/register": "^1.6.7",
@@ -82,16 +82,16 @@
     }
   },
   "optionalDependencies": {
-    "@nx/nx-darwin-x64": "17.0.2",
-    "@nx/nx-darwin-arm64": "17.0.2",
-    "@nx/nx-linux-x64-gnu": "17.0.2",
-    "@nx/nx-linux-x64-musl": "17.0.2",
-    "@nx/nx-win32-x64-msvc": "17.0.2",
-    "@nx/nx-linux-arm64-gnu": "17.0.2",
-    "@nx/nx-linux-arm64-musl": "17.0.2",
-    "@nx/nx-linux-arm-gnueabihf": "17.0.2",
-    "@nx/nx-win32-arm64-msvc": "17.0.2",
-    "@nx/nx-freebsd-x64": "17.0.2"
+    "@nx/nx-darwin-x64": "17.0.3",
+    "@nx/nx-darwin-arm64": "17.0.3",
+    "@nx/nx-linux-x64-gnu": "17.0.3",
+    "@nx/nx-linux-x64-musl": "17.0.3",
+    "@nx/nx-win32-x64-msvc": "17.0.3",
+    "@nx/nx-linux-arm64-gnu": "17.0.3",
+    "@nx/nx-linux-arm64-musl": "17.0.3",
+    "@nx/nx-linux-arm-gnueabihf": "17.0.3",
+    "@nx/nx-win32-arm64-msvc": "17.0.3",
+    "@nx/nx-freebsd-x64": "17.0.3"
   },
   "nx-migrations": {
     "migrations": "./migrations.json",

package/src/command-line/init/implementation/add-nx-to-monorepo.js

@@ -57,6 +57,7 @@ async function addNxToMonorepo(options) {
                 (options.interactive ? await (0, utils_1.askAboutNxCloud)() : false);
     }
     (0, utils_1.createNxJsonFile)(repoRoot, targetDefaults, cacheableOperations, scriptOutputs);
+    (0, utils_1.updateGitIgnore)(repoRoot);
     (0, utils_1.addDepsToPackageJson)(repoRoot);
     output_1.output.log({ title: '📦 Installing dependencies' });
     (0, utils_1.runInstall)(repoRoot);

package/src/command-line/init/implementation/add-nx-to-nest.js

@@ -71,6 +71,7 @@ async function addNxToNest(options, packageJson) {
     }
     (0, utils_1.createNxJsonFile)(repoRoot, [], [...cacheableOperations, ...nestCacheableScripts], {});
     const pmc = (0, package_manager_1.getPackageManagerCommand)();
+    (0, utils_1.updateGitIgnore)(repoRoot);
     (0, utils_1.addDepsToPackageJson)(repoRoot);
     addNestPluginToPackageJson(repoRoot);
     (0, utils_1.markRootPackageJsonAsNxProject)(repoRoot, cacheableOperations, scriptOutputs, pmc);

package/src/command-line/init/implementation/add-nx-to-npm-repo.js

@@ -46,6 +46,7 @@ async function addNxToNpmRepo(options) {
     }
     (0, utils_1.createNxJsonFile)(repoRoot, [], cacheableOperations, {});
     const pmc = (0, package_manager_1.getPackageManagerCommand)();
+    (0, utils_1.updateGitIgnore)(repoRoot);
     (0, utils_1.addDepsToPackageJson)(repoRoot);
     (0, utils_1.markRootPackageJsonAsNxProject)(repoRoot, cacheableOperations, scriptOutputs, pmc);
     output_1.output.log({ title: '📦 Installing dependencies' });

package/src/command-line/init/implementation/utils.d.ts

@@ -4,6 +4,7 @@ export declare function createNxJsonFile(repoRoot: string, topologicalTargets: s
     [name: string]: string;
 }): void;
 export declare function addDepsToPackageJson(repoRoot: string): void;
+export declare function updateGitIgnore(root: string): void;
 export declare function runInstall(repoRoot: string, pmc?: PackageManagerCommands): void;
 export declare function initCloud(repoRoot: string, installationSource: 'nx-init-angular' | 'nx-init-cra' | 'nx-init-monorepo' | 'nx-init-nest' | 'nx-init-npm-repo'): void;
 export declare function addVsCodeRecommendedExtensions(repoRoot: string, extensions: string[]): void;

package/src/command-line/init/implementation/utils.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.printFinalMessage = exports.markRootPackageJsonAsNxProject = exports.addVsCodeRecommendedExtensions = exports.initCloud = exports.runInstall = exports.addDepsToPackageJson = exports.createNxJsonFile = exports.askAboutNxCloud = void 0;
+exports.printFinalMessage = exports.markRootPackageJsonAsNxProject = exports.addVsCodeRecommendedExtensions = exports.initCloud = exports.runInstall = exports.updateGitIgnore = exports.addDepsToPackageJson = exports.createNxJsonFile = exports.askAboutNxCloud = void 0;
 const child_process_1 = require("child_process");
 const enquirer = require("enquirer");
 const path_1 = require("path");
@@ -10,6 +10,7 @@ const output_1 = require("../../../utils/output");
 const package_manager_1 = require("../../../utils/package-manager");
 const path_2 = require("../../../utils/path");
 const versions_1 = require("../../../utils/versions");
+const fs_1 = require("fs");
 async function askAboutNxCloud() {
     return await enquirer
         .prompt([
@@ -108,6 +109,18 @@ function addDepsToPackageJson(repoRoot) {
     (0, fileutils_1.writeJsonFile)(path, json);
 }
 exports.addDepsToPackageJson = addDepsToPackageJson;
+function updateGitIgnore(root) {
+    const ignorePath = (0, path_1.join)(root, '.gitignore');
+    try {
+        let contents = (0, fs_1.readFileSync)(ignorePath, 'utf-8');
+        if (!contents.includes('.nx/cache')) {
+            contents = [contents, '', '.nx/cache'].join('\n');
+            (0, fs_1.writeFileSync)(ignorePath, contents, 'utf-8');
+        }
+    }
+    catch { }
+}
+exports.updateGitIgnore = updateGitIgnore;
 function runInstall(repoRoot, pmc = (0, package_manager_1.getPackageManagerCommand)()) {
     (0, child_process_1.execSync)(pmc.install, { stdio: [0, 1, 2], cwd: repoRoot });
 }

package/src/generators/utils/project-configuration.js

@@ -143,16 +143,18 @@ function readAndCombineAllProjectConfigurations(tree) {
             const config = (0, project_json_1.buildProjectFromProjectJson)(json, projectFile);
             (0, project_configuration_utils_1.mergeProjectConfigurationIntoRootMap)(rootMap, config);
         }
-        else {
+        else if ((0, path_1.basename)(projectFile) === 'package.json') {
             const packageJson = (0, json_1.readJson)(tree, projectFile);
             const config = (0, package_json_workspaces_1.buildProjectConfigurationFromPackageJson)(packageJson, projectFile, (0, nx_json_1.readNxJson)(tree));
-            (0, project_configuration_utils_1.mergeProjectConfigurationIntoRootMap)(rootMap, 
-            // Inferred targets, tags, etc don't show up when running generators
-            // This is to help avoid running into issues when trying to update the workspace
-            {
-                name: config.name,
-                root: config.root,
-            });
+            if (!rootMap.has(config.root)) {
+                (0, project_configuration_utils_1.mergeProjectConfigurationIntoRootMap)(rootMap, 
+                // Inferred targets, tags, etc don't show up when running generators
+                // This is to help avoid running into issues when trying to update the workspace
+                {
+                    name: config.name,
+                    root: config.root,
+                });
+            }
         }
     }
     return (0, project_configuration_utils_1.readProjectConfigurationsFromRootMap)(rootMap);

package/src/project-graph/utils/normalize-project-nodes.js

@@ -6,7 +6,10 @@ const logger_1 = require("../../utils/logger");
 const project_configuration_utils_1 = require("../utils/project-configuration-utils");
 async function normalizeProjectNodes(ctx, builder, nxJson) {
     const toAdd = [];
-    const projects = Object.keys(ctx.projects);
+    // Sorting projects by name to make sure that the order of projects in the graph is deterministic.
+    // This is important to ensure that expanded properties referencing projects (e.g. implicit dependencies)
+    // are also deterministic, and thus don't cause the calculated project configuration hash to shift.
+    const projects = Object.keys(ctx.projects).sort();
     // Used for expanding implicit dependencies (e.g. `@proj/*` or `tag:foo`)
     const partialProjectGraphNodes = projects.reduce((graph, project) => {
         const projectConfiguration = ctx.projects[project];

package/src/project-graph/utils/retrieve-workspace-files.js

@@ -121,7 +121,9 @@ exports.retrieveProjectConfigurationsWithoutPluginInference = retrieveProjectCon
 function buildAllWorkspaceFiles(projectFileMap, globalFiles) {
     perf_hooks_1.performance.mark('get-all-workspace-files:start');
     let fileData = Object.values(projectFileMap).flat();
-    fileData = fileData.concat(globalFiles).sort();
+    fileData = fileData
+        .concat(globalFiles)
+        .sort((a, b) => a.file.localeCompare(b.file));
     perf_hooks_1.performance.mark('get-all-workspace-files:end');
     perf_hooks_1.performance.measure('get-all-workspace-files', 'get-all-workspace-files:start', 'get-all-workspace-files:end');
     return fileData;

package/src/utils/package-manager.d.ts

@@ -7,6 +7,7 @@ export interface PackageManagerCommands {
     addDev: string;
     rm: string;
     exec: string;
+    dlx: string;
     list: string;
     run: (script: string, args: string) => string;
 }

package/src/utils/package-manager.js

@@ -55,13 +55,14 @@ function getPackageManagerCommand(packageManager = detectPackageManager(), root
                 addDev: useBerry ? 'yarn add -D' : 'yarn add -D -W',
                 rm: 'yarn remove',
                 exec: 'yarn',
+                dlx: useBerry ? 'yarn dlx' : 'yarn',
                 run: (script, args) => `yarn ${script} ${args}`,
                 list: useBerry ? 'yarn info --name-only' : 'yarn list',
             };
         },
         pnpm: () => {
             const pnpmVersion = getPackageManagerVersion('pnpm', root);
-            const useExec = (0, semver_1.gte)(pnpmVersion, '6.13.0');
+            const modernPnpm = (0, semver_1.gte)(pnpmVersion, '6.13.0');
             const includeDoubleDashBeforeArgs = (0, semver_1.lt)(pnpmVersion, '7.0.0');
             const isPnpmWorkspace = (0, fs_1.existsSync)((0, path_1.join)(root, 'pnpm-workspace.yaml'));
             return {
@@ -70,7 +71,8 @@ function getPackageManagerCommand(packageManager = detectPackageManager(), root
                 add: isPnpmWorkspace ? 'pnpm add -w' : 'pnpm add',
                 addDev: isPnpmWorkspace ? 'pnpm add -Dw' : 'pnpm add -D',
                 rm: 'pnpm rm',
-                exec: useExec ? 'pnpm exec' : 'pnpx',
+                exec: modernPnpm ? 'pnpm exec' : 'pnpx',
+                dlx: modernPnpm ? 'pnpm dlx' : 'pnpx',
                 run: (script, args) => includeDoubleDashBeforeArgs
                     ? `pnpm run ${script} -- ${args}`
                     : `pnpm run ${script} ${args}`,
@@ -87,6 +89,7 @@ function getPackageManagerCommand(packageManager = detectPackageManager(), root
                 addDev: 'npm install -D',
                 rm: 'npm rm',
                 exec: 'npx',
+                dlx: 'npx',
                 run: (script, args) => `npm run ${script} -- ${args}`,
                 list: 'npm ls',
             };

package/src/utils/params.js

@@ -532,10 +532,25 @@ function getPromptsForSchema(opts, schema, projectsConfigurations) {
             // Normalize x-prompt
             if (typeof v['x-prompt'] === 'string') {
                 const message = v['x-prompt'];
-                v['x-prompt'] = {
-                    type: v.type === 'boolean' ? 'confirm' : 'input',
-                    message,
-                };
+                if (v.type === 'boolean') {
+                    v['x-prompt'] = {
+                        type: 'confirm',
+                        message,
+                    };
+                }
+                else if (v.type === 'array' && v.items?.enum) {
+                    v['x-prompt'] = {
+                        type: 'multiselect',
+                        items: v.items.enum,
+                        message,
+                    };
+                }
+                else {
+                    v['x-prompt'] = {
+                        type: 'input',
+                        message,
+                    };
+                }
             }
             question.message = v['x-prompt'].message;
             question.validate = (s) => {