nw-builder 4.7.0 → 4.7.2

package/README.md

@@ -268,7 +268,6 @@ nwbuild({
 
 - We use [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) style of commit messages.
 - On opening a new PR, the comments will guide you on how to construct the new PR.
-- When making changes, try to follow [SOLID](https://en.wikipedia.org/wiki/SOLID) and [DRY](https://en.wikipedia.org/wiki/Don%27t_repeat_yourself) principles.
 - Pull requests are squashed and merged onto the `main` branch.
 - PR title is used as commit's first line, PR description is used as commit body.
 - Only commit messages starting with `fix`, `feat` and `chore` are recognised by the Release Please bot.
@@ -280,7 +279,7 @@ nwbuild({
 - Approve pull requests before merging.
 - Enforce conventional commits before merging pull requests.
 - A commit's first line should be formatted as `<type>[optional scope]: <description>`.
-- A commit's body should have a description of changes in bullet points followed by any links it references or issues it fixes or closes. It may include an optional `Notes: ...` section to provide additional context on why the PR is being merged when it doesn't seem like it should.
+- A commit's body should have a description of changes in bullet points followed by any links it references or issues it fixes or closes.
 - Google's Release Please Action is used to update the changelog, bump the package version and generate GitHub releases.
 - NPM Publish Action publishes to `npm` if there is a version bump.
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nw-builder",
-  "version": "4.7.0",
+  "version": "4.7.2",
   "description": "Build NW.js desktop applications for MacOS, Windows and Linux.",
   "keywords": [
     "NW.js",
@@ -49,25 +49,25 @@
     "demo": "cd test/fixture && node demo.js"
   },
   "devDependencies": {
-    "@stylistic/eslint-plugin-js": "^1.7.0",
+    "@stylistic/eslint-plugin-js": "^2.1.0",
     "eslint": "^8.57.0",
     "eslint-config-tjw-jsdoc": "^1.0.5",
-    "eslint-plugin-jsdoc": "^48.2.1",
-    "eslint-plugin-markdown": "^4.0.1",
-    "jsdoc": "^4.0.2",
-    "selenium-webdriver": "^4.18.1",
-    "vitest": "^1.4.0"
+    "eslint-plugin-jsdoc": "^48.2.3",
+    "eslint-plugin-markdown": "^5.0.0",
+    "jsdoc": "^4.0.3",
+    "selenium-webdriver": "^4.20.0",
+    "vitest": "^1.6.0"
   },
   "dependencies": {
     "axios": "^1.6.8",
     "cli-progress": "^3.12.0",
     "compressing": "^1.10.0",
-    "glob": "^10.3.10",
-    "node-gyp": "^10.0.1",
+    "glob": "^10.3.12",
+    "node-gyp": "^10.1.0",
     "plist": "^3.1.0",
     "rcedit": "^4.0.1",
-    "semver": "^7.6.0",
-    "tar": "^6.2.1",
+    "semver": "^7.6.1",
+    "tar": "^7.1.0",
     "yargs": "^17.7.2",
     "yauzl-promise": "^4.0.0"
   },

package/src/get/decompress.js

@@ -2,7 +2,7 @@ import fs from "node:fs";
 import path from "node:path";
 import stream from "node:stream";
 
-import tar from "tar";
+import * as tar from "tar";
 import yauzl from "yauzl-promise";
 
 /**
@@ -26,7 +26,7 @@ export default async function decompress(filePath, cacheDir) {
  * Get file mode from entry. Reference implementation is [here](https://github.com/fpsqdb/zip-lib/blob/ac447d269218d396e05cd7072d0e9cd82b5ec52c/src/unzip.ts#L380).
  *
  * @param  {yauzl.Entry} entry  - Yauzl entry
- * @return {number}             - entry's file mode 
+ * @return {number}             - entry's file mode
  */
 function modeFromEntry(entry) {
   const attr = entry.externalFileAttributes >> 16 || 33188;
@@ -93,4 +93,5 @@ async function unzip(zippedFile, cacheDir) {
       await fs.promises.symlink(linkTarget, entryPathAbs);
     }
   }
+  await zip.close();
 }

package/src/get/index.js

@@ -1,5 +1,6 @@
 import fs from "node:fs";
 import path from "node:path";
+import url from "node:url";
 
 import decompress from "./decompress.js";
 import ffmpeg from "./ffmpeg.js";