nw-builder 4.15.0 → 4.16.2

package/README.md

@@ -122,7 +122,7 @@ Get Node headers if you have to rebuild Node addons.
 ```javascript
 nwbuild({
   mode: "get",
-  nativeAddon: "gyp"
+  nativeAddon: true,
 });
 ```
 
@@ -182,27 +182,6 @@ nwbuild({
 });
 ```
 
-#### Rebuild Node addons
-
-> Currently this feature is disabled and it may be removed in the future.
-
-It only builds node addons which have a `binding.gyp` file in the `srcDir`. There are plans to support nan, cmake, ffi and gn and auto rebuild native addons which are installed as node modules.
-
-```javascript
-nwbuild({
-  mode: "build",
-  nodeAddon: "gyp",
-});
-```
-
-We recommend rebuilding Node addons for NW.js via `node-gyp` if you are using NW.js v0.83.0 or above.
-
-```shell
-node-gyp rebuild --target=22.2.0 --nodedir=/path/to/nw/node/headers
-```
-
-NW.js's Node version should match the Node version on the host machine due to [ABI differences in V8](https://github.com/nwjs/nw.js/issues/5025).
-
 ## API Reference
 
 Options
@@ -226,7 +205,7 @@ Options
 | glob | `boolean` | `true`| If true file globbing is enabled when parsing `srcDir`. |
 | outDir | `string` | `"./out"` | Directory to store build artifacts |
 | managedManifest | `boolean \| string \| object` | `false` | Managed manifest |
-| nodeAddon | `false \| "gyp"` | `false` | Rebuild Node native addons |
+| nodeAddon | `boolean` | `false` | Rebuild Node native addons |
 | zip | `boolean \| "zip" \| "tar" \| "tgz"` | `false`| If true, "zip", "tar" or "tgz" the `outDir` directory is compressed. |
 | app | `LinuxRc \| WinRc \| OsxRc` | Additional options for each platform. (See below.)
 
@@ -343,18 +322,6 @@ nwbuild({
 });
 ```
 
-### Let `nw-builder` manage your native addons
-
-> Note: this behaviour is buggy and quite limited. This guide is to show what will be possible in the coming minor releases.
-
-```javascript
-nwbuild({
-  mode: "build",
-  managedManifest: true,
-  nativeAddon: "gyp",
-});
-```
-
 ## Contributing
 
 ### External contributor

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nw-builder",
-  "version": "4.15.0",
+  "version": "4.16.2",
   "description": "Build NW.js desktop applications for MacOS, Windows and Linux.",
   "keywords": [
     "NW.js",
@@ -52,33 +52,32 @@
     "demo:exe:linux": "./tests/fixtures/out/linux/Demo",
     "demo:exe:osx": "./tests/fixtures/out/osx/Demo.app/Contents/MacOS/Demo",
     "demo:exe:win": "./tests/fixtures/out/win/Demo.exe",
-    "demo:cli": "nwbuild --mode=build --flavor=sdk --glob=false --cacheDir=./node_modules/nw --logLevel=debug --outDir=./tests/fixtures/out/linux --app.name=Demo --app.icon=./tests/fixtures/app/icon.png ./tests/fixtures/app"
+    "demo:cli": "nwbuild --mode=build --flavor=sdk --glob=false --cacheDir=./node_modules/nw --logLevel=debug --managedManifest=./tests/fixtures/app/package.json --outDir=./tests/fixtures/out/linux --app.name=Demo --app.icon=./tests/fixtures/app/icon.png ./tests/fixtures/app"
   },
   "devDependencies": {
-    "@eslint/js": "^9.33.0",
-    "@vitest/coverage-v8": "^3.2.4",
+    "@eslint/js": "^9.39.2",
+    "@vitest/coverage-v8": "^4.0.16",
     "base-volta-off-of-nwjs": "^1.0.5",
-    "eslint": "^9.33.0",
-    "eslint-plugin-jsdoc": "^54.1.0",
-    "globals": "^16.3.0",
-    "nw": "^0.102.1",
-    "selenium-webdriver": "^4.35.0",
-    "vitest": "^3.0.7"
+    "eslint": "^9.39.2",
+    "eslint-plugin-jsdoc": "^61.5.0",
+    "globals": "^16.5.0",
+    "nw": "^0.106.1",
+    "selenium-webdriver": "^4.39.0",
+    "vitest": "^4.0.14"
   },
   "dependencies": {
     "archiver": "^7.0.1",
-    "axios": "^1.11.0",
-    "commander": "^14.0.0",
-    "glob": "^11.0.3",
-    "node-gyp": "^11.3.0",
+    "axios": "^1.13.2",
+    "commander": "^14.0.2",
+    "glob": "^13.0.0",
     "plist": "^3.1.0",
-    "resedit": "^2.0.3",
-    "semver": "^7.7.2",
-    "tar": "^7.4.3",
+    "resedit": "^3.0.1",
+    "semver": "^7.7.3",
+    "tar": "^7.5.2",
     "yauzl-promise": "^4.0.0"
   },
   "volta": {
-    "node": "24.5.0",
-    "npm": "11.5.2"
+    "node": "25.2.1",
+    "npm": "11.6.4"
   }
 }

package/src/bld.js

@@ -96,7 +96,6 @@ import setOsxConfig from './bld/osx.js';
  * @property {LinuxRc | WinRc | OsxRc}              [app]                                       Platform specific rc
  * @property {boolean}                              [glob = true]                               File globbing
  * @property {boolean | string | object}            [managedManifest = false]                   Manage manifest
- * @property {false | "gyp"}                        [nativeAddon = false]                       Rebuild native modules
  * @property {false | "zip" | "tar" | "tgz"}        [zip = false]                               Compress built artifacts
  * @property {object}                               [releaseInfo = {}]                          Version specific release metadata.
  */
@@ -119,7 +118,6 @@ async function bld({
   app,
   glob = true,
   managedManifest = false,
-  nativeAddon = false,
   zip = false,
   releaseInfo = {},
 }) {
@@ -190,11 +188,6 @@ async function bld({
     await setOsxConfig({ app, outDir, releaseInfo });
   }
 
-  if (nativeAddon === 'gyp') {
-    throw new Error('Rebuilding Node addons functionality is broken and has been disabled. This functionality may be removed in the future.');
-    // buildNativeAddon({ cacheDir, version, platform, arch, outDir, nodeVersion });
-  }
-
   if (zip !== false) {
     await compress({ zip, outDir });
   }
@@ -354,20 +347,6 @@ const setWinConfig = async ({ app, outDir }) => {
   await fs.promises.writeFile(outDirAppExe, outBuffer);
 };
 
-/*
-const buildNativeAddon = ({ cacheDir, version, platform, arch, outDir, nodeVersion }) => {
-  let nodePath = path.resolve(cacheDir, `node-v${version}-${platform}-${arch}`);
-  const cwd = path.resolve(
-    outDir,
-    platform !== 'osx'
-      ? 'package.nw'
-      : 'nwjs.app/Contents/Resources/app.nw',
-  );
-
-  child_process.execFileSync('node-gyp', ['rebuild', `--target=${nodeVersion}`, `--nodedir=${nodePath}`], { cwd });
-};
-*/
-
 const compress = async ({
   zip,
   outDir,

package/src/cli.js

@@ -22,7 +22,7 @@ program
   .option('--ffmpeg <boolean>', 'Enable/disable community ffmpeg', false)
   .option('--glob <boolean>', 'Enable/disable globbing', true)
   .option('--logLevel <string>', 'Specify log level', 'info')
-  .option('--shaSum <string>', 'Enable/disable shasum', true)
+  .option('--shaSum <boolean>', 'Enable/disable shasum', true)
   .option('--zip <string>', 'Enable/disable compression', false)
   .option('--managedManifest <string>', 'Managed manifest mode', false)
   .option('--nodeAddon <boolean>', 'Download NW.js Node headers', false)

package/src/get/index.js

@@ -20,7 +20,7 @@ import util from '../util.js';
  * @property {string}                               [cacheDir = "./cache"]                Cache directory
  * @property {boolean}                              [cache = true]                        If false, remove cache and redownload.
  * @property {boolean}                              [ffmpeg = false]                      If true, ffmpeg is not downloaded.
- * @property {false | "gyp"}                        [nativeAddon = false]                 Rebuild native modules
+ * @property {boolean}                              [nativeAddon = false]                 Download Node headers for native addons.
  * @property {string}                               [logLevel = 'info']                   User defined log level.
  * @property {boolean}                              [shaSum = true]                       If true shasum is enabled, otherwise disabled.
  */
@@ -183,7 +183,7 @@ async function get(options) {
 
   }
 
-  if (options.nativeAddon === 'gyp') {
+  if (options.nativeAddon === true) {
 
     /**
      * File path to NW'js Node headers tarball.

package/src/index.js

@@ -28,7 +28,7 @@ import util from './util.js';
  * @property {boolean}                             [shaSum = true]                           If true, shasum is enabled. Otherwise, disabled.
  * @property {boolean | "zip" | "tar" | "tgz"}     [zip=false]                               If true, "zip", "tar" or "tgz" the outDir directory is compressed.
  * @property {boolean | string | object}           [managedManifest = false]                 Managed manifest mode
- * @property {false | "gyp"}                       [nodeAddon = false]                       Rebuild Node native addons
+ * @property {boolean}                             [nodeAddon = false]                       Get Node native addons
  * @property {boolean}                             [cli=false]                               If true the CLI is used to parse options. This option is used internally.
  */
 
@@ -139,7 +139,6 @@ async function nwbuild(options) {
         app: options.app,
         glob: options.glob,
         managedManifest: options.managedManifest,
-        nativeAddon: options.nativeAddon,
         zip: options.zip,
         releaseInfo: releaseInfo,
       });

package/src/util.js

@@ -5,7 +5,6 @@ import path from 'node:path';
 import process from 'node:process';
 
 import * as GlobModule from 'glob';
-import semver from 'semver';
 
 /**
  * Get manifest (array of NW release metadata) from URL.
@@ -176,16 +175,14 @@ async function getNodeManifest({
 /**
  * Function to convert `'true'` and `'false'` into `true` and `false`.
  * `commander` does not do the conversion automatically.
- * @param {any} option - a boolean type option
- * @returns {any} Usually `undefined`, `true` or `false`. if not then it is validated later on.
+ * @param {string} option - a boolean type option
+ * @returns {true | false | string} `true`, `false` or file path
  */
 function str2Bool(option) {
-  if (typeof option === 'string') {
-    if (option === 'true') {
-      return true;
-    } else if (option === 'false') {
-      return false;
-    }
+  if (option === 'true') {
+    return true;
+  } else if (option === 'false') {
+    return false;
   } else {
     return option;
   }
@@ -211,7 +208,7 @@ export const parse = async (options, pkg) => {
   options.cache = str2Bool(options.cache ?? true);
   options.ffmpeg = str2Bool(options.ffmpeg ?? false);
   options.logLevel = options.logLevel ?? 'info';
-  options.shaSum = options.shaSum ?? true;
+  options.shaSum = str2Bool(options.shaSum ?? true);
 
   if (options.mode === 'get') {
     return { ...options };
@@ -428,21 +425,15 @@ export const validate = async (options, releaseInfo) => {
   }
 
   if (typeof options.nativeAddon !== 'boolean') {
-    if (typeof options.nativeAddon !== 'boolean' && typeof options.nativeAddon !== 'string') {
-      throw new Error('Expected options.nativeAddon to be a boolean or string type. Got ' + typeof options.nativeAddon);
-    }
-
-    if (semver.parse(options.version).minor >= '83' && options.nativeAddon !== false) {
-      throw new Error('Native addons are not supported for NW.js v0.82.0 and below');
-    }
+      throw new Error('Expected options.nativeAddon to be a boolean. Got ' + typeof options.nativeAddon);
+  }
 
-    if (typeof options.zip !== 'boolean' &
+  if (typeof options.zip !== 'boolean' &
       options.zip !== 'zip' &&
       options.zip !== 'tar' &&
       options.zip !== 'tgz') {
       throw new Error('Expected options.zip to be a boolean, `zip`, `tar` or `tgz`. Got ' + typeof options.zip);
     }
-  }
 
   if (options.platform === 'linux') {
     if (options.app.name && typeof options.app.name !== 'string') {