nucleus-core-ts 0.9.848 → 0.9.850

package/dist/fe/components/IntegrationsPage/components/ConnectionForm.js

@@ -54,11 +54,14 @@ export function ConnectionForm({ actions, source, loading = false, onSaved }) {
                 store.setError('The connection was not saved. The server did not return the record.');
                 return;
             }
+            // Told about the record BEFORE it is selected. The caller is what puts
+            // it into the list, and selecting an id the list does not hold is the
+            // state every card below renders a skeleton for.
+            onSaved?.(saved);
             // Selecting resets everything hanging off a connection, so it is only
             // right for a NEW one — doing it on an edit would empty the endpoint,
             // mapping and run lists the operator is working in.
             if (!source) store.selectSource(saved.id);
-            onSaved?.(saved);
         }).catch((reason)=>{
             setSaving(false);
             store.setError(errorText(reason, 'The connection could not be saved.'));

package/dist/fe/components/IntegrationsPage/components/ConnectionList.js

@@ -59,17 +59,31 @@ export function ConnectionList({ actions, onNewConnection, reloadToken = 0 }) {
     const publishLoading = useEffectEvent(()=>{
         store.setSourcesLoading(list.loading);
     });
+    // Only what the SERVER said. A reset empties the hook's items before the
+    // first page is asked for, and publishing that emptied the shared store —
+    // which is where the editor looks for the record it is editing. Saving
+    // triggers a reset, so saving is when the record vanished.
     useEffect(()=>{
-        publishItems();
+        if (list.settled) publishItems();
     }, [
         list.items,
-        list.total
+        list.total,
+        list.settled
     ]);
     useEffect(()=>{
         publishLoading();
     }, [
         list.loading
     ]);
+    // Handed back on the way out. This flag has exactly one writer — this
+    // component — and unmounting mid-request left it true with nobody able to
+    // clear it, so whatever else reads it showed a skeleton for a request that
+    // had already finished.
+    useEffect(()=>{
+        return ()=>{
+            store.setSourcesLoading(false);
+        };
+    }, []);
     const handleNew = ()=>{
         store.selectSource(null);
         onNewConnection?.();

package/dist/fe/components/IntegrationsPage/components/ConnectionSettingsTab.js

@@ -22,27 +22,35 @@ import { CredentialFields } from './CredentialFields';
  */ export function ConnectionSettingsTab({ actions, onSaved, onDeleted }) {
     const store = useIntegrationsStore();
     const source = store.sources.find((candidate)=>candidate.id === store.selectedSourceId) ?? null;
-    // The list holds only the current page, so a connection selected before a
-    // later page loaded may not be in it yet. Saying so beats an empty form that
-    // looks like the record was lost.
-    const missingFromPage = store.selectedSourceId !== null && source === null;
+    /**
+   * Waiting for THIS record, and nothing else.
+   *
+   * It used to be `store.sourcesLoading || missingFromPage`, and sourcesLoading
+   * is true whenever the rail is fetching ANY page — including a page fetched
+   * because somebody typed a letter into the search box. With no connection
+   * chosen this tab is the blank "new connection" form, and every keystroke in
+   * the rail beside it replaced that form with skeletons.
+   *
+   * A form that is not editing a record is never loading: there is nothing to
+   * wait for. A form that IS editing one waits only until that record is here.
+   */ const waitingForRecord = store.selectedSourceId !== null && source === null;
     return /*#__PURE__*/ _jsxs("div", {
         className: theme.layout.main,
         children: [
             /*#__PURE__*/ _jsx(ConnectionForm, {
                 actions: actions,
-                loading: store.sourcesLoading || missingFromPage,
+                loading: waitingForRecord,
                 onSaved: onSaved,
                 source: source
             }),
             /*#__PURE__*/ _jsx(CredentialFields, {
                 actions: actions,
-                loading: store.sourcesLoading || missingFromPage,
+                loading: waitingForRecord,
                 source: source
             }),
             /*#__PURE__*/ _jsx(ConnectionTest, {
                 actions: actions,
-                loading: store.sourcesLoading || missingFromPage,
+                loading: waitingForRecord,
                 source: source
             }),
             /*#__PURE__*/ _jsx(ConnectionDelete, {

package/dist/fe/components/IntegrationsPage/components/EndpointList.js

@@ -72,17 +72,31 @@ export function EndpointList({ sourceId, actions, onNewEndpoint, onSelect, reloa
     const publishLoading = useEffectEvent(()=>{
         store.setEndpointsLoading(list.loading);
     });
+    // Only what the SERVER said. A reset empties the hook's items before the
+    // first page is asked for, and publishing that emptied the shared store —
+    // which is where the editor looks for the record it is editing. Saving
+    // triggers a reset, so saving is when the record vanished.
     useEffect(()=>{
-        publishItems();
+        if (list.settled) publishItems();
     }, [
         list.items,
-        list.total
+        list.total,
+        list.settled
     ]);
     useEffect(()=>{
         publishLoading();
     }, [
         list.loading
     ]);
+    // Handed back on the way out. This flag has exactly one writer — this
+    // component — and unmounting mid-request left it true with nobody able to
+    // clear it, so whatever else reads it showed a skeleton for a request that
+    // had already finished.
+    useEffect(()=>{
+        return ()=>{
+            store.setEndpointsLoading(false);
+        };
+    }, []);
     const handleNew = ()=>{
         store.selectEndpoint(null);
         onNewEndpoint?.();

package/dist/fe/components/IntegrationsPage/components/EndpointSample.js

@@ -7,6 +7,7 @@ import { integrationsPageTheme } from '../theme';
 import { Badge, CodeBlock, Field, Notice, Stat } from './Primitives';
 import { pathParamNames } from './pathParams';
 import { CardSkeleton, StatGridSkeleton } from './Skeletons';
+import { settlementOf } from './settleOwnership';
 /**
  * One real request, shown in full.
  *
@@ -21,6 +22,7 @@ export function EndpointSample({ endpoint, actions }) {
     const [values, setValues] = useState({});
     // Kept in step with the render so an in-flight reply can ask what is selected
     // NOW, not what was selected when it was sent.
+    const generationRef = useRef(0);
     const selectedRef = useRef(store.selectedEndpointId);
     selectedRef.current = store.selectedEndpointId;
     const params = pathParamNames(endpoint.path);
@@ -29,20 +31,39 @@ export function EndpointSample({ endpoint, actions }) {
     for (const name of params){
         if (!(values[name] ?? '').trim()) unfilled += 1;
     }
+    /**
+   * Discard a late answer, but hand the busy flag back on the way out.
+   *
+   * The discard itself is right — the operator has moved on and the field list
+   * must describe the endpoint they are looking at. It used to be a bare
+   * `return`, which skipped the clearing too: `sampling` stayed set with nobody
+   * left to unset it, and the sample card showed a skeleton until the page was
+   * reloaded. See settleOwnership.ts for who owns the flag.
+   */ const settleElsewhere = (mine, requestedFor)=>{
+        const { discard, releaseFlag } = settlementOf({
+            mine,
+            latest: generationRef.current,
+            requestedFor,
+            selectedNow: selectedRef.current
+        });
+        if (releaseFlag) store.setSampling(false);
+        return discard;
+    };
     const run = ()=>{
         // The endpoint this request is FOR. A sample can take seconds against a slow
         // source, and an operator who clicks another endpoint meanwhile would
         // otherwise get the first one's answer written in as the second one's field
         // list — and then map against fields the endpoint does not have.
         const requestedFor = endpoint.id;
+        const mine = ++generationRef.current;
         store.setSampling(true);
         store.setError(null);
         actions.sampleEndpoint(requestedFor, params.length > 0 ? values : undefined).then((result)=>{
-            if (selectedRef.current !== requestedFor) return;
+            if (settleElsewhere(mine, requestedFor)) return;
             store.setSample(result);
             if (!result.ok && result.error) store.setError(result.error);
         }).catch((error)=>{
-            if (selectedRef.current !== requestedFor) return;
+            if (settleElsewhere(mine, requestedFor)) return;
             store.setSample(null);
             store.setError(error instanceof Error ? error.message : 'Sampling the endpoint failed.');
         });

package/dist/fe/components/IntegrationsPage/components/MappingList.js

@@ -83,17 +83,31 @@ export function MappingList({ actions, sourceId, selectedId, reloadToken, onSele
     const publishLoading = useEffectEvent(()=>{
         store.setMappingsLoading(list.loading);
     });
+    // Only what the SERVER said. A reset empties the hook's items before the
+    // first page is asked for, and publishing that emptied the shared store —
+    // which is where the editor looks for the record it is editing. Saving
+    // triggers a reset, so saving is when the record vanished.
     useEffect(()=>{
-        publishItems();
+        if (list.settled) publishItems();
     }, [
         list.items,
-        list.total
+        list.total,
+        list.settled
     ]);
     useEffect(()=>{
         publishLoading();
     }, [
         list.loading
     ]);
+    // Handed back on the way out. This flag has exactly one writer — this
+    // component — and unmounting mid-request left it true with nobody able to
+    // clear it, so whatever else reads it showed a skeleton for a request that
+    // had already finished.
+    useEffect(()=>{
+        return ()=>{
+            store.setMappingsLoading(false);
+        };
+    }, []);
     const showSkeleton = list.loading && list.items.length === 0;
     return /*#__PURE__*/ _jsxs("section", {
         className: "flex flex-col gap-3",

package/dist/fe/components/IntegrationsPage/components/RunHistory.js

@@ -51,17 +51,30 @@ export function RunHistory({ actions, mappingId, refreshKey, onRefresh }) {
     const publishLoading = useEffectEvent(()=>{
         store.setRunsLoading(list.loading);
     });
+    // Only what the SERVER said — see the same guard on the other three lists: a
+    // reset empties the hook's items before the first page is asked for, and
+    // publishing that emptied the shared store.
     useEffect(()=>{
-        publishRuns();
+        if (list.settled) publishRuns();
     }, [
         list.items,
-        list.total
+        list.total,
+        list.settled
     ]);
     useEffect(()=>{
         publishLoading();
     }, [
         list.loading
     ]);
+    // Handed back on the way out. This flag has exactly one writer — this
+    // component — and unmounting mid-request left it true with nobody able to
+    // clear it, so whatever else reads it showed a skeleton for a request that
+    // had already finished.
+    useEffect(()=>{
+        return ()=>{
+            store.setRunsLoading(false);
+        };
+    }, []);
     const firstPagePending = list.loading && list.items.length === 0;
     return /*#__PURE__*/ _jsxs("section", {
         className: theme.card.wrapper,

package/dist/fe/components/IntegrationsPage/components/RunPanel.js

@@ -66,11 +66,16 @@ export function RunPanel({ mapping, actions, onSubscribeProgress, onRunSettled }
                 setConfirming(true);
                 return;
             }
+            // A refusal ENDS the confirmation. Left standing, the panel kept asking
+            // "are you sure?" about an import the server had already turned down,
+            // and pressing the confirm button again just collected the same refusal.
             if (result.error) {
+                setConfirming(false);
                 store.setError(result.error);
                 return;
             }
             if (!result.runId) {
+                setConfirming(false);
                 store.setError('The import was accepted but no run id came back, so it cannot be tracked.');
                 return;
             }
@@ -80,6 +85,7 @@ export function RunPanel({ mapping, actions, onSubscribeProgress, onRunSettled }
             store.setActiveRun(result.runId);
         }).catch((error)=>{
             setStarting(false);
+            setConfirming(false);
             store.setError(errorText(error, 'The import could not be started.'));
         });
     };
@@ -120,10 +126,21 @@ export function RunPanel({ mapping, actions, onSubscribeProgress, onRunSettled }
    */ const pollActiveRun = useEffectEvent(()=>{
         const runId = store.activeRunId;
         if (!runId) return;
-        actions.listRuns({
+        actions// NEWEST first, explicitly. Without a sort the server answers in its own
+        // order — which is the order the rows were written — so from the sixth
+        // import of a mapping onwards the run being watched was not among the
+        // five that came back. The tick below then found nothing, returned, and
+        // left the progress bar running for an import that had already finished.
+        .listRuns({
             mappingId: mapping.id,
             page: 1,
-            limit: 5
+            limit: 5,
+            sort: [
+                {
+                    field: 'createdAt',
+                    direction: 'desc'
+                }
+            ]
         }).then((result)=>{
             if (store.activeRunId !== runId) return;
             const run = result.items.find((item)=>item.id === runId);

package/dist/fe/components/IntegrationsPage/components/settleOwnership.d.ts

@@ -0,0 +1,35 @@
+/**
+ * Who owns a busy flag when a late answer arrives.
+ *
+ * Every request in this panel sets a shared "in progress" flag on the way in and
+ * clears it on the way out. That breaks the moment an answer is DISCARDED —
+ * because the operator moved on, or because a newer request replaced this one —
+ * since a bare `return` skips the clearing too and the flag stays set with
+ * nobody left to unset it. The panel then shows a skeleton for a request that
+ * has already finished and will never be written.
+ *
+ * Two questions, and they are not the same question:
+ *
+ *   superseded — a NEWER request of the same kind has started. It set the flag
+ *                after this one did and will clear it when it settles, so this
+ *                answer must leave the flag strictly alone.
+ *   movedOn    — the operator is looking at something else. Nobody else is
+ *                coming: this request is the last one out and must clear the
+ *                flag before dropping its answer.
+ */
+export type Settlement = {
+    /** True when this answer must not be written. */
+    discard: boolean;
+    /** True when this request is responsible for clearing the busy flag. */
+    releaseFlag: boolean;
+};
+export declare function settlementOf(args: {
+    /** The generation this request was given when it started. */
+    mine: number;
+    /** The latest generation handed out. */
+    latest: number;
+    /** What this request was for. */
+    requestedFor: string;
+    /** What is selected right now. */
+    selectedNow: string | null;
+}): Settlement;

package/dist/fe/components/IntegrationsPage/components/settleOwnership.js

@@ -0,0 +1,30 @@
+/**
+ * Who owns a busy flag when a late answer arrives.
+ *
+ * Every request in this panel sets a shared "in progress" flag on the way in and
+ * clears it on the way out. That breaks the moment an answer is DISCARDED —
+ * because the operator moved on, or because a newer request replaced this one —
+ * since a bare `return` skips the clearing too and the flag stays set with
+ * nobody left to unset it. The panel then shows a skeleton for a request that
+ * has already finished and will never be written.
+ *
+ * Two questions, and they are not the same question:
+ *
+ *   superseded — a NEWER request of the same kind has started. It set the flag
+ *                after this one did and will clear it when it settles, so this
+ *                answer must leave the flag strictly alone.
+ *   movedOn    — the operator is looking at something else. Nobody else is
+ *                coming: this request is the last one out and must clear the
+ *                flag before dropping its answer.
+ */ export function settlementOf(args) {
+    const superseded = args.latest !== args.mine;
+    const movedOn = args.selectedNow !== args.requestedFor;
+    return {
+        discard: superseded || movedOn,
+        // Only the request that still holds the flag may clear it — otherwise a
+        // slow first answer would switch off the light on a second request that is
+        // still running, and the operator would watch a finished-looking panel fill
+        // in by itself a moment later.
+        releaseFlag: !superseded && movedOn
+    };
+}

package/dist/fe/components/IntegrationsPage/components/settleOwnership.test.d.ts

@@ -0,0 +1 @@
+export {};

package/dist/fe/components/IntegrationsPage/components/settleOwnership.test.js

@@ -0,0 +1,56 @@
+import { describe, expect, it } from 'bun:test';
+import { settlementOf } from './settleOwnership';
+const forEndpoint = (over = {})=>settlementOf({
+        mine: 1,
+        latest: 1,
+        requestedFor: 'a',
+        selectedNow: 'a',
+        ...over
+    });
+describe('settlementOf', ()=>{
+    it('writes the answer when nothing has changed', ()=>{
+        expect(forEndpoint()).toEqual({
+            discard: false,
+            releaseFlag: false
+        });
+    });
+    /**
+   * The bug this exists for: the operator clicked another endpoint while a
+   * sample was in flight, the answer was dropped, and the busy flag was left on
+   * with nobody coming to clear it.
+   */ it('drops the answer AND clears the flag when the operator moved on', ()=>{
+        expect(forEndpoint({
+            selectedNow: 'b'
+        })).toEqual({
+            discard: true,
+            releaseFlag: true
+        });
+    });
+    it('leaves the flag alone when a newer request has taken over', ()=>{
+        expect(forEndpoint({
+            latest: 2
+        })).toEqual({
+            discard: true,
+            releaseFlag: false
+        });
+    });
+    it('never clears the flag for a superseded request, even one that also moved on', ()=>{
+        // Both conditions at once: the newer request owns the flag, so this one must
+        // not switch it off while that one is still running.
+        expect(forEndpoint({
+            latest: 2,
+            selectedNow: 'b'
+        })).toEqual({
+            discard: true,
+            releaseFlag: false
+        });
+    });
+    it('treats nothing-selected as having moved on', ()=>{
+        expect(forEndpoint({
+            selectedNow: null
+        })).toEqual({
+            discard: true,
+            releaseFlag: true
+        });
+    });
+});

package/dist/fe/components/IntegrationsPage/components/useInfiniteList.d.ts

@@ -33,6 +33,19 @@ export type UseInfiniteListResult<T> = {
      * hook reports the failure and the caller must show it.
      */
     error: string | null;
+    /**
+     * Whether what `items` holds has actually come back from the server.
+     *
+     * A reset empties `items` BEFORE the first page is asked for, and callers
+     * mirror `items` into the shared store — so every refetch published an empty
+     * page, and whatever was reading that store lost the record it was showing.
+     * Saving is what triggers a refetch, which is why saving is when it was seen:
+     * the editor asked the store for the record it had just saved and the store
+     * had been emptied a moment earlier.
+     *
+     * False from a reset until the first page settles, success or failure.
+     */
+    settled: boolean;
     /** Put this on an element after the last row; seeing it asks for the next page. */
     sentinelRef: RefObject<HTMLDivElement | null>;
     reload: () => void;

package/dist/fe/components/IntegrationsPage/components/useInfiniteList.js

@@ -17,6 +17,7 @@ export function useInfiniteList(options) {
     const [loading, setLoading] = useState(true);
     const [error, setError] = useState(null);
     const [reloadToken, setReloadToken] = useState(0);
+    const [settled, setSettled] = useState(false);
     const sentinelRef = useRef(null);
     const nextPageRef = useRef(1);
     const loadedCountRef = useRef(0);
@@ -32,6 +33,7 @@ export function useInfiniteList(options) {
             if (generation !== generationRef.current) return;
             inFlightRef.current = false;
             setLoading(false);
+            setSettled(true);
             setTotal(result.total);
             setItems((previous)=>page === 1 ? result.items : [
                     ...previous,
@@ -47,6 +49,9 @@ export function useInfiniteList(options) {
             if (generation !== generationRef.current) return;
             inFlightRef.current = false;
             setLoading(false);
+            // Settled, even though it failed: the caller must be free to show the
+            // error instead of waiting on a page that is never coming.
+            setSettled(true);
             setError(reason instanceof Error ? reason.message : String(reason));
             // Stop asking. The sentinel stays on screen, so retrying on failure
             // would hammer a broken endpoint for as long as the panel is open;
@@ -67,6 +72,7 @@ export function useInfiniteList(options) {
         setItems([]);
         setTotal(0);
         setLoading(true);
+        setSettled(false);
         setError(null);
         fetchPage(1);
         return ()=>{
@@ -103,6 +109,7 @@ export function useInfiniteList(options) {
         items,
         total,
         loading,
+        settled,
         error,
         sentinelRef,
         reload

package/dist/fe/components/IntegrationsPage/store/index.js

@@ -39,13 +39,24 @@ export const { useStore: useIntegrationsStore } = createStore(initial, {
                 store.tab = 'connection';
                 store.endpoints = [];
                 store.endpointsTotal = 0;
-                store.endpointsPage = 1;
                 store.endpointsSearch = '';
                 store.selectedEndpointId = null;
                 store.mappings = [];
                 store.mappingsTotal = 0;
-                store.mappingsPage = 1;
                 store.mappingsSearch = '';
+                // Every WAIT below a connection ends with it too. These are the flags the
+                // cards read to decide between a skeleton and their content, and their
+                // only writers live under the connection being left — so leaving one set
+                // meant the next connection opened onto a skeleton with nothing running.
+                store.endpointsLoading = false;
+                store.mappingsLoading = false;
+                store.runsLoading = false;
+                store.sample = null;
+                store.sampling = false;
+                store.plan = null;
+                store.planning = false;
+                store.activeRunId = null;
+                store.progress = null;
                 store.selectedMappingId = null;
                 store.runs = [];
                 store.runsTotal = 0;
@@ -89,6 +100,12 @@ export const { useStore: useIntegrationsStore } = createStore(initial, {
                 // The sample describes ONE endpoint; carrying it over would offer the
                 // wrong field list to the next mapping.
                 store.sample = null;
+                // And the WAIT for a sample belongs to the endpoint that was left, not to
+                // the one arrived at. Clearing the record without clearing the flag left
+                // the next endpoint showing a skeleton for a request that was never going
+                // to be written — permanently, because the answer, when it came, saw the
+                // selection had moved and returned without touching anything.
+                store.sampling = false;
             }),
     setMappings: (store)=>(items, total)=>batch(()=>{
                 store.mappings = items;
@@ -121,6 +138,10 @@ export const { useStore: useIntegrationsStore } = createStore(initial, {
                 // A plan belongs to the mapping it was computed for. Showing it against a
                 // different one would have an operator approve counts from another import.
                 store.plan = null;
+                // And the WAIT for a plan goes with it. Discarding the plan while leaving
+                // this set put the next mapping's panel on a counting skeleton for a
+                // preview that had been computed for a different mapping and thrown away.
+                store.planning = false;
                 // And so does a RUN, which says something stronger than a plan does: that
                 // this import happened. Seen live — the Ünvanlar run stayed on screen
                 // under a header reading "Writes into locations", for a mapping that had

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "nucleus-core-ts",
-	"version": "0.9.848",
+	"version": "0.9.850",
 	"description": "Production-ready, enterprise-grade TypeScript framework for building multi-tenant APIs",
 	"author": "Hidayet Can Özcan <hidayetcan@gmail.com>",
 	"license": "SEE LICENSE IN LICENSE",