nucleus-core-ts 0.9.848 → 0.9.849

package/dist/fe/components/IntegrationsPage/components/EndpointSample.js

@@ -7,6 +7,7 @@ import { integrationsPageTheme } from '../theme';
 import { Badge, CodeBlock, Field, Notice, Stat } from './Primitives';
 import { pathParamNames } from './pathParams';
 import { CardSkeleton, StatGridSkeleton } from './Skeletons';
+import { settlementOf } from './settleOwnership';
 /**
  * One real request, shown in full.
  *
@@ -21,6 +22,7 @@ export function EndpointSample({ endpoint, actions }) {
     const [values, setValues] = useState({});
     // Kept in step with the render so an in-flight reply can ask what is selected
     // NOW, not what was selected when it was sent.
+    const generationRef = useRef(0);
     const selectedRef = useRef(store.selectedEndpointId);
     selectedRef.current = store.selectedEndpointId;
     const params = pathParamNames(endpoint.path);
@@ -29,20 +31,39 @@ export function EndpointSample({ endpoint, actions }) {
     for (const name of params){
         if (!(values[name] ?? '').trim()) unfilled += 1;
     }
+    /**
+   * Discard a late answer, but hand the busy flag back on the way out.
+   *
+   * The discard itself is right — the operator has moved on and the field list
+   * must describe the endpoint they are looking at. It used to be a bare
+   * `return`, which skipped the clearing too: `sampling` stayed set with nobody
+   * left to unset it, and the sample card showed a skeleton until the page was
+   * reloaded. See settleOwnership.ts for who owns the flag.
+   */ const settleElsewhere = (mine, requestedFor)=>{
+        const { discard, releaseFlag } = settlementOf({
+            mine,
+            latest: generationRef.current,
+            requestedFor,
+            selectedNow: selectedRef.current
+        });
+        if (releaseFlag) store.setSampling(false);
+        return discard;
+    };
     const run = ()=>{
         // The endpoint this request is FOR. A sample can take seconds against a slow
         // source, and an operator who clicks another endpoint meanwhile would
         // otherwise get the first one's answer written in as the second one's field
         // list — and then map against fields the endpoint does not have.
         const requestedFor = endpoint.id;
+        const mine = ++generationRef.current;
         store.setSampling(true);
         store.setError(null);
         actions.sampleEndpoint(requestedFor, params.length > 0 ? values : undefined).then((result)=>{
-            if (selectedRef.current !== requestedFor) return;
+            if (settleElsewhere(mine, requestedFor)) return;
             store.setSample(result);
             if (!result.ok && result.error) store.setError(result.error);
         }).catch((error)=>{
-            if (selectedRef.current !== requestedFor) return;
+            if (settleElsewhere(mine, requestedFor)) return;
             store.setSample(null);
             store.setError(error instanceof Error ? error.message : 'Sampling the endpoint failed.');
         });

package/dist/fe/components/IntegrationsPage/components/settleOwnership.d.ts

@@ -0,0 +1,35 @@
+/**
+ * Who owns a busy flag when a late answer arrives.
+ *
+ * Every request in this panel sets a shared "in progress" flag on the way in and
+ * clears it on the way out. That breaks the moment an answer is DISCARDED —
+ * because the operator moved on, or because a newer request replaced this one —
+ * since a bare `return` skips the clearing too and the flag stays set with
+ * nobody left to unset it. The panel then shows a skeleton for a request that
+ * has already finished and will never be written.
+ *
+ * Two questions, and they are not the same question:
+ *
+ *   superseded — a NEWER request of the same kind has started. It set the flag
+ *                after this one did and will clear it when it settles, so this
+ *                answer must leave the flag strictly alone.
+ *   movedOn    — the operator is looking at something else. Nobody else is
+ *                coming: this request is the last one out and must clear the
+ *                flag before dropping its answer.
+ */
+export type Settlement = {
+    /** True when this answer must not be written. */
+    discard: boolean;
+    /** True when this request is responsible for clearing the busy flag. */
+    releaseFlag: boolean;
+};
+export declare function settlementOf(args: {
+    /** The generation this request was given when it started. */
+    mine: number;
+    /** The latest generation handed out. */
+    latest: number;
+    /** What this request was for. */
+    requestedFor: string;
+    /** What is selected right now. */
+    selectedNow: string | null;
+}): Settlement;

package/dist/fe/components/IntegrationsPage/components/settleOwnership.js

@@ -0,0 +1,30 @@
+/**
+ * Who owns a busy flag when a late answer arrives.
+ *
+ * Every request in this panel sets a shared "in progress" flag on the way in and
+ * clears it on the way out. That breaks the moment an answer is DISCARDED —
+ * because the operator moved on, or because a newer request replaced this one —
+ * since a bare `return` skips the clearing too and the flag stays set with
+ * nobody left to unset it. The panel then shows a skeleton for a request that
+ * has already finished and will never be written.
+ *
+ * Two questions, and they are not the same question:
+ *
+ *   superseded — a NEWER request of the same kind has started. It set the flag
+ *                after this one did and will clear it when it settles, so this
+ *                answer must leave the flag strictly alone.
+ *   movedOn    — the operator is looking at something else. Nobody else is
+ *                coming: this request is the last one out and must clear the
+ *                flag before dropping its answer.
+ */ export function settlementOf(args) {
+    const superseded = args.latest !== args.mine;
+    const movedOn = args.selectedNow !== args.requestedFor;
+    return {
+        discard: superseded || movedOn,
+        // Only the request that still holds the flag may clear it — otherwise a
+        // slow first answer would switch off the light on a second request that is
+        // still running, and the operator would watch a finished-looking panel fill
+        // in by itself a moment later.
+        releaseFlag: !superseded && movedOn
+    };
+}

package/dist/fe/components/IntegrationsPage/components/settleOwnership.test.d.ts

@@ -0,0 +1 @@
+export {};

package/dist/fe/components/IntegrationsPage/components/settleOwnership.test.js

@@ -0,0 +1,56 @@
+import { describe, expect, it } from 'bun:test';
+import { settlementOf } from './settleOwnership';
+const forEndpoint = (over = {})=>settlementOf({
+        mine: 1,
+        latest: 1,
+        requestedFor: 'a',
+        selectedNow: 'a',
+        ...over
+    });
+describe('settlementOf', ()=>{
+    it('writes the answer when nothing has changed', ()=>{
+        expect(forEndpoint()).toEqual({
+            discard: false,
+            releaseFlag: false
+        });
+    });
+    /**
+   * The bug this exists for: the operator clicked another endpoint while a
+   * sample was in flight, the answer was dropped, and the busy flag was left on
+   * with nobody coming to clear it.
+   */ it('drops the answer AND clears the flag when the operator moved on', ()=>{
+        expect(forEndpoint({
+            selectedNow: 'b'
+        })).toEqual({
+            discard: true,
+            releaseFlag: true
+        });
+    });
+    it('leaves the flag alone when a newer request has taken over', ()=>{
+        expect(forEndpoint({
+            latest: 2
+        })).toEqual({
+            discard: true,
+            releaseFlag: false
+        });
+    });
+    it('never clears the flag for a superseded request, even one that also moved on', ()=>{
+        // Both conditions at once: the newer request owns the flag, so this one must
+        // not switch it off while that one is still running.
+        expect(forEndpoint({
+            latest: 2,
+            selectedNow: 'b'
+        })).toEqual({
+            discard: true,
+            releaseFlag: false
+        });
+    });
+    it('treats nothing-selected as having moved on', ()=>{
+        expect(forEndpoint({
+            selectedNow: null
+        })).toEqual({
+            discard: true,
+            releaseFlag: true
+        });
+    });
+});

package/dist/fe/components/IntegrationsPage/store/index.js

@@ -89,6 +89,12 @@ export const { useStore: useIntegrationsStore } = createStore(initial, {
                 // The sample describes ONE endpoint; carrying it over would offer the
                 // wrong field list to the next mapping.
                 store.sample = null;
+                // And the WAIT for a sample belongs to the endpoint that was left, not to
+                // the one arrived at. Clearing the record without clearing the flag left
+                // the next endpoint showing a skeleton for a request that was never going
+                // to be written — permanently, because the answer, when it came, saw the
+                // selection had moved and returned without touching anything.
+                store.sampling = false;
             }),
     setMappings: (store)=>(items, total)=>batch(()=>{
                 store.mappings = items;

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "nucleus-core-ts",
-	"version": "0.9.848",
+	"version": "0.9.849",
 	"description": "Production-ready, enterprise-grade TypeScript framework for building multi-tenant APIs",
 	"author": "Hidayet Can Özcan <hidayetcan@gmail.com>",
 	"license": "SEE LICENSE IN LICENSE",