nucleus-core-ts 0.9.813 → 0.9.815

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "nucleus-core-ts",
-	"version": "0.9.813",
+	"version": "0.9.815",
 	"description": "Production-ready, enterprise-grade TypeScript framework for building multi-tenant APIs",
 	"author": "Hidayet Can Özcan <hidayetcan@gmail.com>",
 	"license": "SEE LICENSE IN LICENSE",

package/scripts/generate-schema.test.ts

@@ -107,3 +107,31 @@ describe('numeric defaults are quoted', () => {
     expect(code).toContain(".default('0')")
   })
 })
+
+/**
+ * An empty array default written as `{}` is an empty OBJECT in Postgres.
+ *
+ * Every row that never had a value then reads back as `{}` — and the first
+ * `for…of` over it throws "object is not iterable". Which is every existing row,
+ * the moment a new jsonb column is added to a table already in use: the panel
+ * that reads it dies on the next click, about a column nobody has filled in yet.
+ */
+describe('jsonb defaults keep their own shape', () => {
+  const emit = (col: Record<string, unknown>) => generateColumnCode(col as never, [], 'widgets')
+
+  it('an empty array default stays an array', () => {
+    expect(emit({ name: 'reference_checks', type: 'jsonb', default: [] })).toContain("'[]'")
+  })
+
+  it('an empty object default stays an object', () => {
+    expect(emit({ name: 'settings', type: 'jsonb', default: {} })).toContain("'{}'")
+  })
+
+  it('carries a default that actually holds something', () => {
+    expect(emit({ name: 'flags', type: 'jsonb', default: { a: 1 } })).toContain('\'{"a":1}\'')
+  })
+
+  it('escapes a quote rather than ending the literal early', () => {
+    expect(emit({ name: 'labels', type: 'jsonb', default: ["it's"] })).toContain("''s")
+  })
+})

package/scripts/generate-schema.ts

@@ -212,7 +212,11 @@ export function selectEmittedTables<T extends { table_name: string }>(
   )
 }
 
-export function generateColumnCode(col: Column, allTables: string[], currentTable?: string): string {
+export function generateColumnCode(
+  col: Column,
+  allTables: string[],
+  currentTable?: string
+): string {
   const drizzleType = TYPE_MAP[col.type] || 'text'
   let code = ''
 
@@ -273,10 +277,13 @@ export function generateColumnCode(col: Column, allTables: string[], currentTabl
       // that ran fine and failed `tsc`, which is how it survived: the file is
       // generated, so nobody reads it, and only a typecheck ever objected.
       code += isNumericType(col.type) ? `.default('${col.default}')` : `.default(${col.default})`
-    } else if (Array.isArray(col.default)) {
-      code += `.default(sql\`'{}'\`)`
-    } else if (typeof col.default === 'object') {
-      code += `.default(sql\`'{}'\`)`
+    } else if (typeof col.default === 'object' && col.default !== null) {
+      // Serialised properly, because `[]` written as `{}` is an empty OBJECT in
+      // Postgres. Every reader that iterates the column then throws "object is
+      // not iterable" the first time a row that never had a value is read —
+      // which is every existing row, the moment the column is added.
+      const literal = JSON.stringify(col.default).replace(/'/g, "''")
+      code += `.default(sql\`'${literal}'\`)`
     }
   }