nucleus-core-ts 0.9.789 → 0.9.790

package/dist/fe/components/IntegrationsPage/components/connectionDraft.js

@@ -65,6 +65,7 @@ export function usesOauth(authType) {
  */ export function draftToSource(draft, id) {
     const oauth = usesOauth(draft.authType);
     const timeout = Number.parseInt(draft.timeoutMs.trim(), 10);
+    const hasTimeout = Number.isFinite(timeout) && timeout > 0;
     return {
         ...id ? {
             id
@@ -84,7 +85,15 @@ export function usesOauth(authType) {
         oauthScope: oauth ? orNull(draft.oauthScope) : null,
         oauthClientAuth: oauth ? draft.oauthClientAuth : null,
         tlsVerify: draft.tlsVerify,
-        timeoutMs: Number.isFinite(timeout) && timeout > 0 ? timeout : null
+        // OMITTED when blank, never sent as null. The column is NOT NULL with a
+        // default, and an explicit null overrides a column default rather than
+        // falling back to it — so "leave it empty for the server default", which is
+        // what the field says, was answered "Missing required field: timeout_ms".
+        // A saved source always has a value, so blank only ever means "creating,
+        // and I have no opinion".
+        ...hasTimeout ? {
+            timeoutMs: timeout
+        } : {}
     };
 }
 const SLUG_PATTERN = /^[a-z0-9][a-z0-9_-]*$/;

package/dist/fe/components/IntegrationsPage/components/connectionDraft.test.d.ts

@@ -0,0 +1 @@
+export {};

package/dist/fe/components/IntegrationsPage/components/connectionDraft.test.js

@@ -0,0 +1,133 @@
+import { describe, expect, test } from 'bun:test';
+import { draftFromSource, draftToSource, emptyConnectionDraft, validateConnectionDraft } from './connectionDraft';
+/**
+ * Found in production, creating the first connection: the form said "Empty
+ * means the server default" under the timeout, and saving with it empty
+ * answered "Missing required field: timeout_ms".
+ *
+ * `timeout_ms` is NOT NULL with a default of 30000. An explicit null does not
+ * fall back to a column default — it overrides it and violates the constraint.
+ * The distinction between "send null" and "do not send the key" is the whole
+ * bug, so it is what these assert.
+ */ const filled = ()=>({
+        ...emptyConnectionDraft,
+        name: 'TatMetal HR',
+        slug: 'tatmetal-hr',
+        baseUrl: 'https://online.tatmetal.com/hr-service'
+    });
+describe('draftToSource — columns that are NOT NULL with a default', ()=>{
+    test('an empty timeout is omitted, not sent as null', ()=>{
+        const payload = draftToSource(filled());
+        expect('timeoutMs' in payload).toBe(false);
+        expect(payload.timeoutMs).toBeUndefined();
+    });
+    test('a timeout that was typed is sent as a number', ()=>{
+        const payload = draftToSource({
+            ...filled(),
+            timeoutMs: '45000'
+        });
+        expect(payload.timeoutMs).toBe(45000);
+    });
+    test('whitespace and nonsense are treated as empty rather than as null', ()=>{
+        for (const value of [
+            '   ',
+            'abc',
+            '0',
+            '-1'
+        ]){
+            const payload = draftToSource({
+                ...filled(),
+                timeoutMs: value
+            });
+            expect(`${value} → ${'timeoutMs' in payload}`).toBe(`${value} → false`);
+        }
+    });
+    test('the other NOT NULL columns always carry a concrete value', ()=>{
+        const payload = draftToSource(filled());
+        expect(payload.authType).toBe('none');
+        expect(payload.tlsVerify).toBe(true);
+        expect(payload.enabled).toBe(true);
+    });
+});
+describe('draftToSource — fields the chosen auth type does not use', ()=>{
+    test('a bearer connection clears the OAuth settings rather than leaving them', ()=>{
+        const payload = draftToSource({
+            ...filled(),
+            authType: 'bearer',
+            tokenUrl: 'https://example.com/token',
+            oauthClientId: 'left-behind'
+        });
+        expect(payload.tokenUrl).toBeNull();
+        expect(payload.oauthClientId).toBeNull();
+        expect(payload.oauthGrantType).toBeNull();
+    });
+    test('a username is kept only for the password grant', ()=>{
+        const base = {
+            ...filled(),
+            authType: 'oauth2',
+            oauthUsername: 'svc-account'
+        };
+        expect(draftToSource({
+            ...base,
+            oauthGrantType: 'password'
+        }).oauthUsername).toBe('svc-account');
+        expect(draftToSource({
+            ...base,
+            oauthGrantType: 'client_credentials'
+        }).oauthUsername).toBeNull();
+    });
+});
+describe('validateConnectionDraft', ()=>{
+    test('the three fields a connection cannot do without are required', ()=>{
+        const errors = validateConnectionDraft(emptyConnectionDraft);
+        expect(errors.name).toBeDefined();
+        expect(errors.slug).toBeDefined();
+        expect(errors.baseUrl).toBeDefined();
+    });
+    test('a filled draft passes', ()=>{
+        expect(validateConnectionDraft(filled())).toEqual({});
+    });
+    test('plain http is accepted — an in-cluster service is a normal target', ()=>{
+        const errors = validateConnectionDraft({
+            ...filled(),
+            baseUrl: 'http://hr-service:8080'
+        });
+        expect(errors.baseUrl).toBeUndefined();
+    });
+    test('a non-numeric timeout is refused before it can reach the server', ()=>{
+        expect(validateConnectionDraft({
+            ...filled(),
+            timeoutMs: 'soon'
+        }).timeoutMs).toBeDefined();
+        expect(validateConnectionDraft({
+            ...filled(),
+            timeoutMs: ''
+        }).timeoutMs).toBeUndefined();
+    });
+});
+describe('draftFromSource', ()=>{
+    test('a saved timeout comes back into the field', ()=>{
+        const draft = draftFromSource({
+            id: 'a',
+            name: 'n',
+            slug: 's',
+            baseUrl: 'https://x.test',
+            authType: 'none',
+            timeoutMs: 45000
+        });
+        expect(draft.timeoutMs).toBe('45000');
+    });
+    test('a round trip through the form does not invent a change', ()=>{
+        const source = {
+            id: 'a',
+            name: 'n',
+            slug: 's',
+            baseUrl: 'https://x.test',
+            authType: 'none',
+            tlsVerify: true,
+            enabled: true,
+            timeoutMs: 30000
+        };
+        expect(draftToSource(draftFromSource(source), 'a').timeoutMs).toBe(30000);
+    });
+});

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "nucleus-core-ts",
-	"version": "0.9.789",
+	"version": "0.9.790",
 	"description": "Production-ready, enterprise-grade TypeScript framework for building multi-tenant APIs",
 	"author": "Hidayet Can Özcan <hidayetcan@gmail.com>",
 	"license": "SEE LICENSE IN LICENSE",
@@ -50,7 +50,7 @@
 		}
 	},
 	"scripts": {
-		"test": "bun test src scripts",
+		"test": "bun test src scripts fe",
 		"build": "bun run scripts/build.ts",
 		"build:quick": "bun run build:js && bun run build:types",
 		"build:js": "bun build ./index.ts ./client.ts ./fe/index.ts ./src/Client/Proxy/index.ts --outdir=dist --target=bun --format=esm --splitting --minify --external react --external react-dom --external gsap --external @gsap/react --external h-state --external elysia --external drizzle-orm --external drizzle-kit --external ioredis --external googleapis --external @dapr/dapr --external pg --external @xyflow/react --external @xyflow/system --external @azure/communication-email --external @azure/identity --external stripe --external sharp",