nubos-pilot 0.9.3 → 0.9.4

package/bin/np-tools/commit-task.cjs

@@ -9,6 +9,32 @@ const git = require('../../lib/git.cjs');
 const { commitTask, findCommitByTaskId } = git;
 const { deleteCheckpoint, readCheckpoint } = require('../../lib/checkpoint.cjs');
 
+const BYPASS_FLAG = '--bypass-nubosloop';
+
+function _assertLoopGate(taskId, cwd, bypass, stderr) {
+  const cp = readCheckpoint(taskId, cwd);
+  const last = cp && cp.nubosloop && cp.nubosloop.last_phase;
+  if (last === 'commit') return { bypassed: false, last_phase: last };
+  const reason = !cp ? 'no-checkpoint' : 'last-phase-mismatch';
+  const observed = last || (cp ? 'none' : 'no-checkpoint');
+  if (bypass) {
+    stderr.write(
+      '[nubos-pilot] WARNING: commit-task ' + taskId +
+      ' bypassing Nubosloop gate (' + BYPASS_FLAG + '; observed=' + observed +
+      '). Single-pass commit, no critic review enforced.\n',
+    );
+    return { bypassed: true, last_phase: last || null };
+  }
+  throw new NubosPilotError(
+    'commit-task-loop-bypass-violation',
+    'commit-task refused: Nubosloop did not reach phase=commit for ' + taskId +
+    ' (observed nubosloop.last_phase=' + observed + '). ' +
+    'Run `loop-run-round ' + taskId + ' --phase commit` first, or pass ' + BYPASS_FLAG +
+    ' for an explicit single-pass override.',
+    { taskId, reason, last_phase: last || null },
+  );
+}
+
 function _resolveTaskFile(taskId, cwd) {
   const parsed = layout.parseTaskFullId(taskId);
   const filePath = layout.taskPlanPath(parsed.milestone, parsed.slice, parsed.task, cwd);
@@ -49,8 +75,11 @@ function run(args, ctx) {
   const context = ctx || {};
   const cwd = context.cwd || process.cwd();
   const stdout = context.stdout || process.stdout;
+  const stderr = context.stderr || process.stderr;
   const list = Array.isArray(args) ? args : [];
-  const taskId = list[0];
+  const bypass = list.includes(BYPASS_FLAG);
+  const positional = list.filter((a) => !String(a).startsWith('--'));
+  const taskId = positional[0];
 
   if (!taskId) {
     throw new NubosPilotError(
@@ -67,6 +96,8 @@ function run(args, ctx) {
     );
   }
 
+  const gate = _assertLoopGate(taskId, cwd, bypass, stderr);
+
   const { filePath } = _resolveTaskFile(taskId, cwd);
   const raw = fs.readFileSync(filePath, 'utf-8');
   const { frontmatter, body } = extractFrontmatter(raw);
@@ -93,7 +124,7 @@ function run(args, ctx) {
   const name = _extractName(frontmatter, body);
   const message = 'task(' + taskId + '): ' + name;
 
-  
+
 
   commitTask(taskId, safeFiles, message);
   const sha = findCommitByTaskId(taskId);
@@ -103,7 +134,14 @@ function run(args, ctx) {
     process.stderr.write('[nubos-pilot warn] setTaskStatus failed for ' + taskId + ': ' + (err && err.message) + '\n');
   }
 
-  const payload = { ok: true, task_id: taskId, sha, files: safeFiles, files_source: filesSource };
+  const payload = {
+    ok: true,
+    task_id: taskId,
+    sha,
+    files: safeFiles,
+    files_source: filesSource,
+    nubosloop_bypassed: gate.bypassed,
+  };
   stdout.write(JSON.stringify(payload));
   return payload;
 }

package/bin/np-tools/commit-task.test.cjs

@@ -82,6 +82,27 @@ function _capture() {
   return { stub, get: () => buf };
 }
 
+// Seed a checkpoint that satisfies the Nubosloop gate (last_phase=commit) so
+// commit-task accepts it. Tests that exercise the gate explicitly bypass this
+// helper. Optional `extra` overrides any field on the envelope.
+function seedLoopReadyCheckpoint(root, taskId, extra) {
+  const cpPath = path.join(root, '.nubos-pilot', 'checkpoints', taskId + '.json');
+  fs.mkdirSync(path.dirname(cpPath), { recursive: true });
+  const base = {
+    schema_version: 1,
+    task_id: taskId,
+    status: 'pre-commit',
+    files_touched: [],
+    nubosloop: {
+      last_phase: 'commit',
+      last_action: 'commit',
+      committed_at: '2026-05-04T12:00:00Z',
+    },
+  };
+  fs.writeFileSync(cpPath, JSON.stringify(Object.assign(base, extra || {})), 'utf-8');
+  return cpPath;
+}
+
 after(() => {
   while (_repos.length) {
     const r = _repos.pop();
@@ -110,6 +131,7 @@ test('CT-2: commit-task rejects invalid TASK_ID format (defense-in-depth)', () =
 test('CT-3: commit-task emits JSON with sha + files on success', () => {
   const root = makeRepo();
   seedPlanAndTask(root, '06-01', 'M006-S001-T0001', ['src/a.ts']);
+  seedLoopReadyCheckpoint(root, 'M006-S001-T0001');
 
   fs.mkdirSync(path.join(root, 'src'), { recursive: true });
   fs.writeFileSync(path.join(root, 'src', 'a.ts'), 'export const a = 1;\n', 'utf-8');
@@ -126,6 +148,7 @@ test('CT-3: commit-task emits JSON with sha + files on success', () => {
   assert.equal(payload.task_id, 'M006-S001-T0001');
   assert.ok(/^[0-9a-f]{40}$/.test(payload.sha));
   assert.deepEqual(payload.files, ['src/a.ts']);
+  assert.equal(payload.nubosloop_bypassed, false);
 
   const subject = execFileSync('git', ['-C', root, 'log', '-n', '1', '--format=%s'], { encoding: 'utf-8' }).trim();
   assert.ok(subject.startsWith('task(M006-S001-T0001):'), 'subject: ' + subject);
@@ -134,6 +157,7 @@ test('CT-3: commit-task emits JSON with sha + files on success', () => {
 test('CT-4: commit-task LOUD-FAILS when every files_modified entry is gitignored (D-25)', () => {
   const root = makeRepo();
   seedPlanAndTask(root, '06-01', 'M006-S001-T0002', ['build/out.js']);
+  seedLoopReadyCheckpoint(root, 'M006-S001-T0002');
   fs.writeFileSync(path.join(root, '.gitignore'), 'build/\n', 'utf-8');
   fs.mkdirSync(path.join(root, 'build'), { recursive: true });
   fs.writeFileSync(path.join(root, 'build', 'out.js'), 'noise', 'utf-8');
@@ -152,9 +176,13 @@ test('CT-4: commit-task LOUD-FAILS when every files_modified entry is gitignored
 
 test('CT-5: commit-task unknown task id → task-not-found', () => {
   const root = makeRepo();
+  // Loop gate runs BEFORE task lookup (no checkpoint seeded), so we expect
+  // the bypass-violation here, not the task-not-found error. Using --bypass
+  // so we exercise the unknown-task path instead.
   const cap = _capture();
+  const stderr = _capture();
   assert.throws(
-    () => subcmd.run(['M006-S099-T0099'], { cwd: root, stdout: cap.stub }),
+    () => subcmd.run(['M006-S099-T0099', '--bypass-nubosloop'], { cwd: root, stdout: cap.stub, stderr: stderr.stub }),
     (err) => err && err.code === 'commit-task-not-found',
   );
 });
@@ -164,14 +192,8 @@ test('CT-6: empty files_modified falls back to checkpoint.files_touched', () =>
   seedPlanAndTask(root, '06-01', 'M006-S001-T0010', []);
   fs.mkdirSync(path.join(root, 'src'), { recursive: true });
   fs.writeFileSync(path.join(root, 'src', 'b.ts'), 'export const b = 2;\n', 'utf-8');
-  const cpPath = path.join(root, '.nubos-pilot', 'checkpoints', 'M006-S001-T0010.json');
-  fs.mkdirSync(path.dirname(cpPath), { recursive: true });
-  fs.writeFileSync(cpPath, JSON.stringify({
-    schema_version: 1,
-    task_id: 'M006-S001-T0010',
-    status: 'pre-commit',
-    files_touched: ['src/b.ts'],
-  }), 'utf-8');
+  // Checkpoint must satisfy the loop gate AND carry files_touched.
+  seedLoopReadyCheckpoint(root, 'M006-S001-T0010', { files_touched: ['src/b.ts'] });
   const prev = process.cwd();
   process.chdir(root);
   const cap = _capture();
@@ -189,9 +211,88 @@ test('CT-6: empty files_modified falls back to checkpoint.files_touched', () =>
 test('CT-7: empty files_modified AND no checkpoint → commit-task-no-files', () => {
   const root = makeRepo();
   seedPlanAndTask(root, '06-01', 'M006-S001-T0011', []);
+  // No checkpoint → gate would normally refuse first; bypass to reach the
+  // no-files path that this test exercises.
   const cap = _capture();
+  const stderr = _capture();
   assert.throws(
-    () => subcmd.run(['M006-S001-T0011'], { cwd: root, stdout: cap.stub }),
+    () => subcmd.run(['M006-S001-T0011', '--bypass-nubosloop'], { cwd: root, stdout: cap.stub, stderr: stderr.stub }),
     (err) => err && err.code === 'commit-task-no-files',
   );
 });
+
+test('CT-8: refuse commit when no checkpoint exists (Nubosloop gate)', () => {
+  const root = makeRepo();
+  seedPlanAndTask(root, '06-01', 'M006-S001-T0020', ['src/c.ts']);
+  fs.mkdirSync(path.join(root, 'src'), { recursive: true });
+  fs.writeFileSync(path.join(root, 'src', 'c.ts'), 'export const c = 3;\n', 'utf-8');
+  const cap = _capture();
+  const stderr = _capture();
+  assert.throws(
+    () => subcmd.run(['M006-S001-T0020'], { cwd: root, stdout: cap.stub, stderr: stderr.stub }),
+    (err) => err && err.code === 'commit-task-loop-bypass-violation' && err.details && err.details.reason === 'no-checkpoint',
+  );
+});
+
+test('CT-9: refuse commit when nubosloop.last_phase ≠ commit', () => {
+  const root = makeRepo();
+  seedPlanAndTask(root, '06-01', 'M006-S001-T0021', ['src/d.ts']);
+  fs.mkdirSync(path.join(root, 'src'), { recursive: true });
+  fs.writeFileSync(path.join(root, 'src', 'd.ts'), 'export const d = 4;\n', 'utf-8');
+  // Checkpoint exists but loop only made it to verifying — gate must refuse.
+  seedLoopReadyCheckpoint(root, 'M006-S001-T0021', {
+    nubosloop: { last_phase: 'verifying', last_action: 'verify-green' },
+  });
+  const cap = _capture();
+  const stderr = _capture();
+  assert.throws(
+    () => subcmd.run(['M006-S001-T0021'], { cwd: root, stdout: cap.stub, stderr: stderr.stub }),
+    (err) => err && err.code === 'commit-task-loop-bypass-violation'
+      && err.details && err.details.reason === 'last-phase-mismatch'
+      && err.details.last_phase === 'verifying',
+  );
+});
+
+test('CT-10: --bypass-nubosloop allows single-pass commit and warns on stderr', () => {
+  const root = makeRepo();
+  seedPlanAndTask(root, '06-01', 'M006-S001-T0022', ['src/e.ts']);
+  fs.mkdirSync(path.join(root, 'src'), { recursive: true });
+  fs.writeFileSync(path.join(root, 'src', 'e.ts'), 'export const e = 5;\n', 'utf-8');
+  const prev = process.cwd();
+  process.chdir(root);
+  const cap = _capture();
+  const stderr = _capture();
+  try {
+    subcmd.run(['M006-S001-T0022', '--bypass-nubosloop'], { cwd: root, stdout: cap.stub, stderr: stderr.stub });
+  } finally {
+    process.chdir(prev);
+  }
+  const payload = JSON.parse(cap.get());
+  assert.equal(payload.ok, true);
+  assert.equal(payload.nubosloop_bypassed, true);
+  assert.match(stderr.get(), /WARNING: commit-task M006-S001-T0022 bypassing Nubosloop gate/);
+  assert.match(stderr.get(), /observed=no-checkpoint/);
+});
+
+test('CT-11: --bypass-nubosloop on partial loop state stamps the bypass reason', () => {
+  const root = makeRepo();
+  seedPlanAndTask(root, '06-01', 'M006-S001-T0023', ['src/f.ts']);
+  fs.mkdirSync(path.join(root, 'src'), { recursive: true });
+  fs.writeFileSync(path.join(root, 'src', 'f.ts'), 'export const f = 6;\n', 'utf-8');
+  seedLoopReadyCheckpoint(root, 'M006-S001-T0023', {
+    nubosloop: { last_phase: 'post-critics', last_action: 'executor' },
+  });
+  const prev = process.cwd();
+  process.chdir(root);
+  const cap = _capture();
+  const stderr = _capture();
+  try {
+    subcmd.run(['M006-S001-T0023', '--bypass-nubosloop'], { cwd: root, stdout: cap.stub, stderr: stderr.stub });
+  } finally {
+    process.chdir(prev);
+  }
+  const payload = JSON.parse(cap.get());
+  assert.equal(payload.ok, true);
+  assert.equal(payload.nubosloop_bypassed, true);
+  assert.match(stderr.get(), /observed=post-critics/);
+});

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nubos-pilot",
-  "version": "0.9.3",
+  "version": "0.9.4",
   "description": "AI-driven planning and execution tool for code projects",
   "homepage": "https://github.com/Nubos-AI/nubos-pilot",
   "repository": {