nsw-design-system 3.18.9 → 3.18.10

package/dist/js/components/file-upload/file-upload.d.ts

@@ -14,6 +14,5 @@ declare class FileUpload {
     createFileItem(file: any): string;
     updateFileList(): void;
     currentFiles: DataTransfer | undefined;
-    removeFile(): void;
     handleFileRemove(event: any): void;
 }

package/dist/js/main.js

@@ -1796,6 +1796,7 @@
         this.label = this.element.querySelector('label.nsw-file-upload__label');
       }
       this.input.addEventListener('change', this.handleInputChange.bind(this));
+      this.element.addEventListener('click', this.handleFileRemove.bind(this));
     }
     handleInputChange() {
       if (this.input.value === '') return;
@@ -1818,6 +1819,7 @@
       </button>`;
       li.insertAdjacentHTML('afterbegin', html);
       li.querySelector('.nsw-file-upload__item-filename').textContent = this.constructor.truncateString(file.name, 50);
+      li.querySelector('.nsw-file-upload__item-filename').dataset.filename = file.name;
       return li.outerHTML;
     }
     updateFileList() {
@@ -1826,32 +1828,43 @@
       }
       this.filesList.classList.add('active');
       const dataTransfer = new DataTransfer();
-      for (let i = 0; i < this.input.files.length; i += 1) {
-        const file = this.input.files[i];
-        dataTransfer.items.add(file);
+      const existingFiles = new Set();
+      if (this.replaceFiles) {
+        this.filesList.innerHTML = '';
+        this.currentFiles = new DataTransfer();
+      }
+
+      // Collect existing files to maintain them in the list (if multiple is allowed)
+      if (this.multipleUpload && this.currentFiles && this.currentFiles.files) {
+        for (let i = 0; i < this.currentFiles.files.length; i += 1) {
+          const file = this.currentFiles.files[i];
+          dataTransfer.items.add(file);
+          existingFiles.add(file.name);
+        }
       }
-      this.currentFiles = dataTransfer;
       let fileListHTML = '';
+
+      // Add only new files
       for (let i = 0; i < this.input.files.length; i += 1) {
         const file = this.input.files[i];
-        fileListHTML = this.createFileItem(file) + fileListHTML;
+        if (!existingFiles.has(file.name)) {
+          dataTransfer.items.add(file);
+          fileListHTML += this.createFileItem(file);
+        }
       }
-      if (this.replaceFiles) {
-        this.filesList.innerHTML = fileListHTML;
-      } else {
+      this.currentFiles = dataTransfer;
+      if (fileListHTML) {
         this.filesList.insertAdjacentHTML('beforeend', fileListHTML);
       }
       this.input.files = this.currentFiles.files;
-      this.removeFile();
-    }
-    removeFile() {
-      this.filesList.addEventListener('click', this.handleFileRemove.bind(this));
     }
     handleFileRemove(event) {
       if (!event.target.closest('.nsw-icon-button')) return;
       event.preventDefault();
       const item = event.target.closest('.nsw-file-upload__item');
-      const filename = item.querySelector('.nsw-file-upload__item-filename').textContent;
+      const {
+        filename
+      } = item.querySelector('.nsw-file-upload__item-filename').dataset;
       const dataTransfer = new DataTransfer();
       for (let i = 0; i < this.currentFiles.files.length; i += 1) {
         const file = this.currentFiles.files[i];

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nsw-design-system",
-  "version": "3.18.9",
+  "version": "3.18.10",
   "description": "Design system for Digital NSW",
   "main": "dist/js/main.js",
   "types": "dist/js/main.d.ts",

package/src/components/file-upload/file-upload.js

@@ -22,6 +22,7 @@ class FileUpload {
     }
 
     this.input.addEventListener('change', this.handleInputChange.bind(this))
+    this.element.addEventListener('click', this.handleFileRemove.bind(this))
   }
 
   handleInputChange() {
@@ -49,6 +50,7 @@ class FileUpload {
 
     li.insertAdjacentHTML('afterbegin', html)
     li.querySelector('.nsw-file-upload__item-filename').textContent = this.constructor.truncateString(file.name, 50)
+    li.querySelector('.nsw-file-upload__item-filename').dataset.filename = file.name
     return li.outerHTML
   }
 
@@ -60,39 +62,47 @@ class FileUpload {
     this.filesList.classList.add('active')
 
     const dataTransfer = new DataTransfer()
+    const existingFiles = new Set()
 
-    for (let i = 0; i < this.input.files.length; i += 1) {
-      const file = this.input.files[i]
-      dataTransfer.items.add(file)
+    if (this.replaceFiles) {
+      this.filesList.innerHTML = ''
+      this.currentFiles = new DataTransfer()
+    }
+
+    // Collect existing files to maintain them in the list (if multiple is allowed)
+    if (this.multipleUpload && this.currentFiles && this.currentFiles.files) {
+      for (let i = 0; i < this.currentFiles.files.length; i += 1) {
+        const file = this.currentFiles.files[i]
+        dataTransfer.items.add(file)
+        existingFiles.add(file.name)
+      }
     }
 
-    this.currentFiles = dataTransfer
     let fileListHTML = ''
 
+    // Add only new files
     for (let i = 0; i < this.input.files.length; i += 1) {
       const file = this.input.files[i]
-      fileListHTML = this.createFileItem(file) + fileListHTML
+      if (!existingFiles.has(file.name)) {
+        dataTransfer.items.add(file)
+        fileListHTML += this.createFileItem(file)
+      }
     }
 
-    if (this.replaceFiles) {
-      this.filesList.innerHTML = fileListHTML
-    } else {
+    this.currentFiles = dataTransfer
+
+    if (fileListHTML) {
       this.filesList.insertAdjacentHTML('beforeend', fileListHTML)
     }
 
     this.input.files = this.currentFiles.files
-    this.removeFile()
-  }
-
-  removeFile() {
-    this.filesList.addEventListener('click', this.handleFileRemove.bind(this))
   }
 
   handleFileRemove(event) {
     if (!event.target.closest('.nsw-icon-button')) return
     event.preventDefault()
     const item = event.target.closest('.nsw-file-upload__item')
-    const filename = item.querySelector('.nsw-file-upload__item-filename').textContent
+    const { filename } = item.querySelector('.nsw-file-upload__item-filename').dataset
 
     const dataTransfer = new DataTransfer()
     for (let i = 0; i < this.currentFiles.files.length; i += 1) {