nsauditor-ai 0.2.23 → 0.2.24

package/README.md

@@ -17,7 +17,9 @@ NSAuditor AI is the open-source core of a privacy-first security intelligence pl
 
 ## What's New
 
-**Latest: CE 0.2.23 + Enterprise 0.31.9** (July 2026) — **operator bug-fix cycle (real CE engine/CLI/MCP change).** Fixes three operator-reported bugs from a live test: **(BUG2b) cloud-scan scope integrity** — cloud auditor plugins ran during a `--host 192.168.1.1` **network** scan; a cloud auditor now runs **only** on its own cloud sentinel (`aws`/`gcp`/`azure`), never on a network host, never via credentials-in-env, and never via an explicit `--plugins`/MCP `probe_service` selection (`--host` is the sole cloud-intent signal); **(BUG1) AI-conclusion robustness** — the AI conclusion no longer aborts on cloud-scale payloads (payload-scaled timeout, 120s→600s, `NSA_AI_TIMEOUT_MS`-overridable) and writes a **visible** `scan_response_ai.txt` stub on failure instead of failing quiet; **(BUG2a)** the AI bail message names the unresolved API key instead of misreporting "AI_ENABLED=false". Externally reviewed across multiple rounds → 🟢 PASS. Paired **Enterprise 0.31.9** (GAP-1 #3 RoC positive-substrate render-site parity). No new framework, no new plugins (still 28), all seven coverage matrices unchanged. Requires CE 0.2.8+. Full detail in **[CHANGELOG.md](./CHANGELOG.md)**.
+**Latest: CE 0.2.24 + Enterprise 0.31.10** (July 2026) — **multi-cloud scope-integrity fix (correctness).** Closes a false-clean in the multi-cloud one-liner: `--host aws,gcp,azure` (and a `--host-file` of cloud sentinels) under a stale / tool-implied `CLOUD_PROVIDER` silently skipped the un-covered cloud legs and reported them **"audited-clean" over zero API calls**. The CLI now reconciles `CLOUD_PROVIDER` against the requested cloud legs — **fail-fast** on a mismatch (a pinned provider that misses a leg is a hard error, not a silent skip), else **imply the union** of the legs (so `--aws-profile prod --host aws,gcp,azure` works) — and classifies a gate-skipped provider as `'skipped'` (dropped from `auditedProviders`, surfaced as `audited:false`, never a bare "audited, 0 findings"). TDD + externally reviewed across two rounds → 🟢 SHIP-CLEAR. Paired **Enterprise 0.31.10** (the EE-side GCP scope-integrity gate for 1024/1025 + the T4 GCP positive-substrate curation). No new framework, no new plugins (still 28), all seven coverage matrices unchanged. Requires CE 0.2.8+. Full detail in **[CHANGELOG.md](./CHANGELOG.md)**.
+
+**Prior: CE 0.2.23 + Enterprise 0.31.9** (July 2026) — **operator bug-fix cycle (real CE engine/CLI/MCP change).** Fixes three operator-reported bugs from a live test: **(BUG2b) cloud-scan scope integrity** — cloud auditor plugins ran during a `--host 192.168.1.1` **network** scan; a cloud auditor now runs **only** on its own cloud sentinel (`aws`/`gcp`/`azure`), never on a network host, never via credentials-in-env, and never via an explicit `--plugins`/MCP `probe_service` selection (`--host` is the sole cloud-intent signal); **(BUG1) AI-conclusion robustness** — the AI conclusion no longer aborts on cloud-scale payloads (payload-scaled timeout, 120s→600s, `NSA_AI_TIMEOUT_MS`-overridable) and writes a **visible** `scan_response_ai.txt` stub on failure instead of failing quiet; **(BUG2a)** the AI bail message names the unresolved API key instead of misreporting "AI_ENABLED=false". Externally reviewed across multiple rounds → 🟢 PASS. Paired **Enterprise 0.31.9** (GAP-1 #3 RoC positive-substrate render-site parity). No new framework, no new plugins (still 28), all seven coverage matrices unchanged. Requires CE 0.2.8+. Full detail in **[CHANGELOG.md](./CHANGELOG.md)**.
 
 → See a sample EE scan output: **[walk-through with synthetic Acme Corp AWS account](https://www.nsauditor.com/ai/docs/sample-scan/)** (no signup required)
 

package/cli.mjs

@@ -912,7 +912,8 @@ Usage:
 
 Scan options:
   --host, --ip, --target <h>   Target host, IP, or CIDR
-  --host-file <path>           File with one host per line
+  --host-file <path>           File with one host per line (cloud sentinels in the
+                               file reconcile CLOUD_PROVIDER the same as --host)
   --env <path>                 Load a dotenv (KEY=value) file for this scan (per-account
                                credentials). Override-on; missing file = hard error.
   --aws-profile <name>         Use a named profile from the OS-default ~/.aws/credentials.
@@ -984,7 +985,11 @@ Cloud-scan hosts:
                                  characters — your shell treats | as a pipe. Sentinels are
                                  not DNS-resolved; they route the scan to the matching
                                  cloud-scanner plugins via the provider's control-plane
-                                 API, and imply CLOUD_PROVIDER=<host> when unset. With
+                                 API, and imply CLOUD_PROVIDER to the cloud leg(s) when
+                                 unset ('aws,gcp,azure' → CLOUD_PROVIDER=aws,gcp,azure).
+                                 A CLOUD_PROVIDER already pinned to a cloud that does NOT
+                                 cover every requested leg is a hard error (fail-fast),
+                                 not a silent skip of the uncovered legs. With
                                  --plugins all the scan AUTO-SCOPES to only that cloud's
                                  plugins (plugins not applicable to this host are skipped +
                                  logged — other-cloud plugins run on their OWN --host pass,
@@ -1028,6 +1033,16 @@ Docs: https://www.nsauditor.com/ai/   |   Pricing: https://www.nsauditor.com/ai/
     console.error('Error: --aws-profile requires a profile name (e.g. --aws-profile prod)');
     process.exit(2);
   }
+  // Resolve the scan host list up-front (scan command only) so the CLOUD_PROVIDER
+  // reconcile below (resolveScanEnv) sees --host-file cloud-sentinel legs too. With
+  // --host-file the `host` arg is undefined, so without this a host-file of cloud
+  // sentinels would bypass the fail-fast/imply reconcile entirely. Reused as the
+  // scan target below (no double-parse); a parse failure is left to the scan-time
+  // resolution so the existing error path + exit code are unchanged.
+  let resolvedHosts = null;
+  if (cmd === 'scan' && hostFile) {
+    try { resolvedHosts = await parseHostFile(hostFile); } catch { /* defer to scan-time resolution */ }
+  }
   try {
     const { resolveScanEnv } = await import('./utils/env_loader.mjs');
     const fsm = await import('node:fs');
@@ -1035,6 +1050,7 @@ Docs: https://www.nsauditor.com/ai/   |   Pricing: https://www.nsauditor.com/ai/
       envPath: typeof args.env === 'string' ? args.env : undefined,
       awsProfile: typeof args.awsProfile === 'string' ? args.awsProfile : undefined,
       host,
+      hosts: resolvedHosts ?? undefined,
       env: process.env,
       fileExists: (p) => fsm.existsSync(p),
       readFile: (p) => fsm.readFileSync(p, 'utf8'),
@@ -1912,7 +1928,10 @@ Docs: https://www.nsauditor.com/ai/   |   Pricing: https://www.nsauditor.com/ai/
   // Resolve host list
   let hosts;
   if (hostFile) {
-    hosts = await parseHostFile(hostFile);
+    // Reuse the up-front resolution done for the CLOUD_PROVIDER reconcile (avoids a
+    // second parse + duplicate suspicious-line warnings); re-parse only if that was
+    // skipped/failed so a genuine host-file error still surfaces here as before.
+    hosts = resolvedHosts ?? await parseHostFile(hostFile);
   } else if (host) {
     hosts = await parseHostArg(host);
   } else {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nsauditor-ai",
-  "version": "0.2.23",
+  "version": "0.2.24",
   "description": "Modular AI-assisted network security audit platform — Community Edition",
   "type": "module",
   "private": false,

package/plugin_manager.mjs

@@ -728,9 +728,15 @@ export class PluginManager {
       const wrappedRuns = await callPlugin(mod, host, ctx, outputs, opts);
       const duration_ms = Date.now() - startMs;
 
-      // Determine manifest status from the plugin results
+      // Determine manifest status from the plugin results. A gate-skip envelope
+      // ({ up:false, skipped:true, ... }) carries neither `timedOut` nor `error`,
+      // so classify it as 'skipped' (not 'ran') iff nothing actually ran and there
+      // was no timeout/error — otherwise a self-skipped plugin would be miscounted
+      // as audited. Timeout/error still win over a skip; a skip+real-run mix is 'ran'.
       let status = 'ran';
       let reason = null;
+      let sawRealRun = false;
+      let skipReason = null;
       for (const wrapped of wrappedRuns) {
         if (wrapped.result?.timedOut) {
           status = 'timeout';
@@ -738,8 +744,16 @@ export class PluginManager {
         } else if (wrapped.result?.error && status !== 'timeout') {
           status = 'error';
           reason = wrapped.result.error;
+        } else if (wrapped.result?.skipped === true) {
+          skipReason = wrapped.result.reason || wrapped.result.skipReason || 'skipped by plugin gate';
+        } else {
+          sawRealRun = true;
         }
       }
+      if (status === 'ran' && skipReason != null && !sawRealRun) {
+        status = 'skipped';
+        reason = skipReason;
+      }
 
       manifest.push({
         id: String(mod.id || ''),
@@ -973,12 +987,25 @@ export class PluginManager {
         const cloudHostKind = mod.cloudProvider ? `cloud:${mod.cloudProvider}` : opts.hostKind;
         const wrappedRuns = await callPlugin(mod, host, ctx, [], { ...opts, timeoutMs, hostKind: cloudHostKind });
         const duration_ms = Date.now() - startMs;
+        // Same classifier as _runOrchestrated: a gate-skip envelope
+        // ({ up:false, skipped:true, ... }) → 'skipped' (not 'ran') iff nothing ran
+        // and there was no timeout/error, so a self-skipped cloud is not counted as
+        // audited (auditedProviders derives from status==='ran' at :1034).
+        // NB: the `!sawRealRun` term is defensive-only on this path — cloud plugins
+        // are runStrategy:'single' (one wrappedRun), so a skip+real-run MIX cannot
+        // arise here (unlike the multi-port network path in _runOrchestrated, which
+        // has the mutation-pinned mix test). Kept for uniformity with that classifier.
         let status = 'ran';
         let reason = null;
+        let sawRealRun = false;
+        let skipReason = null;
         for (const w of wrappedRuns) {
           if (w.result?.timedOut) { status = 'timeout'; reason = w.result.error || `timed out after ${timeoutMs}ms`; }
           else if (w.result?.error && status !== 'timeout') { status = 'error'; reason = w.result.error; }
+          else if (w.result?.skipped === true) { skipReason = w.result.reason || w.result.skipReason || 'skipped by plugin gate'; }
+          else { sawRealRun = true; }
         }
+        if (status === 'ran' && skipReason != null && !sawRealRun) { status = 'skipped'; reason = skipReason; }
         return { manifest: { id: String(mod.id || ''), name: mod.name || 'Plugin', status, reason, duration_ms }, outputs: wrappedRuns };
       } catch (err) {
         return { manifest: { id: String(mod.id || ''), name: mod.name || 'Plugin', status: 'error', reason: String(err?.message || err), duration_ms: 0 }, outputs: [] };

package/utils/env_loader.mjs

@@ -48,17 +48,43 @@ function providerMatchesHost(effective, hostProvider) {
   return tokens.includes(hostProvider);
 }
 
+// The distinct cloud-sentinel legs implied by the scan target, in first-appearance
+// order, lowercased + deduped. Mirrors the CLI's host-file-XOR-host dispatch
+// precedence: a pre-resolved `hosts` array (the --host-file path) is the
+// authoritative source when present; otherwise the `--host` string (single 'aws'
+// or a CSV 'aws,gcp,azure') is used. The two are NEVER unioned — the scan
+// dispatches exactly one source, so reconciling both would over-widen
+// CLOUD_PROVIDER and could false-throw on a leg that is never dispatched.
+// Non-sentinel tokens (IPs / CIDRs / hostnames) are ignored; [] means no cloud
+// leg (a pure network scan needs no CLOUD_PROVIDER).
+function sentinelLegs(host, hosts) {
+  const tokens = Array.isArray(hosts)
+    ? hosts.slice()
+    : (typeof host === 'string' ? host.split(',') : []);
+  const legs = [];
+  for (const raw of tokens) {
+    const t = String(raw).trim().toLowerCase();
+    if (CLOUD_SENTINELS.has(t) && !legs.includes(t)) legs.push(t);
+  }
+  return legs;
+}
+
 /**
  * @param {object} args
  * @param {string} [args.envPath]     value of --env
  * @param {string} [args.awsProfile]  value of --aws-profile
- * @param {string} [args.host]        --host value (for sentinel CLOUD_PROVIDER implication)
+ * @param {string} [args.host]        --host value: a single sentinel ('aws'), a
+ *                                    CSV of sentinels ('aws,gcp,azure'), or a
+ *                                    network host — for CLOUD_PROVIDER implication
+ * @param {string[]} [args.hosts]     pre-resolved host list (the --host-file path,
+ *                                    where `host` is undefined); reconciled the
+ *                                    same way as a CSV `host`
  * @param {object} args.env           snapshot of current process.env (read-only)
  * @param {(p:string)=>boolean} args.fileExists
  * @param {(p:string)=>string}  args.readFile
  * @returns {{set: Record<string,string>, unset: string[]}}
  */
-export function resolveScanEnv({ envPath, awsProfile, host, env = {}, fileExists, readFile }) {
+export function resolveScanEnv({ envPath, awsProfile, host, hosts, env = {}, fileExists, readFile }) {
   const set = {};
   const unset = [];
 
@@ -79,6 +105,16 @@ export function resolveScanEnv({ envPath, awsProfile, host, env = {}, fileExists
     Object.assign(set, dotenv.parse(content));
   }
 
+  // Capture whether the OPERATOR (not the tool) pinned CLOUD_PROVIDER — from the
+  // --env file (step 1) or the shell env — BEFORE the --aws-profile implication
+  // in step 2. This is what decides throw-vs-imply for sentinel legs (step 3):
+  //  • operator-pinned provider that misses a host leg → conflict → fail-fast;
+  //  • unpinned (or only tool/profile-implied) → imply the UNION of the legs.
+  // Without this snapshot, --aws-profile's implied bare 'aws' (step 2) would look
+  // like an operator pin and wrongly THROW on a `--host aws,gcp,azure` run.
+  const operatorPinned = providerAlreadySet(set, env);
+  const operatorProvider = operatorPinned ? effectiveProvider(set, env) : '';
+
   // 2. --aws-profile: AWS_PROFILE wins; clear explicit keys; load ~/.aws/config; imply aws.
   if (typeof awsProfile === 'string' && awsProfile.length) {
     set.AWS_PROFILE = awsProfile;
@@ -90,23 +126,34 @@ export function resolveScanEnv({ envPath, awsProfile, host, env = {}, fileExists
     if (!providerAlreadySet(set, env)) set.CLOUD_PROVIDER = 'aws';
   }
 
-  // 3. Sentinel host implies its provider when CLOUD_PROVIDER is still unset.
-  //    Fail-fast on a host vs CLOUD_PROVIDER contradiction: if the effective
-  //    provider (--env file + shell env) is set to a cloud that does NOT match
-  //    the host, scoping would select host-plugins that then all self-skip on
-  //    the awsScanSkipReason gate → ZERO plugins run → a silent "clean" report.
-  if (typeof host === 'string' && CLOUD_SENTINELS.has(host.trim().toLowerCase())) {
-    const hostProvider = host.trim().toLowerCase();
-    const effective = effectiveProvider(set, env);
-    if (effective && !providerMatchesHost(effective, hostProvider)) {
-      throw new Error(
-        `--host '${hostProvider}' conflicts with CLOUD_PROVIDER='${effective}': the host and the ` +
-        `effective cloud provider do not match, which would silently skip every plugin (an empty ` +
-        `"clean" report). Resolve by dropping the conflicting CLOUD_PROVIDER, or scan the matching host ` +
-        `(--host ${effective.split(',')[0].trim()}).`,
-      );
+  // 3. Sentinel host leg(s) imply their provider(s) when the operator hasn't
+  //    pinned CLOUD_PROVIDER; fail-fast when a pinned provider does NOT cover
+  //    every leg. Handles a single sentinel ('aws'), a CSV ('aws,gcp,azure'),
+  //    AND a --host-file resolved list (`hosts`) uniformly — each is a set of
+  //    legs. A leg that the effective provider does not cover would silently
+  //    self-skip on the awsScanSkipReason/gcpScanSkipReason gate → ZERO plugins
+  //    run on that leg → a silent "clean" report for a whole cloud.
+  const legs = sentinelLegs(host, hosts);
+  if (legs.length) {
+    if (operatorPinned) {
+      const uncovered = legs.filter((leg) => !providerMatchesHost(operatorProvider, leg));
+      if (uncovered.length) {
+        throw new Error(
+          `--host '${legs.join(',')}' conflicts with CLOUD_PROVIDER='${operatorProvider}': the host ` +
+          `leg(s) [${uncovered.join(', ')}] are not covered by the effective cloud provider, so every ` +
+          `plugin on ${uncovered.length > 1 ? 'those legs' : 'that leg'} would silently self-skip (an ` +
+          `empty "clean" report). Resolve by dropping the conflicting CLOUD_PROVIDER, or set ` +
+          `CLOUD_PROVIDER to include ${uncovered.join(',')} (e.g. CLOUD_PROVIDER=${legs.join(',')}).`,
+        );
+      }
+      // pinned provider covers every leg → leave the operator's value untouched
+    } else {
+      // Unpinned (or only tool/profile-implied): imply the UNION of the legs so
+      // each cloud leg runs. This overrides a bare 'aws' that step 2's
+      // --aws-profile implication may have written — 'aws' ⊆ the union, and the
+      // aws leg still resolves the profile via AWS_PROFILE.
+      set.CLOUD_PROVIDER = legs.join(',');
     }
-    if (!providerAlreadySet(set, env)) set.CLOUD_PROVIDER = hostProvider;
   }
 
   return { set, unset };