nsauditor-ai 0.1.94 → 0.1.95

package/README.md

@@ -19,6 +19,7 @@ NSAuditor AI is the open-source core of a privacy-first security intelligence pl
 
 **Latest: CE 0.1.94 + Enterprise 0.16.3** (May 2026)
 
+- 🛡️ **`scan_cloud` now surfaces cloud findings reliably** (CE 0.1.95 — paired EE 0.16.4) — *(false-clean fix)* the tool now builds a `findingsSummary` (per-provider severity counts + the CRITICAL/HIGH list) **directly from the scan results**, instead of the network-host concluder — which is built for port/service scans, doesn't understand cloud compliance findings, and silently **dropped** them. A scan could previously report `audited:true` with **0 findings over real CRITICALs**; now every finding is counted and every CRITICAL/HIGH is listed. Distinct from the 0.1.93 not-audited fold (caught by the `audit-cloud-plugin-false-negatives` review). Plugin count UNCHANGED at 28; all six matrices UNCHANGED.
 - ⚡ **`scan_cloud` runs cloud plugins in parallel** (CE 0.1.94 — paired EE 0.16.3) — the cloud-audit engine now runs the requested clouds' plugins **concurrently** (default up to 20 at once, 25s per-plugin timeout) so a full ~20-plugin AWS/GCP/Azure audit finishes within Claude Desktop's ~60s tool-call limit — previously the heaviest, most security-critical plugins (IAM, S3, EC2, Inspector/GuardDuty, decrypt-path) timed out at the 5s the budget forced under sequential execution. Tunable via `CLOUD_SCAN_CONCURRENCY` / `CLOUD_PLUGIN_TIMEOUT_MS`; the network `scan_host` path is unchanged; the anti-false-clean reporting is preserved. Plugin count UNCHANGED at 28; all six matrices UNCHANGED.
 - ☁️ **MCP `scan_cloud` tool: audit cloud accounts directly** (CE 0.1.93 — paired EE 0.16.2) — *(Enterprise)* a dedicated MCP tool so you can say *"Audit my AWS account"* or *"Audit my AWS and Azure accounts"* in Claude Desktop / Claude Code, with **no network host** — the server scopes the run to only the requested clouds' EE plugins. The MCP analog of the CLI `--host aws --plugins all` scoping. Enterprise-gated (`enterpriseMCP`) with plugin-layer defense-in-depth, and **anti-false-clean reporting** — a cloud is reported "audited" only if a plugin actually ran; a missing-credential / skipped cloud is surfaced as an explicit note + `audited:false` (R-HIGH caught + folded by the `audit-cloud-plugin-false-negatives` review). Plugin count UNCHANGED at 28; all six matrices UNCHANGED.
 - 🔌 **MCP `NSA_ENV_FILE`: per-environment `.env` for the MCP server** (CE 0.1.92 — paired EE 0.16.1) — the MCP analog of 0.16.0's CLI `--env`. Point the MCP server at a specific account/cloud by setting **`NSA_ENV_FILE`** to a dotenv path in your Claude Desktop / Claude Code config instead of inlining every credential; the server loads that environment's cloud credentials + `CLOUD_PROVIDER` at startup. Loaded **after** the MCP auth gate + license (scan-target vars only; the auth key + license are ignored if present in the file), **fail-fast** on a missing / INI / set-but-empty path, and treated as the **authoritative scan target** — leftover ambient provider credentials the file doesn't set are cleared, closing a false-clean (a partial file could otherwise silently scan a leftover account) caught + folded by the `audit-cloud-plugin-false-negatives` review. Plugin count UNCHANGED at 28; all six matrices UNCHANGED.
@@ -424,7 +425,9 @@ npx nsauditor-ai-mcp
 > `scan_cloud` runs the requested clouds' plugins **concurrently** (default up to 20 at once, 25s per-plugin
 > timeout) so a full multi-service cloud audit completes within Claude Desktop's ~60s tool-call limit. Tune with
 > `CLOUD_SCAN_CONCURRENCY` (default 20) and `CLOUD_PLUGIN_TIMEOUT_MS` (default 25000) in the server env. The
-> network `PLUGIN_TIMEOUT_MS` still governs `scan_host` / network scans.
+> network `PLUGIN_TIMEOUT_MS` still governs `scan_host` / network scans. Read the result's **`findingsSummary`**
+> (per-provider severity counts + a CRITICAL/HIGH list) for the findings; `audited:false` / `notes` / `pluginsRan:0`
+> still mean a cloud was NOT audited (never a clean pass). Pass `providers:["aws"]` to audit only the cloud named.
 
 Security: SSRF protection on all host inputs (blocks RFC 1918, loopback, fc00::/7, cloud metadata), port validation (1–65535), CPE format enforcement, dependency injection for test isolation. **Server-startup authentication is required** — see next section.
 

package/mcp_server.mjs

@@ -25,6 +25,7 @@ import {
 import { getTierFromEnv, loadLicense } from './utils/license.mjs';
 import { resolveCapabilities } from './utils/capabilities.mjs';
 import { buildMarkdownReport } from './utils/report_md.mjs';
+import { summarizeCloudFindings, renderCloudFindingsMarkdown } from './utils/cloud_finding_summary.mjs';
 import { authorizeMcpServerStartup, getMcpAuthKeyAge, getRotationWarningDays, reportMcpAuthSource } from './utils/mcp_auth.mjs';
 
 const _require = createRequire(import.meta.url);
@@ -196,7 +197,7 @@ const TOOLS = [
   {
     name: 'scan_cloud',
     description:
-      'Audit one or more cloud accounts (AWS / GCP / Azure) for security & compliance posture using the credentials configured in the server environment. No network host required. Requires an Enterprise license. Use for "audit my AWS account" / "audit my AWS and Azure accounts".',
+      'Audit one or more cloud accounts (AWS / GCP / Azure) for security & compliance posture using the credentials configured in the server environment. No network host required. Requires an Enterprise license. Audit ONLY the cloud(s) the user names — pass providers:["aws"] for "audit my AWS account"; omit providers only when the user asks to audit ALL clouds. Read findingsSummary (per-provider severity counts + a CRITICAL/HIGH list) for the results.',
     inputSchema: {
       type: 'object',
       properties: {
@@ -379,12 +380,17 @@ export async function handleScanCloud(args) {
     else process.env.CLOUD_PROVIDER = savedProvider;
   }
 
-  // Render a Markdown summary (best-effort, same as scan_host).
+  // Build the caller-visible findings surface DIRECTLY from the raw results — the
+  // network-host concluder (result_concluder.mjs) doesn't understand cloud
+  // compliance findings and silently drops them (the false-clean this fixes).
+  const providerOf = (id) => (pm.plugins || []).find((p) => String(p.id) === String(id))?.cloudProvider || null;
+  const findingsSummary = summarizeCloudFindings(output.results || [], providerOf);
+
+  // Render Markdown FROM the findings summary (NOT the host renderer, which is
+  // empty for a cloud conclusion). Best-effort.
   let markdown = null;
   try {
-    if (output.conclusion) {
-      markdown = buildMarkdownReport({ host: output.host, conclusion: output.conclusion, toolVersion: TOOL_VERSION });
-    }
+    markdown = renderCloudFindingsMarkdown(findingsSummary, providers);
   } catch { /* swallow — markdown is best-effort */ }
 
   // Anti-false-clean: a requested cloud is "audited" ONLY if >=1 of its plugins
@@ -412,7 +418,7 @@ export async function handleScanCloud(args) {
     providers,
     audited: auditedProviders.length > 0,
     auditedProviders,
-    conclusion: output.conclusion ?? null,
+    findingsSummary,
     manifest: output.manifest ?? [],
     pluginsRan,
     markdown,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nsauditor-ai",
-  "version": "0.1.94",
+  "version": "0.1.95",
   "description": "Modular AI-assisted network security audit platform — Community Edition",
   "type": "module",
   "private": false,

package/utils/cloud_finding_summary.mjs

@@ -0,0 +1,83 @@
+// utils/cloud_finding_summary.mjs
+//
+// Builds the caller-visible findings surface for scan_cloud DIRECTLY from the raw
+// plugin results — the network-host concluder (result_concluder.mjs) doesn't
+// understand cloud compliance findings and silently drops them. Robust across the
+// plugin-specific finding shapes (AWS bucket/userName/issues, GCP/Azure title).
+
+const RANK = { CRITICAL: 5, HIGH: 4, MEDIUM: 3, LOW: 2, INFO: 1, PASS: 0 };
+// Resource-identifying keys, most-specific first so a precise label wins over the
+// generic resource/name/arn fallbacks. Grounded in the REAL EE plugin emissions
+// (S3 1020 emits `bucket`, Key Vault `vault`, DynamoDB `table`, KMS `key`, …).
+const RESOURCE_KEYS = ['userName', 'bucket', 'bucketName', 'function', 'functionName', 'table', 'tableName', 'instanceId', 'group', 'groupId', 'key', 'keyId', 'vault', 'vaultName', 'pipeline', 'topic', 'queue', 'projectId', 'domain', 'secretName', 'roleName', 'accountName', 'resource', 'resourceId', 'name', 'arn'];
+const REASON_KEYS = ['classification', 'title', 'message', 'reason', 'finding', 'detail'];
+const UNKNOWN_PROVIDER = 'unknown';
+
+/** Robust one-line descriptor from any plugin finding shape. Never empty, never a raw object dump. */
+export function describeFinding(x) {
+  if (!x || typeof x !== 'object') return String(x ?? '').slice(0, 160);
+  let res = '';
+  for (const k of RESOURCE_KEYS) { if (x[k]) { res = String(x[k]); break; } }
+  let why = '';
+  if (Array.isArray(x.issues) && x.issues.length) why = String(x.issues[0]);
+  else for (const k of REASON_KEYS) { if (x[k]) { why = String(x[k]); break; } }
+  const s = ((res ? res + ' — ' : '') + why).trim();
+  if (s) return s.slice(0, 160);
+  const sev = String(x.severity || x.level || '').toUpperCase();
+  return sev ? sev + ' finding (no description)' : 'finding (no description)';
+}
+
+function findingsOf(r) {
+  const f = (r && (r.findings ?? r.result?.findings ?? r.result?.data)) ?? [];
+  return Array.isArray(f) ? f : [];
+}
+
+/**
+ * @param {Array} results              out.results (each {id, result:{findings|data}})
+ * @param {(id:any)=>string|null} providerOf  plugin id -> cloudProvider
+ * @param {number} [cap]               max CRITICAL/HIGH entries listed per provider
+ * @returns {Object} { [provider]: { counts:{SEV:n}, findings:[{severity,plugin,title}], truncated:boolean } }
+ */
+export function summarizeCloudFindings(results, providerOf, cap = Number(process.env.CLOUD_FINDINGS_CAP) || 60) {
+  const out = {};
+  for (const r of (Array.isArray(results) ? results : [])) {
+    const found = findingsOf(r);
+    if (!found.length) continue;
+    // Attribute to the plugin's cloud; an unresolved id that carries REAL findings is
+    // bucketed under 'unknown' rather than silently dropped (defense-in-depth against a
+    // future id collision / cloudProvider drift — never let a real finding vanish).
+    const prov = providerOf(r?.id ?? r?.result?.id) || UNKNOWN_PROVIDER;
+    const bucket = (out[prov] ||= { counts: {}, findings: [], truncated: false });
+    for (const x of found) {
+      const sev = String(x?.severity || x?.level || 'INFO').toUpperCase();
+      bucket.counts[sev] = (bucket.counts[sev] || 0) + 1;
+      if (sev === 'CRITICAL' || sev === 'HIGH') {
+        bucket.findings.push({ severity: sev, plugin: String(r?.id ?? ''), title: describeFinding(x) });
+      }
+    }
+  }
+  // Sort by severity (CRITICAL first) THEN truncate — so a CRITICAL is never evicted
+  // from the displayed list by a HIGH. Counts above are always complete (pre-cap).
+  for (const prov of Object.keys(out)) {
+    const b = out[prov];
+    b.findings.sort((a, c) => (RANK[c.severity] || 0) - (RANK[a.severity] || 0));
+    if (b.findings.length > cap) { b.truncated = true; b.findings = b.findings.slice(0, cap); }
+  }
+  return out;
+}
+
+/** Compact markdown from a summary. Named providers first, then any extras (e.g. 'unknown') so nothing is hidden. */
+export function renderCloudFindingsMarkdown(summary, providers) {
+  const named = providers && providers.length ? providers.slice() : [];
+  const order = [...named, ...Object.keys(summary).filter((p) => !named.includes(p))];
+  const lines = [];
+  for (const prov of order) {
+    const b = summary[prov]; if (!b) continue;
+    const c = b.counts || {};
+    lines.push(`## ${String(prov).toUpperCase()} — ${c.CRITICAL || 0} CRITICAL · ${c.HIGH || 0} HIGH · ${c.MEDIUM || 0} MEDIUM · ${c.LOW || 0} LOW · ${c.PASS || 0} PASS`);
+    for (const f of (b.findings || [])) lines.push(`- **[${f.severity}]** ${f.plugin}: ${f.title}`);
+    if (b.truncated) lines.push(`- _…CRITICAL/HIGH list truncated; see counts above for totals._`);
+    lines.push('');
+  }
+  return lines.join('\n').trim();
+}