npq 3.7.0 → 3.7.1

package/__tests__/marshalls.tasks.test.js

@@ -53,3 +53,54 @@ test('running marshall tasks fails', async () => {
 
   await expect(marshalls.tasks(config)).resolves.toMatchObject(context)
 })
+
+test('running marshall tasks throws error when single package is not found', async () => {
+  const PackageRepoUtilsNotFoundMock = class Fake {
+    getPackageInfo() {
+      return Promise.resolve({ error: 'Not found' })
+    }
+  }
+
+  marshalls.collectMarshalls = jest.fn(() => {
+    return Promise.resolve([path.join(process.cwd(), '__tests__/__fixtures__/test.marshall.js')])
+  })
+
+  const config = {
+    pkgs: [{ packageName: 'nonexistent-package' }],
+    packageRepoUtils: new PackageRepoUtilsNotFoundMock()
+  }
+
+  await expect(marshalls.tasks(config)).resolves.toEqual({
+    error: true,
+    message: 'Package not found: nonexistent-package'
+  })
+})
+
+test('running marshall tasks filters out not found packages when multiple packages provided', async () => {
+  const PackageRepoUtilsMixedMock = class Fake {
+    getPackageInfo(packageName) {
+      if (packageName === 'nonexistent-package') {
+        return Promise.resolve({ error: 'Not found' })
+      }
+      return Promise.resolve(true)
+    }
+  }
+
+  marshalls.collectMarshalls = jest.fn(() => {
+    return Promise.resolve([path.join(process.cwd(), '__tests__/__fixtures__/test.marshall.js')])
+  })
+
+  const config = {
+    pkgs: [
+      { packageName: 'express' },
+      { packageName: 'nonexistent-package' },
+      { packageName: 'semver' }
+    ],
+    packageRepoUtils: new PackageRepoUtilsMixedMock()
+  }
+
+  const result = await marshalls.tasks(config)
+  // Should filter out the nonexistent package and keep only express and semver
+  expect(result.pkgs).toHaveLength(2)
+  expect(result.pkgs).toEqual([{ packageName: 'express' }, { packageName: 'semver' }])
+})

package/lib/marshalls/index.js

@@ -65,7 +65,26 @@ class Marshalls {
   }
 
   static tasks(options) {
+    // console.log(options);
+    // process.exit(1);
     return Marshalls.warmUpPackagesCache(options)
+      .then((packagesDataList) => {
+        // handle error in case we get just one package and it is not found
+        if (packagesDataList && packagesDataList.length === 1) {
+          if (packagesDataList[0].error && packagesDataList[0].error === 'Not found') {
+            throw new Error(`Package not found: ${options.pkgs[0].packageName}`)
+          }
+        }
+
+        // handle error in case we get more than one package and at least one is not found
+        // in which we case we simply remove the package from the `options` array
+        // which lists objects (each have a property of packageName)
+        if (packagesDataList && packagesDataList.length > 1) {
+          options.pkgs = options.pkgs.filter((pkg, index) => {
+            return !packagesDataList[index].error || packagesDataList[index].error !== 'Not found'
+          })
+        }
+      })
       .then(() => Marshalls.collectMarshalls())
       .then((marshalls) => {
         return Marshalls.buildMarshallTasks(marshalls, {
@@ -75,6 +94,12 @@ class Marshalls {
       .then((tasks) => {
         return Marshalls.runTasks(tasks, options)
       })
+      .catch((err) => {
+        // console.error('Error:', err.message)
+        // avoid implementing a custom error message for a not found package
+        // because the package manager will yield its own error message
+        return { error: true, message: err.message }
+      })
   }
 
   static warmUpPackagesCache(options) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "npq",
-  "version": "3.7.0",
+  "version": "3.7.1",
   "description": "marshall your npm/npm package installs with high quality and class 🎖",
   "bin": {
     "npq": "./bin/npq.js",
@@ -135,7 +135,7 @@
       "security/detect-no-csrf-before-method-override": "error",
       "security/detect-non-literal-regexp": "error",
       "security/detect-non-literal-require": "warn",
-      "security/detect-object-injection": "warn",
+      "security/detect-object-injection": "off",
       "security/detect-possible-timing-attacks": "error",
       "security/detect-pseudoRandomBytes": "error",
       "node/no-unsupported-features/node-builtins": [