npq 3.4.7 → 3.5.0

package/lib/marshalls/age.marshall.js

@@ -5,6 +5,7 @@ const { marshallCategories } = require('./constants')
 
 const MARSHALL_NAME = 'age'
 const PACKAGE_AGE_THRESHOLD = 22 // specified in days
+const PACKAGE_AGE_UNMAINTAINED_RISK = 365 // specified in days
 
 class Marshall extends BaseMarshall {
   constructor(options) {
@@ -18,22 +19,49 @@ class Marshall extends BaseMarshall {
   }
 
   validate(pkg) {
-    return this.packageRepoUtils.getPackageInfo(pkg.packageName).then((data) => {
-      if (data && data.time && data.time.created) {
-        const pkgCreatedDate = data.time.created
-        const dateDiff = Date.now() - Date.parse(pkgCreatedDate)
-
-        if (dateDiff < PACKAGE_AGE_THRESHOLD) {
-          throw new Error(
-            `detected a newly published package (created < ${PACKAGE_AGE_THRESHOLD} days) act carefully`
-          )
+    let packageData = null
+    let ageDateDiff = null
+    return this.packageRepoUtils
+      .getPackageInfo(pkg.packageName)
+      .then((data) => {
+        if (data && data.time && data.time.created) {
+          packageData = data
+          const pkgCreatedDate = data.time.created
+          const dateDiff = Date.now() - Date.parse(pkgCreatedDate)
+
+          ageDateDiff = dateDiff
+          if (dateDiff < PACKAGE_AGE_THRESHOLD) {
+            throw new Error(
+              `detected a newly published package (created < ${PACKAGE_AGE_THRESHOLD} days) act carefully`
+            )
+          }
+
+          return pkg
+        } else {
+          throw new Error('could not determine package age')
         }
+      })
+      .then((pkg) => {
+        return this.packageRepoUtils.getSemVer(pkg.packageName, pkg.packageVersion)
+      })
+      .then((versionResolved) => {
+        const versionReleaseDate = packageData.time[versionResolved]
+        const versionDateDiff = new Date() - new Date(versionReleaseDate)
+
+        const versionDateDiffInDays = Math.round(versionDateDiff / (1000 * 60 * 60 * 24))
+
+        let timeAgoText = 'days'
+        let timeAgoNumber = versionDateDiffInDays
 
-        return dateDiff
-      } else {
-        throw new Error('could not determine package age')
-      }
-    })
+        if (versionDateDiffInDays >= 365) {
+          timeAgoText = 'years'
+          timeAgoNumber = Math.floor(versionDateDiffInDays / 365)
+        }
+
+        if (versionDateDiffInDays >= PACKAGE_AGE_UNMAINTAINED_RISK) {
+          throw new Error(`detected an old package (created ${timeAgoNumber} ${timeAgoText} ago)`)
+        }
+      })
   }
 }
 

package/lib/marshalls/author.marshall.js

@@ -70,7 +70,6 @@ class Marshall extends BaseMarshall {
     // get date in ms
     const currentDate = new Date()
     const dateDiffInMsVersionPublished = currentDate - new Date(versionPublishedDateString)
-    console.log(dateDiffInMsVersionPublished)
     let dateDiffVersionPublished = 0
     if (dateDiffInMsVersionPublished > 0) {
       dateDiffVersionPublished = Math.round(dateDiffInMsVersionPublished / (1000 * 60 * 60 * 24))

package/lib/marshalls/downloads.marshall.js

@@ -1,10 +1,12 @@
 'use strict'
 
 const BaseMarshall = require('./baseMarshall')
+const Warning = require('../helpers/warning')
 const { marshallCategories } = require('./constants')
 
 const MARSHALL_NAME = 'downloads'
-const DOWNLOAD_COUNT_THRESHOLD = 20 // threshold per month
+const DOWNLOAD_COUNT_THRESHOLD = 100 // threshold per month
+const DOWNLOAD_COUNT_UPPER_THRESHOLD = 10000 // threshold per month
 
 class Marshall extends BaseMarshall {
   constructor(options) {
@@ -25,6 +27,12 @@ class Marshall extends BaseMarshall {
         )
       }
 
+      if (downloadCount < DOWNLOAD_COUNT_UPPER_THRESHOLD) {
+        throw new Warning(
+          `detected a low relatively low download-count package (${downloadCount} downloads last month)`
+        )
+      }
+
       return downloadCount
     })
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "npq",
-  "version": "3.4.7",
+  "version": "3.5.0",
   "description": "marshall your npm/npm package installs with high quality and class 🎖",
   "bin": {
     "npq": "./bin/npq.js",