npq 3.11.2 → 3.11.3

package/bin/npq-hero.js

@@ -71,7 +71,6 @@ marshall
   })
   .then((result) => {
     if (result && result.countErrors > 0) {
-      // eslint-disable-next-line no-console
       console.log()
       return cliPrompt.prompt({
         name: 'install',
@@ -80,7 +79,6 @@ marshall
       })
     } else {
       if (result && result.countWarnings > 0) {
-        // eslint-disable-next-line no-console
         console.log()
         return cliPrompt.autoContinue({
           name: 'install',
@@ -93,7 +91,11 @@ marshall
     return { install: true }
   })
   .then((status) => {
-    if (status && status.hasOwnProperty('install') && status.install === true) {
+    if (
+      status &&
+      Object.prototype.hasOwnProperty.call(status, 'install') &&
+      status.install === true
+    ) {
       pkgMgr.process(PACKAGE_MANAGER_TOOL)
     }
   })

package/bin/npq.js

@@ -97,7 +97,6 @@ Promise.resolve()
     }
 
     if (result && result.countErrors > 0) {
-      // eslint-disable-next-line no-console
       console.log()
       return cliPrompt.prompt({
         name: 'install',
@@ -106,7 +105,6 @@ Promise.resolve()
       })
     } else {
       if (result && result.countWarnings > 0) {
-        // eslint-disable-next-line no-console
         console.log()
         return cliPrompt.autoContinue({
           name: 'install',
@@ -119,7 +117,11 @@ Promise.resolve()
     return { install: true }
   })
   .then((status) => {
-    if (status && status.hasOwnProperty('install') && status.install === true) {
+    if (
+      status &&
+      Object.prototype.hasOwnProperty.call(status, 'install') &&
+      status.install === true
+    ) {
       pkgMgr.process(cliArgs.packageManager)
     }
   })

package/lib/helpers/cliSpinner.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const growVertical = {
   interval: 120,
   frames: ['▁', '▃', '▄', '▅', '▆', '▇', '▆', '▅', '▄', '▃']

package/lib/helpers/cliSupportHandler.js

@@ -2,7 +2,6 @@
 
 const { styleText } = require('node:util')
 
-// eslint-disable-next-line security/detect-child-process
 const childProcess = require('child_process')
 const semver = require('semver')
 
@@ -20,10 +19,8 @@ function isEnvSupport() {
 
 function noSupportError(failFast) {
   if (isInteractiveTerminal()) {
-    // eslint-disable-next-line no-console
     console.error(styleText('red', 'error:'), 'npq suppressed due to old node version')
   } else {
-    // eslint-disable-next-line no-console
     console.error('error: npq suppressed due to old node version')
   }
 

package/lib/helpers/packageRepoUtils.js

@@ -85,7 +85,7 @@ class PackageRepoUtils {
           if (satisfyingVersion) {
             return satisfyingVersion
           }
-        } catch (error) {
+        } catch {
           // semver.maxSatisfying throws if the range is invalid, continue to error below
         }
       }

package/lib/helpers/promiseThrottler.js

@@ -1,3 +1,5 @@
+'use strict'
+
 // Example use-case
 //
 // Using the new throttling mechanism - each audit will be throttled globally

package/lib/helpers/reportResults.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const { styleText } = require('node:util')
 const { marshallCategories } = require('../marshalls/constants')
 const { isInteractiveTerminal } = require('./cliSupportHandler')
@@ -12,7 +14,7 @@ function getTerminalWidth() {
       const [columns] = process.stdout.getWindowSize()
       return columns
     }
-  } catch (error) {
+  } catch {
     // Fallback if terminal size detection fails
   }
   return 80 // Default fallback width
@@ -25,6 +27,7 @@ function getTerminalWidth() {
  */
 function getDisplayLength(str) {
   // Remove ANSI escape sequences to get actual character count
+  // eslint-disable-next-line no-control-regex
   return str.replace(/\u001b\[[0-9;]*m/g, '').length
 }
 

package/lib/helpers/sourcePackages.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const path = require('node:path')
 const fs = require('node:fs/promises')
 

package/lib/marshall.js

@@ -1,4 +1,3 @@
-/* eslint-disable no-console */
 'use strict'
 
 // const util = require('node:util')

package/lib/marshalls/age.marshall.js

@@ -21,7 +21,6 @@ class Marshall extends BaseMarshall {
 
   validate(pkg) {
     let packageData = null
-    let ageDateDiff = null
     return this.packageRepoUtils
       .getPackageInfo(pkg.packageName)
       .then((data) => {
@@ -30,7 +29,6 @@ class Marshall extends BaseMarshall {
           const pkgCreatedDate = data.time.created
           const dateDiff = Date.now() - Date.parse(pkgCreatedDate)
 
-          ageDateDiff = dateDiff
           if (dateDiff < PACKAGE_AGE_THRESHOLD) {
             throw new Error(
               `Detected a newly published package (created < ${PACKAGE_AGE_THRESHOLD} days) act carefully`

package/lib/marshalls/author.marshall.js

@@ -48,7 +48,7 @@ class Marshall extends BaseMarshall {
 
     // Agree with Colin on keeping email regex simple: https://colinhacks.com/essays/reasonable-email-regex
     const emailRegex =
-      /^(?!\.)(?!.*\.\.)([a-z0-9_'+\-\.]*)[a-z0-9_'+\-]@([a-z0-9][a-z0-9\-]*\.)+[a-z]{2,}$/i
+      /^(?!\.)(?!.*\.\.)([a-z0-9_'+\-.]*)[a-z0-9_'+-]@([a-z0-9][a-z0-9-]*\.)+[a-z]{2,}$/i
     if (!emailRegex.test(npmUser.email)) {
       throw new Error('The publishing user has no valid email address')
     }

package/lib/marshalls/constants.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const marshallCategories = {
   SupplyChainSecurity: {
     id: 'SupplyChainSecurity',

package/lib/marshalls/index.js

@@ -24,7 +24,6 @@ class Marshalls {
     }
 
     const marshallTasks = marshalls.reduce((prev, curr) => {
-      // eslint-disable-next-line security/detect-non-literal-require
       const Marshall = require(curr)
       const marshall = new Marshall(config)
 

package/lib/marshalls/newbin.marshall.js

@@ -55,7 +55,9 @@ class NewBinMarshall extends BaseMarshall {
       previousVersionData.name || pkg.packageName
     )
 
-    const newBinaries = Object.keys(newBin).filter((key) => !oldBin.hasOwnProperty(key))
+    const newBinaries = Object.keys(newBin).filter(
+      (key) => !Object.prototype.hasOwnProperty.call(oldBin, key)
+    )
 
     if (newBinaries.length > 0) {
       newBinaries.forEach((binaryName) => {

package/lib/marshalls/provenance.marshall.js

@@ -188,7 +188,6 @@ class Marshall extends BaseMarshall {
     const registryKeysEndpoint = '/-/npm/v1/keys'
 
     const registryKeysUrl = `${registryHost}${registryKeysEndpoint}`
-    // eslint-disable-next-line no-undef
     return fetch(registryKeysUrl)
       .then((response) => {
         return response.json()

package/lib/marshalls/repo.marshall.js

@@ -30,7 +30,7 @@ class Marshall extends BaseMarshall {
         try {
           urlStructure = new URL(lastVersionData.repository.url)
           urlOfGitRepository = new URL(`https://${urlStructure.host}${urlStructure.pathname}`)
-        } catch (error) {
+        } catch {
           throw new Warning('No valid repository is associated with the package')
         }
         return fetch(urlOfGitRepository.href).catch(() => {

package/lib/marshalls/scripts.marshall.js

@@ -39,7 +39,7 @@ class Marshall extends BaseMarshall {
       blacklistScripts.forEach((scriptName) => {
         if (
           packageScripts &&
-          packageScripts.hasOwnProperty(scriptName) &&
+          Object.prototype.hasOwnProperty.call(packageScripts, scriptName) &&
           packageScripts[scriptName].length > 0
         ) {
           throw new Error(

package/lib/marshalls/signatures.marshall.js

@@ -63,7 +63,6 @@ class Marshall extends BaseMarshall {
     const registryKeysEndpoint = '/-/npm/v1/keys'
 
     const registryKeysUrl = `${registryHost}${registryKeysEndpoint}`
-    // eslint-disable-next-line no-undef
     return fetch(registryKeysUrl)
       .then((response) => {
         return response.json()

package/lib/marshalls/snyk.marshall.js

@@ -163,7 +163,7 @@ class Marshall extends BaseMarshall {
           return snykConfig.api
         }
       }
-    } catch (error) {
+    } catch {
       return null
     }
 

package/lib/marshalls/typosquatting.marshall.js

@@ -23,7 +23,6 @@ class Marshall extends BaseMarshall {
   validate(pkg) {
     let levenshteinDistance = null
     let similarPackages = []
-    let packageFoundInTopPackages = false
     return new Promise((resolve, reject) => {
       // If package is within an allow-list
       if (this.packageRepoUtils.isPackageInAllowList(pkg.packageName)) {
@@ -34,7 +33,6 @@ class Marshall extends BaseMarshall {
         // If the package to be installed is itself found within the Top Packages dataset
         // then we don't report on it
         if (pkg.packageName === popularPackageNameInRepository) {
-          packageFoundInTopPackages = true
           return resolve([])
         }
 

package/lib/packageManager.js

@@ -1,4 +1,3 @@
-/* eslint-disable indent */
 'use strict'
 
 const childProcess = require('child_process')

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "npq",
-  "version": "3.11.2",
+  "version": "3.11.3",
   "description": "marshall your npm/npm package installs with high quality and class 🎖",
   "bin": {
     "npq": "./bin/npq.js",
@@ -9,19 +9,16 @@
   "scripts": {
     "lint": "eslint && npm run lint:lockfile",
     "lint:lockfile": "lockfile-lint --path package-lock.json --type npm --validate-https --allowed-hosts npm npm",
-    "test": "cross-env NODE_OPTIONS=\"--experimental-vm-modules\" jest",
+    "fix": "eslint --fix",
+    "test": "jest",
     "build": "node scripts/build.js",
-    "test:watch": "cross-env NODE_OPTIONS=\"--experimental-vm-modules\" jest --watch",
-    "coverage:view": "opn coverage/lcov-report/index.html",
+    "test:watch": "jest --watch",
     "commit": "git-cz",
     "format": "prettier --config .prettierrc.js --write \"**/*.js\"",
-    "docs": "npm run docs:code && npm run docs:api",
-    "docs:api": "doxdox \"*.js\" --layout bootstrap --output docs/index.html",
-    "docs:code": "docco \"*.js\" --output docs/code",
     "semantic-release": "npx semantic-release",
     "#postinstall": "node scripts/postinstall.js",
     "#preuninstall": "node scripts/preuninstall.js",
-    "#prepare": "husky install"
+    "prepare": "husky || true"
   },
   "engines": {
     "node": ">=20.13.0"
@@ -52,59 +49,21 @@
     "semver": "^7.7.2"
   },
   "devDependencies": {
-    "@babel/core": "^7.28.0",
-    "@babel/plugin-transform-runtime": "^7.28.0",
-    "@babel/preset-env": "^7.28.0",
-    "@babel/runtime": "^7.28.2",
-    "@babel/types": "^7.28.2",
     "@commitlint/cli": "^19.8.1",
     "@commitlint/config-angular": "^19.8.1",
+    "@eslint/js": "^9.32.0",
     "commitizen": "^4.3.1",
-    "cross-env": "^10.0.0",
     "cz-conventional-changelog": "^3.3.0",
     "eslint": "^9.32.0",
-    "eslint-plugin-import": "^2.32.0",
+    "eslint-plugin-n": "^17.21.3",
     "eslint-plugin-security": "^3.0.1",
+    "globals": "^16.3.0",
     "husky": "^9.1.7",
     "jest": "^30.0.5",
     "lint-staged": "^16.1.4",
     "lockfile-lint": "^4.14.1",
     "prettier": "^3.6.2"
   },
-  "jest": {
-    "testEnvironment": "node",
-    "verbose": true,
-    "notify": false,
-    "collectCoverage": true,
-    "coverageThreshold": {
-      "global": {
-        "branches": 75,
-        "functions": 75,
-        "lines": 75,
-        "statements": 75
-      },
-      "scripts/*": {
-        "branches": 60,
-        "functions": 90,
-        "lines": 80,
-        "statements": 80
-      }
-    },
-    "testMatch": [
-      "**/__tests__/**/*.test.js"
-    ],
-    "testPathIgnorePatterns": [
-      "/__tests__/__fixtures__/*"
-    ]
-  },
-  "babel": {
-    "presets": [
-      "@babel/env"
-    ],
-    "plugins": [
-      "@babel/plugin-transform-runtime"
-    ]
-  },
   "config": {
     "commitizen": {
       "path": "./node_modules/cz-conventional-changelog"
@@ -118,72 +77,9 @@
   "lint-staged": {
     "**/*.js": [
       "npm run format",
-      "npm run lint",
-      "git add"
+      "npm run lint"
     ]
   },
-  "eslintConfig": {
-    "env": {
-      "node": true,
-      "es6": true,
-      "jest": true
-    },
-    "plugins": [
-      "node",
-      "security"
-    ],
-    "extends": [
-      "plugin:node/recommended",
-      "plugin:security/recommended"
-    ],
-    "rules": {
-      "semi": "off",
-      "no-process-exit": "off",
-      "node/no-unsupported-features": "off",
-      "node/no-unpublished-require": "off",
-      "security/detect-non-literal-fs-filename": "warn",
-      "security/detect-unsafe-regex": "warn",
-      "security/detect-buffer-noassert": "error",
-      "security/detect-child-process": "warn",
-      "security/detect-disable-mustache-escape": "error",
-      "security/detect-eval-with-expression": "error",
-      "security/detect-no-csrf-before-method-override": "error",
-      "security/detect-non-literal-regexp": "error",
-      "security/detect-non-literal-require": "warn",
-      "security/detect-object-injection": "off",
-      "security/detect-possible-timing-attacks": "error",
-      "security/detect-pseudoRandomBytes": "error",
-      "node/no-unsupported-features/node-builtins": [
-        "error",
-        {
-          "version": ">=18.17.0",
-          "ignores": []
-        }
-      ],
-      "node/no-unsupported-features/es-syntax": [
-        "error",
-        {
-          "version": ">=18.17.0",
-          "ignores": []
-        }
-      ]
-    },
-    "overrides": [
-      {
-        "files": [
-          "__tests__/*"
-        ],
-        "rules": {
-          "node/no-unsupported-features/es-syntax": "off"
-        }
-      }
-    ],
-    "parserOptions": {
-      "ecmaFeatures": {
-        "impliedStrict": true
-      }
-    }
-  },
   "release": {
     "branches": [
       "main"

package/scripts/build.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const fs = require('fs/promises')
 const path = require('path')
 

package/scripts/postinstall.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const fs = require('fs')
 const { styleText } = require('node:util')
 const semver = require('semver')

package/scripts/preuninstall.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const helpers = require('./scriptHelpers')
 
 const runPreUninstall = async () => {

package/scripts/scriptHelpers.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const fs = require('fs')
 const os = require('os')
 const path = require('path')