npq 3.10.1 → 3.11.0

package/__tests__/env-var-integration.test.js

@@ -1,109 +0,0 @@
-// __tests__/env-var-integration.test.js
-
-// Test the NPQ_PKG_MGR environment variable functionality
-// This tests the key logic change: process.env.NPQ_PKG_MGR || values.packageManager || values.pkgMgr || 'npm'
-
-const packageManager = require('../lib/packageManager')
-
-const childProcess = require('child_process')
-
-jest.mock('child_process', () => {
-  return {
-    spawn: jest.fn((cmd, options) => {
-      return { pid: 12345 }
-    })
-  }
-})
-
-describe('NPQ_PKG_MGR Environment Variable Integration', () => {
-  let originalNPQ_PKG_MGR
-
-  beforeEach(() => {
-    originalNPQ_PKG_MGR = process.env.NPQ_PKG_MGR
-    delete process.env.NPQ_PKG_MGR
-    childProcess.spawn.mockClear()
-  })
-
-  afterEach(() => {
-    if (originalNPQ_PKG_MGR !== undefined) {
-      process.env.NPQ_PKG_MGR = originalNPQ_PKG_MGR
-    } else {
-      delete process.env.NPQ_PKG_MGR
-    }
-  })
-
-  test('package manager process should handle pnpm correctly', async () => {
-    process.argv = ['node', 'npq', 'install', 'fastify']
-
-    // Test that the package manager can spawn pnpm (which would be passed from CLI parsing)
-    await packageManager.process('pnpm')
-
-    expect(childProcess.spawn).toHaveBeenCalledWith('pnpm install fastify', {
-      stdio: 'inherit',
-      shell: true
-    })
-  })
-
-  test('package manager process should handle yarn correctly', async () => {
-    process.argv = ['node', 'npq', 'install', 'express', 'lodash']
-
-    await packageManager.process('yarn')
-
-    expect(childProcess.spawn).toHaveBeenCalledWith('yarn install express lodash', {
-      stdio: 'inherit',
-      shell: true
-    })
-  })
-
-  test('package manager process should handle various package managers', async () => {
-    const packageManagers = ['npm', 'yarn', 'pnpm', 'bun']
-
-    for (const pm of packageManagers) {
-      process.argv = ['node', 'npq', 'install', 'test-package']
-
-      await packageManager.process(pm)
-
-      expect(childProcess.spawn).toHaveBeenCalledWith(`${pm} install test-package`, {
-        stdio: 'inherit',
-        shell: true
-      })
-
-      childProcess.spawn.mockClear()
-    }
-  })
-
-  test('should demonstrate NPQ_PKG_MGR environment variable precedence logic', () => {
-    // This test documents the specific logic that was implemented:
-    // packageManager: process.env.NPQ_PKG_MGR || values.packageManager || values.pkgMgr || 'npm'
-
-    // Test 1: Environment variable takes precedence
-    process.env.NPQ_PKG_MGR = 'pnpm'
-    const values1 = { packageManager: 'yarn', pkgMgr: 'npm' }
-    const result1 = process.env.NPQ_PKG_MGR || values1.packageManager || values1.pkgMgr || 'npm'
-    expect(result1).toBe('pnpm')
-
-    // Test 2: Falls back to packageManager when env var not set
-    delete process.env.NPQ_PKG_MGR
-    const values2 = { packageManager: 'yarn', pkgMgr: 'npm' }
-    const result2 = process.env.NPQ_PKG_MGR || values2.packageManager || values2.pkgMgr || 'npm'
-    expect(result2).toBe('yarn')
-
-    // Test 3: Falls back to pkgMgr when env var and packageManager not set
-    delete process.env.NPQ_PKG_MGR
-    const values3 = { pkgMgr: 'pnpm' }
-    const result3 = process.env.NPQ_PKG_MGR || values3.packageManager || values3.pkgMgr || 'npm'
-    expect(result3).toBe('pnpm')
-
-    // Test 4: Falls back to npm default when nothing is set
-    delete process.env.NPQ_PKG_MGR
-    const values4 = {}
-    const result4 = process.env.NPQ_PKG_MGR || values4.packageManager || values4.pkgMgr || 'npm'
-    expect(result4).toBe('npm')
-
-    // Test 5: Empty string environment variable falls back to CLI options
-    process.env.NPQ_PKG_MGR = ''
-    const values5 = { packageManager: 'yarn' }
-    const result5 = process.env.NPQ_PKG_MGR || values5.packageManager || values5.pkgMgr || 'npm'
-    expect(result5).toBe('yarn')
-  })
-})

package/__tests__/marshalls.base.test.js

@@ -1,113 +0,0 @@
-const TestMarshall = require('./__fixtures__/test.marshall')
-const TEST_MARSHALL_NAME = 'test.marshall'
-const BaseMarshall = require('../lib/marshalls/baseMarshall')
-
-test('base marshall implemented isEnabled', async () => {
-  const testMarshall = new TestMarshall({
-    packageRepoUtils: null
-  })
-
-  expect(testMarshall.isEnabled()).toBeTruthy()
-})
-
-test('checkPackage returns validation data if it was a success', async () => {
-  const testMarshall = new TestMarshall({
-    packageRepoUtils: null
-  })
-
-  const ctx = {
-    marshalls: {
-      [TEST_MARSHALL_NAME]: {
-        data: {}
-      }
-    }
-  }
-
-  const result = await testMarshall.checkPackage({ packageName: 'express' }, ctx, {})
-  expect(result).toEqual('validation-result')
-})
-
-test('checkPackage sets the error property if the validation failed', async () => {
-  const testMarshall = new TestMarshall({
-    packageRepoUtils: null
-  })
-
-  const pkg = {
-    packageString: 'trojan'
-  }
-
-  const ctx = {
-    marshalls: {
-      [TEST_MARSHALL_NAME]: {
-        data: {}
-      }
-    }
-  }
-
-  testMarshall.init(ctx)
-  await testMarshall.checkPackage(pkg, ctx, {})
-  expect(ctx.marshalls[TEST_MARSHALL_NAME].errors[0].pkg).toEqual(pkg.packageString)
-})
-
-test('setError sets the errors properly', () => {
-  const testMarshall = new TestMarshall({
-    packageRepoUtils: null
-  })
-
-  const ctx = {
-    marshalls: {
-      [TEST_MARSHALL_NAME]: {
-        data: {}
-      }
-    }
-  }
-  const err = {
-    pkg: 'test',
-    message: 'error message'
-  }
-
-  testMarshall.init(ctx)
-  testMarshall.setMessage(err)
-  expect(ctx.marshalls[TEST_MARSHALL_NAME].errors.length).toEqual(1)
-  expect(ctx.marshalls[TEST_MARSHALL_NAME].errors[0]).toEqual(err)
-})
-
-test('setWarning sets the warnings properly', () => {
-  const testMarshall = new TestMarshall({
-    packageRepoUtils: null
-  })
-
-  const ctx = {
-    marshalls: {
-      [TEST_MARSHALL_NAME]: {
-        data: {}
-      }
-    }
-  }
-  const warn = {
-    pkg: 'test',
-    message: 'warning message'
-  }
-
-  testMarshall.init(ctx)
-
-  testMarshall.setMessage(warn, true)
-  expect(ctx.marshalls[TEST_MARSHALL_NAME].warnings.length).toEqual(1)
-  expect(ctx.marshalls[TEST_MARSHALL_NAME].warnings[0]).toEqual(warn)
-})
-
-test('base marshall implemented isEnabled', async () => {
-  const testMarshall = new BaseMarshall({
-    packageRepoUtils: null
-  })
-
-  testMarshall.validate = jest.fn(() => {
-    return Promise.reject(new Error('some mock error'))
-  })
-
-  const ctx = { pkgs: ['pkg1'], marshalls: {} }
-  const task = {}
-  testMarshall.init(ctx, task)
-  const result = await testMarshall.run(ctx, task)
-  expect(result).toStrictEqual([undefined])
-})

package/__tests__/marshalls.classMethods.test.js

@@ -1,34 +0,0 @@
-beforeEach(() => {
-  jest.resetModules()
-})
-
-test('collecting marshalls resolves with files array', async () => {
-  const marshalls = require('../lib/marshalls')
-
-  const marshallFiles = await marshalls.collectMarshalls()
-  expect(marshallFiles.length).toBeGreaterThan(0)
-  expect(marshallFiles.every((file) => file.endsWith('.marshall.js'))).toBe(true)
-})
-
-test('collecting marshalls handles directory read errors', async () => {
-  const fs = require('node:fs')
-  const marshalls = require('../lib/marshalls')
-
-  // Mock fs.promises.readdir to throw an error
-  const originalReaddir = fs.promises.readdir
-  fs.promises.readdir = jest.fn().mockRejectedValue(new Error('Directory read error'))
-
-  await expect(marshalls.collectMarshalls()).rejects.toThrow('Directory read error')
-
-  // Restore original function
-  fs.promises.readdir = originalReaddir
-})
-
-test('build marshalls without any should throw error', () => {
-  const marshalls = require('../lib/marshalls')
-
-  expect(marshalls.buildMarshallTasks([])).rejects.toEqual(expect.any(Error))
-  expect(marshalls.buildMarshallTasks({})).rejects.toEqual(expect.any(Error))
-  expect(marshalls.buildMarshallTasks(5)).rejects.toEqual(expect.any(Error))
-  expect(marshalls.buildMarshallTasks('something')).rejects.toEqual(expect.any(Error))
-})

package/__tests__/marshalls.expiredDomains.test.js

@@ -1,100 +0,0 @@
-const ExpiredDomainsMarshall = require('../lib/marshalls/expiredDomains.marshall')
-
-const testMarshall = new ExpiredDomainsMarshall({
-  packageRepoUtils: {
-    getPackageInfo: (pkgInfo) => {
-      return new Promise((resolve) => {
-        resolve(pkgInfo)
-      })
-    }
-  }
-})
-
-describe('Expired domains test suites', () => {
-  beforeEach(() => {
-    jest.clearAllMocks()
-    jest.resetAllMocks()
-  })
-
-  test('has the right title', async () => {
-    expect(testMarshall.title()).toEqual('Detecting expired domains for authors account...')
-  })
-
-  test('throws the right error when an email domain cant be verified', async () => {
-    const nonExistentEmailAddress =
-      'liran.tal+test1234@somenonexistentdomainongoogle109dubv98g39ujasdasda.com'
-    const pkgData = {
-      packageName: {
-        'dist-tags': {
-          latest: '1.0.0'
-        },
-        versions: {
-          '1.0.0': {
-            maintainers: [
-              { name: 'lirantal', email: 'liran.tal@gmail.com' },
-              {
-                name: 'lirantal_test_user',
-                email: nonExistentEmailAddress
-              }
-            ]
-          }
-        }
-      }
-    }
-
-    await expect(testMarshall.validate(pkgData)).rejects.toThrow(
-      /Detected expired domain can be abused for account takeover/
-    )
-  })
-
-  test('if email hostname is empty then show an unknown message', async () => {
-    const nonExistentEmailAddress = ''
-    const pkgData = {
-      packageName: {
-        'dist-tags': {
-          latest: '1.0.0'
-        },
-        versions: {
-          '1.0.0': {
-            maintainers: [
-              { name: 'lirantal', email: 'liran.tal@gmail.com' },
-              {
-                name: 'lirantal_test_user',
-                email: nonExistentEmailAddress
-              }
-            ]
-          }
-        }
-      }
-    }
-
-    await expect(testMarshall.validate(pkgData)).rejects.toThrow(
-      /Detected expired domain can be abused for account takeover: <unknown>/
-    )
-  })
-
-  test('does not throw any errors if the domain resolves well', async () => {
-    jest.setTimeout(15000)
-
-    const pkgData = {
-      packageName: {
-        'dist-tags': {
-          latest: '1.0.0'
-        },
-        versions: {
-          '1.0.0': {
-            maintainers: [
-              { name: 'lirantal', email: 'liran.tal@gmail.com' },
-              {
-                name: 'lirantal_test_user',
-                email: 'liran.tal@gmail.com'
-              }
-            ]
-          }
-        }
-      }
-    }
-
-    await expect(testMarshall.validate(pkgData)).resolves.toEqual(expect.anything())
-  })
-})