npq 2.5.3 → 3.0.1

package/.github/workflows/main.yml

@@ -52,7 +52,7 @@ jobs:
       - name: install dependencies
         run: npm ci --ignore-engines --ignore-scripts
       - name: release
-        run: npm run semantic-release
+        run: npx semantic-release
         env:
           GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}
           NPM_TOKEN: ${{secrets.NPM_TOKEN}}

package/.husky/commit-msg

@@ -0,0 +1,4 @@
+#!/usr/bin/env sh
+. "$(dirname -- "$0")/_/husky.sh"
+
+npx commitlint --edit $1

package/.husky/post-merge

@@ -0,0 +1,4 @@
+#!/usr/bin/env sh
+. "$(dirname -- "$0")/_/husky.sh"
+
+npm install

package/.husky/pre-commit

@@ -0,0 +1,4 @@
+#!/usr/bin/env sh
+. "$(dirname -- "$0")/_/husky.sh"
+
+npx lint-staged

package/.husky/pre-push

@@ -0,0 +1,4 @@
+#!/usr/bin/env sh
+. "$(dirname -- "$0")/_/husky.sh"
+
+npm run lint && npm run test

package/__tests__/__fixtures__/test.marshall.js

@@ -5,16 +5,16 @@ const BaseMarshall = require('../../lib/marshalls/baseMarshall')
 const MARSHALL_NAME = 'test.marshall'
 
 class TestMarshall extends BaseMarshall {
-  constructor (options) {
+  constructor(options) {
     super(options)
     this.name = MARSHALL_NAME
   }
 
-  title () {
+  title() {
     return 'A test marshall'
   }
 
-  run (ctx, task) {
+  run(ctx, task) {
     const tasks = ctx.pkgs.reduce((prevPkg, currPkg) => {
       return prevPkg.concat(this.mockCheck(currPkg, ctx, task))
     }, [])
@@ -22,7 +22,7 @@ class TestMarshall extends BaseMarshall {
     return Promise.all(tasks)
   }
 
-  mockCheck (pkg, ctx, task) {
+  mockCheck(pkg, ctx, task) {
     return this.validateSomething(pkg)
       .then(() => {
         const data = 'mock data check'
@@ -33,13 +33,13 @@ class TestMarshall extends BaseMarshall {
       })
       .catch((err) => {
         this.setMessage({
-          pkg: pkg,
+          pkg,
           message: err.message
         })
       })
   }
 
-  validateSomething (pkg) {
+  validateSomething(pkg) {
     if (pkg === 'express' || pkg === 'semver') {
       return Promise.resolve()
     } else {
@@ -47,7 +47,7 @@ class TestMarshall extends BaseMarshall {
     }
   }
 
-  validate (pkg) {
+  validate(pkg) {
     if (pkg === 'express' || pkg === 'semver') {
       return Promise.resolve('validation-result')
     } else {

package/__tests__/marshalls.classMethods.test.js

@@ -2,15 +2,15 @@ beforeEach(() => {
   jest.resetModules()
 })
 
+jest.mock('glob', () => {
+  return {
+    glob: jest.fn().mockResolvedValue(['file1', 'file2'])
+  }
+})
+
 test('collecting marshalls resolves with files array', async () => {
   const marshalls = require('../lib/marshalls')
 
-  jest.mock('glob', () => {
-    return jest.fn((pattern, options, callback) => {
-      return callback(null, ['file1', 'file2'])
-    })
-  })
-
   const marshallFiles = await marshalls.collectMarshalls()
   expect(marshallFiles).toEqual(['file1', 'file2'])
 })
@@ -19,9 +19,9 @@ test('collecting marshalls resolves with error if unable to process files', () =
   const marshalls = require('../lib/marshalls')
 
   jest.mock('glob', () => {
-    return jest.fn((pattern, options, callback) => {
-      return callback(new Error('some error'), null)
-    })
+    return {
+      glob: jest.fn().mockRejectedValue(new Error('error'))
+    }
   })
 
   expect(marshalls.collectMarshalls()).rejects.toEqual(expect.any(Error))

package/__tests__/marshalls.provenance.test.js

@@ -1,7 +1,4 @@
 jest.mock('pacote')
-jest.mock('node-fetch')
-
-const fetch = require('node-fetch')
 
 const ProvenanceMarshall = require('../lib/marshalls/provenance.marshall')
 const pacote = require('pacote')
@@ -40,7 +37,7 @@ describe('Provenance test suites', () => {
         ]
       })
     }
-    fetch.mockImplementationOnce(() => Promise.resolve(mockResponse))
+    global.fetch = jest.fn().mockImplementationOnce(() => Promise.resolve(mockResponse))
 
     pacote.manifest = jest.fn().mockResolvedValue({
       name: 'packageName',
@@ -114,7 +111,7 @@ describe('Provenance test suites', () => {
         ]
       })
     }
-    fetch.mockImplementationOnce(() => Promise.resolve(mockResponse))
+    global.fetch = jest.fn().mockImplementationOnce(() => Promise.resolve(mockResponse))
 
     const pkg = {
       packageName: 'packageName',
@@ -166,7 +163,7 @@ describe('Provenance test suites', () => {
         ]
       })
     }
-    fetch.mockImplementationOnce(() => Promise.resolve(mockResponse))
+    global.fetch = jest.fn().mockImplementationOnce(() => Promise.resolve(mockResponse))
 
     const pkg = {
       packageName: 'packageName',

package/__tests__/marshalls.repo.test.js

@@ -1,7 +1,4 @@
 const RepoMarshall = require('../lib/marshalls/repo.marshall')
-const fetch = require('node-fetch')
-
-jest.mock('node-fetch')
 
 const testMarshall = new RepoMarshall({
   packageRepoUtils: {
@@ -81,7 +78,7 @@ describe('Repo test suites', () => {
   })
 
   test('throws the right error when the repository url does not exist', async () => {
-    fetch.mockImplementationOnce(() => Promise.reject(new Error('error')))
+    global.fetch = jest.fn().mockImplementationOnce(() => Promise.reject(new Error('error')))
 
     await expect(testMarshall.validate(fullPkgData)).rejects.toThrow(
       'no valid repository is associated with the package'
@@ -89,7 +86,7 @@ describe('Repo test suites', () => {
   })
 
   test('throws the right error when the repository url is unreachable', async () => {
-    fetch.mockImplementationOnce(() => Promise.reject(new Error('error')))
+    global.fetch = jest.fn().mockImplementationOnce(() => Promise.reject(new Error('error')))
 
     fullPkgData.packageName.versions['1.0.0'].repository.url =
       'https://dsfsdfsdfs.abcdeugwecwekjasda.com/'
@@ -99,7 +96,7 @@ describe('Repo test suites', () => {
   })
 
   test('throws the right error when the homepage url does not exist', async () => {
-    fetch.mockImplementationOnce(() => Promise.reject(new Error('error')))
+    global.fetch = jest.fn().mockImplementationOnce(() => Promise.reject(new Error('error')))
 
     const pkgData = {
       packageName: {
@@ -121,7 +118,7 @@ describe('Repo test suites', () => {
   })
 
   test('does not throw any errors if the url exists', async () => {
-    fetch.mockImplementationOnce(() => Promise.resolve('success'))
+    global.fetch = jest.fn().mockImplementationOnce(() => Promise.resolve('success'))
 
     fullPkgData.packageName.versions['1.0.0'].repository.url = 'https://google.com'
     await expect(testMarshall.validate(fullPkgData)).resolves.toEqual(expect.anything())

package/__tests__/marshalls.signatures.test.js

@@ -9,10 +9,6 @@ jest.mock('pacote', () => {
   }
 })
 
-jest.mock('node-fetch')
-
-const fetch = require('node-fetch')
-
 const SignaturesMarshall = require('../lib/marshalls/signatures.marshall')
 const pacote = require('pacote')
 
@@ -50,7 +46,7 @@ describe('Signature test suites', () => {
         ]
       })
     }
-    fetch.mockImplementationOnce(() => Promise.resolve(mockResponse))
+    global.fetch = jest.fn().mockImplementationOnce(() => Promise.resolve(mockResponse))
 
     const testMarshall = new SignaturesMarshall({
       packageRepoUtils: {
@@ -107,7 +103,7 @@ describe('Signature test suites', () => {
         ]
       })
     }
-    fetch.mockImplementationOnce(() => Promise.resolve(mockResponse))
+    global.fetch = jest.fn().mockImplementationOnce(() => Promise.resolve(mockResponse))
 
     // the manifest() method should throw an error
     // in this jest mock to simulate a problem:

package/__tests__/marshalls.tasks.test.js

@@ -2,7 +2,7 @@ const path = require('path')
 const marshalls = require('../lib/marshalls')
 
 const PackageRepoUtilsMock = class Fake {
-  getPackageInfo () {
+  getPackageInfo() {
     return Promise.resolve(true)
   }
 }
@@ -51,8 +51,5 @@ test('running marshall tasks fails', async () => {
     }
   }
 
-  await expect(marshalls.tasks(config)).rejects.toMatchObject({
-    message: 'Something went wrong',
-    context: context
-  })
+  await expect(marshalls.tasks(config)).resolves.toMatchObject(context)
 })

package/__tests__/packageManager.test.js

@@ -1,5 +1,5 @@
 const packageManager = require('../lib/packageManager')
-// eslint-disable-next-line security/detect-child-process
+
 const childProcess = require('child_process')
 
 jest.mock('child_process', () => {

package/__tests__/packageRepoUtils.test.js

@@ -1,8 +1,6 @@
 const PackageRepoUtils = require('../lib/helpers/packageRepoUtils')
-const fetch = require('node-fetch')
 
-jest.mock('node-fetch')
-fetch.mockImplementation(() =>
+global.fetch = jest.fn().mockImplementation(() =>
   Promise.resolve({
     json: () => require('./mocks/registryPackageOk.mock.json')
   })
@@ -64,7 +62,7 @@ test('repo utils retrieves package README information', async () => {
 
 test('repo utils retrieves package latest version as null if not exists', async () => {
   const PackageRepoUtils = require('../lib/helpers/packageRepoUtils')
-  fetch.mockReturnValue(
+  global.fetch = jest.fn().mockImplementation(() =>
     Promise.resolve({
       json: () => require('./mocks/registryPackageUnpublished.mock.json')
     })
@@ -78,7 +76,7 @@ test('repo utils retrieves package latest version as null if not exists', async
 
 test('repo utils retrieves package download count', async () => {
   const PackageRepoUtils = require('../lib/helpers/packageRepoUtils')
-  fetch.mockReturnValue(
+  global.fetch = jest.fn().mockImplementation(() =>
     Promise.resolve({
       json: () => ({
         downloads: 1950,
@@ -97,7 +95,7 @@ test('repo utils retrieves package download count', async () => {
 
 test('repo utils retrieves package README information even when not available', async () => {
   const PackageRepoUtils = require('../lib/helpers/packageRepoUtils')
-  fetch.mockReturnValue(
+  global.fetch = jest.fn().mockImplementation(() =>
     Promise.resolve({
       json: () => require('./mocks/registryPackageUnpublished.mock.json')
     })
@@ -111,7 +109,7 @@ test('repo utils retrieves package README information even when not available',
 
 test('repo utils retrieves package LICENSE information', async () => {
   const PackageRepoUtils = require('../lib/helpers/packageRepoUtils')
-  fetch.mockReturnValue(
+  global.fetch = jest.fn().mockImplementation(() =>
     Promise.resolve({
       json: () => require('./mocks/registryPackageOk.mock.json')
     })
@@ -125,7 +123,7 @@ test('repo utils retrieves package LICENSE information', async () => {
 
 test('repo utils parses package version', async () => {
   const PackageRepoUtils = require('../lib/helpers/packageRepoUtils')
-  fetch.mockReturnValue(
+  global.fetch = jest.fn().mockImplementation(() =>
     Promise.resolve({
       json: () => require('./mocks/registryPackageOk.mock.json')
     })

package/lib/cliCommons.js

@@ -1,6 +1,6 @@
 const npa = require('npm-package-arg')
 class cliCommons {
-  static getInstallCommand () {
+  static getInstallCommand() {
     return {
       command: 'install [package...]',
       aliases: [
@@ -31,7 +31,7 @@ class cliCommons {
     }
   }
 
-  static getOptions () {
+  static getOptions() {
     return {
       P: {
         alias: ['save-prod', 'peer'],

package/lib/helpers/cliSupportHandler.js

@@ -1,18 +1,14 @@
 'use strict'
 
-const chalk = require('chalk')
+const color = require('kleur')
 // eslint-disable-next-line security/detect-child-process
 const childProcess = require('child_process')
 const semver = require('semver')
-const updateNotifier = require('update-notifier')
-const pkg = require('../../package.json')
 
 const DEFAULT_PKGMGR = process.env.NPQ_PKG_MGR || 'npm'
 
 const nodeVersion = process.versions.node
 
-updateNotifier({ pkg }).notify()
-
 module.exports.isEnvSupport = function () {
   if (!semver.satisfies(nodeVersion, '>=7.6.0')) {
     return false
@@ -23,7 +19,7 @@ module.exports.isEnvSupport = function () {
 
 module.exports.noSupportError = function (failFast) {
   // eslint-disable-next-line no-console
-  console.error(chalk.red('error:'), 'npq suppressed due to old node version')
+  console.error(color.red('error:'), 'npq suppressed due to old node version')
 
   if (failFast === true) {
     process.exit(-1)

package/lib/helpers/packageRepoUtils.js

@@ -1,22 +1,21 @@
 'use strict'
 
-const fetch = require('node-fetch')
 const semver = require('semver')
 const NPM_REGISTRY = 'http://registry.npmjs.org'
 const NPM_REGISTRY_API = 'https://api.npmjs.org'
 
 class PackageRepoUtils {
-  constructor (options = {}) {
+  constructor(options = {}) {
     this.registryUrl = options.registryUrl ? options.registryUrl : NPM_REGISTRY
     this.registryApiUrl = options.registryApiUrl ? options.registryApiUrl : NPM_REGISTRY_API
     this.pkgInfoCache = {}
   }
 
-  formatPackageForUrl (pkg) {
+  formatPackageForUrl(pkg) {
     return pkg.replace(/\//g, '%2F')
   }
 
-  getPackageInfo (pkg) {
+  getPackageInfo(pkg) {
     if (this.pkgInfoCache[pkg]) {
       return Promise.resolve(this.pkgInfoCache[pkg])
     } else {
@@ -29,27 +28,27 @@ class PackageRepoUtils {
     }
   }
 
-  getLatestVersion (pkg) {
+  getLatestVersion(pkg) {
     return this.getPackageInfo(pkg).then((data) => {
-      return data['dist-tags'] && data['dist-tags']['latest'] ? data['dist-tags']['latest'] : null
+      return data['dist-tags'] && data['dist-tags'].latest ? data['dist-tags'].latest : null
     })
   }
 
-  getDownloadInfo (pkg) {
+  getDownloadInfo(pkg) {
     return fetch(`${this.registryApiUrl}/downloads/point/last-month/${pkg}`)
       .then((response) => response.json())
       .then(({ downloads }) => downloads)
   }
 
-  getReadmeInfo (pkg) {
+  getReadmeInfo(pkg) {
     return this.getPackageInfo(pkg).then(({ readme }) => readme)
   }
 
-  getLicenseInfo (pkg) {
+  getLicenseInfo(pkg) {
     return this.getPackageInfo(pkg).then(({ license }) => license)
   }
 
-  parsePackageVersion (version) {
+  parsePackageVersion(version) {
     return semver.coerce(version)
   }
 }

package/lib/marshall.js

@@ -1,7 +1,7 @@
 /* eslint-disable no-console */
 'use strict'
 
-const chalk = require('chalk')
+const color = require('kleur')
 
 const Marshalls = require('./marshalls')
 const PackageRepoUtils = require('./helpers/packageRepoUtils')
@@ -12,12 +12,12 @@ const MESSAGE_TYPE = {
 }
 
 class Marshall {
-  constructor (options = {}) {
+  constructor(options = {}) {
     this.pkgs = options ? options.pkgs : null
     this.packageRepoUtils = new PackageRepoUtils()
   }
 
-  process () {
+  process() {
     // nothing to do? move on
     if (!this.pkgs) {
       return Promise.resolve()
@@ -28,16 +28,12 @@ class Marshall {
       packageRepoUtils: this.packageRepoUtils
     }
 
-    return Marshalls.tasks(config).catch((ctx) => {
-      if (ctx && ctx.context && ctx.context.marshalls) {
-        return this.report(ctx.context.marshalls)
-      }
-
-      throw ctx
+    return Marshalls.tasks(config).then((ctx) => {
+      return this.report(ctx.marshalls)
     })
   }
 
-  createPackageVersionMaps (packages) {
+  createPackageVersionMaps(packages) {
     const packageVersionMapping = packages.reduce((prev, curr) => {
       const versionSymbolPosition = curr.lastIndexOf('@')
       const versionPosition =
@@ -57,23 +53,24 @@ class Marshall {
     return packageVersionMapping
   }
 
-  report (marshalls) {
+  report(marshalls) {
     const messages = this.collectPackageMessages(marshalls)
 
-    if (!messages) {
+    if (!messages || Object.keys(messages).length === 0) {
       return { error: false }
     }
 
+    console.log()
     console.log('Detected possible issues with the following packages:')
     for (const packageName in messages) {
       const packageMessages = messages[packageName]
-      console.log(`  [${chalk.red(packageName)}]`)
+      console.log(`  [${color.red(packageName)}]`)
 
       packageMessages.forEach((message) => {
         if (message.type === MESSAGE_TYPE.ERROR) {
-          console.log(`    - ${chalk.red(message.text)}`)
+          console.log(`    - ${color.red(message.text)}`)
         } else {
-          console.log(`    - ${chalk.yellow(message.text)}`)
+          console.log(`    - ${color.yellow(message.text)}`)
         }
       })
     }
@@ -81,7 +78,7 @@ class Marshall {
     return { error: true, data: messages }
   }
 
-  collectPackageMessages (marshalls) {
+  collectPackageMessages(marshalls) {
     const allPackageMessages = {}
     for (const key in marshalls) {
       this.prepareMessages(allPackageMessages, marshalls[key].errors)
@@ -91,7 +88,7 @@ class Marshall {
     return allPackageMessages
   }
 
-  prepareMessages (allPackageMessages, messages, isWarning) {
+  prepareMessages(allPackageMessages, messages, isWarning) {
     if (Array.isArray(messages) && messages.length > 0) {
       messages.forEach((msg) => {
         this.appendPackageMessage(allPackageMessages, msg.pkg, {
@@ -102,7 +99,7 @@ class Marshall {
     }
   }
 
-  appendPackageMessage (packages, packageName, packageMessage) {
+  appendPackageMessage(packages, packageName, packageMessage) {
     packages[packageName]
       ? packages[packageName].push(packageMessage)
       : (packages[packageName] = [packageMessage])

package/lib/marshalls/age.marshall.js

@@ -6,16 +6,16 @@ const MARSHALL_NAME = 'age'
 const PACKAGE_AGE_THRESHOLD = 22 // specified in days
 
 class Marshall extends BaseMarshall {
-  constructor (options) {
+  constructor(options) {
     super(options)
     this.name = MARSHALL_NAME
   }
 
-  title () {
+  title() {
     return 'Checking package maturity'
   }
 
-  validate (pkg) {
+  validate(pkg) {
     return this.packageRepoUtils.getPackageInfo(pkg.packageName).then((data) => {
       if (data && data.time && data.time.created) {
         const pkgCreatedDate = data.time.created

package/lib/marshalls/author.marshall.js

@@ -7,19 +7,19 @@ const Warning = require('../helpers/warning')
 const MARSHALL_NAME = 'author'
 
 class Marshall extends BaseMarshall {
-  constructor (options) {
+  constructor(options) {
     super(options)
     this.name = MARSHALL_NAME
   }
 
-  title () {
+  title() {
     return 'Identifying package author...'
   }
 
-  validate (pkg) {
+  validate(pkg) {
     return this.packageRepoUtils.getPackageInfo(pkg.packageName).then((data) => {
       const lastVersionData =
-        data.versions && data['dist-tags'] && data.versions[data['dist-tags']['latest']]
+        data.versions && data['dist-tags'] && data.versions[data['dist-tags'].latest]
 
       const hasAuthorEmail =
         (lastVersionData &&

package/lib/marshalls/baseMarshall.js

@@ -3,11 +3,11 @@
 const Warning = require('../helpers/warning')
 
 class BaseMarshall {
-  constructor (options) {
+  constructor(options) {
     this.packageRepoUtils = options.packageRepoUtils
   }
 
-  init (ctx, task) {
+  init(ctx, task) {
     this.ctx = ctx
     this.task = task
 
@@ -19,7 +19,7 @@ class BaseMarshall {
     }
   }
 
-  run (ctx, task) {
+  run(ctx, task) {
     const tasks = ctx.pkgs.reduce((prevPkg, currPkg) => {
       return prevPkg.concat(this.checkPackage(currPkg, ctx, task))
     }, [])
@@ -27,7 +27,7 @@ class BaseMarshall {
     return Promise.all(tasks)
   }
 
-  checkPackage (pkg, ctx, task) {
+  checkPackage(pkg, ctx, task) {
     return this.validate(pkg)
       .then((data) => {
         task.output = `querying ${pkg.packageString}...`
@@ -47,13 +47,13 @@ class BaseMarshall {
       })
   }
 
-  isEnabled () {
+  isEnabled() {
     const isMarshallSilent = process.env[`MARSHALL_DISABLE_${this.name.toUpperCase()}`] || false
 
     return !isMarshallSilent
   }
 
-  setMessage (msg, isWarning) {
+  setMessage(msg, isWarning) {
     const messages = isWarning
       ? this.ctx.marshalls[this.name].warnings
       : this.ctx.marshalls[this.name].errors
@@ -64,7 +64,7 @@ class BaseMarshall {
     })
   }
 
-  handleMessages () {
+  handleMessages() {
     const errors = this.ctx.marshalls[this.name].errors
     const warnings = this.ctx.marshalls[this.name].warnings
     if ((errors && errors.length) || (warnings && warnings.length)) {

package/lib/marshalls/downloads.marshall.js

@@ -6,16 +6,16 @@ const MARSHALL_NAME = 'downloads'
 const DOWNLOAD_COUNT_THRESHOLD = 20 // threshold per month
 
 class Marshall extends BaseMarshall {
-  constructor (options) {
+  constructor(options) {
     super(options)
     this.name = MARSHALL_NAME
   }
 
-  title () {
+  title() {
     return 'Checking package download popularity'
   }
 
-  validate (pkg) {
+  validate(pkg) {
     return this.packageRepoUtils.getDownloadInfo(pkg.packageName).then((downloadCount) => {
       if (downloadCount < DOWNLOAD_COUNT_THRESHOLD) {
         throw new Error(

package/lib/marshalls/expiredDomains.marshall.js

@@ -6,25 +6,25 @@ const dns = require('dns').promises
 const MARSHALL_NAME = 'maintainers_expired_emails'
 
 class Marshall extends BaseMarshall {
-  constructor (options) {
+  constructor(options) {
     super(options)
     this.name = MARSHALL_NAME
   }
 
-  title () {
+  title() {
     return 'Detecting expired domains for authors account...'
   }
 
-  validate (pkg) {
+  validate(pkg) {
     return this.packageRepoUtils
       .getPackageInfo(pkg.packageName)
       .then((data) => {
         const lastVersionData =
-          data.versions && data['dist-tags'] && data.versions[data['dist-tags']['latest']]
+          data.versions && data['dist-tags'] && data.versions[data['dist-tags'].latest]
 
-        let maintainersAccounts = lastVersionData && lastVersionData.maintainers
+        const maintainersAccounts = lastVersionData && lastVersionData.maintainers
 
-        let testEmails = []
+        const testEmails = []
         for (const maintainerInfo of maintainersAccounts) {
           const maintainerEmail = maintainerInfo.email
           const emailDomain = maintainerEmail.split('@')[1]
@@ -34,7 +34,7 @@ class Marshall extends BaseMarshall {
         return Promise.all(testEmails)
       })
       .catch((error) => {
-        let emailHostname = error.hostname ? error.hostname : '<unknown>'
+        const emailHostname = error.hostname ? error.hostname : '<unknown>'
         throw new Error(
           'Unable to resolve domain for maintainer e-mail, could be an expired account: ' +
             emailHostname

package/lib/marshalls/index.js

@@ -1,29 +1,19 @@
 'use strict'
 
-const Listr = require('listr')
-const glob = require('glob')
+const { Listr } = require('listr2')
+const { glob } = require('glob')
 
 class Marshalls {
-  static collectMarshalls () {
-    return new Promise((resolve, reject) => {
-      glob(
-        this.GLOB_MARSHALLS,
-        {
-          cwd: __dirname,
-          absolute: true
-        },
-        (err, files) => {
-          if (err) {
-            reject(err)
-          }
-
-          resolve(files)
-        }
-      )
+  static async collectMarshalls() {
+    const files = await glob(this.GLOB_MARSHALLS, {
+      cwd: __dirname,
+      absolute: true
     })
+
+    return files
   }
 
-  static buildMarshallTasks (marshalls, config) {
+  static buildMarshallTasks(marshalls, config) {
     if (!marshalls || !Array.isArray(marshalls) || marshalls.length === 0) {
       return Promise.reject(new Error('unable to collect marshalls, or no marshalls found'))
     }
@@ -46,7 +36,7 @@ class Marshalls {
     return new Listr(marshallTasks, { exitOnError: false, concurrent: true })
   }
 
-  static tasks (options) {
+  static tasks(options) {
     return Marshalls.warmUpPackagesCache(options)
       .then(() => Marshalls.collectMarshalls())
       .then((marshalls) => {
@@ -59,7 +49,7 @@ class Marshalls {
       })
   }
 
-  static warmUpPackagesCache (options) {
+  static warmUpPackagesCache(options) {
     const fetchPackagesInfoPromises = []
     options.pkgs.forEach((packageMeta) => {
       fetchPackagesInfoPromises.push(
@@ -70,7 +60,7 @@ class Marshalls {
     return Promise.all(fetchPackagesInfoPromises)
   }
 
-  static runTasks (tasks, options) {
+  static runTasks(tasks, options) {
     return tasks.run({
       pkgs: options.pkgs,
       marshalls: {}

package/lib/marshalls/license.marshall.js

@@ -5,16 +5,16 @@ const BaseMarshall = require('./baseMarshall')
 const MARSHALL_NAME = 'license'
 
 class Marshall extends BaseMarshall {
-  constructor (options) {
+  constructor(options) {
     super(options)
     this.name = MARSHALL_NAME
   }
 
-  title () {
+  title() {
     return 'Checking availability of a LICENSE'
   }
 
-  validate (pkg) {
+  validate(pkg) {
     return this.packageRepoUtils.getLicenseInfo(pkg.packageName).then((licenseContents) => {
       if (!licenseContents || licenseContents === 'ERROR: No LICENSE data found!') {
         throw new Error('package has no LICENSE file available')

package/lib/marshalls/provenance.marshall.js

@@ -1,23 +1,22 @@
 'use strict'
 
 const BaseMarshall = require('./baseMarshall')
-const fetch = require('node-fetch')
 const pacote = require('pacote')
 const Warning = require('../helpers/warning')
 
 const MARSHALL_NAME = 'provenance'
 
 class Marshall extends BaseMarshall {
-  constructor (options) {
+  constructor(options) {
     super(options)
     this.name = MARSHALL_NAME
   }
 
-  title () {
+  title() {
     return 'Verifying package provenance'
   }
 
-  validate (pkg) {
+  validate(pkg) {
     const validationMetadata = {}
 
     return this.packageRepoUtils
@@ -26,7 +25,7 @@ class Marshall extends BaseMarshall {
         const packageName = packageInfo.name
         const packageVersion =
           pkg.packageVersion === 'latest'
-            ? packageInfo['dist-tags'] && packageInfo['dist-tags']['latest']
+            ? packageInfo['dist-tags'] && packageInfo['dist-tags'].latest
             : this.packageRepoUtils.parsePackageVersion(pkg.packageVersion).version
 
         validationMetadata.name = packageName
@@ -42,7 +41,7 @@ class Marshall extends BaseMarshall {
           verifyAttestations: true,
           registry: 'https://registry.npmjs.org',
 
-          [`//registry.npmjs.org/:_keys`]: keys
+          '//registry.npmjs.org/:_keys': keys
         })
       })
       .then((metadata) => {
@@ -58,7 +57,7 @@ class Marshall extends BaseMarshall {
       })
   }
 
-  fetchRegistryKeys () {
+  fetchRegistryKeys() {
     const registryHost = 'https://registry.npmjs.org'
     const registryKeysEndpoint = '/-/npm/v1/keys'
 

package/lib/marshalls/readme.marshall.js

@@ -5,16 +5,16 @@ const BaseMarshall = require('./baseMarshall')
 const MARSHALL_NAME = 'readme'
 
 class Marshall extends BaseMarshall {
-  constructor (options) {
+  constructor(options) {
     super(options)
     this.name = MARSHALL_NAME
   }
 
-  title () {
+  title() {
     return 'Checking availability of a README'
   }
 
-  validate (pkg) {
+  validate(pkg) {
     return this.packageRepoUtils.getReadmeInfo(pkg.packageName).then((readmeContents) => {
       if (!readmeContents || readmeContents === 'ERROR: No README data found!') {
         throw new Error('package has no README file available')

package/lib/marshalls/repo.marshall.js

@@ -1,21 +1,20 @@
 'use strict'
 
 const BaseMarshall = require('./baseMarshall')
-const fetch = require('node-fetch')
 const URL = require('url').URL
 const MARSHALL_NAME = 'repo'
 
 class Marshall extends BaseMarshall {
-  constructor (options) {
+  constructor(options) {
     super(options)
     this.name = MARSHALL_NAME
   }
 
-  title () {
+  title() {
     return 'Identifying package repository...'
   }
 
-  validate (pkg) {
+  validate(pkg) {
     return this.packageRepoUtils.getPackageInfo(pkg.packageName).then((data) => {
       const lastVersionData =
         (data.versions &&
@@ -29,7 +28,7 @@ class Marshall extends BaseMarshall {
           urlStructure = new URL(lastVersionData.repository.url)
           urlOfGitRepository = new URL(`https://${urlStructure.host}${urlStructure.pathname}`)
         } catch (error) {
-          throw new Error(`no valid repository is associated with the package`)
+          throw new Error('no valid repository is associated with the package')
         }
         return fetch(urlOfGitRepository.href).catch(() => {
           throw new Error(

package/lib/marshalls/scripts.marshall.js

@@ -5,20 +5,20 @@ const BaseMarshall = require('./baseMarshall')
 const MARSHALL_NAME = 'scripts'
 
 class Marshall extends BaseMarshall {
-  constructor (options) {
+  constructor(options) {
     super(options)
     this.name = MARSHALL_NAME
   }
 
-  title () {
+  title() {
     return 'Checking package for pre/post install scripts'
   }
 
-  validate (pkg) {
+  validate(pkg) {
     return this.packageRepoUtils.getPackageInfo(pkg.packageName).then((data) => {
       const packageVersion =
         pkg.packageVersion === 'latest'
-          ? data['dist-tags'] && data['dist-tags']['latest']
+          ? data['dist-tags'] && data['dist-tags'].latest
           : this.packageRepoUtils.parsePackageVersion(pkg.packageVersion).version
 
       if (!packageVersion) {
@@ -29,7 +29,7 @@ class Marshall extends BaseMarshall {
         data &&
         data.versions &&
         data.versions[packageVersion] &&
-        data.versions[packageVersion]['scripts']
+        data.versions[packageVersion].scripts
 
       // blacklisted scripts due to possible malicious intent:
       const blacklistScripts = ['install', 'preinstall', 'postinstall']

package/lib/marshalls/signatures.marshall.js

@@ -1,22 +1,21 @@
 'use strict'
 
 const BaseMarshall = require('./baseMarshall')
-const fetch = require('node-fetch')
 const pacote = require('pacote')
 
 const MARSHALL_NAME = 'signatures'
 
 class Marshall extends BaseMarshall {
-  constructor (options) {
+  constructor(options) {
     super(options)
     this.name = MARSHALL_NAME
   }
 
-  title () {
+  title() {
     return 'Verifying registry signatures for package'
   }
 
-  validate (pkg) {
+  validate(pkg) {
     // @TODO currently we're hardcoding the official npm registry
     // this should however allow for local proxies and other registries
     return this.fetchRegistryKeys()
@@ -25,7 +24,7 @@ class Marshall extends BaseMarshall {
           verifySignatures: true,
           registry: 'https://registry.npmjs.org',
 
-          [`//registry.npmjs.org/:_keys`]: keys
+          '//registry.npmjs.org/:_keys': keys
         })
       })
       .then((metadata) => {
@@ -33,7 +32,7 @@ class Marshall extends BaseMarshall {
       })
   }
 
-  fetchRegistryKeys () {
+  fetchRegistryKeys() {
     const registryHost = 'https://registry.npmjs.org'
     const registryKeysEndpoint = '/-/npm/v1/keys'
 

package/lib/marshalls/snyk.marshall.js

@@ -3,7 +3,6 @@
 const fs = require('fs')
 const os = require('os')
 const path = require('path')
-const fetch = require('node-fetch')
 const BaseMarshall = require('./baseMarshall')
 
 const MARSHALL_NAME = 'snyk'
@@ -14,18 +13,18 @@ const SNYK_API_TOKEN = process.env.SNYK_TOKEN
 const SNYK_CONFIG_FILE = '.config/configstore/snyk.json'
 
 class Marshall extends BaseMarshall {
-  constructor (options) {
+  constructor(options) {
     super(options)
     this.name = MARSHALL_NAME
 
     this.snykApiToken = this.getSnykToken()
   }
 
-  title () {
+  title() {
     return 'Checking for known vulnerabilities'
   }
 
-  run (ctx, task) {
+  run(ctx, task) {
     const tasks = ctx.pkgs.reduce((prevPkg, currPkg) => {
       return prevPkg.concat(this.checkPackage(currPkg, ctx, task))
     }, [])
@@ -33,7 +32,9 @@ class Marshall extends BaseMarshall {
     return Promise.all(tasks)
   }
 
-  validate (pkg) {
+  validate(pkg) {
+    return Promise.resolve(true)
+
     return Promise.resolve()
       .then(() => {
         if (!pkg.packageVersion || pkg.packageVersion === 'latest') {
@@ -60,7 +61,7 @@ class Marshall extends BaseMarshall {
       })
   }
 
-  getSnykVulnInfoUnauthenticated ({ packageName, packageVersion }) {
+  getSnykVulnInfoUnauthenticated({ packageName, packageVersion }) {
     const url = encodeURI(`${SNYK_TEST_URL}/${packageName}/${packageVersion}?type=json`)
 
     return fetch(url)
@@ -77,7 +78,7 @@ class Marshall extends BaseMarshall {
       .catch(() => false)
   }
 
-  getSnykVulnInfo ({ packageName, packageVersion } = {}) {
+  getSnykVulnInfo({ packageName, packageVersion } = {}) {
     if (!this.snykApiToken) {
       return this.getSnykVulnInfoUnauthenticated({ packageName, packageVersion })
     }
@@ -102,7 +103,7 @@ class Marshall extends BaseMarshall {
       .catch(() => false)
   }
 
-  getSnykToken () {
+  getSnykToken() {
     if (SNYK_API_TOKEN) {
       return SNYK_API_TOKEN
     }
@@ -111,7 +112,7 @@ class Marshall extends BaseMarshall {
 
     try {
       if (fs.statSync(snykConfigPath)) {
-        let snykConfig = require(snykConfigPath)
+        const snykConfig = require(snykConfigPath)
         if (snykConfig && snykConfig.api) {
           return snykConfig.api
         }

package/lib/packageManager.js

@@ -5,12 +5,12 @@ const childProcess = require('child_process')
 const DEFAULT_PKGMGR = 'npm'
 
 class packageManager {
-  static process (packageManagerOption) {
+  static process(packageManagerOption) {
     const detectedPackageManager = packageManager.validatePackageManager(packageManagerOption)
     return packageManager.spawnPackageManager(detectedPackageManager)
   }
 
-  static spawnPackageManager (packageManagerOption) {
+  static spawnPackageManager(packageManagerOption) {
     let args = []
 
     args = args.concat(process.argv.slice(2)).filter((item) => {
@@ -32,7 +32,7 @@ class packageManager {
     return Promise.resolve(child)
   }
 
-  static validatePackageManager (packageManagerOption) {
+  static validatePackageManager(packageManagerOption) {
     if (!packageManagerOption) {
       packageManagerOption = packageManager.getDefaultPackageManager()
     }
@@ -44,7 +44,7 @@ class packageManager {
     return packageManagerOption
   }
 
-  static getDefaultPackageManager () {
+  static getDefaultPackageManager() {
     return DEFAULT_PKGMGR
   }
 }

package/package.json

@@ -1,25 +1,29 @@
 {
   "name": "npq",
-  "version": "2.5.3",
+  "version": "3.0.1",
   "description": "marshall your npm/npm package installs with high quality and class 🎖",
   "bin": {
     "npq": "./bin/npq.js",
     "npq-hero": "./bin/npq-hero.js"
   },
   "scripts": {
-    "lint": "standard --fix && eslint . --ignore-path .gitignore && npm run lint:lockfile",
+    "lint": "eslint . --ignore-path .gitignore && npm run lint:lockfile",
     "lint:lockfile": "lockfile-lint --path package-lock.json --type npm --validate-https --allowed-hosts npm npm",
-    "test": "jest",
-    "test:watch": "jest --watch",
+    "test": "NODE_OPTIONS=\"--experimental-vm-modules\" jest",
+    "test:watch": "NODE_OPTIONS=\"--experimental-vm-modules\" jest --watch",
     "coverage:view": "opn coverage/lcov-report/index.html",
     "commit": "git-cz",
     "format": "prettier --config .prettierrc.js --write '**/*.js'",
     "docs": "npm run docs:code && npm run docs:api",
     "docs:api": "doxdox *.js --layout bootstrap --output docs/index.html",
     "docs:code": "docco *.js --output docs/code",
-    "semantic-release": "semantic-release",
-    "postinstall": "node scripts/postinstall.js",
-    "preuninstall": "node scripts/preuninstall.js"
+    "semantic-release": "npx semantic-release",
+    "#postinstall": "node scripts/postinstall.js",
+    "#preuninstall": "node scripts/preuninstall.js",
+    "prepare": "husky install"
+  },
+  "engines": {
+    "node": ">=18"
   },
   "author": {
     "name": "Liran Tal",
@@ -35,32 +39,29 @@
     "access": "public"
   },
   "devDependencies": {
-    "@babel/core": "^7.7.4",
-    "@babel/plugin-transform-runtime": "^7.7.4",
-    "@babel/preset-env": "^7.7.4",
-    "@babel/runtime": "^7.7.4",
-    "@babel/types": "^7.7.4",
-    "@commitlint/cli": "^7.0.0",
-    "@commitlint/config-angular": "^8.0.0",
-    "commitizen": "^3.0.0",
-    "cz-conventional-changelog": "^2.1.0",
-    "eslint": "^5.0.0",
-    "eslint-plugin-import": "^2.2.0",
-    "eslint-plugin-node": "^8.0.0",
-    "eslint-plugin-security": "^1.3.0",
-    "husky": "^3.0.0",
-    "jest": "^24.9.0",
-    "lint-staged": "^13.1.0",
+    "@babel/core": "^7.23.0",
+    "@babel/plugin-transform-runtime": "^7.22.15",
+    "@babel/preset-env": "^7.22.20",
+    "@babel/runtime": "^7.23.1",
+    "@babel/types": "^7.23.0",
+    "@commitlint/cli": "^17.7.2",
+    "@commitlint/config-angular": "^17.7.0",
+    "commitizen": "^4.3.0",
+    "cz-conventional-changelog": "^3.3.0",
+    "eslint": "^8.50.0",
+    "eslint-plugin-import": "^2.28.1",
+    "eslint-plugin-node": "^11.1.0",
+    "eslint-plugin-security": "^1.7.1",
+    "husky": "^8.0.3",
+    "jest": "^29.7.0",
+    "lint-staged": "^14.0.1",
     "lockfile-lint": "^4.12.1",
-    "opn-cli": "^4.0.0",
-    "prettier": "^2.8.3",
-    "semantic-release": "21.0.2",
-    "standard": "^12.0.0"
+    "prettier": "^3.0.3"
   },
   "jest": {
     "testEnvironment": "node",
     "verbose": true,
-    "notify": true,
+    "notify": false,
     "collectCoverage": true,
     "coverageThreshold": {
       "global": {
@@ -93,16 +94,6 @@
       "path": "./node_modules/cz-conventional-changelog"
     }
   },
-  "husky": {
-    "hooks": {
-      "commit-msg": "commitlint --env HUSKY_GIT_PARAMS",
-      "pre-commit": "lint-staged",
-      "pre-push": "npm run lint && npm run test",
-      "post-commit": "git status",
-      "post-checkout": "git status",
-      "post-merge": "npm install"
-    }
-  },
   "commitlint": {
     "extends": [
       "@commitlint/config-angular"
@@ -115,12 +106,6 @@
       "git add"
     ]
   },
-  "standard": {
-    "env": [
-      "node",
-      "jest"
-    ]
-  },
   "eslintConfig": {
     "env": {
       "node": true,
@@ -132,7 +117,8 @@
       "security"
     ],
     "extends": [
-      "plugin:node/recommended"
+      "plugin:node/recommended",
+      "plugin:security/recommended"
     ],
     "rules": {
       "semi": "off",
@@ -154,14 +140,14 @@
       "node/no-unsupported-features/node-builtins": [
         "error",
         {
-          "version": ">=10.6.0",
+          "version": ">=18.17.0",
           "ignores": []
         }
       ],
       "node/no-unsupported-features/es-syntax": [
         "error",
         {
-          "version": ">=10.6.0",
+          "version": ">=18.17.0",
           "ignores": []
         }
       ]
@@ -183,17 +169,15 @@
     }
   },
   "dependencies": {
-    "chalk": "^2.3.0",
-    "glob": "^8.0.3",
-    "inquirer": "^8.0.0",
-    "listr": "^0.14.0",
-    "node-fetch": "^2.6.7",
-    "npm-package-arg": "^10.1.0",
+    "glob": "^10.3.10",
+    "inquirer": "^8.2.6",
+    "kleur": "^4.1.5",
+    "listr2": "^7.0.1",
+    "npm-package-arg": "^11.0.1",
     "pacote": "^17.0.4",
-    "semver": "^7.3.8",
-    "update-notifier": "^5",
-    "validator": "13.7.0",
-    "yargs": "^17.6.2"
+    "semver": "^7.5.4",
+    "validator": "13.11.0",
+    "yargs": "^17.7.2"
   },
   "release": {
     "branches": [

package/scripts/postinstall.js

@@ -1,5 +1,5 @@
 const fs = require('fs')
-const chalk = require('chalk')
+const color = require('kleur')
 const inquirer = require('inquirer')
 const semver = require('semver')
 
@@ -42,17 +42,17 @@ const runPostInstall = async () => {
         message: `Do you want to add ${shellConfig.name} aliases for npm and yarn?`
       }
     ])
-    if (answers['install']) {
+    if (answers.install) {
       // eslint-disable-next-line security/detect-non-literal-fs-filename
       await fs.promises.appendFile(shellConfig.profilePath, shellConfig.aliases)
-      console.log(chalk.green('✔'), 'Reload your shell profile to use npq!')
+      console.log(color.green('✔'), 'Reload your shell profile to use npq!')
     }
   } catch (err) {
     if (err.isTtyError) {
       // Could not render inquirer prompt; abort auto-install
       return
     }
-    console.error(chalk.red('Failed to add aliases: '), err)
+    console.error(color.red('Failed to add aliases: '), err)
   }
 }
 

package/scripts/scriptHelpers.js

@@ -43,13 +43,13 @@ module.exports.removeFromFile = async (profilePath, aliases) => {
 }
 
 module.exports.isRunningInYarn = () => {
-  const execPath = process.env['npm_execpath'] || ''
+  const execPath = process.env.npm_execpath || ''
   const binaryName = execPath.split(path.sep).pop()
   return binaryName.toLowerCase().includes('yarn')
 }
 
 module.exports.getNpmVersion = () => {
-  const npmData = process.env['npm_config_user_agent'] || '0.0.0'
+  const npmData = process.env.npm_config_user_agent || '0.0.0'
   const version = /npm\/(.*) node/.exec(npmData)[1]
   return semver.valid(version) ? version : '0.0.0'
 }
@@ -61,6 +61,7 @@ const getProfile = async (profilePath) => {
     return profileData
   } catch (err) {
     if (err && err.code === 'ENOENT') {
+      return null
     } else if (err) {
       throw err
     }